Commit Graph

62 Commits

Author SHA1 Message Date
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Mihaela Stoica
76b3c05b9a CA-250145: XenCenter cannot shutdown VM as VmPowerAdmin user if HA is enabled
The error was happening because of the Pool.sync_database call (when HA is enabled and the VM has a saved restart priority other than DoNotRestart) which requires pool admin or pool operator roles.
This call is not needed, so removing it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-28 09:08:44 +01:00
Mihaela Stoica
74885674c3 CA-238901: PVS proxy not setup for imported VM
For ElyOrGreater hosts, we try move the existing VIFs to the desired networks. We will only destroy and create new ones for older hosts or when a corresponding VIF cannot be found in the network mapping.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-20 12:54:13 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
c395a8ce14 CA-233454: Fix the action test
Added an extra parameter to the CreateVmFastAction constructor, which is used to specify whether to set the VM's property IsBeingCreated. In order to set this property, we need to wait for the newly created VM to appear in the cache. But we cannot do this in the action test, because the cache is not being updated. Therefore the action needs skip this step when running from the tests. The IsBeingCreated property is only used in the UI, to refresh the PVS tab after the VM is created, so the accuracy of the action test (CreateVMFastActionTest) is not affected by this change.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 12:09:03 +00:00
mcintyre94
7f2ecb6eab [CA-233454] PVS tab doesn't show a new VM when it's created (#1314)
* [CA-233454] PVS tab doesn't show a new VM when it's created

Refined the rules for not adding a VM to the table, if it is a template (thus not_a_real_vm), and it has the __gui__ prefix (thus hidden), we still add it, but hide it.
When its name is changed (to remove the __gui__ prefix), we update its name and re-calculate whether it should be visible (in the case of a new VM this will be true once the __gui__ prefix is gone). Also resort the table if a node changes from hidden to visible, because it appears as an addition to the table.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update criteria for VM visibility to include is_a_real_vm

is_a_template is changed before the name_label removes the __gui__ prefix, so this works with no other changes to the vm property changed event.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update when the VMs are shown in the PVS list

New observable property IsBeingCreated for VMs, set to true when they're made a hidden object, and false when they're removed from hidden objects (both in CreateVMAction). In the PVS Page when this is set to false, we re-evaluate whether a VM can be shown. This means that new VMs show here at the same time they're added to the tree (only different is tree refresh time), instead of far earlier (and before their networks were added).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Set IsbeingCreated in the CreateVMFastAction

* [CA-233454] Properly support the VM Fast Create action

Further changes to CreateVMFastAction, to ensure it works with PVS tab - use the __gui__ prefix when the VM is created and then change it back just before showing.

* [CA-233454] Small logic adjustments/tidying up
2016-11-30 12:24:02 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Konstantina Chremmou
c7994c286d CA-227272: Ignore unresolved VDIs first, then check if the storage mapping contains
the resolved ones and then try getting the target SR from the mapping.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-28 10:57:10 +01:00
Mihaela Stoica
dabe77e0d0 CA-223374: Fix typo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 12:53:30 +01:00
Mihaela Stoica
34a4d44987 CA-223374: Able to unplug vCPUs from running VM when changing vCPU from two iCenters concurrently
- check the current number of vCPUs (by getting the latest value from the cache) before trying to change it.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-10 12:37:11 +01:00
Gabor Apati-Nagy
6296277317 Merge pull request #1188 from kc284/vm_migration
CA-220218, CA-205799, CA-205791 plus one or two other issues and refactoring
2016-10-07 16:18:49 +01:00
Konstantina Chremmou
1acc717417 CA-205791: Added detail to the action migrating a VM that's not resident on a host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:52 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Callum McIntyre
336e4d8149 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Move the test for whether we can boot the VM on the previous host into the VmSnapshotRevertAction, and run it using the Session of the action.
2016-09-22 13:36:43 +01:00
Callum McIntyre
d30ff533fd CA-218260: Correcting nesting
The else if (vm.power_state == vm_power_state.Suspended) block had been incorrectly moved out an indent level to the outer if.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:45:42 +01:00
Callum McIntyre
502e386e53 CA-218260: Reverting to Snapshots causes VM to go back to parent host
Where we have a host the VM is running on (ie vm.resident_on is not null) at the time it is reverted, attempt to start/resume on that host if possible, instead of the home server of the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-21 17:39:03 +01:00
Mihaela Stoica
a04e8dbccf Merge pull request #1123 from GaborApatiNagy/CA-150816
CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
2016-09-20 14:02:18 +01:00
Gabor Apati-Nagy
9b383054af CA-222118: CentOS 7 VM's XenServer Tools installation message is misleading in Notifications
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 14:10:21 +01:00
Konstantina Chremmou
73a549a4d0 Improvements made while investigating CA-218953:
- when the cd drive or the tools iso cannot be found, the action should fail.
- if the tools SR is broken, do not show the error on a pop-up because the UX is
bad when installation is attempted on multiple VMS.
- added one more entry to the list of possible tools iso names.
- small performance improvement.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-17 22:35:01 +01:00
Gabor Apati-Nagy
c7482b8c93 CA-150816: fix: G11n:I18n: Hardcode issue "Set VM other_config" on Authentication dialog.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:43:20 +01:00
Konstantina Chremmou
917754c937 CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk Image actions
title so we can tell the one from the other. For consistency I used a format similar
to Import/export XVA. I also removed the gerund from the latter as it cannot be
used when the action is completed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-19 23:53:17 +01:00
Mihaela Stoica
727c7a5212 CA-203345: Exporting snapshot jams and cant be cancelled (when exporting 2 snapshots to the same file)
Replaced the call to Task.destroy() with the DestroyTask() method, which additionally sets RelatedTask to null. This ensures that we stop polling the task for its progress and report the error.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-07 15:27:45 +01:00
Frezzle
07a62a703d CA-211369: focus of the machine/console switching back to the vm post snapshot with disk and memory is performed incorrectly/misleading (#1019)
[CA-211369] Console switching when snapshot completes

ConsolePanel.setCurrentSource() being called in ConsolePanel.Snapshot() was causing the console view to switch to the target snapshotted VM's console, but only if the user is already on a console tab. The screenshot now happens before the snapshot begins, instead of after; this way, the screenshot always occurs when not on the console tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-22 16:27:14 +01:00
Mihaela Stoica
219209f1fe CA-209281: Check pool.policy_no_vendor_device on VM create before setting VM's has_vendor_device property
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-04-27 09:58:33 +01:00
Stephen Turner
5093ef677c CA-201421: tools ISO is missing in drop-down list 2016-02-25 17:18:48 +00:00
Gabor Apati-Nagy
1ca313c1e0 Revert "CA-178985: Removed ova.xml import from XenCenter" 2016-02-24 15:33:18 +00:00
Rob Hoes
b9f4d24ca7 Use new SR.is_tools_sr and VDI.is_tools_iso fields to detect the Tools SR/VDI
If the new field is not present, we'll fall back to the old method, which is by
name_label (SR.is_tools_sr/VDI.is_tools_iso will be false in that case).

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
2016-01-29 15:40:49 +00:00
Gabor Apati-Nagy
89a91bd247 CA-187681: Improvement for VM.IsWindows property
vm.guest_metrics.PV_drivers_up_to_date is obsolete (and can be wrong) for new type Windows VMs and this led to early escape from this action.
2016-01-20 12:13:35 +00:00
Gabor Apati-Nagy
274c98d8d9 CP-14822: UI: New VM Creation: update code to apply recommendations
This changeset implements the followings:

On creation of a new VM,
* XenCenter will use licensed state of the host to determine whether it should obey/apply the template-recommendation regarding the vendor device.
* If the host is licensed, and the selected template's recommendations suggest that has_vendor_device can be set/should be set to true, as part of VM creation, XenCenter will set the vm's has_vendor_device based on the recommendation using set_has_vendor_device API call (after it has cloned the template and before calling vm.provision).
* XenCenter will not expose details whether 1G or 2G VM is going to be created.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-17 15:31:41 +00:00
Gabor Apati-Nagy
f0ea3aa807 CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 12:12:20 +00:00
Gabor Apati-Nagy
4586832d5f CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 11:01:28 +00:00
Mihaela Stoica
3c956f28ac CP-14780: Revert Windows Update changes (part2)
Revert "Merge pull request #708 from GaborApatiNagy/master_windows_update"

This reverts commit fe03f1382f, reversing
changes made to 423065a2c8.

Conflicts:
	XenAdminTests/TabsAndMenus/MainMenuGeorge.cs
2015-11-10 13:13:23 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Gabor Apati-Nagy
7b7bcb0aa5 CP-14379, CP-14461, CP-14462, CP-14463, CP-14464, CP-14465, CP-14467:
Implementing Upgrading VMs to Windows Update

New screen features:
-Create skeleton of the Upgrade VM dialog
-Implement a Go To Console link (just a link that opens a vm console)
-Implement logic to show the right status for a VM (includes rules to
get the states). Includes updating the dialog whenever the status changes.
-Add status texts to Messages, proper text on the UI
-Add stub methods to VM class in XenAPI-Extensions to r/w states from
Guest Agent
-UI: Implement rules what vms to display, checkbox rules, read only vms,
and when to enable the Upgrade button
-Implement Upgrade button (writes state for GA, mounts ISO) + maximum
parallel executions/actions

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-10-16 12:47:00 +01:00
Mihaela Stoica
f507b65126 CA-183321: Fixed the bug where the disk initial and incremental allocations values were ignored while creating new VM's disk
When creating a new VM, we no longer use vm.provision to create VM's disks, but instead we create the disks ourselves using vdi.create; this way we can specify the initial and incremental allocations for the new disks.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-18 15:51:17 +01:00
Gabor Apati-Nagy
191820abf4 CA-177058: [SCTX-2146] VM Power Admin could not create VMs - RBAC issues with XS 6.5 2015-08-04 11:25:59 +01:00
Gabor Apati-Nagy
ffb620461f CA-147254: Adding DVD drive fails with obscure error message 2015-05-15 16:32:37 +01:00
Mihaela Stoica
830d8f6f60 CP-11292: Remove storage motion constraints: changes following code review
- added some null checks
- in the Cross pool migrate wizard, add Transfer network page for all cases except intra-pool move (which is performed via VMMoveAction)
- added comments to VMCrossPoolMigrateAction constructor to make it cleared what the copy parameter means

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-15 09:37:12 +01:00
Mihaela Stoica
e314a654f7 CP-11292: Remove storage motion constraints: Allow cross-pool copy for stopped VMs
- modified the VMCopyCommand to launch a cross pool copy if permitted
- added the CrossPoolCopyVMCommand which opens the Cross pool migration wizard in "copy" mode
- modified the cross pool migrate action with an extra "copy" parameter, which will add a copy option to the vm.migrate_send function call

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-31 14:27:04 +01:00
Mihaela Stoica
d616009824 CP-11032: Remove storage motion constraints: Allow cross-pool move of stopped and suspended VMs
- With these changes, a stopped or suspended VM can be moved across pools; this is performed as a vm migrate operation.
- The intra pool move will continue to be a vdi.copy + destroy operation for stopped VMs, but for suspended VMs we need to do it a as vm migrate operation.
- We use the Cross Pool migrate wizard for both intra and cross pool move operations, but introduced a wizard mode parameter in order to adapt the wizard to the specific operation we want to perform (migrate, move or copy)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-17 16:35:12 +00:00
Mihaela Stoica
18ee60104b CA-162966: Fix the bug where the GPU value could not be updated via VM Properties for Linux HVM
- The problem was that we didn't create a vgpu if the vgpu_type was null. But for Linux HVM, this is gpu passthrough case.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-03-04 16:50:49 +00:00
Mihaela Stoica
eab66b9bf0 CA-161002: Internationalize strings on the Cloud Config Parameters page and CreateVMAction
- also added Help Id got the Cloud Config Parameters page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-19 14:48:52 +00:00
Mihaela Stoica
9c652cd687 CP-10926: Add dialog for customizing the config drive in XenCenter after VM creation
- The cloud config parameters page is only visible on a VM that already has a config drive.
- The cloud config parameters can only be changed when the VM is halted.
- In the New VM wizard, if a template is selected that already has a config drive, them the wizard will display the existing configuration, not the default one.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-13 14:43:13 +00:00
Mihaela Stoica
8b9d089687 CA-160904: Fix NullReferenceException on the New VM Wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-09 11:16:01 +00:00
Gabor Apati-Nagy
fddb5a032b Merge remote-tracking branch 'creedence-docker/master' into docker
Conflicts:
	XenAdmin/Wizards/NewVMWizard/NewVMWizard.cs
	XenModel/Messages.resx
2015-02-04 16:23:20 +00:00
Mihaela Stoica
dbdd3cc02c CA-157501: Fixing inconsistent GPU dialogs in XS "Standard" when compared with "Enterprise"
New properties:
- Pool.HasGpu = Pool has at least one PGPU
- Pool.HasVGpu = Pool has at least one PGPU that HasVGpu
- PGPU.HasVGpu = PGPU has at least one supported_VGPU_type that is not pass-through

New or modified helper functions:
- Helpers.GpuCapability = GPU feature not restricted (by licensing) and Pool.HasGpu
- Helpers.VGpuCapability = vGPU feature not restricted (by licensing) and Pool.HasVGpu
- Helpers.ClearwaterSp1OrGreater = API version is 2.1 or greater

The GPU dialogs are displayed as follows:
- GPU page on VM properties dialog: Visible only if VM.CanHaveGpu and the GPU feature not restricted (by licensing)
- GPU page on New VM Wizard: Visible only if VM.CanHaveGpu and the pool has GPU capability (Helpers.GpuCapability)
- GPU page on Pool properties dialog: Visible only if the pool has vGPU capability (Helpers.VGpuCapability)
- GPU tab: Visible only if the pool has GPU capability (Helpers.GpuCapability) and is Clearwater SP1 or greater
- On the GPU tab, the "Placement policy" panel: Visible only if the pool has vGPU capability (Helpers.VGpuCapability)
- On the GPU tab, the "Edit" button on the "vGPU types" panel: Visible only if the PGPU.HasVGpu and vGPU feature not restricted (by licensing)

Also:
- VM.CanHaveVGpu function renamed to CanHaveGpu
- On the GPU tab, renamed "Allowed vGPU types" to "vGPU types
2015-01-19 16:49:47 +00:00
Gabor Apati-Nagy
afbbf25325 CA-153179: Add options for customizing the config drive to the XC VM creation wizard
Todo: tidy up code & code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-12-04 18:04:43 +00:00
Stephen Turner
577363a3a1 CA-141389 Log all GET and POST calls 2014-08-07 16:23:06 +01:00
Mihaela Stoica
3c051654d6 CA-136173: Getting several notifications for one user-level action (e.g. Updating network operation creates 4 entries in the Notifications/Events view)
-  Suppress reporting of success and failure for sub-actions:
The suppress history flag is set when the action is created and if is false (by default) the action is added to the history (the Events list).
In order to suppress history for the subactions, we need change all actions used in Edit pages so their constructor can set the SuppressHistory flag and then use these constructors with suppressHistory = true on all the implementations of IEditPage.SaveSettings() where an action is created
(then we need to remember to do the same everytime we introduce a new page and / or "save" action).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-07-21 11:19:04 +01:00
Mihaela Stoica
d69df44cf1 CA-137305: When creating a VM, ensure that the vGPUs are unset if not needed.
If a VM is created from snapshot which has a vGPU and "No" vGPU is selected  then the newly created VM shouldn't have a vGPU.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2014-06-30 09:44:19 +01:00