Commit Graph

503 Commits

Author SHA1 Message Date
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Gabor Apati-Nagy
01cebc9166 Merge pull request #1404 from MihaelaStoica/CP-19607
CP-19607: Make sure that event handlers are unregistered when controls are not visible
2017-02-01 13:53:14 +00:00
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Sharath Babu
9da9aabce7 CA-241767: [VMSS] Scheduled snapshots not getting listed in XC
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-31 10:01:33 +05:30
Letsibogo Ramadi
2aae7ab0f2 CA-239890 - EN: The update for PVS-Accelerator is displayed as “pvsaccelerator” on the “General” page.
Changes all update names to friendly names which are usually identical to the Name Description.
2017-01-26 10:39:06 +00:00
Mihaela Stoica
c35eae23be CP-19607: Unregister event handlers when the tab pages are hidden
Implemented a generic mechanism to allow tab pages to unregister their event handlers when they are hidden (when a tab page gets deselected)
Also changed VMStoragePage to derive from BaseTabPage, so it could use the same mechanism.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:38:33 +00:00
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
66eab6d8cb Merge pull request #1384 from letsboogey/master
CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Cre…
2017-01-17 12:47:47 +00:00
Letsibogo Ramadi
d83bc64cef CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Created On” list
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-17 10:37:55 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
9b9d0bb353 Merge pull request #1354 from GaborApatiNagy/master
CA-214628: .NET Image limit causes exception
2017-01-16 11:47:13 +00:00
sri harsha tagore k
cb0a0e2267 L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
Gabor Apati-Nagy
a1a411b9df CA-214628: .NET Image limit causes exception
Further changes

* implemented similar logic for the Commands too as those are keep on getting updates so affected
* moved these static fields to a class (at Images)
* used the same casing as in Resources once they have been moved

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-11 13:56:45 +00:00
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Mihaela Stoica
e45accbe55 CP-20245: Wording changes for change of feature name to PVS-Accelerator
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
5a117334af CA-214628: .NET Image limit causes exception
Changed code at a a few places where it made sense to limit how many times XenCenter asks the Resource Manager for a new instance(*1) of the same(*2) image.
*1: RM returns a new object each time
*2: they are the same as we don't change the locale of a thread and also we don't localise these images - by design

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 13:57:50 +00:00
sri harsha tagore k
5bb479ec4e L10N:TRanslations check-in
CA-235023 fix
2016-12-16 10:59:45 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Mihaela Stoica
a1d878725d CA-231500: XenCenter allows you to open multiple windows from change role button
Show the "Change role" dialog as modal. This way we avoid other issues, like removing the user while the "Change role" dialog is open.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-01 17:08:51 +00:00
Mihaela Stoica
1aaa310c50 Merge pull request #1287 from kc284/master
CA-145890: added new Page to the options dialog where the user can co…
2016-12-01 09:39:22 +00:00
mcintyre94
7f2ecb6eab [CA-233454] PVS tab doesn't show a new VM when it's created (#1314)
* [CA-233454] PVS tab doesn't show a new VM when it's created

Refined the rules for not adding a VM to the table, if it is a template (thus not_a_real_vm), and it has the __gui__ prefix (thus hidden), we still add it, but hide it.
When its name is changed (to remove the __gui__ prefix), we update its name and re-calculate whether it should be visible (in the case of a new VM this will be true once the __gui__ prefix is gone). Also resort the table if a node changes from hidden to visible, because it appears as an addition to the table.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update criteria for VM visibility to include is_a_real_vm

is_a_template is changed before the name_label removes the __gui__ prefix, so this works with no other changes to the vm property changed event.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Update when the VMs are shown in the PVS list

New observable property IsBeingCreated for VMs, set to true when they're made a hidden object, and false when they're removed from hidden objects (both in CreateVMAction). In the PVS Page when this is set to false, we re-evaluate whether a VM can be shown. This means that new VMs show here at the same time they're added to the tree (only different is tree refresh time), instead of far earlier (and before their networks were added).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* [CA-233454] Set IsbeingCreated in the CreateVMFastAction

* [CA-233454] Properly support the VM Fast Create action

Further changes to CreateVMFastAction, to ensure it works with PVS tab - use the __gui__ prefix when the VM is created and then change it back just before showing.

* [CA-233454] Small logic adjustments/tidying up
2016-11-30 12:24:02 +00:00
Mihaela Stoica
c437d10bc8 Merge pull request #1310 from mcintyre94/CA-232963
[CA-232963] XC hangs after restarting toolstack while viewing PVS tab
2016-11-24 17:17:33 +00:00
Callum McIntyre
1046cf2fb8 [CA-232963] XC hangs after restarting toolstack while viewing PVS tab
Changed the collection handlers to use ProgramInvokeHandler in the same way as other tabs, instead of Program.Invoke which caused the hang.
2016-11-24 16:51:48 +00:00
Mihaela Stoica
ad5669e718 Merge pull request #1280 from mcintyre94/CA-149812
[CA-149812] EN: Duplicate hotkeys about “Dismiss All” and “Dismiss Selected" tabs.
2016-11-24 10:15:13 +00:00
Callum McIntyre
c512fe8542 [CA-149812] Set Dismiss All as the default option on Updates page 2016-11-17 15:35:27 +00:00
Konstantina Chremmou
2e6b2d8995 CA-145890: added new Page to the options dialog where the user can configure how
confirmations are displayed. Added checkboxes to the dialogs requesting confirmation
of dismissal of notifications so the user can opt to skip this step.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-17 13:35:31 +00:00
Callum McIntyre
ce9d8fd409 [CA-228051] XenCenter should notify user if the PVS Cache config is incomplete
Changes as discussed on the ticket: No longer disable the rows when they have a warning in the dialog, support warning about storage configuration as well as PVS configuration, and also include these warnings in the PVS page table.
2016-11-11 17:02:04 +00:00
Callum McIntyre
fed20f9c41 [CA-149812] Change to D for date, A for all, C for selected. Use same hotkeys on all three of the similar pages. 2016-11-11 14:37:11 +00:00
Callum McIntyre
db2b824242 [CA-149812] EN: Duplicate hotkeys about “Dismiss All” and “Dismiss Selected” tabs.
Moved to A for Dismiss All, and E for Dismiss Selected. Since this frees D (the toolstrip menu split button uses one of these, so was previously always D), moved Filter by Date from A to D.
2016-11-10 16:45:57 +00:00
Mihaela Stoica
8f7c34c33f Merge pull request #1247 from mcintyre94/CA-207601
[CA-207601] License expiry time in general tab is incorrect
2016-10-31 15:29:26 +00:00
Callum McIntyre
034a686947 [CA-226116] Add Windows update as a hidden feature
If windows_update is in the hidden features registry key, then we hide the virtualization state line about Windows update.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-28 12:58:23 +01:00
Callum McIntyre
25c7accae5 [CA-207601] License expiry time in general tab is incorrect
The problem here was that TimeSpan.Minutes is always below 60, eg. for 67 minutes it is 7 (with TimeSpan.Hours being 1 then). So our TimeSpan was correct, but if it was between 1 and 2 hours then we would write the minutes in the second hour (which is below 60), ignoring the hour. The fix is to use s.TotalMinutes which for 67 minutes is 67. Hours also had a similar issue, except it would be off by 24 hours for spans between 1 and 2 days.
2016-10-27 16:07:07 +01:00
Mihaela Stoica
8b9985f894 Merge pull request #1246 from GaborApatiNagy/CA-227067
CA-227067: General tab: XenCenter does not show Reboot required when Toolstack restart is required
2016-10-27 15:33:32 +01:00
Gabor Apati-Nagy
fa7dbc14ed CA-227067: General tab: XenCenter does not show Reboot required when Toolstack restart required
On the General tab XenCenter shows a list of updates that requires the host to be restarted. This is shown for applied updates for which the required guidance hasn't been done (eg. restartHost or restartAgent after-apply-guidances)

This commit fixes a regression that caused restartToolstack warnings to be not shown in the list of warnings.

The displayed messages are also improved, XenCenter will show Toolstack restart or host restart appropriately and not just restart only as it used to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-27 14:27:20 +01:00
sri harsha tagore k
5b482aa43a L10N:TRanslations checkpin 2016-10-27 14:46:55 +05:30
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
sri harsha tagore k
1e8791fb38 L10N:TRanslations check-ins 2016-10-19 16:37:43 +05:30
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Konstantina Chremmou
c7ea650cf6 CA-157786: Use NameWithLocation to display the name of the VDI's SR. Also, removed
unconventionally named method which did not offer much to code legibility.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 23:26:13 +01:00
Konstantina Chremmou
38bf5b86d3 Merge pull request #1208 from MihaelaStoica/CA-224567
CA-224567: PVS Site renaming plus some other improvements
2016-10-17 22:06:48 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Gabor Apati-Nagy
f5545c83f5 CP-19265: Some improvements to comments
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:59:20 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Mihaela Stoica
af680eb6eb CA-224666: Things in PVS tab constantly refreshing
- instead of repopulating the whole grid when a proxy or a site changes, we now refresh just the row that needs refreshing, and when the refresh is indeed needed.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 16:59:46 +01:00
Gabor Apati-Nagy
5df1593989 CP-19264: Live Patching in XC: Use Pool_update version of Host.patches_requiring_reboot in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 14:48:17 +01:00
Mihaela Stoica
d6c735bd18 Merge pull request #1173 from kc284/migration
CA-220511, CA-187659, CA-220216 plus some refactoring and minor enhancements.
2016-10-07 10:11:07 +01:00
Konstantina Chremmou
f36fa9ea2f Fixed regressed button height. Also, it seems VS designer has the bad habit of
removing event registration unless it's written out fully like the rest of the
autogenerated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-06 09:13:52 +01:00
Gabor Apati-Nagy
c3f376ed7d CP-18422: Remove supp pack handling code for Ely hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 13:22:29 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Mihaela Stoica
d827361acc CP-19086: Improvements to the PVS cache UI
- Removed the cache configuration gridview from the PVS tab. This tab now contains the button to configure PVS cache and the VMs grid
- Show the confirmation dialog even when deleting a new site
- Enabled the "View PVS servers" button only if the site has servers

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-05 09:51:23 +01:00
sri harsha tagore k
77631ffb3e L10N:TRanslations check-ins 2016-10-05 10:58:50 +05:30
Gabor Apati-Nagy
5966c5399a Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PatchingPage.cs
2016-10-04 15:10:47 +01:00
Gabor Apati-Nagy
1750c47de9 CP-18421: Use host.updates instead of host.patches
Showing relevant Pool_updates instead of Pool_patches on General tab

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-03 14:19:32 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Konstantina Chremmou
2ff6f74488 Fixed the following issues:
- Was only able to move and not migrate vdi if selected from the objects view.
- The text on the ToolStripMenuItems on the SrStoragePage was different from the
corresponding buttons.
- Added item move/migrate to the multiple VDI context menu. The Properties item
should not be shown in this case.
2016-09-28 09:50:23 +01:00
Mihaela Stoica
fe6144ba70 CP-17920: Add dialog for PVS cache configuration
- this commit contains a temporary image for PVS_site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:44:17 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Mihaela Stoica
8ea8c71f74 Merge pull request #1164 from kc284/master2
Did some work on the SrStoragePage:
2016-09-22 14:12:59 +01:00
Konstantina Chremmou
03639d35b5 Added missing hotkey to the delete toolstripmenuitem; changed the hotkey on the move
toolstripmenuitem so it's the same as the button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 23:12:54 +01:00
mcintyre94
6707139e6e CAR-2184: XAPI changes. (#1177)
* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-20 12:33:00 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Konstantina Chremmou
9a26b3cb2e Did some work on the SrStoragePage:
- show/hide the context menu items instead of creating and adding new ones each time the context menu opens
- right click menu with rescan/add was not available for empty list or when empty space was clicked
- the condition for the edit button was slightly different from the edit toolstripmenuitem
- improved button layout (part of CA-100083)
- tidied up button event handlers and renamed one or two class members
- removed unused parameter in constructor and method of VDIRow

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-14 09:06:19 +01:00
Konstantina Chremmou
0f9c6fbc2f Did some work on the VM storage page:
- fixed issue where the context menu with add/attach items was not available
for empty list or when empty space was clicked; in the latter case I also clear
the selections
- added ability to launch the context menu by using the windows properties button
- moved context menu to the designer; changed code to show/hide the relevant menu
items instead of adding new ones each time the context menu opens
- added icon to the context menu item Properties
- fixed button layout (part of CA-100083), then removed separators between buttons
because when they wrap it looks a bit strange
- fixed some weird cross-threading exception (could not reproduce reliably)
- renamed one or two class members and tidied up the button event handlers

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-13 01:29:47 +01:00
Konstantina Chremmou
d2a3a17369 Fixed typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 14:53:46 +01:00
Mihaela Stoica
8755126e8d Merge pull request #1144 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-09-02 11:17:55 +01:00
Callum McIntyre
df9410ac6a CA-112317: Sorting on SR storage tab is incorrect
Making the requested changes: Name is now sorted by the generic CompareTo method (which uses name with opaque ref as tiebreaker), and Description also uses opaque ref as tiebreaker for consistency.
2016-08-31 16:42:01 +01:00
Gabor Apati-Nagy
b510dbe8c7 Merge pull request #1140 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-08-30 15:57:47 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
1cc960860b CA-112317: Sorting on SR storage tab is incorrect
Change the sorting on the Name and Description columns to use StringUtility.NaturalCompare, which correctly sorts strings with numbers at the end (eg name, name0, name1, name2, name10 will now sort correctly while alphabetic sorting is incorrect). Also added a tie break on uuid to make sorting behave predictably with duplicates in these columns.
2016-08-26 10:06:30 +01:00
Callum McIntyre
cf4ed293ba CA-140181: Inconsistent name displaying when it contains symbol '&’ and becomes hotkey.
Now using the EscapeAmpersands string extension method. Also resolved the custom fields display issue in the same way.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 11:33:24 +01:00
Callum McIntyre
14288ede3a CA-140181: Inconsistent name displaying when it contains symbol '&’
The ticket said the character after the & became a hotkey (like labels etc do with UseMnemonic enabled) but I couldn't reproduce that - & symbols were simply removed from the string. The fix is to replace them with &&, so the string.format prints a single & as it should.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 16:07:53 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Callum McIntyre
2d089fa9e9 CP-18013: [XenCenter] Update host/pool updates pane
Generalising to also support pools. New CheckHostPatchesRequiringReboot method with the same behaviour as old method (return list of KeyValue warning messages). Pool updates on Ely use the union of messages from this method instead of the old one. Also localised the "{hotfix} on {server}" string per todo (hence resx changes).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 10:45:11 +01:00
Callum McIntyre
dffd7507cc CP-18013: [XenCenter] Update host updates pane
For servers running Ely or greater we now produce messages for patching requiring reboot using the host.patches_requiring_reboot field. The Pool_patch objects resolved are sufficient to produce the same messages. Note that some patches produce a message in the old API but not the new, this is intentional. Still to do: update pool updates in the same way,

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 09:29:39 +01:00
Gabor Apati-Nagy
0cb878d577 CA-150198: EN: Missing hotkey for “Properties” after right clicking virtual disk.
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-15 17:32:53 +01:00
Sharath Babu
795b12cdcd CA-213500: Revert To, Actions and Delete buttons
are enabled even if there is no manual snapshot.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-08-10 12:04:11 +05:30
Mihaela Stoica
9df8b0494c CP-18407: Rename PVS farm to PVS site
- Rename everything to PVS site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 12:01:59 +01:00
Mihaela Stoica
dea2749afa CP-18407: Rename PVS farm to PVS site
- New API bindings
- Fixed usages of PVS_farm class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 11:12:34 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Sharath Babu
815822e003 CA-213499: List view of snapshots not working as expected with VMSS
vmss snapshots are shown even when Scheduled snapshots is
unchecked in same menu.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-29 09:28:21 +05:30
Frezzle
6c7df810f3 [CP-16936] Implement GUI for viewing the PVS farms and PVS servers (read-only)
Added new dialog for viewing PVS farms and servers.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-25 15:26:08 +01:00
Mihaela Stoica
5d6867dab0 CP-16921: Add new PVS tab
- Changes following code review
- Made PVS tab localizable and added Chinese and Japanese resources

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-21 11:47:42 +01:00
Konstantina Chremmou
2fd3a91ee6 CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-20 00:04:06 +01:00
Mihaela Stoica
f2b21975aa CP-16921: Add new PVS tab
- tab visible on pool or standalone server if the feature is not restricted and the pools has at least one farm

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-13 13:36:49 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Frezzle
84b587235e Merge pull request #1053 from kc284/master
Some refactoring and small issues fixed.
2016-07-11 11:43:57 +01:00
Konstantina Chremmou
336681fc6a Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the
VMstorage page uses the default colours of the controls, hence we only need to set
them on the VNCTabView and the linklabel does not need to be public.
2016-07-06 08:55:28 +01:00
Konstantina Chremmou
f320dd7881 Renamed control because Resharper was complaining about ambiguous references in
the resx files between this and homonymous control in two derived classes. Removed
reference of non-existent file from XenAdmin.csproj.
2016-07-03 19:45:40 +01:00
Alexander von Gluck IV
4d0097ce9c XenAdmin/TabPages: Case fix on WlbPage files 2016-06-30 22:51:27 -05:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Mihaela Stoica
62870544c6 CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix UpsellDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:26:52 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
546dbca6e1 CP-17444: Show minimal hotfixes on General tab
Changed heading from Recommended Updates to Required Updates following further discussions around wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 16:16:01 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Gabor Apati-Nagy
725beacd4b CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
Fixed duplicated headers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 12:03:26 +01:00
Frederico Mazzone
9a729e2547 [CP-17415] XC: Add awareness of new AD feature flag
Added awareness; basic license now shows upsell tab and premium license shows full feature tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 13:01:51 +01:00
Frederico Mazzone
049e0f100d CA-209496: EN: Duplicate hotkey appeared on the “Updates” page of “Notifications” windows.
Changed hotkey for 'Check for Updates Now' button from Alt+U to Alt+C.

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2016-05-03 18:09:59 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
CITRITE\sriharshak
ed7c0a3b82 L10N:CA-205516 fix 2016-04-14 20:15:46 +05:30
Mihaela Stoica
cc28388726 CP-16756: Change how XenCenter decides whether to display "I/O is optimized"
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-08 17:10:08 +01:00
Gabor Apati-Nagy
7477c1080d Merge pull request #926 from MihaelaStoica/CA-202269
CA-202269: Hide "Subscription advantage" link on the Updates page bas…
2016-04-07 09:57:48 +01:00
Mihaela Stoica
93c22c04b0 CA-202269: Hide "Subscription advantage" link on the Updates page based on the registry key
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-06 07:33:18 +01:00
Mihaela Stoica
a0940ebeec CA-205181: The error message for check update truncated when the screen resolution is 1024x768
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-05 08:21:14 +01:00
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Gabor Apati-Nagy
347efe3305 Merge pull request #898 from MihaelaStoica/CA-203434
CA-203434: License Status displayed as "Not Found" on General tab
2016-03-15 15:53:58 +00:00
Mihaela Stoica
c4b7ca3514 CA-203434: License Status displayed as "Not Found" on General tab
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-11 14:17:58 +00:00
Mihaela Stoica
a63fe3fd66 CA-202483: Change the Search tab title to "New Search" when a new search is created
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-11 13:57:21 +00:00
Mihaela Stoica
a62726254a CA-202476: Hide Scheduled snapshots option on the Snapshots page for hosts version 6.2.0 and higher
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-08 15:35:19 +00:00
Koushik Chakravarty
e13b2b7beb CAR-2146: Changed the SDK API naming terminology
Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-18 16:27:17 +05:30
Koushik Chakravarty
e11974d864 CAR-2146: Integrated new SDK changes, re-using existing VMPP Dialog
Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-18 16:27:17 +05:30
Koushik Chakravarty
cf5040e9a9 CAR-2146: SDK Integration for VMSS and Testing
Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-18 16:27:17 +05:30
Stephen Turner
6949349830 Merge pull request #845 from GaborApatiNagy/master_CP-16097
CP-16097: Hide Thin Provosioning in XenCenter
2016-02-17 13:58:20 +00:00
Gabor Apati-Nagy
0f20df0f4b CP-16097: Hide Thin Provosioning in XenCenter
Added the same comment to all the changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 13:14:42 +00:00
Gabor Apati-Nagy
6cf7776795 CP-16097: Hide Thin Provosioning in XenCenter
Commented code out only for easier reverting.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-17 11:42:19 +00:00
Stephen Turner
5a6283c5ec Merge pull request #843 from GaborApatiNagy/homepage2
CP-15402: Improvements to the new HomePage
2016-02-17 09:31:52 +00:00
Gabor Apati-Nagy
f5e833b230 CP-15402: New Home Page (html based)
Localized the url of the Home Page. Globalization team can now reference different files per localization in InvisibleMessages.resx. (Eg. HomePage.ja.mht) The file then has to be added to XenAdmin.csproj, similarly to HomePage.mht.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-16 15:09:06 +00:00
Gabor Apati-Nagy
977d4c0c76 Merge pull request #810 from huizh/CP-13123
CP-13123: Add two buttons on General Tab of docker container.
2016-02-16 11:25:33 +00:00
Gabor Apati-Nagy
8d7bff1b45 CP-15402: New Home Page (html based)
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-15 16:25:17 +00:00
Gabor Apati-Nagy
5e8c3b4f62 CP-15402: Replaced existing to a new, html-based Home Page
* Changed the installer to use the (yet) manually generated MHT file that encapsulates all the source files of the HomePage, so we don't have to have the installer to deploy every single file, so have changed the installer as well. This also makes branding easier.
* Added the license to the LegalNoticesDialog

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-15 15:37:21 +00:00
Gabor Apati-Nagy
8a0f4512d7 CP-15402: Replaced existing to a new, html-based Home Page
Tried to keep changes at one place while not abstracting things too much as we have don't need any complex functionality yet.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-15 14:01:37 +00:00
Hui Zhang
c5d9445684 CP-13124: Use SSH private key for docker guest VM authentication.
1. Specify the key file location and name.
2. Update of the file name of docker command.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2016-02-15 18:24:37 +08:00
Hui Zhang
784804c8d8 CP-13124: Invoke Putty, SSH to VM and run docker command.
1. Run 'docker attach' if user clicks 'View Console' button.
2. Run 'docker logs' if user clicks 'View Log' button.
3. Make IPAddressForSSH a property of VM for common usage.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2016-02-14 15:14:44 +08:00
Mihaela Stoica
9f99c37f83 CP-16012: Rename branding variables
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-10 11:52:30 +00:00
Hui Zhang
73c8bf4604 CP-13123: Add two buttons on General Tab of docker container.
1. Add "View Console" and "View Log" on general tab of docker container.
2. Grey the two buttons if the container is on Windows (Server 2016) VM.
3. Enable the two buttons when the container is running on Linux VM.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2016-02-06 15:34:09 +08:00
Mihaela Stoica
86ec959e26 CP-15399: Improvements to the way we handle rebranding of saved searches
- InvisibleMessages.resx contains the default value for the saved search (xensearch), which can be overwritten in Branding.cs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 12:04:33 +00:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Gabor Apati-Nagy
249489220b Merge pull request #786 from MihaelaStoica/CP-15407
CP-15407: Add license editions
2016-01-26 11:32:54 +00:00
Mihaela Stoica
3416707fd2 Merge pull request #785 from cheng--zhang/CP-15401
CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depend…
2016-01-26 09:31:24 +00:00
Cheng Zhang
5c399ab4ba CP-15401: Avoid have null in URL constructor
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-26 11:16:39 +08:00
Cheng Zhang
04d3b81d92 CP-15401: Changed WarningWithInformationUrl and ProblemWithInformationUrl to cope with empty URL string
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 11:15:30 +08:00
Mihaela Stoica
3ccfcc7e3a Merge pull request #782 from cheng--zhang/CP-15398
CP-15398: Make version, xsupdate and xensearch rebrandable
2016-01-22 13:16:03 +00:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Mihaela Stoica
6feab75fb4 CP-15407: Add license editions
Cherry-picked from cream-indigo:
CP-14857: Add "premium" license edition
CP-14857: Add premium license edition for CN version
CA-190342: Add friendly name for "basic" edition
- also hide the Status field from the License Details section if the license is basic

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-21 12:31:33 +00:00
Mihaela Stoica
9aee7a4f9b Merge pull request #773 from GaborApatiNagy/CA-187681
CA-187681: xs-tools ISO doesn't get mounted on dlvm xva(Centos 7 HVM)
2016-01-20 12:27:29 +00:00
Cheng Zhang
992ee9e62f CP-15400: Make xensearch rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-20 11:33:54 +08:00
Cheng Zhang
08741a1fa0 CP-15398: Make texture company name rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:54 +08:00
Cheng Zhang
4f0270d049 CP-15398: Make texture XenServer Host rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:52 +08:00
Cheng Zhang
010ff919c1 CP-15398: Make texture XenServer product rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:36:21 +08:00
Cheng Zhang
a33d10bade CP-15398: Make texture XenCenter rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-14 18:52:53 +08:00