Commit Graph

16 Commits

Author SHA1 Message Date
Konstantina Chremmou
6adcd2b83f Some more code simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Gabor Apati-Nagy
3805bcef40 CA-249084: Fixes for code review
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:31:17 +01:00
Gabor Apati-Nagy
2823e0337b CA-249084: Fix code for new build number format
removing unneeded code (after 55f17d4)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:37:19 +01:00
Gabor Apati-Nagy
55f17d416b CA-249084: Fix code for new build number format
fixed by removing checks that are no longer needed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 11:06:03 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
f17617b2ec CA-227601: check whether the storage repositories support database replication
on a background thread and show a spinner while this is going on. Also: run this
check only the first time the page is loaded; some refactoring, namely simplified
the code scanning for SRs by reducing the number of things each method does;
fixed column widths; removed unused property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-07 13:54:03 +00:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Adrian Jachacy
6e2b3fc40f CP-4946: PR-1634: Bulk import of FibreChannel LUNs in DR Wizard.
Clear All button disabled when no rows selected; Select All button
disabled when all rows selected.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-06-28 09:04:39 +01:00
Adrian Jachacy
9358362bd0 CP-4946: PR-1634: Bulk import of FibreChannel LUNs in DR Wizard.
Fixed issue reported in review #1846.
2013-06-25 17:01:21 +01:00
Adrian Jachacy
085629c3de CP-4946: PR-1634: Bulk import of FibreChannel LUNs in DR Wizard.
Added possibility to select/clear all rows on the Locate Mirrored SRs
page in the DR wizard.
2013-06-25 11:48:20 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00