Commit Graph

14 Commits

Author SHA1 Message Date
Konstantina Chremmou
f0c1396a7c CA-334860: Attempt repatriating only VMs that have actually been evacuated
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:42:14 +00:00
Mihaela Stoica
01b011c982 CA-329399: Improve the error message displayed if the update wizard if a host cannot be evacuated.
If a host cannot be evacuated because other hosts in the pool are maintenance mode and pending a reboot following an update installation, then include instructions to reboot those hosts and then press Retry.
Also updated the text for the Manual mode, removing the reference to installing other updates and doing a reboot manually at the end, because that won't be always possible, due to the fact that now we put the hosts in maintenance mode before installing the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-11-08 10:27:49 +00:00
Mihaela Stoica
aaa573dd21
Merge pull request #2438 from xenserver/feature/REQ-745
Merge feature/REQ-745 branch into master
2019-05-20 10:48:48 +01:00
Mihaela Stoica
32a41236a8 CA-317856: Ensure that VMs are repatriated after all hotfixes are appl… (#2436)
* CA-317856: Ensure that VMs are repatriated after all hotfixes are applied and the host has been rebooted.
- there is no need to remove the "reboot host" plan actions from the delayed actions list, because the action itself has code to check if a reboot is actually needed.
* CA-317856: Only add the "Exit maintenance mode" progress step if the host is in maintenance mode at that point.
- moved the AddProgressStep() call inside the function that checks if anything needs to be done (i.e. is host needs to be enables)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-05-17 12:32:25 +01:00
Mihaela Stoica
788f0cd9df CA-309037: Do the host evacuation before applying the updates
If a host needs to be rebooted after the update application, and the update is not a live patch, then do the host evacuation before applying the update.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-02-15 11:18:28 +00:00
Mihaela Stoica
6d44fd0350 CP-30335 - Part 2: Add a new precheck + Part 3: Enhance the error message displayed in case of migration failure during the RPU (#2371)
* CP-30335: Fix RPU wizard tests

* CP-30335: Add abstract class WarningWithMoreInfo and use it for two of the existing Warnings

* CP-30335: Add a new precheck which produces a warning if the Dom0 memory after the upgrade will be increased.

- if the Dom0 memory after the upgrade is known, then a warning is shown if this is higher than the current memory, regardless of the version of the upgrade
- if the Dom0 memory after the upgrade is not known (e.g. because the rpu plugin does not have the function that returns this), then a warning is shown if upgrading from a pre-Naples version

* CP-30335: Add a more detailed error message if the host evacuation fails due to not enough memory in the RPU and Patching wizards

* CP-30335: Add branding variable for version 8.0

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-01-28 14:44:58 +00:00
Aaron Robson
a6d1ad9bfa CA-297666: Wait for host to become enabled before resuming a VM in the patching wizard. (#2233)
Signed-off-by: Aaron Robson <aaron.robson@citrix.com>
2018-10-04 13:55:50 +01:00
Konstantina Chremmou
ca6458ac84 Do not repatriate VMs if there are none to repatriate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
8d6b615841 Check and plug PBDs for VMs only if and when there are VMs to migrate; do not log
a message in this case as the SRs are reconnected after reboot and this may lead
to duplicate messages. Also, simplified check-and-plug methods for PBDs to avoid
repetition of iterations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-27 07:58:55 +01:00
Konstantina Chremmou
d3f761b070 Reworked the logging for the plan actions. (#2109)
* Deprecate set but unused Status property in favour of ProgressDescription.
* Deprecate set but unused TitlePlan property.
* Deprecated property Title in favour of ProgressDescription.
* Removed unused plan RebootHostPlanAction.
* Updated event declaration.
* Removed property Visible. The plan is to have the actions log their history as soon as some is available.
* Reworked the logging for the plan actions. The main change is the replacement of
the ProgressDescription with a stack where all the steps of an action are stored,
i.e. the action is responsible for its history, not the worker running it.
* Lock the progress history before accessing it.
* Better handling of error logging and user cancellation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-26 14:04:51 +01:00
Mihaela Stoica
1bd439a2af CP-28279: Corrections to the plan actions
- In the RPU case, re-enable the host after the upgrade is done, as the host will be put back into maintenance mode when needed during the update process.
- The VMs should not be repatriated during the RPU
- When a host is rebooted, it needs to be disabled first (even if an evacuation is not needed), otherwise the reboot won't happen

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-25 17:12:39 +01:00
Mihaela Stoica
a99ae50f57 CP-28279: Change the upgrade page of the RPU wizard to inherit from the class AutomatedUpdatesBasePage
- Methods have been added to the base class to deal with the manual upgrade mode

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-25 11:31:18 +01:00
Konstantina Chremmou
d69f2ddda3 Enforce treating warnings as errors in Debug mode too as it is going to save
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
4b6e826ed3 CA-284125: Prioritise a pending host restart over a mandatory toolstack restart.
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 15:12:04 +00:00