Commit Graph

5158 Commits

Author SHA1 Message Date
Konstantina Chremmou
d65dbeaf2e Launch action dialogs in a using block. Prevent button flickering when the gridview is repopulated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
1d5d06c15d No need to repopulate the whole list if a subject's property has changed, refresh just this subject's row.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
21072e13fc Removed redundant code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
41c2eb71f6 Smarter icon/text selection and minor layout improvements, in particular icon alignment.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
3bd8a03699 CA-272127: Aesthetic and usability improvements in the AD users list: fixed
cell alignment; removed grid; expand/collapse on row double click and on expander
cell single click. Refactored class AdSubjectRow.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
Konstantina Chremmou
18be622889 Made the Events page rows to expand/collapse on double click like the Alerts and Updates pages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-08-01 08:27:04 +01:00
timliu55
d6b18e969a CA-287610: EN: Error message "Unable to connect to iSCSI storage" is truncated
Just enable the AutoSize property like the other labels.

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-07-31 11:42:47 +01:00
Mihaela Stoica
9dc0d77ef6 CA-292626: Consider the contains-livepatch flag when doing prechecks in the automated updates mode.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-30 14:33:22 +01:00
Jisheng Xing
6cf48a9125 CA-293680: Tasks to be performed after upgrade in XC don't quite fit within the box
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-07-30 12:21:58 +01:00
timliu55
38391c943e CA-293628 Some RPU prechecks do not mention the host the precheck has… (#2156)
* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293628: Some RPU prechecks do not mention the host the precheck has run on
Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-07-30 11:06:26 +01:00
jishengx
260ec2d013 CA-284914: Prechecks are re-run every time the 'Hide successful prech… (#2088)
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-07-26 16:11:53 +01:00
Mihaela Stoica
f663ababd5 CA-293857: When uploading and introducing an update, delete the VDI if the update introduce fails (regardless of the error).
Also add a sleep to try and avoid getting a VDI_IN_USE exception when deleting the VDI after the upload failed or has been cancelled by the user

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-25 13:08:04 +01:00
Mihaela Stoica
2266e89cd9 CA-294285: Make WlbRetrieveVmRecommendationsAction an AsyncAction and specify the method for the RBAC checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-25 10:46:23 +01:00
Konstantina Chremmou
1bcbb3d454 CA-289960: If a VM does not acknowledge the need to shut down on host reboot,
include the VM's name in the message to help the user identify it.
Also, we have more instances of "shut down" than "shutdown".

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Konstantina Chremmou
85b326497d CA-293664: Corrected text colour for selected item.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-25 09:39:04 +01:00
Konstantina Chremmou
664bd9dd0c CA-293723: Reworked SR selection logic so that hotfix application works for
for both fully and partially attached SR. For ely and above the SR needs to
be visible from master, while for earlier versions we pick a list of a SRs
to cover all hosts.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Konstantina Chremmou
d0c011d00c Improved error message and simplified error handling and logging to avoid multiple catch-rethrow of exceptions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Konstantina Chremmou
58c6754ff2 No need to access the setting ServerHistory in a try-catch block that resets
all settings in case of failure. Null check and minor optimisation of setting
KnownServers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-24 10:14:57 +01:00
Mihaela Stoica
ee6925beae CA-293923: Changed the sleep time between retries.
Also, there shouldn't be a sleep after the last try.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-19 16:12:50 +01:00
Joey
e5f4329f5d
Merge pull request #2146 from MihaelaStoica/CA-293923
CA-293923: Use a NetworkAvailabilityChanged event to detect changes i…
2018-07-19 14:12:28 +01:00
vetrivelc
8ef1764c84 L10N: Translation Updates & CA-293780 2018-07-19 11:05:16 +01:00
Konstantina Chremmou
a86edc6cfd Copy some more properties of the XmlRpcProxy to the JsonRpcClient and ensure all
JsonRpcCient properties are replicated when the session is duplicated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-18 14:49:37 +01:00
Konstantina Chremmou
ac7eb1a8e2 CA-293478: Always set the WebRequest properties to the values specified by the JsonRpcClient.
This fixes issue where the WebRequest.Proxy had a non-null default value, which
prevented connection to a server with the management interface on a vlan.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-18 14:49:37 +01:00
Mihaela Stoica
42c3a369a3 CA-293923: Use a NetworkAvailabilityChanged event to detect changes in the network connectivity and mark the download as failed when the network becomes unavailable
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-18 14:23:37 +01:00
Mihaela Stoica
9fb6b85887
Merge pull request #2144 from xenserver/REQ-672
Merge REQ-672 to master
2018-07-16 12:36:15 +01:00
Konstantina Chremmou
d639708781 CA-293863: Do not update the done and in-progress actions on the worker thread.
Also, do not log error every time the output panel is updated.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-16 11:50:42 +01:00
Konstantina Chremmou
c67abdb9b8
Merge pull request #2141 from MihaelaStoica/REQ-672
Merge master into REQ-672 branch + fix the PoolHasGFS2SR class
2018-07-13 13:40:48 +01:00
Mihaela Stoica
a2aa002aae Update the PoolHasGFS2SR class to inherit from HostPostLivenessCheck
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-13 13:23:01 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
b0f9d41381 Changed the description of the actions saving properties of XenObjects to express
explicitly what the actions do. The previous description "updating" could be
confusing when seen out of context amidst other actions on the events page,
because updating also refers to server patching.
2018-07-13 12:39:33 +01:00
Konstantina Chremmou
a55d9d3edd CA-293764: Do not suppress history for the actions applying hotfixes because
if they fail the user has no indication an error occurred.
Also, simplified the logging and error handling within the action body: failures
are logged anyway by the base class, so no special handling is necessary.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
Konstantina Chremmou
9157db94ac CA-293764: Added new property XenObject to the Checks, which returns the Pool
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
Mihaela Stoica
192f38671b Add RBAC checks to PoolDisableClusteringAction
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 15:15:21 +01:00
serenc
e1cb27a80d CA-292991: Remove unused modules and check clusterHostPif not null
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
dc833d2cc8 CA-292991: Store resolved values in a variable
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
118eca3d61 CA-292991: Block host joining cluster with cluster network (bonded/unbonded) unless the interface is defined
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:59 +01:00
serenc
0bec35629a CA-293337: Pass device-config from probe to PBD.create
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-07-12 14:57:14 +01:00
Mihaela Stoica
15aee105f0 CA-293669:Code optimisation
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
f09683be7c CA-293669: Block the installation of an old-format patch if the pool is partially upgraded and the master is Ely or greater
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Mihaela Stoica
6e468da70a CA-293669: In the Updates tab, show the required updates for the slaves in a partiallly upgraded pool, even when the master's version cannot be found in the c-f-u
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 14:45:23 +01:00
Ji Jiang
6e2720cbc4 CA-292377: Show warning if no cluster network found
1) When create/delete bond, inconsistent cluster network may occur. Show
warning in this case.
2) Refactor UI on cluster network edit page.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-12 14:40:46 +01:00
Konstantina Chremmou
542cf63428 Improved the RBAC message on the Patching wizard to provide more info on the
minimum required role. Do not deselect a pool on the RPU wizard if it fails
the RBAC check; let the user decide either to reconnect with more privileges
or deselect it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-12 13:36:27 +01:00
Mihaela Stoica
5e9f6d84f9 CP-28712: Add new message and friendly names (#2132)
CP-28712: Add new message and friendly names

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-12 10:39:16 +01:00
Ji Jiang
ce3a1a6f02 CA-293686: Fix the spelling mistake
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 16:35:00 +01:00
Ji Jiang
9e8e8237e2 CA-293721: Improve host HostMaintenanceMode problem description
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-07-11 14:28:49 +01:00
Mihaela Stoica
12dc85f830 CA-293687: Remove redundant check
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
eeb671d960 CA-293687: After a host has been upgraded, perform a check for updates before calculating the minimal patches
(to ensure that XC has the latest c-f-u data, as it's possible that the user hasn't configured XenCenter to automatically check for updates)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
f59c6a4815 In the RPU wizard, run the HA and automated updates license checks on SelectedMasters, to ensure that they are run even if the master does not need to be upgraded or updated
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
Mihaela Stoica
046c4e1c7b CA-293682: In the RPU wizard, only check the batch hotfix license restriction for Dundee or greater hosts
... because pre-Dundee hosts dont't have this license flag, but they might have it after the upgrade.

Also added a bit more logging in the function that generates the update plan actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-11 12:59:52 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00