* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
- Moved Windows Server templates to a different category.
- Show templates in reverse alphabetical (typically release) order.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Fixed issue where the SR was not preselected when editing an existing disk and no scans were taking place.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Remove credentials controls from `BugToolPageDestination`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Explicitly call dispose in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Tidy up code in `BugToolPageDestination.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `StatusReportRow` to its own file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Move `ClientSideDataRow` and `HostStatusRow` to own files
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update order of pages in `BugToolWizard`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update action and create row for packaging status report in BugTool wizard
Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Allow for pending `StatusReportAction` to be cancelled
This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* CP-40842: Report packaged data amount in `ZipStatusReportAction`
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Remove unused `using`s
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
* Minor layout tweaks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed folder and namespace to match the ones for the other wizards.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed wizard's private fields. Some code efficiency corrections.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Keep the row classes as private within the BugToolPageRetrieveData class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Removed leftover unused action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Tidy up status report messages. Use more relevant icon.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Made blurb localisable.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed private fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplified the stages of the compilation of the status report.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Renamed row classes again to match the action names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Simplify reporting the progress of the zipping action.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
* Recursive call is not necessary. Tweaked message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Sort strings
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* Update copyright notices
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
---------
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-359965: Consider `physical_utilisation` value when checking for free space in thinly provisioned SRs
* CA-359965: Fix miscellaneous formatting issues
* Made SrPickerItem show the SR by default. Removed virtual method that was never overriden.
* Use slightly more intuitive name for property; also inverted its logic.
* Renamed VdiCreationCanProceed to the more specific CanFitDisks since it only deals with sizes.
* Re-arranged classes in file.
* Refactored SrPickerItem:
- Merged CanBeEnabled and DisabledReason properties to method CanBeEnabled(out disabledREason)
to avoid running the same checks twice.
- Pass the disk instead of the size into extension method SR.CanFitDisks
so that the correct size can be used for each storage (thin vs. non-thin provision).
* Correction as per code review and some tweaks to make the checks clearer and more efficient.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, some corrections to the template comparer on the NewVM wizard's Template page.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
* CA-34231: Replace negative language with `block list` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `stop` in code and references
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `freezing` in code
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run/ran` in code comments
Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
* CA-34231: Replace negative language with `run` in Command.cs Run method
Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/TabPages/GeneralTabPage.cs
* CA-34231: Replace negative language with `run` in Command.cs CanRun method
Used Resharper rename utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/DRConfigureCommand.cs
# XenAdmin/Commands/DRDryrunCommand.cs
# XenAdmin/Commands/DRFailbackCommand.cs
# XenAdmin/Commands/DRFailoverCommand.cs
# XenAdmin/Commands/DisasterRecoveryCommand.cs
# XenAdmin/Commands/VMGroupCommand.cs
* CA-34231: Replace negative language with `run` in Command.cs RunCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method
Used ReSharper rename utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Command.cs
Also applied to related symbols. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods named CanRun
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/CrossPoolMigrateCommand.cs
* CA-34231: Replace negative language with `run` in remaining Run methods
Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in Commands folder
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder
Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
# XenAdmin/Dialogs/Wlb/WorkloadReports.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
* CA-34231: Replace all remaining negative language with `run` in code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/Controls/WlbRecommendations.cs
# XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
# XenModel/WLB/WlbScheduledTask.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in code strings
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative language with `supporter` in .resx files
Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in CFUValidator code
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# CFUValidator/CFUValidator.cs
* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method
Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
# XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resources
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/EvacuateHostDialog.resx
* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`
Used ReSharper renaming utility. Excluded jp and zh resource files.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.resx
* CA-34231: Rename missing language references for change to `coordinator`
Misc files were not saved before last commits.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/HACommand.cs
# XenAdmin/TabPages/AdPage.cs
# XenModel/Actions/Network/CreateBondAction.cs
# XenModel/Actions/Network/NetworkAction.cs
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`
Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
# XenAdmin/Commands/HACommand.cs
* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Commands/AddHostToPoolCommand.cs
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/NewPoolDialog.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.cs
# XenAdmin/TabPages/GeneralTabPage.cs
# XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
# XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
# XenAdmin/XenSearch/Columns.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Actions/Network/CreateBondAction.cs
* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenModel/Messages.Designer.cs
# XenModel/Messages.resx
* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
# XenModel/Messages.resx
* CA-34231: Rename dialogs to replace negative connotations with `main`
Used ReSharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`
Also updated its resx file. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Update class names in HelpManager.resx
Following renaming of main password dialog. Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace negative language with `main` in `Metadata.cs`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`
Used ReSharper renaming
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`
Used ReSharper
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34231: Replace remaining negative language in solution
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove commented out code in VNCGraphicsClient.cs
Code has only been improved partially as it's not strictly relevant to the PR
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend negative word replacement in XSVNCScreen.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Simplify debug call formatting in NewPoolDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Add code mistakenly removed in MainWindow.cs
Removed as part of `f155f9c8`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Revert renaming of constant related to Windows' API
Considered external to CH Center
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`
Previous ALT+<key> hotkey was conflicting with CreatePool
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs
Not relevant to the PR, but the change is small enought to no need extra testing
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend typo in PoolJoinRules.cs
supporer -> supporter
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`
Variables and methods XenAPI-Extensions were mistakenly skipped
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`
Used ReSharper renaming utility.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`
This is only used to format the string
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`
Done in order to fix merge conflict into master
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CP-34231: Amend misc negative language renaming typos
`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Hide GPU page if the host has no GPU capability
* Hid GPU page in PropertiesDialog
* Hid GPU page in NewVMWizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Move GPU availability check to Helpers class
* Switch from field to method based check
* Update affected logic
* Remove rubric toggle in PopulatePage when GpuEditPage is shown
* Hide AddVGPUDialog when GpusAvailable returns false
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove missing GPUs strings in Messages.resx
* GPU_RUBRIC_NO_GPUS_POOL
* GPU_RUBRIC_NO_GPUS_SERVER
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Disable combobox in AddVGPUDialog when there are no GPUs
Avoids exception being thrown if user tries to select empty first item
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Amend position of GPU availability check
Moved since gpuCapability is used in the Finish method of the wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-310974: Remove unecessary null checks in Helpers method
The Cache and its properties (e.g. GPU_groups) are readonly and initialised as empty.
The API object properties that are ref lists (g.PGPUs, g.supported_VGPU_types) are also initialised as empty and are demarshalled by the SDK as empty if they have no values.
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
* CA-34935 ConnectionOptions invalid tooltip now dissappears when page changes or when the dialog moves
Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>
* CA-349435 modified IOptionsPage & IEditPage to include a Hide Tooltip method, implemented it in all relevant classes. Hooked up events in the options dialog & properties dialog to hide tooltips on tab change or dialog move
Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>
* CA-349435 removed duplicate pages that were added accidently/automatically
Signed-off-by: Christopher Lancaster <christopher.lancaste1@citrix.com>
Moving and copying a VM should be treated differently, hence we need a different
SrPickerItem subclass for each operation. Minor logic simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Reordered the labels to reduce flickering for short actions.
- No need to fire action events in a try-catch block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
