Commit Graph

47 Commits

Author SHA1 Message Date
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:17 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
25b61ea129
CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874. (#2730)
* CA-343763: Corrected the handling of VMSS alert priority/severity according to CA-342874.

- Distinguish between warnings and errors.
- Made PolicyAlert derive from MessageAlert to conform with other alert types.
- Replaced EventType column by a simple image column because it adds to clatter
  without really offering useful information.

* Correction as per code review.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 14:51:14 +01:00
Konstantina Chremmou
e3896239df CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues:
- Use a plain list to store update alerts and, where possible, fire a collection
  change event only after a bulk change and not every time a single object is added
  or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
  pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
9e1ec4cf41 CA-333236: Calculate local time for HotfixEligibilityAlert properties on the UI thread.
The Title and Description of HotfixEligibilityAlert  involve calculation of local
time which should be done on the UI thread, otherwise the time is not localised
correctly, and additionally the application crashes when dismissing or sorting
these alerts.
Also, stop spamming the logs with each alert removal; code efficiency correction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-02 13:15:18 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Mihaela Stoica
b7c64bddb2 CA-326341: Refresh the hotfix eligibility alerts after a check for updates is completed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-04 14:40:03 +01:00
Mihaela Stoica
e4305ecb15 CA-325822: Refresh existing hotfix eligibility alerts when the license status changes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Ji Jiang
0390bc3f6e CA-265405: Fix string bug in vmss history dialog
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-24 10:40:46 +01:00
Konstantina Chremmou
d9aeeb15e5 Rewriting of the Snapshot Schedule dialog for performance optimisation.
Merged the PolicyHistory control into the dialog; removed legacy column from
the policies datagridview; put retrieval of messages on a background thread
to avoid UI freezing if there is a huge number of messages; retrieve messages
only when the VMSS collection changes and not every time the run history grid
is repopulated; sorted out button enabled state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 11:02:07 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Mihaela Stoica
ffe7ff9520 Merge pull request #1632 from xenserver/REQ-378
Feature "REQ-378: Support Chinese Language E-mail Performance Alerts"
2017-06-13 10:51:42 +01:00
Mihaela Stoica
1bae482bc5 CA-242134: Remove the VMPP code: changes following code review
- removed unused methods and properties from the NewPolicyWizard class
- made the wizard pages private in the NewPolicyWizard class
- removed unused constructor from the NewPolicySnapshotTypePage class
- removed unused property from the PolicyHistory class
- removed the public properties TreeView and DataGridView from the SnapshotsPage
- removed the PolicyType from the PolicyAlert class and the constructor that is no longer used
- removed unused property from the VMSS class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:08:01 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Kun Ma
f533891df0 CP-21658: Refine control logic in PerfmonAlertOptionsPage
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-25 09:54:17 +08:00
Kun Ma
c007194e06 CP-21658: Expose UI of feature REQ-378 to user when the XenServer support the feature
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-17 15:27:50 +08:00
Kun Ma
8c837bb2c2 CP-19639: Refine data structure for mail language
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-13 13:34:30 +08:00
Kun Ma
22446010b4 CP-19639: Provide XenCenter UI configuration option for email alert charset
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 09:58:17 +08:00
Mihaela Stoica
335bffefaa Merge pull request #1431 from geosharath/CP-20545
CP-20545: [XC] Validate the usage of "scheduled snapshots" and "snapshot schedules"
2017-02-08 13:53:24 +00:00
Sharath Babu
087be4a776 CP-20545: [XC] Validate the usage of "scheduled snapshots" and "snapshot schedules"
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-08 14:00:47 +05:30
Sharath Babu
5595019d47 CA-241847: [VMSS] VM Protection policies pop-up from Pool -> VM Protection policies
raises XenCenter error on XS 6.1

When Text is null error is raised by split() function, we
need to handle that case.

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-03 10:41:19 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Sharath Babu
af182d9e7e CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-23 16:25:16 +05:30
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Stephen Turner
197ac05570 CA-200532: Restore a try-catch I shouldn't have removed 2016-02-26 17:12:24 +00:00
Stephen Turner
e67f6c4eb5 CA-200532: Fix "dom0 memory alerts turns on continuous dom0 file system alerts" 2016-02-26 16:36:27 +00:00
Koushik Chakravarty
556229c0a1 CAR-2146: Removed enum typecast, fixed some texts in UI
Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-19 17:32:18 +05:30
Koushik Chakravarty
d5db0335db CAR-2146: Initial Review comments incorporated
1. Changed the Messages to remove ambiguity between scheduled snapshots and
snapshot schedules
2. Made some functions as properties in IVMPolicy
3. Removed some redundant code

Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-18 16:27:17 +05:30
Koushik Chakravarty
e11974d864 CAR-2146: Integrated new SDK changes, re-using existing VMPP Dialog
Signed-off-by: Koushik Chakravarty <Koushik.Chakravarty@citrix.com>
2016-02-18 16:27:17 +05:30
Gabor Apati-Nagy
4baa36efab CA-189084: Control domain memory alerts not getting generated in Xencenter.
Dom0 memory alerts have to be configured in the other_config of the control domain (dom0) and not of the the host. This changeset implements this exception.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-07 17:57:54 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Mihaela Stoica
84372eb118 CP-13770: Configure the alerts for SR physical utilisation in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-21 00:04:46 +01:00
Mihaela Stoica
38a1633acb CP-14047: Display alerts for SR physical utilisation in XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-09-10 15:18:26 +01:00
Carmen Agimof
31924f9888 CA-181316: Sort by description is now working correctly. 2015-09-02 18:21:10 +01:00
Gabor Apati-Nagy
b9abdc4b1a CP-12640: Create alert when logs partition is full
Adding code for "log_fs_alert"
2015-07-24 16:03:27 +01:00
Carmen Agimof
b1a2b49559 CP-13026: Changes code style and removes commented out code. 2015-07-23 13:48:30 +01:00
Carmen Agimof
f79199752a CP-13026: Provide Dismiss option on the Updates Tab. 2015-07-23 11:48:14 +01:00
Gabor Apati-Nagy
c57800113b CP-9092: XenCenter work for Dom0 memory usage alert
-Adding control domain memory usage alerts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2014-08-05 21:40:26 +01:00
Konstantina Chremmou
c8ff1bee69 CA-122558: Removed FixLinkDelegate. Use System.Action instead.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 11:58:42 +00:00
Konstantina Chremmou
a762442b70 CA-122558: Removed property DescriptionInvariant; after the logs and alerts rewrite
it was only used when logging and only for the updates; using the Description in
its place should be adequate. Fixed bug in the formatting of XenCenterUpdateAlert.Description
and removed duplicate logging when dismissing an alert.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-03 11:27:35 +00:00
Konstantina Chremmou
b2e0c858e3 CP-6093: Tidying up: moved property from Alert to XenServerPatchAlert as it only
applies to the latter. Converted methods from AlertSummaryPage to one Alert and
one String extension method so they can be used more widely. Code simplification
on the Updates page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-23 14:04:15 +00:00
Konstantina Chremmou
fcc627113d CP-6093: Remove update alerts from the Alerts page, part 1/3: some code simplification
and efficiency improvements.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 14:11:29 +00:00
Konstantina Chremmou
361b49066c CP-6093: Anyone outside the Alert class should not know anything about the lock
used to access the alerts list. The list itself should be private as there is a
risk to access it and forgetting to use the lock.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-21 12:32:27 +00:00
Konstantina Chremmou
86234b2121 PR-1537: Moved duplicate alert comparison code from the AlertSummary and the ManageUpdates dialogs to the Alert class.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-03 12:00:00 +01:00
Konstantina Chremmou
8a7476c9c7 PR-1537: Added new virtual property Name to the Alert class. Removed time info from the Description of the XenCenterUpdate-, XenServerPatch- and XenServerUpdateAlert (not needed because it is shown on a separate column on the alert lists).
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-03 11:28:10 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00