Commit Graph

1208 Commits

Author SHA1 Message Date
Michael
1d0a2b76a0 CA-272769: Enable user to cancel URL testing in rolling upgrade wizard. (#1882)
* CA-272769: Enable user to cancel URL testing in rolling upgrade wizard.

* CA-272769: Sort messages resource file.
2017-12-06 12:06:36 +00:00
serenc
3532e9b586 CP-25563: Improved code from feedback
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-06 09:49:56 +00:00
serenc
7790bed4ca Merge remote-tracking branch 'upstream/REQ-477' into REQ-477
Signed-off-by: serenc <seren.corbett@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NetworkingPropertiesPage.cs
#	XenAdmin/Help/HelpManager.resx
2017-12-05 11:16:16 +00:00
serenc
f430cf58c8 CP-25563: Corrected column layout of tableLayoutInfo
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 15:57:12 +00:00
serenc
00aa042bd7 CP-25563: Added hotkeys,changed flowLayout and corrected label alignment
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 13:50:52 +00:00
Mihaela Stoica
72071a3334 Merge master into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI/Proxy.cs
2017-12-04 13:37:12 +00:00
serenc
69edc172eb CP-25563: Build now passes unit tests
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 10:53:58 +00:00
Mihaela Stoica
ea91951389 CP-26114: Hide the GFS2 option for FCoE
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-01 15:59:00 +00:00
Mihaela Stoica
1e4c293300 CP-26021: Update the GFS2 SR creation with the new syntax
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-01 15:27:42 +00:00
serenc
9f9754c8b0 CP-25563: Added Clustering page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-01 14:47:50 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
serenc
0f752ea035 CP-25551: Changed Page order and removed Event Handler from Designer
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-29 13:34:48 +00:00
serenc
7e7a6d9c46 CP-25551 and CP-25565: Updated branch based on PR comments
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 13:34:38 +00:00
serenc
5bb7a07711 CP-25551: Added Provisioning Page to the Wizard
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 10:51:44 +00:00
Konstantina Chremmou
23a9c50389 Merge remote-tracking branch 'upstream/master' into REQ-420 2017-11-23 14:07:21 +00:00
serenc
c4b228e8da CP-25551: Change Type page, Add provisioning page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-23 10:59:15 +00:00
Vetrivel Chinnasamy
5f594dae8a L10N: Translation Checkins 2017-11-22 16:03:36 +05:30
Mihaela Stoica
681f77bfd9 CA-273307: Replaced the links in the Upsell dialogs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-17 12:24:43 +00:00
Konstantina Chremmou
a170ec33e2 Merge remote-tracking branch 'upstream/master' into REQ-420
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	autogenerated XenModel/XenAPI/* files
2017-11-17 11:53:41 +00:00
Mihaela Stoica
7f602a782a CA-271970: Incorrect error when copying a VM on an unlicensed pool
Instead of showing the cross-pool migration upsell dialog, we now show the wizard, where user can try to perform an intra-pool copy (the cross-pool option is disabled with an explanatory message displayed)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-13 11:28:00 +00:00
Mihaela Stoica
0d41c62a01 Merge pull request #1837 from vetrivelc/master
L10N:CA-261954,CA-270715 & CA-270716 Truncation Fixes
2017-10-26 15:23:35 +01:00
vetrivelc
102b2d096f L10N:CA-261954,CA-270715 & CA-270716 Truncation Fixes 2017-10-26 15:36:54 +05:30
Mihaela Stoica
95323239a0 Merge pull request #1827 from vetrivelc/master
L10N:Translation Updates
2017-10-25 08:48:23 +01:00
Gabor Apati-Nagy
59b904eb2d CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-24 14:55:07 +01:00
Michael Zhao
b093082bcd REQ-158: Merge master to fix conflicts. 2017-10-24 18:51:24 +08:00
Gabor Apati-Nagy
033e7df8af CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-23 15:05:25 +01:00
vetrivelc
d05fd0efd3 L10N:Translation Updates 2017-10-23 19:01:14 +05:30
Mihaela Stoica
304b2c9fab CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-20 11:06:16 +01:00
Mihaela Stoica
6249663ae2 CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard.cs
	XenAdmin/Wizards/NewSRWizard_Pages/ChooseSrTypePage.cs
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoHBA.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
2017-10-20 11:05:45 +01:00
Mihaela Stoica
3bab5186f8 CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Rename SrWizardType
2017-10-20 10:42:54 +01:00
Mihaela Stoica
a56338861c CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoISCSI.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
	XenAdmin/XenAdmin.csproj
2017-10-20 10:42:35 +01:00
Mihaela Stoica
08cce7cb1d Merge pull request #1821 from GaborApatiNagy/master_CA-265225
[SCTX-2608] Honolulu Update - Server is still booting error
2017-10-18 10:00:11 +01:00
Gabor Apati-Nagy
8297314499 [SCTX-2608] Honolulu Update - Server is still booting error
Increased the wait between host_enable attempts, allowing to wait more for the host to reboot.

This will affect Automated Updates and other normal Patching Wizard
operations as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-18 09:56:35 +01:00
Joey
2dc9c00e41 Merge pull request #1817 from GaborApatiNagy/master_new
CA-267330: [Update Wizard Improvements] The Update wizard: block the installation of an update on slaves if a reboot or a toolstack restart is pending on master
2017-10-18 09:53:51 +01:00
Ji Jiang
e4ee106366 CA-268557: Fix the hosts order in Patching Wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-16 11:52:08 +01:00
Gabor Apati-Nagy
b589d0dd9e CA-267330: [Update Wizard Improvements] The Update wizard: block the installation of an update on slaves if a reboot or a toolstack restart is pending on master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-13 13:55:19 +01:00
Ji Jiang
7c6b94d172 CA-267671: Fix Configure HA wizard display text
when the max tolerance is being calculated, the text and icon on top of HA
wizard is no longer visible after this fix.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-12 18:12:44 +01:00
Mihaela Stoica
8fbfe4c060 Merge branch 'REQ-528' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/MainWindow.Designer.cs
2017-10-12 11:39:19 +01:00
Michael
e8cb4ad7d6 CP-24412 & CP-24333: USB device list filter in Attach dialog. (#1789)
* CP-24412: Apply a filter before adding USBs to candidate list in Attach Dialog.

* CP-24333: Apply HA restraint.

* CP-24412: Fix a merge error.

* CP-24412: implement actions to attach/detach/passthrough.

* CP-24412: Add license check before making UI components visible.

* CP-24412: Change layout of new components to Dpi.

* Fixed all comments.

* Fix comments.

* fixed comments
2017-10-10 09:05:22 +01:00
Mihaela Stoica
b79d7923cc CA-268105: fix the bug where the pool item is disabled when an update is already installed on one host in the pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-04 16:48:58 +01:00
Gabor Apati-Nagy
c00439bef4 CP-24818: [Update Wizard Improvements] Show the progress of the download in Automated mode
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-02 16:35:10 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Gabor Apati-Nagy
0cc907bb14 CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement (#1791)
* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Fixed unintended designer code additions/changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-29 11:05:57 +01:00
Mihaela Stoica
0e5f1335d4 CP-24498: RPU wizard to block the selection of unlicensed hosts
Also includes some improvements to the Select Pools page of the RPU wizard
- do not show the checkbox if the item is disabled
- show the icon for the pool items, not only for hosts (making this consistent with the similar page in the Update Wizard)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-25 13:27:06 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
0a33bf1448 Fix PatchingWizard_SelectServers version sorting
The problem is that pool and host rows are mixed when sorting by
version.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
dfe7a2ea70 Refactoring RollingUpgradeWizardSelectPool sorting
Combine sorting by Description and by Version to a single class

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Gabor Apati-Nagy
e92d3df839 Merge pull request #1752 from kc284/master
CA-265044: Text corrections on the New VMSS Schedule wizard; image co…
2017-09-08 18:00:03 +01:00
Mihaela Stoica
4274bf28fb CA-265172: Ensure that the "disk space requirement" precheck is performed for a standalone host in automated updates mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-07 14:29:39 +01:00
Konstantina Chremmou
dd76b9f0d5 CA-265044: Text corrections on the New VMSS Schedule wizard; image correction
on the VM Snapshots page; update VM's status on the Snapshots page when the
VM's membership in a policy changes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 12:56:41 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
69007dbaec CP-24213: Some fixes in the Patching wizard
- Change the "Web page" column alignment to TopLeft, to match the other columns
- When trying to find an alert from a filename, use the patch name instead of the alert name, because now the alert name can also be a version name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-30 09:31:05 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Vetrivel Chinnasamy
21eff4d819 L10N:CA-261954,CA-261973 & CA-261977 2017-08-21 16:19:39 +05:30
Ji Jiang
6bfbbc7aa8 CA-141166: Fix truncation issue on HA wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-31 09:09:54 +01:00
Letsibogo Ramadi
c44f89bf05 CA-249823 - Accept zip files in Updates Wizard (#1667)
* CA-249823 - Accept zip files in Updates Wizard
* CA-258326 - Improve implementation of CA-248823(Accept zip files in Updates Wizard)
* Small unrelated bugfix: Stop selectFromDiskRadioButton being checked when
restoring dismissed updates.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 15:56:27 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
vetrivelc
d829654203 Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-07-19 14:22:53 +05:30
vetrivelc
78fc06d0af L10N : Issue Fixing 2017-07-05 17:10:43 +05:30
Gabor Apati-Nagy
51c08c7433 Merge pull request #1666 from MihaelaStoica/CP-21161
CP-21161: Do not call the disk-space plugin cleanup functions on Ely …
2017-07-04 15:37:34 +01:00
vetrivelc
d624d93865 L10N:CP-23040,CP-23012 Traanslation Checkin 2017-07-04 10:39:46 +05:30
Mihaela Stoica
bdbe40187a CA-257760: Strip leading and trailing spaces from the filename in the Import wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-29 16:19:39 +01:00
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
537e569a62 CP-21161: Do not call the disk-space plugin cleanup functions on Ely and above hosts
- Ensure that the disk-space plugin functions are not called on Ely or greater hosts, except for the 'get_avail_host_disk_space' function, which is still needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 13:48:54 +01:00
Vetrivel Chinnasamy
1fce4298e5 L10N: Fix CA-255548 & translation updates (#1660) 2017-06-22 09:19:58 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
minl1
2105cbf1a4 cp-21685/cp-22367: Linx/YinheKylin linux XenCenter ICON support 2017-06-07 21:01:01 +08:00
Gabor Apati-Nagy
de97577430 CA-255551: [SCTX-2553] Automated Updates - Slaves rebooted before Master - XenCenter 7.1.1
Due to a regression (introduced by [1]), XenCenter will not run delayed actions in the correct host-order at all times. This can cause the master to be not the first host to be rebooted what may result in connections being lost to slaves should the API change between restarts/updates in a way that it would not be compatible to the previous version. This would make the wizard fail and users would have to restart their master host manually to make it connect to its slaves again.

This commit fixes the order of the hosts when executing the delayed actions.

[1]: 15827512e1

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-01 21:20:19 +01:00
Mihaela Stoica
5291c3aa7d Merge pull request #1613 from minli1/feature/Asianux-Turbo-Linux-support/master
req-398/req-440: ICON support for Asianux Linux and Turbo Linux.
2017-06-01 14:30:25 +01:00
minl1
c146747798 CP-21662:replace the icon for new vm template(asianux and turbo linux) in Xencenter 2017-05-31 13:19:47 +08:00
Mihaela Stoica
1bae482bc5 CA-242134: Remove the VMPP code: changes following code review
- removed unused methods and properties from the NewPolicyWizard class
- made the wizard pages private in the NewPolicyWizard class
- removed unused constructor from the NewPolicySnapshotTypePage class
- removed unused property from the PolicyHistory class
- removed the public properties TreeView and DataGridView from the SnapshotsPage
- removed the PolicyType from the PolicyAlert class and the constructor that is no longer used
- removed unused property from the VMSS class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:08:01 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Mihaela Stoica
6288ace0f5 Merge pull request #1594 from xenserver/release/falcon/staging
Merge release/falcon/staging into master
2017-05-17 12:45:36 +01:00
Gabor Apati-Nagy
47f7690536 Merge pull request #1590 from MihaelaStoica/CA-244663
CA-244663: In the Migrate VM wizard, add storage mappings for the VDI…
2017-05-16 13:54:13 +01:00
Mihaela Stoica
e50187b85e Merge pull request #1593 from GaborApatiNagy/master_CA-252923
CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
2017-05-16 11:52:22 +01:00
Gabor Apati-Nagy
eb45d14a8a Merge pull request #1576 from MihaelaStoica/CA-251630
CA-251630: XenCenter update wizard incorrectly states that some hosts…
2017-05-15 13:59:19 +01:00
Gabor Apati-Nagy
d55af4e5a7 CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
In rare cases, the GetMaster could return null, causing the update progress to fail with "Pool_patch or Pool_update not found". (when the Cache hasn't been populated by the execution gets here)
This commit drops GetMaster and uses a pre-saved masterUuid instead of waiting for the Cache what would be the other way to solve this issue.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-12 16:10:36 +01:00
Mihaela Stoica
d2f3c0c116 CA-244663: In the Migrate VM wizard, add storage mappings for the VDIs belonging to the VM's snapshots
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-11 16:42:41 +01:00
vetrivelc
21a7a74408 L10N: CA-250470,CA-250471,CA-250472,CA-250473,CA-250893,CA-250894 Localized UI fixes 2017-05-11 19:36:14 +05:30
Mihaela Stoica
1bc43eda7d Merge pull request #1586 from GaborApatiNagy/master_updates
CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
2017-05-10 12:35:00 +01:00
Gabor Apati-Nagy
d14f0d6b49 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 12:21:11 +01:00
Mihaela Stoica
d015ba223e Merge pull request #1575 from letsboogey/master
CA-251526 - Change template order in New VM wizard
2017-05-10 11:33:03 +01:00
Letsibogo Ramadi
0c7cf8678b CA-251526 - Change template order in New VM wizard
Moved "Legacy Windows" template to the bottom of the Windows templates
to discourage users from selecting it and avoid it being selected by default
at the top of the list as was the case.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 11:30:16 +01:00
Gabor Apati-Nagy
5eff76be28 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 10:06:41 +01:00
Konstantina Chremmou
652e446245 Merge pull request #1585 from MihaelaStoica/CA-242134
CA-242134: Remove the code targetting <= 6.1 XenServers
2017-05-10 08:14:23 +01:00
Mihaela Stoica
a31c31eb07 CA-242134: Remove licensing code targeting pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 13:40:48 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Mihaela Stoica
dd861cfeed CA-253047: Wrong prechecks are performed in Automated Updates mode if an update has been previously uploaded
Reset the PrecheckPage.PoolUpdate property on leaving the SelectPatch page, because it needs to be null for the Automated Updates mode and for the single update mode it will be updated on leaving the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 15:14:06 +01:00
Mihaela Stoica
6e4c5d3548 CA-251630: XenCenter update wizard incorrectly states that some hosts need rebooting and requires suspending VMs
Perform all the prechecks on applicable hosts only (i.e. the hosts that don't have the update applied already), with the following exceptions:
- The HA check, which is performed on the pool master
- The server-side precheck (PatchPrecheckCheck) which will still be performed on all servers in the pool and will show the warning if the update has already been applied on some servers

This commit also adds an override to the HAOffCheck.SuccessfulCheckDescription to show the pool name instead of the master's if the check is successful.
Also, in the PatchPrecheckCheck, I had moved the code that checks if the patch is already applied to the very beginning (before the host liveness check), so it will return the warning that the server will be skipped even if the server is not reachable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 14:32:36 +01:00
Gabor Apati-Nagy
95caad4919 CA-248920: The radiobutton selection on Select Update page is not preserved while navigating to the previous page in the Install Update wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-20 17:40:54 +01:00
vetrivelc
a291bd730a L10N:CA-205538 & other translation checkins 2017-04-19 14:36:03 +05:30
Gabor Apati-Nagy
49fd823650 CA-249084: deleted more unneeded code
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:50:47 +01:00
Gabor Apati-Nagy
3805bcef40 CA-249084: Fixes for code review
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:31:17 +01:00
Gabor Apati-Nagy
2823e0337b CA-249084: Fix code for new build number format
removing unneeded code (after 55f17d4)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:37:19 +01:00
Gabor Apati-Nagy
55f17d416b CA-249084: Fix code for new build number format
fixed by removing checks that are no longer needed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 11:06:03 +01:00
Mihaela Stoica
8650f5880b CA-249824: Unable to create vlan, bond using XenCenter
- set managed=true, otherwise the network creation fails with the error "The network is not managed by xapi"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-10 07:49:51 -04:00
Mihaela Stoica
47ccbd4581 Merge remote-tracking branch 'upstream/REQ-411' into REQ-411
Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.resx
2017-03-28 12:44:54 +01:00
Gabor Apati-Nagy
8afd06ee00 CP-21182: Improved wording in the Install Updates Wizard 2017-03-28 11:21:27 +01:00
Gabor Apati-Nagy
acf6bc5ef8 CP-21182: Improved wording in the Install Updates Wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-28 11:17:26 +01:00
Mihaela Stoica
40680b09ea CP-21574: Add checkbox on the Select Servers page for applying all the released updates after the new version is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-27 16:12:49 +01:00
Gabor Apati-Nagy
6051949227 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:54:57 +01:00
Gabor Apati-Nagy
0ac4cd5014 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:29:44 +01:00
Gabor Apati-Nagy
bd2fa92cbb CP-21504: Added check for restart (for the version update)
as we are expecting that to require a host-restart

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:36:11 +01:00
Gabor Apati-Nagy
77daf14629 CP-21504: minor fix
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:34:20 +01:00
Mihaela Stoica
4bfbcc5f83 CP-21504: Add automated updates license check for the new versions that are available as updates 2017-03-27 11:11:26 +01:00
Mihaela Stoica
7bd629c54e CP-21504: Removed an unused property in the PatchingWizard_ModePage
Also rearranged some code in PatchingWizard  class, to keep all property assignments together for each wizard page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:48:26 +00:00
Mihaela Stoica
1896d9f958 CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Introduced the WizardMode enum and the WizardMode  properties in several wizard pages (replacing the IsInAutomatedUpdates boolean property)
When in NewVersion mode, we show the same wizard pages as the AutomatedUpdates mode and we build the update sequence based on the selected update alert (which is an update to a new version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:43:19 +00:00
Gabor Apati-Nagy
3ec897a6fc CP-21500: Updates wizard: Show new versions that are available as updates
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 11:37:43 +00:00
Gabor Apati-Nagy
1317e5a4e3 CP-21500: Updates wizard: Show new versions that are available as updates
In the Updates wizard:
New versions that are available as updates will be listed in the "Download Updates from Citrix" section, before any other updates.
If XenCenter is not the latest version, these rows will be greyed out, with a tooltip.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-23 14:05:09 +00:00
Mihaela Stoica
83dbaf6b5e CA-237939: Cannot create VM from Checkpoint other than the resident host in pool
Use VM.clone (and not VM.copy) when creating a VM from a snapshot.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-23 12:49:24 +00:00
Mihaela Stoica
170dcfc70b Merge pull request #1504 from geosharath/CA-246288
CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
2017-03-23 09:34:08 +00:00
Sharath Babu
553e559bee CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-23 04:02:13 +05:30
Gabor Apati-Nagy
40074d5969 Merge pull request #1491 from MihaelaStoica/CA-242918
CA-242918: Improve the exception shown in XenCenter if the hotfix upl…
2017-03-22 11:05:51 +00:00
Mihaela Stoica
b65084fdc3 CP-21184: Add a check for the XenCenter version
- On the Updates tab: for new versions, check that the version of XenCenter is at least the latest. If not, give an additional option to download a newer XenCenter (for both updates and upgrades), and not offer "Download and Install" (for updates).
- In the Patching wizard: if the update is a new version, we force the user to first update their XenCenter to the new version
- In the RPU wizard: if the server version is not the latest and their XenCenter version is not the latest from updates.xml, we assume that they want to upgrade to the latest XenServer version and we force the user to first update their XenCenter to the latest version.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-22 10:59:32 +00:00
Sharath Babu
035fd959c3 CA-246288: [VMSS] Incorrect message in schedule properties->snapshot type window
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-22 09:58:04 +05:30
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
418d2edb7b Merge pull request #1461 from GaborApatiNagy/CA-244687_2
CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
2017-03-01 13:35:42 +00:00
Gabor Apati-Nagy
e9eeb3d595 CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 13:10:45 +00:00
Gabor Apati-Nagy
15827512e1 CA-244687: XSINT71E003 asks user to restart toolstack after installing hotfixes using Batch hotfixing
This commit fixes a bug in the Update Wizard that causes XenCenter to not restart Toolstack when it should in the following case: in Automated Mode, when the update sequence for a host has an update that contains live-patch with restartHost guidance (and guidance-mandatory=false) followed by an update with Toolstack restart guidance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 12:05:44 +00:00
Gabor Apati-Nagy
118dea1fa7 Merge pull request #1455 from MihaelaStoica/CA-245345
CA-245345: XenCenter doesn't mark a host as unapplicable when an upda…
2017-02-28 15:19:16 +00:00
Mihaela Stoica
dab5e3da05 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-28 14:29:59 +00:00
Mihaela Stoica
33979bb1f2 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:45:34 +00:00
Mihaela Stoica
f1470d1c53 CA-245345: XenCenter doesn't mark a host as unapplicable when an update is installed via "Select update from disk" option
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:43:02 +00:00
Gabor Apati-Nagy
da4140d75e Merge pull request #1443 from stephen-turner/CA-243964
CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers
2017-02-20 11:36:28 +00:00
Stephen Turner
20df8ce2fe CA-244097: XenCenter sometimes refuses .xsupdate files 2017-02-17 17:11:03 +00:00
Stephen Turner
74c567ef1d CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers 2017-02-17 16:56:44 +00:00
Gabor Apati-Nagy
2de8f55e30 Merge pull request #1439 from letsboogey/funnylabelfix
CA-236150 - Funny label on status report wizard
2017-02-15 14:05:14 +00:00
Letsibogo Ramadi
10bb65d2f2 CA-236150 - Funny label on status report wizard
Changed label to a LinkLabel instead of RichTextBox. Also fixed similar bug on the healthcheck enrollment dialog.
2017-02-15 13:51:19 +00:00
Stephen Turner
f3a64fc54b Merge pull request #1433 from geosharath/feature_merge
Scheduled Snapshots feature merge
2017-02-14 10:09:17 +00:00
vetrivelc
6d9273f304 L10N: Translation Changes & VMSS updates CP-20708 2017-02-14 03:27:38 +00:00
Gabor Apati-Nagy
6693570b11 Merge pull request #1428 from MihaelaStoica/CA-238265
CA-238265: Add the action title to the error message displayed on the…
2017-02-08 11:47:38 +00:00
Mihaela Stoica
ef331986c7 CA-238265: Add the action title to the error message displayed on the Install Update page of the patching wizard.
Also changed  ApplyPatchAction and ApplyUpdateAction to install a single update to a single host, so that the appropriate action title can be displayed if an action fails. And replaced 2 hardcoded strings with resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-06 13:04:07 +00:00
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Gabor Apati-Nagy
01cebc9166 Merge pull request #1404 from MihaelaStoica/CP-19607
CP-19607: Make sure that event handlers are unregistered when controls are not visible
2017-02-01 13:53:14 +00:00
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Sharath Babu
4833565ec6 Fixing copyright check failures at build time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-25 14:11:24 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Gabor Apati-Nagy
d85cc824b5 Merge pull request #1392 from letsboogey/master
Ca-238273 - Install Update Wizard: Update still shows up in the grid …
2017-01-20 17:01:26 +00:00
Letsibogo Ramadi
8f48c99b2d Ca-238273 - Install Update Wizard: Update still shows up in the grid after it's been installed
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-20 11:35:25 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Mihaela Stoica
0115461f66 CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added SelectDefaultControl() to more wizard pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-21 13:33:04 +00:00
Mihaela Stoica
ed4981b5a8 Merge pull request #1348 from GaborApatiNagy/CA-236547
CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
2016-12-21 11:32:28 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Konstantina Chremmou
e176194a06 Merge pull request #1339 from GaborApatiNagy/master_CA-211363
CA-211363: Replace 'User name' labels with 'Username'
2016-12-20 09:44:25 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Gabor Apati-Nagy
bff70c5c6a CA-211363: Replace 'User name' labels with 'Username'
Second round of renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-16 18:36:35 +00:00
Gabor Apati-Nagy
751ba4956d Merge pull request #1303 from kc284/CA-104329
CA-104329: Removed calculation which might cause lag from the page lo…
2016-12-16 11:13:05 +00:00
Mihaela Stoica
ce554a7cd3 Merge pull request #1335 from GaborApatiNagy/CP-20065
CP-20065: Change "Automatic Update" to "Automated Updates"
2016-12-13 11:16:04 +00:00
Konstantina Chremmou
f165cef307 CA-104329: Do not re-iterate through the datagridview rows to retrieve the VMs'
restart settings when leaving the page. Get the already calculated value from the
tolerance indicator instead.
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
bad9ef8cca Enforce a minimum size for the groupbox so its title does not appear ellipsized.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Konstantina Chremmou
38bc4848bb CA-104329: Removed calculation which might cause lag from the page loading step;
have the wizard do it before we get there. Also, replaced the labels in such way
that, if there should be lag, the user will not see the draft message used only
on the designer.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-12-13 09:10:26 +00:00
Gabor Apati-Nagy
9d5e71326c CP-20065: Change "Automatic Update" to "Automated Updates"
changed more messages following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-12 18:12:01 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Gabor Apati-Nagy
b0ca08ae6d CP-20065: Change "Automatic Update" to "Automated Updates"
made naming more consistent

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:44:15 +00:00
Gabor Apati-Nagy
5b6bedea48 CP-20065: Change "Automatic Update" to "Automated Updates"
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 14:19:37 +00:00
Gabor Apati-Nagy
122e6ae012 CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
fixed the name of a method

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-09 15:27:22 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Gabor Apati-Nagy
5f24a4e084 CA-211363: Replace 'User name' labels with 'Username'
According to the Microsoft style guide XC to use 'username' for UI fields and use 'user name' when it's being referred to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-07 11:12:58 +00:00
Gabor Apati-Nagy
517b4cc45b CA-207011: Don't allow XC to create more than one SMB ISO SR on the same share
This commit uses the same logic that is used for NFS ISOs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-06 11:27:53 +00:00
Gabor Apati-Nagy
5826a87551 Merge pull request #1325 from MihaelaStoica/CA-234827
CA-234827: Destination dropdown menu content is blurred with overlapp…
2016-12-02 16:19:45 +00:00
Mihaela Stoica
1d92986aa7 CA-234827: Added check for ErroDescription.Count
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 15:47:42 +00:00
sri harsha tagore k
821f42e1f2 L10N:Translations check-ins 2016-12-02 20:13:49 +05:30
Mihaela Stoica
765dee4fe7 CA-234827: Destination dropdown menu content is blurred with overlapping 'Action: vm.assert_can_migrate' text in Migrate VM wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 13:52:32 +00:00
Gabor Apati-Nagy
9c4628f216 CA-229365: Install Update Wizard: Fixed commas in the blurb
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-25 17:40:15 +00:00
Gabor Apati-Nagy
5cd032525c CA-229009: VDI is not deleted for the updates
If batch updating fails in a pool, this code will do the clean up by
running the appropriate (next in the queue) RemoveUpdateFilesFromMaster action. In addition to Pool_update.clean(), Pool_update.destroy() will be called when needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-24 10:40:06 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Sharath Babu
6b64efb9a6 CA-213563: VM policy cannot be changed to snapshot with
quiesce after installing vss tools

Enabling snapshot policy type to be changed to quiesce from
other snapshot policy types if the selected VMs are
quiesce snapshot capable.

Signed-off-by: Sharath Babu <sharath.babu@citrix.com>
2016-11-11 06:12:35 +05:30
Mihaela Stoica
ceaa7460e4 Merge pull request #1281 from GaborApatiNagy/CA-229009&CA-229019
CA-229019 and CA-229009
2016-11-10 17:52:24 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
Mihaela Stoica
bef415cc98 Merge pull request #1277 from GaborApatiNagy/CA-227719
CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
2016-11-10 17:20:03 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Mihaela Stoica
a609e440f6 Merge pull request #1272 from mcintyre94/CA-228729
[CA-228729] Improve the message shown on finishing the update installation
2016-11-10 14:47:29 +00:00
Mihaela Stoica
30a5f36515 Merge pull request #1271 from mcintyre94/CA-228723
[CA-228723]  Cancelling update installation leaves the update in xapi db
2016-11-10 14:45:51 +00:00
mcintyre94
e7f4f3b8a0 Merge pull request #1267 from kc284/CA-227601
CA-227601: check SR supports db replication on a background thread.
2016-11-09 17:42:41 +00:00
Callum McIntyre
638d8fe9e6 [CA-228723] Use sync destroy method in the cleanup action 2016-11-09 16:32:16 +00:00
Callum McIntyre
4a2b27e8ab [CA-228729] Improve the message shown on finishing the update installation
Changed the message to Delete/Deleting/Deleted update installation files, as used in other messages.
2016-11-09 15:52:52 +00:00
Mihaela Stoica
4df0c65d26 Merge pull request #1264 from mcintyre94/CA-226897
[CA-226897] Resume on Server option won't automatically resume the VM
2016-11-09 14:44:03 +00:00
mcintyre94
c595a1a624 Merge pull request #1262 from MihaelaStoica/CA-226103
CA-226103: Hotkey conflict in the “Choose the type of new storage” UI…
2016-11-09 11:00:44 +00:00
Callum McIntyre
d71d9d10d8 [CA-228729] Improve the message shown on finishing the update installation
Previous message was Remove/Removing/Removed Updates, which is confusing. Changed to Clean/Cleaning/Cleaned Update Files.
2016-11-08 16:53:50 +00:00
Callum McIntyre
6a096ebf07 [CA-226897] Move the VMCrossPoolMigrateAction to be a variable outside the block, and added SuppressHistory to the MultipleAction. 2016-11-08 16:05:51 +00:00
Callum McIntyre
d7060cbdb1 [CA-228723] Cancelling update installation leaves the update in xapi db
Modify the cleanup pool update action to also call update destroy (removing the update from xapi db) when the update has not been applied to any hosts (ie we cancelled the wizard before completion).
2016-11-08 15:31:35 +00:00
Gabor Apati-Nagy
bb298cc213 Merge pull request #1270 from MihaelaStoica/CA-227034
CA-227034: Slipstream packaged Live patching hotfix is rebooting host
2016-11-08 14:44:07 +00:00
Mihaela Stoica
b0c4521340 Merge pull request #1266 from mcintyre94/CA-227845
[CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
2016-11-08 14:31:20 +00:00
Mihaela Stoica
6b374cb400 CA-227034: Slipstream packaged Live patching hotfix is rebooting host
This happened because the LivePatchCodesByHost was null when the prechecks were generated for an update, so the live patch codes returned by the precheck were ignored.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-08 11:43:54 +00:00
Konstantina Chremmou
f17617b2ec CA-227601: check whether the storage repositories support database replication
on a background thread and show a spinner while this is going on. Also: run this
check only the first time the page is loaded; some refactoring, namely simplified
the code scanning for SRs by reducing the number of things each method does;
fixed column widths; removed unused property.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-11-07 13:54:03 +00:00
Callum McIntyre
15e04d1a6d [CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
Due to the tooltip container introduced for the automatic radio button, winforms didn't treat these radio buttons properly - we needed code to make them mutually exclusive, tab didn't behave properly and keyboard arrow navigation between them didn't work. Therefore I have removed the tooltip container (so our radio buttons behave properly without any extra work) and we instead use a winforms tooltip shown when the mouse is over the automatic radio button. Note that since the control is disabled when we want a tooltip, neither hover events nor attaching a winforms tooltip in the usual way will work. Therefore I use a mousemove event on the table, which displays the tooltip if and only if we are over the disabled control. Also adjusted the tab indexes to make sure tab works correctly across the whole page.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-04 17:09:52 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Mihaela Stoica
af8c178712 CA-147722: Truncation issue occurred on CPU & Memory window when VM memory more than physical memory.
Also aligning the warning icon with the label.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 15:30:56 +00:00
Mihaela Stoica
aca6c41aef CA-226103: Hotkey conflict in the “Choose the type of new storage” UI while creating new storage
Also changed the page to use different resource strings for the Storage type in the right hand panel (no hotkeys should be shown there)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-03 13:55:46 +00:00
Cheng Zhang
0b27b36d9b CA-227274: Fix CN and JP version process lable size
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-11-02 18:05:36 +08:00
Callum McIntyre
8e88d9d36d [CA-227608] Change HA intro page wording
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 17:42:00 +00:00
Callum McIntyre
07f866e3a0 [CA-227602] Remove the unused bottom row from the table
This fixes the extra padding, we don't need that bottom row at all

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 16:32:45 +00:00
Callum McIntyre
722527f84e [CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
I've looked at how this was implemented in Dundee, and there we used an absolute height on the row containing the manual checkbox. I've done the same here, changing row 3 from autosize to absoliute 47px. I've also removed the empty row that was between the two radio buttons. This is a Winforms problem, without workarounds an autosize radio button in an autosize container (say the table row) will report its height as one row of text, no matter whether it needs more. This seems to be the only place we use a long radio label (as opposed to a separate label underneath the radio), so I doubt it's worth doing anything more complex than this. I've tested it with the CN string used in the ticket, and it uses less space than the English translation. The string also hasn't changed from Dundee.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 15:17:43 +00:00
mcintyre94
5518efaa69 Merge pull request #1245 from kc284/master
CA-226817: Do not allow OVF/OVA import on a host incompatible with th…
2016-10-28 15:46:15 +01:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Callum McIntyre
c1e3346bd4 [CA-223486] Only add the licensing check if any hosts need to be checked
This will avoid having an empty group if no host needs checking.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 14:01:17 +01:00
Callum McIntyre
318faeedad [CA-223486] Refactoring and expanding fltering to all pre-Clearwater only checks
We now enumerate pre-Creedence and pre-Clearwater servers once, and check hosts only in those lists for the checks that only apply to those servers.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 11:39:01 +01:00
Callum McIntyre
299ed430cc [CA-223486] Only add the check for hosts that it applies to, instead of all selected ones.
This avoids unnecessary checks where we are upgrading multiple pools from different versions. Also made the same change for the unrelated pre-Clearwater only checks which had the same issue.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:18:26 +01:00
Callum McIntyre
0ba1e5c6df [CA-223486] Storage Link Status validation is included in Precheck During RPU
We now only include the StorageLink check if we have any hosts earlier than Creedence in the RPU.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 17:28:11 +01:00
Gabor Apati-Nagy
325f2c2c6e Merge pull request #1238 from xenserver/CAR-2245
CAR-2245: XenCenter changes for CAR-2245 Standarize packaging formats
2016-10-24 17:56:16 +01:00
Mihaela Stoica
6eb2c80895 CP-19257: Icon for Kylin Linux
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-21 18:46:38 +01:00
Gabor Apati-Nagy
55a4957056 Removed unused field (Release build failed on this)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 11:29:32 +01:00
Gabor Apati-Nagy
92b59a9e44 CA-226261: Install HFX Wizard: Mode page: both radio buttons selected
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 10:20:25 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
1c7f6ac643 Merge remote-tracking branch 'github_xenadmin/CAR-2245' into CAR-2245_temp 2016-10-20 17:58:20 +01:00
Gabor Apati-Nagy
6c26359dd6 Merge pull request #1222 from MihaelaStoica/CAR-2245
CP-19218: Add restart warnings to the Precheck Page when installing h…
2016-10-20 17:41:32 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Mihaela Stoica
2a66b68c7b Merge pull request #1220 from GaborApatiNagy/CAR-2245_temp
CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
2016-10-20 16:02:05 +01:00
Mihaela Stoica
8c93206ce5 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
-  If reboot is needed, display this as an info, not a warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 13:09:48 +01:00
Mihaela Stoica
2546731edc CA-226102: HFX wizard host selection not grayed out when hotfix not applicable for current version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 11:33:55 +01:00
Gabor Apati-Nagy
da0ebc467c CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Fixed refactoring mistake

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 14:02:29 +01:00
Gabor Apati-Nagy
64d7938f55 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Removed dead code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:34 +01:00
Gabor Apati-Nagy
27581fa7a1 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Moved ISO to InvisibleMessages and Branding

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:16 +01:00
Gabor Apati-Nagy
225885ac45 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Always define the extension to search for

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:39:14 +01:00
Mihaela Stoica
07faabe1f0 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
- added a new precheck, called "Live patching status" which checks is a reboot is needed for each host. If reboot is needed, the check will display a warning, otherwise it will show a green tickbox, saying that the server does not need to be rebooted, and if live patching is used, this information will be included as well.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-19 13:10:24 +01:00
Gabor Apati-Nagy
8ac6774e80 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 11:29:57 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Mihaela Stoica
7ec3881e05 Merge pull request #1212 from kc284/CA-157786
CA-157786: General tab for VDIs.
2016-10-18 08:01:57 +01:00
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Konstantina Chremmou
cff98908b3 Merge remote-tracking branch 'upstream/CAR-2226' 2016-10-17 11:07:15 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
0b3d3abfcc Code repetition.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 12:21:59 +01:00
Mihaela Stoica
9398837c38 Merge pull request #1205 from GaborApatiNagy/CAR-2245_CP-19266_2
CP-19266 & other changes
2016-10-13 15:08:38 +01:00
Gabor Apati-Nagy
7e20b11300 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:53:46 +01:00
Gabor Apati-Nagy
a9c2662715 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:55:21 +01:00
Gabor Apati-Nagy
a722c8b853 CAR-2245: Remove unused method
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:54:53 +01:00
Gabor Apati-Nagy
5fa7f5a797 CP-19265: Use Pool_update.async_apply
Changed XenCenter following the XAPI fix

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:27:34 +01:00
Mihaela Stoica
47665f5323 CA-225015: XenCenter Allows VM migration to MemorySR
- We shouldn't include the hidden SRs in the list of available SRs in the Migration wizard
- Updated the SR.SupportsVdiCreate function to return false for the Memory SR; this fixes other places where the Memory SR might be visible (e.g. all places where SrPicker is used)
- Also fixed the same issue in the  Attach disk dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 15:47:24 +01:00
Gabor Apati-Nagy
5df1593989 CP-19264: Live Patching in XC: Use Pool_update version of Host.patches_requiring_reboot in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 14:48:17 +01:00
Konstantina Chremmou
6df0508c92 Enforce filetrs to be run with a target that is Pool or Host and a non-null VM selection.
Small refactoring for performance gain on Host extension method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-11 09:45:37 +01:00
Gabor Apati-Nagy
6296277317 Merge pull request #1188 from kc284/vm_migration
CA-220218, CA-205799, CA-205791 plus one or two other issues and refactoring
2016-10-07 16:18:49 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
sri harsha tagore k
77631ffb3e L10N:TRanslations check-ins 2016-10-05 10:58:50 +05:30
Gabor Apati-Nagy
5cfce00e01 CP-17848: Apply hotfixes using new API calls
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 23:26:35 +01:00
Gabor Apati-Nagy
5966c5399a Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PatchingPage.cs
2016-10-04 15:10:47 +01:00
Gabor Apati-Nagy
7d62621dd3 CP-17848: Apply hotfixes using new API calls
Using new XAPI functionality in Install Update Wizard required by the new packaging format (ISO updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 14:58:54 +01:00
Konstantina Chremmou
b78f823b17 CA-220218: For halted VMs moving intra-pool, XenCenter does not need to assert migration
is possible, because what it actually does is move. When asserting migration use
an SR other than the VDI's current SR for the check to ensure that both source and
target SRs are checked to see whether they support migration. Also, use the VM's
Home() instead of resident_on to ensure the current server cannot be selected as
target server. Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-03 10:30:40 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
Mihaela Stoica
cdfec90fa8 Merge branch 'master' into CAR-2184 2016-09-30 14:46:26 +01:00
Konstantina Chremmou
61a2c12c45 CA-205799: Fixed issue where the user was allowed to select the VM's home server
as move (halted) or migrate (suspended) destination; this was caused by using the
VM's resident_on instead of Home() host. Also, changed the disabled reason to be
a bit more generic and cover cases other than migration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:59 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
Mihaela Stoica
2a6a237a7f CP-18889: Fix the layout in the CN version of the CPU page (#1166)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:17:00 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Mihaela Stoica
4aaaea43d9 CA-223407: Hosts don't get rebooted after a supplemental pack installation and the wizard is stuck in "rebooting" phase
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 10:07:00 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Gabor Apati-Nagy
b09de72f83 Revert "CP-18925: Hide batch hotfixing option in XenCenter" 2016-09-20 15:00:06 +01:00
Mihaela Stoica
963d5211d6 Merge pull request #1174 from mcintyre94/CA-217821
CA-217821: Renaming home server to target server in VM migration wizard
2016-09-20 11:43:24 +01:00
Callum McIntyre
0c5eaef042 CA-217821: Renaming home server to target server in VM migration wizard
We already renamed the column to target server, this changes the message in the case where the user doesn't choose a server on this page to also use target server.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-19 17:00:02 +01:00
Mihaela Stoica
db9eea0cf6 Merge pull request #1168 from sriharshak/master
L10N: Ely:Translation check-ins
2016-09-18 07:12:27 +01:00
Gabor Apati-Nagy
bd7d6bcc9c CP-18925: Hide batch hotfixing option in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-16 14:04:10 +01:00
Callum McIntyre
d83a9cefb5 CP-18417 review changes: Improved PatchRequiresReboot logic. Introduced a new bool someHostMayRequireRestart, passed as an out parameter into both the guidance string builder methods, and the Build method they both use. In that Build method the parameter is set to true if any restartHost guidance is seen - this check is done before live checks exit for consistency.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 17:19:47 +01:00
Callum McIntyre
5d53ab3db3 CP-18417 review changes: Simpler other_config key, added a pool extension method to check for it, moved the check on the Select Servers page to be the first check, simpler logic toggling the automatic/manual buttons. Still need to rework the PatchRequiresReboot part
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 16:37:37 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Callum McIntyre
31941eb71e Remove unwanted files from first commit
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-14 10:41:57 +01:00
Callum McIntyre
b22618ef5c Merge remote-tracking branch 'upstream/master' into CP-18417 2016-09-14 10:30:52 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Konstantina Chremmou
f4dfbe83b4 Merge pull request #1155 from MihaelaStoica/CA-220613
CA-220613: Truncation on the Migration Network page of the Cross Pool…
2016-09-12 09:02:28 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
2b215ffd78 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-17848
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs (resolved using master)
2016-09-09 12:59:29 +01:00
Callum McIntyre
9a8cb87e29 Pull down + merge master (which has changes to update wizard in live patching etc). Automerged. 2016-09-09 12:40:07 +01:00
Callum McIntyre
d302815b66 CP-17848: Commit to hand over. PatchingWizard_UploadPage.cs contains new code to introduce a Pool_update, PatchingWizard_PatchingPage.cs to apply and clean it. 2016-09-09 12:02:59 +01:00
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
a548c21120 CP-18417: Simplifying the automatic enabled/disabled logic.
Automatic is disabled if any pool forbids auto restart (per Neptune), and reboot is required. It's also disabled if the update type isn't one of the three in the switch statement. If it's enabled it is checked by default.
2016-08-26 14:45:24 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Callum McIntyre
af9327d30a CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Redone the commit without any size changes.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 10:52:00 +01:00
Callum McIntyre
493b86a5c3 Revert "CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard."
This reverts commit d928a406bc.
2016-08-23 10:37:29 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Callum McIntyre
615b55321d Intermediate checkin, branched from REQ156 and applied my changes, needs checking. 2016-08-19 17:27:24 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00
Gabor Apati-Nagy
feafb7ac62 CA-217232: Fixed regression caused by the fix for CA-216935
Comparing uuids instead of references that likely will be changed after the Cache has been repopulated.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:25:39 +01:00
Gabor Apati-Nagy
3fc9c3edb6 Merge pull request #1111 from MihaelaStoica/CA-210549
CA-210551: Non-modal action progress bar on the Pre-Checks page of th…
2016-08-16 16:08:54 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Mihaela Stoica
549bcd8480 CA-210551: Non-modal action progress bar on the Pre-Checks page of the Hotfix and RPU wizards
- Moved progress bar at the bottom of the page and made it the same height as on Upload page; This progress bar is now used when the prechecks are performed (existing functionality) and also for the "resolve" actions (new functionality).
- Added a label for displaying action progress.
- The icon and label saying that you need to resolve problems is hidden when there are no issues found and when an action is in progress (when the progress label is shown instead).
- When a resolve action is in progress, all controls on the page are disabled, apart from Cancel; pressing Cancel will cancel the "resolve" action and the wizard.
- Also put everything in a TableLayoutPanel (hence all the designer changes)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-12 13:27:47 +01:00
Gabor Apati-Nagy
50e9504da7 CA-217862: Batch Updates: Fixed order of checks when setting the tooltip for disabled hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-11 11:14:32 +01:00
Konstantina Chremmou
68ac5a50e4 CA-33357: FIxed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-10 15:24:47 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
12b44cfece Merge pull request #1093 from MihaelaStoica/CA-217388
CA-217388: Hotfix Install wizard shows update as already uploaded whe…
2016-08-10 09:11:37 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00
Konstantina Chremmou
208d4aa1f9 Merge pull request #1099 from GaborApatiNagy/CA-217844
CA-217844: Handling Automatic update not supported
2016-08-09 14:05:12 +01:00
Konstantina Chremmou
016c39bdaa CA-217843: AS requested per code review, hide originally the controls related to
automatic mode to avoid flickering during page load.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 12:45:35 +01:00
Gabor Apati-Nagy
e28ca1ded1 CA-217844: Handling Automatic update not supported
If there is no <minimalpatches /> tag, the version is not supported. This check has priority over licensed state when displaying the reason why a server is not supported.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:30:54 +01:00
Gabor Apati-Nagy
16afbd3bed CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-08 18:05:42 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Konstantina Chremmou
c30938ff12 CA-217843: Fixed various issues on the select patch page: control tab order; some
hotkeys; button enabled state; some memory leaks; added spinner while check for
updates is in progress; added alternative text for when automatic mode is not available.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 11:41:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Gabor Apati-Nagy
0ae6568a60 CA-216854: Fixed error messages shown
Now the wizard shows localized and friendly error messages instead of error codes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-03 17:15:57 +01:00
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Mihaela Stoica
9b9e9f87a8 Merge pull request #1076 from kc284/bugfix
Fixed bugs CA-207901 and CA-149814
2016-07-25 09:14:39 +01:00
Sharath Babu
5aaeeb3318 CA-213498: [VMSS] XC create new VMSS Policy wizard
disables "quiesce" option when no VMs are selected in policy

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-25 11:36:28 +05:30
Konstantina Chremmou
13e6a73fa5 Merge pull request #1074 from MihaelaStoica/CA-216697
CA-216697: MTU message present on the Network Settings page when crea…
2016-07-22 20:38:44 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Sharath Babu
4d4fab03cb CA-213493: [VMSS] Quiesce info icon and alert icon
in VMSS wizard are not aligned properly

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-07-21 12:43:55 +05:30
Mihaela Stoica
2e62dc8476 CA-216697: MTU message present on the Network Settings page when creating an internal network
In the New Network wizard, when the "Single-Server Private Network" type is selected, the Network settings page should not display the MTU hint message, because it is not relevant to any controls on the page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-20 10:26:12 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00
Gabor Apati-Nagy
893275fb2f CA-215573: Batch updates: Install update wizard "Finish" button activated even when batch install still in progress
Trivial changeset

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:25:17 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Frezzle
54a2ba7ac4 [CA-107357] Migrate VM Wizard allows selection of broken SRs
Detached SRs are no longer selectable.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-07 14:57:20 +01:00
Gabor Apati-Nagy
bd26c7ac0e CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Utilising default comparer on Host (This will makemaster first.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 15:37:52 +01:00
Gabor Apati-Nagy
f8a7d97890 CA-215093: Batch updates: Update progress failed in a pool of mixed state hosts
Where (in code removed by this commit) we iterated through the planActionsByHost dictionary, the hosts were iterated through in the order how the dictionary was initialized. Despite the actions were added in the right order, they then were screwed up, because the Cache.Hosts can have the hosts randomly while we want the master to be first.

To fix the bug, I changed the data structure from a dictionary to a list that has the actions exactly in the (good) order, the order they were added, eliminating the risk of the actions being retrieved in the wrong order.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 14:35:31 +01:00
Gabor Apati-Nagy
1fe300c16d CA-214063: Batch Updates: Name of the master is shown
Removed unused field

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 11:00:40 +01:00
Gabor Apati-Nagy
504f73778f CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Code review changes: Showing server icon for standalone hosts instead the pool icon

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-05 10:42:49 +01:00
Gabor Apati-Nagy
55ff3794cf CA-214063: Batch Updates: Name of the master is shown instead of the pool's name on Select Servers Page
Fixed display issue, now showing pools (and standalone hosts at the same level), not masters.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-01 17:41:49 +01:00
Mihaela Stoica
60c298d9e3 CA-116547: During Installation of Hotfix requiring restart of PV guests displays Dom0 in the list of VMs to be rebooted in XenCenter.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-30 12:32:41 +01:00
Gabor Apati-Nagy
66be637878 Merging (upstream) master into REQ-156 branch caused a build error:
Fixed build error that was caused by changed visibility of a method.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-29 17:56:51 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Gabor Apati-Nagy
ee08e06f52 CA-214566: Upload succeeded, but Pool_patch hasn't been found
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-27 19:43:41 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
e87505e13d CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix a dialog return check changed by accident

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-23 15:47:15 +01:00
Gabor Apati-Nagy
a8445d5ed8 Fixed warning as an error in build
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-23 10:27:16 +01:00
Konstantina Chremmou
3fc701ecb8 CP-17502: Hide SR types from the NewSrWizard if the corresponding sm plugin is not available.
Further, disable the Reattach SR if there is no sm plugin for its type.
2016-06-22 18:34:21 +01:00
Gabor Apati-Nagy
587c2b5f5d CA-214077: Typo in Messages.resx
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 14:43:22 +01:00
Gabor Apati-Nagy
39109d30a4 CA-214062: REQ-156 Batch Updates: In progress actions shown as done
Fixed trivial bug where in progress actions had done shown as their statuses

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-22 11:07:12 +01:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Konstantina Chremmou
0f908a674e CP-17750: Block the patching wizard for clusters with the hci-forbid-update flag (disable the relevant pools/hosts on the select servers page; do not launch the patching wizard at all if there are no clusters that can be patched). 2016-06-20 14:10:00 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Konstantina Chremmou
b575fd3d44 CP-17690: Block RPU for clusters with the hci-forbid-rpu flag (disable the relevant pools/hosts on the select pool page; do not launch the RPU wizard at all if there are no upgradable clusters). 2016-06-20 13:11:21 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
7a84b305ef CP-17699: Developer testing and improvements
for Batch Updating

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-17 14:15:59 +01:00
Sharath Babu
93e3c05216 Incoporating review comments by Mihaela.
Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-06-14 15:22:15 +00:00
Sharath Babu
2ad62fd48e CP-17752: make unit tests use a generic class of policy wizard and
added support for New Policy Wizard help document.

Signed-off-by: Sharath Babu <Sharath.Babu@citrix.com>
2016-06-14 13:20:04 +00:00
Mihaela Stoica
fcee4d8876 CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW (#951)
* CA-77990: Report required actions for all VMs at once in the hotfix wizard / RPUW

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Resolve precheck problems in parallel in the Patching wizard

Changes following code review: Made the ParallelAction work across connections and removed CrossConnectionParallelAction

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-77990: Modified ParallelAction to create queue on RunSubActions only, with the correct queue size

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-07 17:40:59 +01:00
Gabor Apati-Nagy
9ec512921b CP-15790: Prepare XenCenter for unit testing of Automatic Updates
Added support for defining custom update.xml location in Registry. This
can be either a local file or an URL. This will be beneficial when testing XenCenter.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-07 16:02:57 +01:00
Gabor Apati-Nagy
bd69aab6d2 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Changes following code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-03 15:08:30 +01:00
Gabor Apati-Nagy
d449b153b3 Merge remote-tracking branch 'github_xenadmin/REQ-156' into master_batch_new2 2016-06-03 13:31:00 +01:00
Gabor Apati-Nagy
3561155d03 CP-15719: UI: Implement error handling/reporting on Upload & Install page
Some more on error handling, better displaying of errors

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-01 13:45:21 +01:00
Gabor Apati-Nagy
81a0bf20f9 CP-15714: UI: Change Select Servers Page
DownloadUpdatesXmlAction is called on PageLeave and not when the user selects Automatic Mode. This way we get the error message at the right time, also showing a progress dialog what makes the UX much better.
New tooltips for servers on the Select Server Page to to cover two more cases

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-31 19:00:35 +01:00
Gabor Apati-Nagy
73d67f407d CP-15719: UI: Implement error handling/reporting on Upload & Install page
Implemented error handling.
If there has been an error in a pool, we stop executing actions in that pool immediately, and report the error once every other actions have finished. Error in one pool will not affect the upgrade process of other pools.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-18 13:43:34 +01:00
Gabor Apati-Nagy
a05e92d001 UI: Implement parallel execution of the sequences
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-11 14:13:14 +01:00
Gabor Apati-Nagy
235ebe9b33 Merge branch 'master' of https://github.com/xenserver/xenadmin into master_batchupdate_new 2016-05-05 13:59:28 +01:00
Gabor Apati-Nagy
834c012fb8 Merge pull request #953 from MihaelaStoica/CA-206464
CA-206464: Add certificate validation to the VM export
2016-05-04 13:58:04 +01:00
Gabor Apati-Nagy
deb4d5724c CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 13:47:41 +01:00
Gabor Apati-Nagy
ae02594683 CP-15713: UI: Change Before You Start page
Removed the first item instead of changing it - it is more logical to not to have it displayed here.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 12:25:38 +01:00
Gabor Apati-Nagy
62d332bc45 CP-15713: UI: Change Before You Start page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:37:39 +01:00
Gabor Apati-Nagy
fdb930bb19 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
cleaned up code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:21:23 +01:00
Gabor Apati-Nagy
72147734b5 CP-16513: UI: Apply licensing requirements 2016-05-04 11:08:08 +01:00
Gabor Apati-Nagy
fca591cd6f CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:07:37 +01:00
Gabor Apati-Nagy
466f01b926 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:06:39 +01:00
Gabor Apati-Nagy
d3914a2318 CP-15717: UI: Implement basic upload/precheck/patch/cleanup logic
intermediate commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-05-04 11:02:16 +01:00
CITRITE\sriharshak
809bf9161e L10N:Dundee translation changes 2016-04-26 16:39:21 +05:30
Mihaela Stoica
f9c52cd637 Merge pull request #962 from sriharshak/master
L10N:CA-205536 fix
2016-04-22 11:18:32 +01:00