Commit Graph

3631 Commits

Author SHA1 Message Date
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
2020-04-29 16:47:48 +01:00
Konstantina Chremmou
436ffe4a37 CA-338003: The action's Sessions is set once the action has started to run. Added missing help references.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests.
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
2020-04-24 15:37:01 +01:00
Konstantina Chremmou
40e395f2bd CA-338273: Accept more ISO 8086 formats.
Also, move time utility methods to one place (the Util class which contains unit conversions).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-24 14:30:32 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching
Merge feature/read-caching branch to master
2020-04-24 11:47:26 +01:00
Konstantina Chremmou
ec86bb39dc Fixed broken build.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 22:44:17 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627)
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 14:47:03 +01:00
Konstantina Chremmou
dcc87f4710 CP-32713: Show an error message if the user attempts an update using the base installation ISO.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-22 10:33:22 +01:00
Konstantina Chremmou
0ffccc6d03 CA-338184: Check for null before accessing host properties.
Also, property modernisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-21 10:38:15 +01:00
Konstantina Chremmou
fda52da475 Adjusted margins; made label bold because the current server state was not very obvious.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 19:07:31 +01:00
Konstantina Chremmou
cf0da96b87 CA-187943: Revised warning messages to take account the selected affinity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 19:07:31 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811
Merge feature/REQ-811 into master
2020-04-20 18:39:37 +01:00
Konstantina Chremmou
f31a8f2085 Some refactoring to memory editing controls.
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards.
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Konstantina Chremmou
456978e572 CP-32688: Remove guest tools from DVD ISO dropdown for Stockholm onwards
Also, removed properties that were never set to true.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-17 16:23:06 +01:00
Mihaela Stoica
66d192b1d8 CP-32985: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
f0f8f90875 Dispose of X509Certificate2 objects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
73a7903ddf Move deprecated feature checks closer to the top of the list.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-02 23:39:42 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
2020-04-02 10:58:58 +01:00
Konstantina Chremmou
d5035a010d Run LegacySsl , PowerOn mode, and PV Guest checks only if strictly necessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-02 10:55:37 +01:00
Konstantina Chremmou
21071ce463 CA-330308: Do not mark the page as changed or save settings before the page is loaded for the first time.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-02 10:55:37 +01:00
Konstantina Chremmou
6c5edddda8 CP-32701: Show certificate expiry alerts.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
fc944784b4 CP-32697: Show certificate metadata on the host's General TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
8c4af40cf2 Added command and menu item for launching the certificate installation dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
2b3884fa72 Spinner Icon enhancements
Added failure result; added default values for success and failure images;
renamed method and property; removed duplicate code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 16:27:13 +01:00
Konstantina Chremmou
00e015f2d0 Run vSwitch Controller and PV Guest checks only if strictly necessary.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 15:31:36 +01:00
Konstantina Chremmou
8f79c7cf13 CA-336986: Handle server side update precheck for vSwitchController.
Also, renamed a couple of parameters because the old name was specific to one error.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-01 15:31:36 +01:00
Konstantina Chremmou
974ece8878 CA-337287: Skip legacy protocol and power-on iLO checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3a35a96530 CP-33294: Remove iLO power on option from XenCenter
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues:
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
d7ae7a8571 Corrected instruction to match the documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-27 16:49:51 +00:00
Konstantina Chremmou
888a0555ab CA-337287: Skip vSwitch controller and PV guest checks with a warning if the RPU hotfix is missing.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-27 16:47:25 +00:00
Konstantina Chremmou
608f56fe7d CA-336931: Informational problems should not be resolvable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-18 13:24:22 +00:00
Konstantina Chremmou
862971621b CA-333059: Fixed issue where the updates list was not refreshed for pool slaves after applying an update.
Also, fixed some performance issues; minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-11 22:22:17 +00:00
Konstantina Chremmou
6c06b08024 Some refactoring and code modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-11 22:22:17 +00:00
Konstantina Chremmou
44dd03e85f Fixed issue where it was possible to have both View ToolStripMenuItems in unchecked state.
Also, UX enhancement: added tooltips showing the update alert page URL.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-11 22:22:17 +00:00