Konstantina Chremmou
bf9f5b1308
Ensure all the CommandLib classes are defined in this namespace so as to avoid conflicts with homonymous classes from other namespaces.
...
- Automatic indentation fix as a consequence.
- Use proper xml doc for the various methods and classes.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3d6db3a80
Removed support for long retired XVA v1 packages.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-07 13:22:33 +01:00
Konstantina Chremmou
e3896239df
CA-339305: XenCenter was hanging when update alerts were removed very fast, and other issues:
...
- Use a plain list to store update alerts and, where possible, fire a collection
change event only after a bulk change and not every time a single object is added
or removed.
- Fixed issue where dismissed updates were stored in the config of all connected
pools, even of those where the update did not apply.
- Corrected RBAC checks for update dismissal.
- Fixed enabled state of dismiss buttons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-21 16:08:20 +01:00
Konstantina Chremmou
2e66ec9133
Merge remote-tracking branch 'upstream/master' into feature/REQ-819
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
# Conflicts:
# XenAdmin/Dialogs/OptionsPages/SecurityOptionsPage.cs
2020-08-11 13:35:39 +01:00
Konstantina Chremmou
c244d8d4db
CA-339584: Include CD VDI in the storage mapping for intra-pool migration
...
Also: removed unused method; some property modernisation; removed class
LiveMigrateOptionsVmMapping which was rather complicating things.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-08-11 08:46:42 +01:00
Konstantina Chremmou
e30ea433c7
Refactoring to simplify the code and make calculations more efficient:
...
Removed unnecessary abstractions. Replaced named delegates with anonymous ones.
Use pattern matching and avoid multiple casts. Be consistent in the properties
we check.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-30 10:42:20 +01:00
Konstantina Chremmou
9d7cf72c78
CP-33781: Added admin exit procedure warnings.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-07-17 16:04:10 +01:00
Konstantina Chremmou
f3c5e74dae
CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-25 11:17:11 +01:00
Konstantina Chremmou
db041099ef
CA-339271: Improved action description. Also:
...
Added cancelling ability to MoveVM action; made some simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-19 14:04:59 +01:00
Konstantina Chremmou
acd3094b48
CA-314005: Proceed to setting the memory if the issued shutdown has been interrupted by a different shutdown task.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-10 23:48:54 +01:00
Konstantina Chremmou
c9449b9914
CP-33153: Added friendly title and description for GFS2_CAPACITY alert. Corrected scan action description.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:50:49 +01:00
Konstantina Chremmou
ec7fc14c18
Typo.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-06-05 11:48:54 +01:00
Konstantina Chremmou
4f4217a2b1
CA-339685: Corrected calculation of completion percentage and added checks for division by zero.
...
Also, some simplifications and removal of unused variables and fields.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:25:56 +01:00
Konstantina Chremmou
64aa4e730b
CA-339237: Show more information in XenCenter's logs on why a patch or update may have failed to apply.
...
Also, ensure the Failure.ErrorDescription property is always initialised.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:19:40 +01:00
Konstantina Chremmou
166fe0ecc5
CA-333443: Use the master's address instead of the connection name when joining a pool.
...
Also, moved code handling RBAC failure from the Failure class into the
PoolJoinAction because it is pretty specific to the latter action.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 23:03:45 +01:00
Konstantina Chremmou
8a478011d9
CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-19 07:49:23 +01:00
Konstantina Chremmou
d1c9e7ddd1
CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also:
...
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-04 14:30:24 +01:00
Konstantina Chremmou
8d6686b63f
CA-337280: Creation of GFS2 SRs with CHAP authentication is not supported.
...
This is also a better fix for CA-335356.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-01 15:27:18 +01:00
Konstantina Chremmou
436ffe4a37
CA-338003: The action's Sessions is set once the action has started to run. Added missing help references.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-27 10:36:51 +01:00
Konstantina Chremmou
17b6c28978
Merged master into feature/REQ-453 and resolved conflicts.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
# Conflicts:
# XenAdminTests/UnitTests/TimeUtilTests.cs
# XenCenterLib/TimeUtil.cs
2020-04-26 04:11:14 +01:00
Konstantina Chremmou
0188fdc69b
Corrections as per code review.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64
Try handling a connection interruption.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d
CP-32699: New dialog for certificate installation on a server.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-04-08 13:55:35 +01:00
Konstantina Chremmou
3a35a96530
CP-33294: Remove iLO power on option from XenCenter
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
5406b933fd
CA-330308: Rewrote Power-On edit page to fix workflow issues:
...
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-03-30 10:48:32 +01:00
Konstantina Chremmou
3869d9654d
New bindings (includes CP-29452, CA-75634, CA-280976).
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-02-14 14:43:22 +00:00
Mihaela Stoica
2b0822f3d3
CP-32931: Stop sending licensing information to the licensing server
...
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2020-02-11 08:35:42 +00:00
Konstantina Chremmou
fc1cbf636e
Simplified signature of connection events.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-12-06 11:17:46 +00:00
Konstantina Chremmou
072397ac2a
Refactoring and deletion of dead code.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
5614dafbe6
CA-329742, CA-330301: Logging simplification.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
99572da0fb
Corrections to the logging of Win32 exceptions. Minor refactoring.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf
Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b
Avoid duplicate logging; compact multiple logging calls.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca
Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fb2edf99b8
Do not initialise a logger if a class does not use it.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
ec79720057
Do not pass the delegates showing messages as parameters to the actions, but rather have them handle action events.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-14 09:24:36 +01:00
Konstantina Chremmou
e9d2da082d
Prevent XenCenter from crashing if starting it by double-clicking a license file.
...
Also, fixed hotkeys and info message on the PasswordRequest dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-07 18:00:32 +01:00
Konstantina Chremmou
441734be82
CP-32140: Allow the user to select which XCM VPX to use when there are multiple XCM VPXs in the pool.
...
Also, corrected the RBAC permission check after stopping using the conversion plugin.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-25 13:25:26 +01:00
Konstantina Chremmou
ca72f25ebe
Merge remote-tracking branch 'upstream/master' into feature/REQ-756
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
# Conflicts:
# XenAdmin/MainWindow.Designer.cs
# XenAdmin/MainWindow.resx
# XenAdmin/Properties/Resources.resx
2019-09-13 13:17:32 +01:00
Konstantina Chremmou
d5d32baa88
CA-326611: Improved connecting to the conversion VM.
...
- Poll for the appliance version because the service may take a while to
start after an IP address is obtained.
- More flexible IP address look up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-11 13:27:29 +01:00
Konstantina Chremmou
61f6f89c25
Merge pull request #2510 from xenserver/feature/REQ-775
...
Merge REQ-775 into master
2019-09-06 12:08:23 +01:00
Mihaela Stoica
3f5125b293
CA-325846: Do not display invalid data in the hotfix eligibility warnings and alerts
...
- if a hotfix eligibility date field is invalid, then the hotfix eligibility warning does not include any reference to this date.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-09-03 08:52:40 +01:00
Konstantina Chremmou
1a88c3713d
Activate the conversion VPX and get the service IP address without employing the conversion plug-in.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-09-02 10:34:58 +01:00
Konstantina Chremmou
d22b212afa
Renamed property as there are clashes with a child class (will have to be refactored in future). Treat warnings as errors in all projects.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 14:03:30 +01:00
Konstantina Chremmou
9157735803
CP-30958: Initial implementation of the Conversion Manager in XenCenter. ( #2481 )
...
* CP-30958: Initial implementation of the Conversion Manager in XenCenter.
* Corrections following review and improvements.
* Further corrections and improvements.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-22 10:47:43 +01:00
Mihaela Stoica
482c86a731
CP-31527: Add notifications in XenCenter for versions that are no lon… ( #2486 )
...
CP-31527: Add notifications in XenCenter for versions that are no longer eligible for hotfixes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2019-08-21 11:43:11 +01:00
Konstantina Chremmou
8fedb2d6e0
Removed unnecessary constructors. The ones with the 'params' param cover for them.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-15 11:33:01 +01:00
Konstantina Chremmou
e6da7045b6
Ensure we always dispose of the ArchiveIterator and ArchiveWriter after use.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-13 10:18:15 +01:00
Konstantina Chremmou
dd81a5d14c
CA-280117: Show the user the VDI uuid instead of the VDI opaque_ref when enabling HA throws VDI_NOT_AVAILABLE error.
...
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-23 10:28:01 +01:00
Konstantina Chremmou
85654a4f36
CA-314720: Replaced "Still waiting" dialog popping up during RPU with a message displayed in the upgrade output.
...
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-07-22 13:15:59 +01:00