Commit Graph

67 Commits

Author SHA1 Message Date
jishengx
aa276dc8f5 CA-286449: Filter out SR-IOV network when importing OVF (#2037)
CA-286449: Filter out SR-IOV network when importing OVF

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-04-19 15:51:33 +01:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Michael
a4aaeb1165 CA-272150: Optimize destination page of cross-pool-migrate wizard. (#1941)
* CA-272150: Optimize destination page of cross-pool-migrate wizard.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-03-08 13:22:38 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931)
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-02-05 15:31:22 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934)
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-02-05 10:07:24 +00:00
Vetrivel Chinnasamy
5f594dae8a L10N: Translation Checkins 2017-11-22 16:03:36 +05:30
Mihaela Stoica
7f602a782a CA-271970: Incorrect error when copying a VM on an unlicensed pool
Instead of showing the cross-pool migration upsell dialog, we now show the wizard, where user can try to perform an intra-pool copy (the cross-pool option is disabled with an explanatory message displayed)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-13 11:28:00 +00:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
Gabor Apati-Nagy
47f7690536 Merge pull request #1590 from MihaelaStoica/CA-244663
CA-244663: In the Migrate VM wizard, add storage mappings for the VDI…
2017-05-16 13:54:13 +01:00
Mihaela Stoica
d2f3c0c116 CA-244663: In the Migrate VM wizard, add storage mappings for the VDIs belonging to the VM's snapshots
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-11 16:42:41 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
1d92986aa7 CA-234827: Added check for ErroDescription.Count
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 15:47:42 +00:00
Mihaela Stoica
765dee4fe7 CA-234827: Destination dropdown menu content is blurred with overlapping 'Action: vm.assert_can_migrate' text in Migrate VM wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-02 13:52:32 +00:00
Callum McIntyre
6a096ebf07 [CA-226897] Move the VMCrossPoolMigrateAction to be a variable outside the block, and added SuppressHistory to the MultipleAction. 2016-11-08 16:05:51 +00:00
Callum McIntyre
9b1a3315f0 [CA-226897] Resume on Server option won't automatically resume the VM
The resume on server uses the CrossPoolMigrateCommand to implement the migration of the VM to the desired host. Before this change that command had no support for resuming a VM after migrating it, so the VM was not resumed. With this change, the CrossPoolMigrateWizard can take an optional (default false) parameter to restart the VM after migration. When this is true, the migrate action becomes a MultipleAction, first migrating and then restarting the VM.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-03 15:35:25 +00:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Konstantina Chremmou
6df0508c92 Enforce filetrs to be run with a target that is Pool or Host and a non-null VM selection.
Small refactoring for performance gain on Host extension method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-11 09:45:37 +01:00
Konstantina Chremmou
b78f823b17 CA-220218: For halted VMs moving intra-pool, XenCenter does not need to assert migration
is possible, because what it actually does is move. When asserting migration use
an SR other than the VDI's current SR for the check to ensure that both source and
target SRs are checked to see whether they support migration. Also, use the VM's
Home() instead of resident_on to ensure the current server cannot be selected as
target server. Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-03 10:30:40 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
Konstantina Chremmou
61a2c12c45 CA-205799: Fixed issue where the user was allowed to select the VM's home server
as move (halted) or migrate (suspended) destination; this was caused by using the
VM's resident_on instead of Home() host. Also, changed the disabled reason to be
a bit more generic and cover cases other than migration.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:59 +01:00
Konstantina Chremmou
4bf04e6279 In Move mode the text on the destination page should read "move the VMs" and not migrate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:37 +01:00
Konstantina Chremmou
97278e88ad Refactoring: normally we create the actions in the wizard class obtaining the parameters
from the page properties; removed unnecessary field.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-30 13:45:04 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Gabor Apati-Nagy
ed43975454 CA-201083: Incorrect help link in Copy VM wizard
Changed keys of help ids related to copy mode

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 18:12:16 +00:00
Gabor Apati-Nagy
9bf37f7d25 CA-201083: Incorrect help link in Copy VM wizard
Removed redundant criterias from some ifs

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-01 18:07:53 +00:00
Gabor Apati-Nagy
bb592fc769 CA-201083: Incorrect help link in Copy VM wizard
Copy VM or Copy Templates wizard will point to the same help: "Copying VMs and Templates"
Migrate and Move VM will show: "Migrate Virtual Machines"

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-26 18:21:51 +00:00
Gabor Apati-Nagy
ebec8b1d7e CA-197423: Incorrect UI text and help link in Copy Template wizard
One missing helpid fixed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 13:52:10 +00:00
Gabor Apati-Nagy
0c56385921 CA-197423: Incorrect UI text and help link in Copy Template wizard
Fixed helpids

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 11:10:09 +00:00
Gabor Apati-Nagy
4bdc5ffa79 CA-197423: Incorrect UI text and help link in Copy Template wizard
Fixing UI text (template instead of VM where needed)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-24 10:44:37 +00:00
Cheng Zhang
31b7337026 CP-15398: Remove enbedded icons
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:56 +08:00
Mihaela Stoica
c8620e978f CA-191315: Storage motion from XenCenter should no longer be blocked on WLB-enabled pools
The restriction that Storage Motion was not possible in the presence of WLB has been removed in Dundee. This commit removes the check in XenCenter.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-12-16 12:58:24 +00:00
Mihaela Stoica
fd5b882b38 Merge pull request #750 from GaborApatiNagy/CA-189674
CA-189674: Move VM shows an irrelevant (VIF mapping) error, but it sh…
2015-12-02 12:10:43 +00:00
Gabor Apati-Nagy
a8ea4d47be CA-189674: Move VM shows an irrelevant (VIF mapping) error, but it shouldn't
I assumed the problem was that vm.resident_on is always unknown for stopped vms, but this is there intentionally to match only running vms and be always false for stopped ones. However, we still need similar logic to not to send VIF mapping when not needed in the assert.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-02 12:03:54 +00:00
Gabor Apati-Nagy
3df22f4735 CA-189674: Move VM shows an irrelevant (VIF mapping) error, but it shouldn't
Fixed filters that are used to determine whether a vm can be migrated to a destination or not.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-01 21:31:48 +00:00
Gabor Apati-Nagy
16cd22f3db CA-186244: Cross-pool copy of a stopped VM allows selection of the current pool
Hide the pool instead

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-01 11:29:06 +00:00
Gabor Apati-Nagy
93c3badac7 Revert "CA-186244: Cross-pool copy of a stopped VM allows selection of the current pool"
This reverts commit aecb18ab15.
2015-11-27 10:52:34 +00:00
Gabor Apati-Nagy
aecb18ab15 CA-186244: Cross-pool copy of a stopped VM allows selection of the current pool
Now CrossPoolMigrateCanMigrateFilter can accept a parameter to decide whether to allow same target pool or not -- if allowSameTargetPool is false, it won't.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-24 18:36:03 +00:00
Mihaela Stoica
f352c0cc73 CA-149229: Add VDI and VIF mappings when calling "assert_can_migrate"
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-11-09 14:20:37 +00:00
Mihaela Stoica
b7b71c786c CP-11292: Remove storage motion constraints: Fixing tests and some more wording changes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-22 13:21:31 +01:00
Mihaela Stoica
22ba1544e2 CP-11292: Remove storage motion constraints: Wording changes in the cross pool migrate wizard
- changes to the text to be suitable for migrate and copy operations, where possible
- added different text for copy on some pages
- also different text for single and multiple selection
- changes to text alignment, tab order, hotkeys on the copy pages
- removed Finish page from the intra-pool copy wizard

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-21 14:30:41 +01:00
Mihaela Stoica
830d8f6f60 CP-11292: Remove storage motion constraints: changes following code review
- added some null checks
- in the Cross pool migrate wizard, add Transfer network page for all cases except intra-pool move (which is performed via VMMoveAction)
- added comments to VMCrossPoolMigrateAction constructor to make it cleared what the copy parameter means

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-04-15 09:37:12 +01:00