Commit Graph

1047 Commits

Author SHA1 Message Date
Konstantina Chremmou
b0cdc74188 The code in the BackgroundWorker's ProgressChanged and RunWorkerCompleted event handlers does not need invoking as it's already on the UI thread.
Also, some logic simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 13:50:46 +01:00
Konstantina Chremmou
18f2ff0785 Typo.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-29 10:46:14 +01:00
Mihaela Stoica
c2b42fa107 CA-289335: Refactoring to avoid setting the SelectedItem twice
- also avoids iterating through the combobox items again to determine which item to select

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 16:23:04 +01:00
Mihaela Stoica
5d0b760a96 CA-288751: Fix the RBAC checks for probe_ext
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-24 13:00:05 +01:00
Mihaela Stoica
01c8a7ed83 CA-289150: Use a local variable to avoid calculating DistinctHosts twice
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:33:31 +01:00
Mihaela Stoica
171284ff34 CP-28094: Rationalise device-config keys with SMAPIv1
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-16 17:18:12 +01:00
Konstantina Chremmou
085b4d4f6e CA-248353: Do not use a hardcoded string or integer to reference DataGridView columns or ToolStripMenuItems.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
79684617eb CA-248353: Reference the column object directly instead of trying to retrieve it using a hardcoded string as a key.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-15 13:17:04 +01:00
Konstantina Chremmou
3fc14c5344 Disable creation of SR-IOV network if the feature is disabled.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-09 12:38:26 +01:00
Vetrivel Chinnasamy
998cea2ec2 L10N: Kolkata Bug Fixes (#2052)
* L10N: UI Truncation Fixes

* L10N: Bug fix truncation issue JA

* L10N: Removed the help image in SC Wizard page

* L10N: Update to zh-CN XenWizrd Base
2018-04-25 18:19:03 +01:00
Mihaela Stoica
8a16c794c1
Merge pull request #2046 from vetrivelc/master
L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates
2018-04-20 11:38:52 +01:00
Vetrivel Chinnasamy
0cf3d404ee L10N:CA-281877,CA-283587,CA-286950,CA-287318 Fix Updates 2018-04-20 18:28:09 +08:00
jishengx
aa276dc8f5 CA-286449: Filter out SR-IOV network when importing OVF (#2037)
CA-286449: Filter out SR-IOV network when importing OVF

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-04-19 15:51:33 +01:00
vetrivelc
4ac8f99bae L10N: Localization File updates 2018-04-19 18:07:23 +05:30
Konstantina Chremmou
04a29dd3a0 Message correction.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-17 13:32:05 +01:00
vetrivelc
ea1baf33e7 L10N: CA-281877 JA & SC fix 2018-04-17 15:25:29 +05:30
vetrivelc
7c3c95f74b L10N: Fixes CA-283585,CA-283587,CA-287318,CA-286950,CA-287342,CA-281877 UI/Truncation Issues 2018-04-17 12:11:23 +05:30
vetrivelc
b57d7d13bf L10N:CA-287607 Translation Updates 2018-04-17 10:08:42 +05:30
Mihaela Stoica
2af3de8e7f CA-287430: Fixed the issue where the "Install Update" page of the patching wizard does not show the information on the host reboot steps.
- use the plan action's ProgressDescription property to display the steps in RestartHostPlanAction (evacuate host, reboot host, bring babies back);
- the plan action should not be visible if the restart is skipped;

- The change to the DownloadAndUnzipXenServerPatchAction is to ensure that the download progress description is updated on the wizard with the correct description (in automated updates mode, via DownloadPatchPlanAction); DownloadPatchPlanAction is using the ActionChanged event to update its description based on the  action's DownloadProgressDescription property, but the ActionChanged event is called when the PercentComplete is updated, so this needs to happen after DownloadProgressDescription has been updated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-10 11:08:18 +01:00
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 09:58:40 +01:00
Mihaela Stoica
1925fc9ec4 CA-285215: Cancel button should be enabled on the Patching wizard when the update installation is in progress
- also fixing an error on the patching wizard where a null reference exception is thrown if, when the wizard is cancelled, the host where an update has been uploaded is not connected anymore

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-09 08:47:26 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
2018-04-04 09:59:29 +01:00
Konstantina Chremmou
5d4a9270eb Simplified class hierarchies for the SrDescriptors. Among others, we avoid the presence of irrelevant key-value pairs in the DeviceConfig .
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
2943b048fa CP-17099: Remove unused function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
6a8b65b21e CP-17099: Do the double probe for HBA
- The LVMOHBAWarningDialog class has been changed to display the type of the existing SR and the requested type (that will be used for formatting)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Konstantina Chremmou
585f7a848f Cleared some more warnings with regards to xml documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Vetrivel Chinnasamy
587144d3bf L10N: Translation Updates (#2020)
* L10N: Translation Updates
2018-04-03 11:57:09 +01:00
Konstantina Chremmou
6adcd2b83f Some more code simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-28 11:34:42 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Jisheng Xing
8e64c917e2 fix review comments
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:53 +08:00
Jisheng Xing
59ba1db95f CA-286136: modify the SR-IOV related display 2018-03-23 14:44:59 +08:00
Jisheng Xing
73eefe33b5 CA-286136: modify SR-IOV related info display
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:57 +08:00
jishengx
a22cb38835 CP-26363: Display the remaining VF numbers in NIC TabPage (#1982)
* CP-26363: Display the remaining VF numbers in NIC TabPage

* correct the link status of Networking TabPage

* show the warning when creating SR-IOV network

* fix some comments

* modify the action

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:44:56 +08:00
jishengx
9cfac68d8d CP-25990: Enable Create VLAN on SR-IOV network (#1975)
* CP-25990: Enable Create VLAN on SR-IOV network

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix review comments
2018-03-23 14:43:51 +08:00
jishengx
6f4fa43c03 CP-26362: Enable create SR-IOV network (#1952)
* update the XenAPI according to the Jason-RPC

* CP-26362: Enable create SR-IOV network

* fix review comments

* fix the judgement on SR-IOV details page

* disable the finish button

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-23 14:27:04 +08:00
jishengx
b2c74ff261 CP-25982: add wizard to enable SR-IOV network (#1887) 2018-03-23 14:24:10 +08:00
Mihaela Stoica
a61dd0c5c0 Fix NullReferenceException in the Patching wizard, on pressing the Finish button)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-22 10:32:41 +00:00
Michael
cb0ee70012
Merge pull request #1986 from MihaelaStoica/CA-285268
CA-285268: Patching Wizard improvement: Read metadata from the update…
2018-03-21 17:30:59 +08:00
Mihaela Stoica
45ad13133d Use the new methods PageLeaveCore and PageLoadedCore in ChooseSrProvisioningPage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-19 14:08:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Mihaela Stoica
713877b49e CA-285268: Code simplification
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-16 14:00:07 +00:00
jishengx
0c13d8786d CA-274082: Check status of SR uploaded updates during update installa… (#1937)
* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-14 12:19:14 +00:00
Mihaela Stoica
f64fd58970 CA-285268: Patching Wizard improvement: Read metadata from the update file, instead of relying on the file name to match the update name in cfu
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-14 12:12:18 +00:00
Konstantina Chremmou
d69f2ddda3 Enforce treating warnings as errors in Debug mode too as it is going to save
us a lot of broken builds. Fixed bug where the HostPlanAction.CurrentHost was
always null (as the private field was never set).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
2b8bf70ee5 CA-272769: Call the base class method in the end of the PageLeave override, so the
WizardContentUpdater is invoked and information flows from the SelectInstallMethod
page to the following pages.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
a8b831fab9 Simplified check as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Mihaela Stoica
0184470ea3
Merge pull request #1968 from kc284/master
CA-284125: Automated updates should prioritise a pending host restart to a mandatory xapi restart
2018-03-08 15:54:39 +00:00
Michael
a4aaeb1165 CA-272150: Optimize destination page of cross-pool-migrate wizard. (#1941)
* CA-272150: Optimize destination page of cross-pool-migrate wizard.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-03-08 13:22:38 +00:00
Konstantina Chremmou
9e3a9abfa0 Resolve host before querying its properties.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-08 11:34:00 +00:00
Konstantina Chremmou
b3828ef452 Added parameter enableOnly defaulting to false to the RestartHostPlanAction
so as to be able to evacuate-reboot the host without bringing the VMs back.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-07 17:50:51 +00:00
Konstantina Chremmou
4b6e826ed3 CA-284125: Prioritise a pending host restart over a mandatory toolstack restart.
For this purpose, the evacuate-reboot-bringbabiesback triplet was replaced by a
new RestartHostPlanAction, which allows fallback to toolstack restart if live
patching has succeeded. Also, created new abstract class HostPlanAction to
reduce code duplication.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 15:12:04 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
a22a9a41e3 A couple of small inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
7505bda9e3 Removed unused properties of UpdateProgressBackgroundWorker; store the number of
actions on creation instead of calculating it every time on access.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
c5b0af533e Removed methods GetHostBootTime and GetHostAgentTime because they duplicated logic
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
ed4b131643 Removed unused code and old style custom delegates, and updated property notation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
71e554cc39 Removed duplicate logic calculating VM groups from the WizardPages and moved it the Host class as extension methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
Konstantina Chremmou
3171005d23 Removed redundant code in file.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:15 +00:00
Konstantina Chremmou
058601f761 CA-279578: Update the Recheck/Resolve button state and error message visibility
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
2018-02-27 17:42:18 +00:00
serenc
c7ac86224a CA-282014: Patching wizard now deletes downloaded patch when wizard cancelled
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-02-27 11:16:26 +00:00
Konstantina Chremmou
1728eb64b6 Simplified the code building the plan actions list as the previous code was
calculating the AfterApplyGuidanceActionsForPatch twice when the patch had
mandatory guidance.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:14:03 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931)
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-02-05 15:31:22 +00:00
Mihaela Stoica
95471eaac5 CA-281646: Do not download the update again when using an update from disk (#1933)
* CA-281646: Do not download the update again when using an update from disk

When applying a "new version" update, XenCenter starts an automated updates sequence that by default downloads all the updates. However, when using an update from disk, we shouldn't download it again.

With these changes, when an update from disk is used we save the [update, path] mapping, which we then use in the automated updates sequence, so we don't download that update again.

Also fixed a bug where a zipped update file from disk is not identified as a new version.

* CA-281646: Remove unused directive

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-02-05 12:36:49 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934)
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-02-05 10:07:24 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Mihaela Stoica
deb953a6ff CA-280287: Fix the null reference exception on the Import wizard (#1918)
* CA-280287: Fix the null reference exception on the Import wizard

- Added a check so that we don't attempting to show the license warning if the wizard is open without a preselected host/pool.
- The license warning is now updated whenever the host selection changes; plus, we are not attempting to show it if the wizard is open without a preselected host/pool.

- Also a minor refactoring in the GlobalSelectHost page to fix this issue: when the wizard is open with a pre-selected host, we pass this to the page by assigning SelectedHost property, which in turn sets the m_selectedHost. The getter for SelectedHost  resets m_selectedHost to the selected item in the host list. If the getter is used before the host list selection is updated, then the desired pre-selection is lost, because m_selectedHost is reset to null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-280287: Corrections following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-19 14:05:20 +00:00
Mihaela Stoica
b9e85f93d5
Merge pull request #1914 from serencorbett1/REQ-477
CP-26253: changed "images" to "virtual disks" to avoid confusion
2018-01-18 15:39:51 +00:00
Mihaela Stoica
5fb9709b8a Merge master into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/FriendlyNames.resx
#	XenModel/Messages.resx
#	XenModel/XenAPI/ApiVersion.cs
2018-01-15 14:41:40 +00:00
Mihaela Stoica
6cefd4d202 CA-276976: Add a new precheck in the Update Wizard
- The new "server selection" precheck is added for Inverness or greater pools and checks if all the servers in the pool are selected (if update not already applied) when applying an update that has the "enforce-homogeneity" flag set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-12 14:34:50 +00:00
serenc
92a809e433 CP-26253: changed "images" to "virtual disks" to avoid confusion
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-01-12 14:05:01 +00:00
Mihaela Stoica
13a8b26fc4 Merge release/jura/master into REQ-637
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/Utils/Helpers.cs
2017-12-19 13:12:39 +00:00
Mihaela Stoica
ffa42c086b CP-26290: Add new edition
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-18 13:22:17 +00:00
serencorbett1
f4d501474a CP-25564: Changed clusteringEnabled variable (#1891)
* CP-25564: Changed clusteringEnabled variable

* CP-26026: Added a link to enable clustering on SR Wizard

* CP-26026: Tweaked according to PR feedback

* CP-25967: Added license restriction for GFS2

Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-12 13:36:09 +00:00
Jisheng Xing
449dfe7f56 CA-272130: modify truncated linklabel and text on the memory settings wizard 2017-12-07 17:28:03 +08:00
Michael
1d0a2b76a0 CA-272769: Enable user to cancel URL testing in rolling upgrade wizard. (#1882)
* CA-272769: Enable user to cancel URL testing in rolling upgrade wizard.

* CA-272769: Sort messages resource file.
2017-12-06 12:06:36 +00:00
serenc
3532e9b586 CP-25563: Improved code from feedback
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-06 09:49:56 +00:00
serenc
7790bed4ca Merge remote-tracking branch 'upstream/REQ-477' into REQ-477
Signed-off-by: serenc <seren.corbett@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NetworkingPropertiesPage.cs
#	XenAdmin/Help/HelpManager.resx
2017-12-05 11:16:16 +00:00
serenc
f430cf58c8 CP-25563: Corrected column layout of tableLayoutInfo
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 15:57:12 +00:00
serenc
00aa042bd7 CP-25563: Added hotkeys,changed flowLayout and corrected label alignment
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 13:50:52 +00:00
Mihaela Stoica
72071a3334 Merge master into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI/Proxy.cs
2017-12-04 13:37:12 +00:00
serenc
69edc172eb CP-25563: Build now passes unit tests
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 10:53:58 +00:00
Mihaela Stoica
ea91951389 CP-26114: Hide the GFS2 option for FCoE
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-01 15:59:00 +00:00
Mihaela Stoica
1e4c293300 CP-26021: Update the GFS2 SR creation with the new syntax
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-01 15:27:42 +00:00
serenc
9f9754c8b0 CP-25563: Added Clustering page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-01 14:47:50 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
serenc
0f752ea035 CP-25551: Changed Page order and removed Event Handler from Designer
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-29 13:34:48 +00:00
serenc
7e7a6d9c46 CP-25551 and CP-25565: Updated branch based on PR comments
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 13:34:38 +00:00
serenc
5bb7a07711 CP-25551: Added Provisioning Page to the Wizard
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 10:51:44 +00:00
Konstantina Chremmou
23a9c50389 Merge remote-tracking branch 'upstream/master' into REQ-420 2017-11-23 14:07:21 +00:00
serenc
c4b228e8da CP-25551: Change Type page, Add provisioning page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-23 10:59:15 +00:00
Vetrivel Chinnasamy
5f594dae8a L10N: Translation Checkins 2017-11-22 16:03:36 +05:30
Mihaela Stoica
681f77bfd9 CA-273307: Replaced the links in the Upsell dialogs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-17 12:24:43 +00:00
Konstantina Chremmou
a170ec33e2 Merge remote-tracking branch 'upstream/master' into REQ-420
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	autogenerated XenModel/XenAPI/* files
2017-11-17 11:53:41 +00:00
Mihaela Stoica
7f602a782a CA-271970: Incorrect error when copying a VM on an unlicensed pool
Instead of showing the cross-pool migration upsell dialog, we now show the wizard, where user can try to perform an intra-pool copy (the cross-pool option is disabled with an explanatory message displayed)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-13 11:28:00 +00:00
Mihaela Stoica
0d41c62a01 Merge pull request #1837 from vetrivelc/master
L10N:CA-261954,CA-270715 & CA-270716 Truncation Fixes
2017-10-26 15:23:35 +01:00
vetrivelc
102b2d096f L10N:CA-261954,CA-270715 & CA-270716 Truncation Fixes 2017-10-26 15:36:54 +05:30
Mihaela Stoica
95323239a0 Merge pull request #1827 from vetrivelc/master
L10N:Translation Updates
2017-10-25 08:48:23 +01:00
Gabor Apati-Nagy
59b904eb2d CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-24 14:55:07 +01:00
Michael Zhao
b093082bcd REQ-158: Merge master to fix conflicts. 2017-10-24 18:51:24 +08:00
Gabor Apati-Nagy
033e7df8af CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-23 15:05:25 +01:00
vetrivelc
d05fd0efd3 L10N:Translation Updates 2017-10-23 19:01:14 +05:30
Mihaela Stoica
304b2c9fab CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-20 11:06:16 +01:00
Mihaela Stoica
6249663ae2 CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard.cs
	XenAdmin/Wizards/NewSRWizard_Pages/ChooseSrTypePage.cs
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoHBA.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
2017-10-20 11:05:45 +01:00
Mihaela Stoica
3bab5186f8 CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Rename SrWizardType
2017-10-20 10:42:54 +01:00
Mihaela Stoica
a56338861c CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoISCSI.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
	XenAdmin/XenAdmin.csproj
2017-10-20 10:42:35 +01:00
Mihaela Stoica
08cce7cb1d Merge pull request #1821 from GaborApatiNagy/master_CA-265225
[SCTX-2608] Honolulu Update - Server is still booting error
2017-10-18 10:00:11 +01:00
Gabor Apati-Nagy
8297314499 [SCTX-2608] Honolulu Update - Server is still booting error
Increased the wait between host_enable attempts, allowing to wait more for the host to reboot.

This will affect Automated Updates and other normal Patching Wizard
operations as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-18 09:56:35 +01:00
Joey
2dc9c00e41 Merge pull request #1817 from GaborApatiNagy/master_new
CA-267330: [Update Wizard Improvements] The Update wizard: block the installation of an update on slaves if a reboot or a toolstack restart is pending on master
2017-10-18 09:53:51 +01:00
Ji Jiang
e4ee106366 CA-268557: Fix the hosts order in Patching Wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-16 11:52:08 +01:00
Gabor Apati-Nagy
b589d0dd9e CA-267330: [Update Wizard Improvements] The Update wizard: block the installation of an update on slaves if a reboot or a toolstack restart is pending on master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-13 13:55:19 +01:00
Ji Jiang
7c6b94d172 CA-267671: Fix Configure HA wizard display text
when the max tolerance is being calculated, the text and icon on top of HA
wizard is no longer visible after this fix.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-12 18:12:44 +01:00
Mihaela Stoica
8fbfe4c060 Merge branch 'REQ-528' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/MainWindow.Designer.cs
2017-10-12 11:39:19 +01:00
Michael
e8cb4ad7d6 CP-24412 & CP-24333: USB device list filter in Attach dialog. (#1789)
* CP-24412: Apply a filter before adding USBs to candidate list in Attach Dialog.

* CP-24333: Apply HA restraint.

* CP-24412: Fix a merge error.

* CP-24412: implement actions to attach/detach/passthrough.

* CP-24412: Add license check before making UI components visible.

* CP-24412: Change layout of new components to Dpi.

* Fixed all comments.

* Fix comments.

* fixed comments
2017-10-10 09:05:22 +01:00
Mihaela Stoica
b79d7923cc CA-268105: fix the bug where the pool item is disabled when an update is already installed on one host in the pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-04 16:48:58 +01:00
Gabor Apati-Nagy
c00439bef4 CP-24818: [Update Wizard Improvements] Show the progress of the download in Automated mode
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-02 16:35:10 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Gabor Apati-Nagy
0cc907bb14 CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement (#1791)
* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Fixed unintended designer code additions/changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-29 11:05:57 +01:00
Mihaela Stoica
0e5f1335d4 CP-24498: RPU wizard to block the selection of unlicensed hosts
Also includes some improvements to the Select Pools page of the RPU wizard
- do not show the checkbox if the item is disabled
- show the icon for the pool items, not only for hosts (making this consistent with the similar page in the Update Wizard)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-25 13:27:06 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
0a33bf1448 Fix PatchingWizard_SelectServers version sorting
The problem is that pool and host rows are mixed when sorting by
version.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
dfe7a2ea70 Refactoring RollingUpgradeWizardSelectPool sorting
Combine sorting by Description and by Version to a single class

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Gabor Apati-Nagy
e92d3df839 Merge pull request #1752 from kc284/master
CA-265044: Text corrections on the New VMSS Schedule wizard; image co…
2017-09-08 18:00:03 +01:00
Mihaela Stoica
4274bf28fb CA-265172: Ensure that the "disk space requirement" precheck is performed for a standalone host in automated updates mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-07 14:29:39 +01:00
Konstantina Chremmou
dd76b9f0d5 CA-265044: Text corrections on the New VMSS Schedule wizard; image correction
on the VM Snapshots page; update VM's status on the Snapshots page when the
VM's membership in a policy changes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 12:56:41 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
69007dbaec CP-24213: Some fixes in the Patching wizard
- Change the "Web page" column alignment to TopLeft, to match the other columns
- When trying to find an alert from a filename, use the patch name instead of the alert name, because now the alert name can also be a version name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-30 09:31:05 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00