Commit Graph

6792 Commits

Author SHA1 Message Date
Konstantina Chremmou
c89fe9991f
Merge pull request #3180 from danilo-delbusso/bug/installer-shortcut-CA-380355
CA-380355 & CA-380545: Fix creation of Desktop shortcut in installer
2023-07-28 11:45:15 +01:00
Konstantina Chremmou
80a722f1db Bumped pipeline to v4.9
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 11:10:03 +01:00
Konstantina Chremmou
36c5b940cc Allow using test locations for downloading LCM hotfixes.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 10:14:27 +01:00
Danilo Del Busso
4f14f3264d
CA-380355: Revert line endings to LF in metadata lines of WixToolset patch file
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-28 09:10:08 +01:00
Danilo Del Busso
ccce6b7ad8
CA-380355: Align Tree in CustomizeDlg with Box on its right
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-28 09:02:24 +01:00
Konstantina Chremmou
049b85fb11 CA-380218: It was not possible to create VMs with VDIs smaller than the max disk size when the summed size exceeded the latter limit.
The limitation of 2TB for non-GFS2 SRs is on the size of individual VDIs, not the total.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-25 12:24:55 +01:00
Danilo Del Busso
23482a6be1
CA-380545: Do not use RemoveFolder for Desktop folder
It's meant to delete empty folders on uninstall but it's not applicable in this case, and caused issued if users don't have the correct rights.

Also rename the IDs to better match content

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 11:32:43 +01:00
Danilo Del Busso
675775cb01
CA-380355: Ensure shortcut is only created if user selects option in installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-25 08:30:10 +01:00
Konstantina Chremmou
c439f3de41
Merge pull request #3175 from xenserver/feature/merge
Merge branch 'feature/merge' -> master
2023-07-19 15:32:22 +01:00
Konstantina Chremmou
1d21ceef93 Bumped pipeline version to v4.8.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 15:32:06 +01:00
Danilo Del Busso
d3a811d566 CA-378758: Ensure all hosts in pool hit HOST_NOT_ENOUGH_FREE_MEMORY before preventing migration
If pool any of the hosts in a pool hit the `HOST_NOT_ENOUGH_FREE_MEMORY` when calling `VM.assert_can_migrate`, XenCenter would prevent migration even if other hosts had enough memory to accommodate the VM.

Likely a result of the fact that other `VM.assert_can_migrate` failures are a consequence of pool-wide configurations. This is an exception.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 13:42:15 +01:00
Konstantina Chremmou
aa6703cc5f Bumped branding to v4.17.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-19 12:29:33 +01:00
Konstantina Chremmou
693286425f Corrections following the merge from master.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 16:35:21 +01:00
Konstantina Chremmou
9950996db2
Merge pull request #3171 from xenserver/master
Merge master into feature/merge
2023-07-12 10:19:07 +01:00
Konstantina Chremmou
387d030a4f Updated SDK to v23.15.0. Updated code as this drop deprecates certain Session constructors.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 09:56:06 +01:00
Konstantina Chremmou
00246d7429 Disallow connection to havana servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-12 09:55:42 +01:00
Konstantina Chremmou
00668e8d53
Merge pull request #3166 from kc284/wlb_images
CP-43770: Removed images from the WLB credentials dialog (plus some refactoring and layout tweaks)
2023-07-11 11:36:09 +01:00
Konstantina Chremmou
33d0b725ff
Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings
Miscellaneous fixes to vCPUs warnings
2023-07-10 15:11:56 +01:00
Konstantina Chremmou
d3004bfac3
Merge pull request #3136 from danilo-delbusso/dev/start-twice-CA-376480
CA-376480, CA-374325, & CA-378489: Prevent two instances from starting after running installer; Add desktop shortcut option; Remove existing shortcuts
2023-07-10 15:07:34 +01:00
Danilo Del Busso
1d8391c9f9
CA-378489: Remove all remnants of previous installation when upgrading with Wix installer
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-10 13:48:09 +01:00
Danilo Del Busso
715f873329
CA-374325: Move shortcut to last page
Also update spacing of controls within the `CustomizeDlg` to take more advantage of the available space

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-10 13:48:09 +01:00
Danilo Del Busso
a08ed18770
Improve wording for IMPORT_WIZARD_CPUS_COUNT_MISMATCH_POOL warning
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-10 13:44:09 +01:00
Konstantina Chremmou
b7eff2d790
Merge pull request #3167 from danilo-delbusso/bug/CA-379402_eua
CA-379402: Fix EUA check & add hotfix check to `HostMemoryPostUpgradeCheck`
2023-07-04 15:47:29 +01:00
Danilo Del Busso
d2424eacf3
Ensure PrepareToUpgradeCheck is run first in the manual upgrade block
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-04 08:58:31 +01:00
Danilo Del Busso
4e59f26cad
Ensure CanRun is called before adding EUA check to precheks list
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-04 08:57:45 +01:00
Danilo Del Busso
eba3305587
Prevent HostMemoryPostUpgradeCheck from running if required hotfixes are missing
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 16:03:17 +01:00
Danilo Del Busso
6eb09cbac4
CA-379402: Do not return Problems if the EUA check is run for upgrades to 8.2 CU1 or below
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 16:03:16 +01:00
Danilo Del Busso
dc747fec05
Update wording of vCPUs count warnings in ImportWizard
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 15:46:02 +01:00
Danilo Del Busso
b43387774e
Remove backing field for AllSelectedTargets
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 15:43:49 +01:00
Konstantina Chremmou
d4374285a9 CA-377017: Improved message shown when attempting to export VMs with vTPMs as OVF/OVA packages.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-03 11:38:58 +01:00
Konstantina Chremmou
57c2cb9fb5 Refactoring to avoid repetition of calculations.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-29 18:10:29 +01:00
Konstantina Chremmou
cfd0216bf4 CP-43770: Removed images from the WLB credentials dialog. Minor text and layout tweaks:
- The checkbox should be above the credential textboxes.
- Some controls were not aligned correctly.
- Place the controls in tableLayout panels.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-29 18:10:29 +01:00
Danilo Del Busso
1e78d6964b CP-41573: Do not attempt problem reversion if SolutionAction.Connection is null
Applies to newly added EUA presence problem

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 16:26:22 +01:00
Danilo Del Busso
594db56b6a CP-41573: Refresh pre-checks once EuaNotAcceptedProblem is fixed
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
06ab09eabb CP-41573: Apply code review suggestions
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
- Group non-manual checks in same if block
- Remove unused field in `EuaNotFoundProblem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
6ce22f759a CP-41923: Update RPU005 to version 5.0
Also:
- Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary
- Filter our `null` EUAs before passing them to the `Problem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
58be7ff5f9 CP-41573: Make AcceptEuaDialog resizable
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
c0f849e4fa CP-41573: Use existing generic message for EuaNotFoundProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
ffbf8e3cd0 CP-41573: Use wizard page as a parent of AcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
927c5b138f CP-41573: Set AcceptButton and CancelButton for AcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
b7a20d5c04 CP-41573: Add 10 padding to AcceptEuaDialog content
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
c463601e52 CP-41573: Add blocking problem if POST82X hosts cannot fetch the EUA
Also:
- Remove unused `button_click` event handler in `AcceptEuaDialog`
- Load EUAs within the `UpgradeRequiresEua` `Check` and removed the spinner from `AcceptEuaDialog`
- Remove `_errors` from `AcceptEuaDialog`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
de6372f680 CP-41573: Check for presence of valid URI within UpgradeRequiresEUA Check
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
f03c1cc17b CP-41573: Move EUA precheck after hotfixes
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
5f5695057d CP-41573: Improve comparison logic for problems
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
f707b0daca CP-41573: Add UpgradeRequiresEua as a permanent check to the RollingUpgradeWizardPrecheckPage
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
49b8f8e16f CP-41573: Add UpgradeRequiresEua and EuaNotAcceptedProblem
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
e265a1f23e CP-41573: Add helper function to fetch host EUA
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
34eb5ff9b0 Enable multiple IXenObjects to be associated with a Check instance
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
eb0636fe9c
Update warning messages for host selection when importing VM appliance
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`.

This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-19 13:46:33 +01:00