Commit Graph

51 Commits

Author SHA1 Message Date
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 09:58:40 +01:00
Jisheng Xing
8e64c917e2 fix review comments
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:53 +08:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
kunm
f0f37d9690 CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing (#1931)
* CA-280329: Fix CrossPoolMigrateDestinationPage with Current Server showing

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CA-280329: Refine usage of CreateTargetServerFilterList

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2018-02-05 15:31:22 +00:00
Michael
6a6931dbd5 CA-280322: Space requirement calculation error in migration wizard. (#1934)
* CA-280322: Space requirement calculation error in migration wizard.

* Fix comments.

Signed-off-by: Michael Zhao <michael.zhao@citrix.com>
2018-02-05 10:07:24 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Mihaela Stoica
deb953a6ff CA-280287: Fix the null reference exception on the Import wizard (#1918)
* CA-280287: Fix the null reference exception on the Import wizard

- Added a check so that we don't attempting to show the license warning if the wizard is open without a preselected host/pool.
- The license warning is now updated whenever the host selection changes; plus, we are not attempting to show it if the wizard is open without a preselected host/pool.

- Also a minor refactoring in the GlobalSelectHost page to fix this issue: when the wizard is open with a pre-selected host, we pass this to the page by assigning SelectedHost property, which in turn sets the m_selectedHost. The getter for SelectedHost  resets m_selectedHost to the selected item in the host list. If the getter is used before the host list selection is updated, then the desired pre-selection is lost, because m_selectedHost is reset to null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-280287: Corrections following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-19 14:05:20 +00:00
Mihaela Stoica
13a8b26fc4 Merge release/jura/master into REQ-637
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/Utils/Helpers.cs
2017-12-19 13:12:39 +00:00
Mihaela Stoica
ffa42c086b CP-26290: Add new edition
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-18 13:22:17 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Konstantina Chremmou
a170ec33e2 Merge remote-tracking branch 'upstream/master' into REQ-420
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	autogenerated XenModel/XenAPI/* files
2017-11-17 11:53:41 +00:00
Gabor Apati-Nagy
0cc907bb14 CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement (#1791)
* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Fixed unintended designer code additions/changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-29 11:05:57 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
Mihaela Stoica
bdbe40187a CA-257760: Strip leading and trailing spaces from the filename in the Import wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-29 16:19:39 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Konstantina Chremmou
3a2444ea49 CA-226817: Do not allow OVF/OVA import on a host incompatible with the VM's hardware
platform version. Also, preserve between export and import the VM's has_vendor_device settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-27 16:03:16 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
e6b2f9b293 Refactoring: removed three out of the classes deriving from the DelayLoadingOptionComboBoxItem
because the differentiation was in the filters, which can be passed in as parameters
to the base class, and other than this they were only adding complexity.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-02 22:04:58 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Callum McIntyre
3a5444ceb2 CA-217821: Specified home server in cross pool migration should behave as home server
Mostly just terminology changes from home server to target server in the CPM wizard. Changes in shared component SelectMultipleVMDestinationPage (shared with ImportWizard) to allow CPM wizard to rename the Home Server column (as it can the VM/template one - using the same pattern).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-15 14:22:18 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Gabor Apati-Nagy
1ca313c1e0 Revert "CA-178985: Removed ova.xml import from XenCenter" 2016-02-24 15:33:18 +00:00
Mihaela Stoica
9f99c37f83 CP-16012: Rename branding variables
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-10 11:52:30 +00:00
Cheng Zhang
31b7337026 CP-15398: Remove enbedded icons
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:56 +08:00
Cheng Zhang
4f0270d049 CP-15398: Make texture XenServer Host rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-19 18:40:52 +08:00
Cheng Zhang
a33d10bade CP-15398: Make texture XenCenter rebrandable
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-14 18:52:53 +08:00
Gabor Apati-Nagy
f0ea3aa807 CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 12:12:20 +00:00
Gabor Apati-Nagy
4586832d5f CA-178985: Removed ova.xml import from XenCenter
because it has been broken and we decided not to keep this feature

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-11-25 11:01:28 +00:00
Gabor Apati-Nagy
aefed11165 Revert "CA-149867: Invoke on MainWindow instead of various controls"
This reverts commit 92f0499911.
2015-04-16 14:17:02 +01:00
Gabor Apati-Nagy
92f0499911 CA-149867: Invoke on MainWindow instead of various controls
We observed that some threads can reach deadlock-ish state after they have Invoked into a control's UI thread. When it happens they are all in a waiting for join or in sleep state for very long time, although there should not be any deadlock situations.
It seems this has something to do with multiple parent controls and with which control we invoked on. This should not make a difference, because we have got one UI thread (for MainWindow) they should wait for, but we have seen it does.

The solution that fixed this issue was to invoke on the MainWindow instead of various controls (see a4fe507adf ).

This changeset is changing all our Invokes to invoke into MainWindow
instead of a control itself. (MainWindow's UI thread is the only UI thread
all Control is using in XenCenter)
This changeset should be in place until we have found the root cause or the exact reason for the above.
2015-04-08 15:16:10 +01:00
Gabor Apati-Nagy
0f821a190a CA-150338: Importing system template causes XenCenter to throw an exception
-Fixed NullReferenceException
2014-12-11 15:06:56 +00:00
vetrivelc
6e2e1a214d Iteration_002 translation check-ins 2014-10-14 21:41:41 +05:30
Konstantina Chremmou
f5bee7102c Refactored MainWindow to derive from IMainWindow rather than implement a field deriving
from this interface.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-22 12:39:32 +00:00
Konstantina Chremmou
b95dcf2237 CA-122644: Fixes issue where a vmware package was not detected as such and hence
the import crashed. Some missing null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-12-02 12:37:35 +00:00
Konstantina Chremmou
c843f5b867 CP-6511: Ovf import/export for vGPU enabled VMs.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1384181202 0
#      Mon Nov 11 14:46:42 2013 +0000
# Node ID 6810ba763a896bcf7dd4295f30c6d5f42b02e9de
# Parent  37666849a54470e0da04b8d14c17940f8b580636

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-11-14 12:29:30 +00:00
Konstantina Chremmou
a3bfe5c7e4 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
# Date 1376062101 -3600
# Node ID e9a03389b4dfd447a4034b55d74827d30e3950be
# Parent  d0a3fa6db59fcaea186f0909053866153d15d450
CA-112877: Set the description text of the transfer VM network page when the export/import
mode is set ratehr than when the page is populated to avoid refreshing issues. Also,
fixed string formatting issue which could potentially cause problems with the word
order in languages other than English.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 14:16:44 +01:00
Konstantina Chremmou
39392e6aec CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1375369840 -19800
# Node ID 0bd7c8e13bdbcda6f95dfa4616c9621ee32857d5
# Parent  85e97db6b94e3b8b55d1a06747a1f1b63c58277f
SC T9N Changes + Bug Fix :111776,111806,111874,111226,112233,112234

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 13:35:33 +01:00
Konstantina Chremmou
2c184b3ef1 CP-6317: Importing from branch clearwater-ln.
# HG changeset patch
# User vetrivelc <vetrivel.chinnasamy@citrix.com>
# Date 1373384864 -19800
# Node ID 8604c77f3fcf5215b1ae962220cd75be01f21d4c
# Parent  4f3d46c46536366498a79ace2220051eb89b329c
Checking in Localization Changes

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 13:00:28 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00