Commit Graph

389 Commits

Author SHA1 Message Date
sri harsha tagore k
08edd54ac1 L10N:Translations check-ins 2017-01-06 12:46:19 +00:00
Mihaela Stoica
3f89610f75 CP-20245: Wording changes for change of feature name to PVS-Accelerator
- changes following the renaming of the RRDs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-04 14:41:56 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
sri harsha tagore k
fcda47d3a0 L10N:Translations check-ins
Cherry-picked: ff6a3984d5a97313903a4d230bca15e54674976e [ff6a398]
Author: sri harsha tagore k <sriharshatagore.karpurapu@citrix.com>
2016-12-21 16:20:30 +00:00
Gabor Apati-Nagy
751ba4956d Merge pull request #1303 from kc284/CA-104329
CA-104329: Removed calculation which might cause lag from the page lo…
2016-12-16 11:13:05 +00:00
sri harsha tagore k
7e13917939 L10N:TRanslations check-ins
CA-235084/CA-235085/CA-235080/CA-235081 fixes
2016-12-16 11:01:53 +00:00
Mihaela Stoica
30c30e85bb CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- Replaced the information tooltip with a warning icon and label at the bottom of the page.
- Added some null checks

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-13 11:09:23 +00:00
Konstantina Chremmou
f165cef307 CA-104329: Do not re-iterate through the datagridview rows to retrieve the VMs'
restart settings when leaving the page. Get the already calculated value from the
tolerance indicator instead.
2016-12-13 09:10:26 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Mihaela Stoica
1156d57787 CA-235381: XenCenter should not allow users to edit the PVS cache storage if it is in use
- On the PVS Cache Configuration dialog, disable the cache storage fields with an information tooltip stating that this PVS cache storage cannot be changed because it is in use.
- Also set the minimum width for the splitter panels, to avoid display issues when the splitter is moved and either of the panels becomes unusable.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-07 17:45:50 +00:00
Mihaela Stoica
6f28a7bfb1 CP-17276: Out of Memory exception when XenCenter exceeds the maximum number of GDI handles
Changed the tree builder so that the tree nodes rely on the TreeView's font. If the nodes have their NodeFont != null, then a tree update causes new fonts to be generated for each node and when fonts are being created faster than they could be cleaned up, we reach the GLI handles limit of 10000 (which causes the Out of Memory exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-24 16:35:51 +00:00
Callum McIntyre
8e542c199f [CA-229350] Correct the minimum dom0 memory required to enable Memory Only 2016-11-15 12:19:43 +00:00
Callum McIntyre
b3e334654f [CA-229350] PVS allows Memory Only even when no control domain memory available
We now disable the Memory Only option if the available dom0 memory is less than the minimum the spinner supports (1Gb)
2016-11-14 14:59:57 +00:00
Mihaela Stoica
19b0a86fa7 CA-192747: Default name for the performance graphs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-10 14:42:45 +00:00
Callum McIntyre
a1e254e7a4 [CA-225715] Performance Graph reporting for CPU for a VM based on max VCPUs(not current vcpu)
Instead of using VCPUs_max, use VCPUs_at_startup, which is the value set when we change the VCPUs count on the VM. Note that despite its name we don't need to restart to see this value change.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-02 17:24:51 +00:00
Callum McIntyre
fd46c9b24e [CA-220457] Move the match Regex objects to be static class objects
Moved from BuildList method to the GraphHelpers class. Since they're only used in this class for this search, and there's similar but broader Regex objects in the Helpers class that are used for parsing, I think it's better to keep them in this class to avoid confusion.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-27 10:41:44 +01:00
Callum McIntyre
173149b749 [CA-220457] Add friendly names for new graphs, and filter duplicates
We have some new RRDs - read, write, read_latency and write_latency. This adds support for them by adding a friendly name and using it to display them. It also adds some filtering (see GraphHelpers.cs) because for backward compatibility io_throughput_read and io_throughput_write (which differ from read and write only in scale) are still available, but shouldn't be displayed in XC. If the new read or write are available, we filter these old datasources out.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-26 16:03:12 +01:00
sri harsha tagore k
1e8791fb38 L10N:TRanslations check-ins 2016-10-19 16:37:43 +05:30
Mihaela Stoica
9de2dae4a1 Merge pull request #1219 from sriharshak/master
L10N:TRanslations check-ins
2016-10-18 17:57:42 +01:00
sri harsha tagore k
529cddb035 L10N:TRanslations check-ins 2016-10-18 22:16:57 +05:30
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Konstantina Chremmou
38bf5b86d3 Merge pull request #1208 from MihaelaStoica/CA-224567
CA-224567: PVS Site renaming plus some other improvements
2016-10-17 22:06:48 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Mihaela Stoica
9ec9cf1aee CA-225057: Add a helper method for setting the Clipboard text and use in all places where Clipboard.SetText was used.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 16:16:16 +01:00
Mihaela Stoica
387c28dadc CA-225057: XenCenter throws an Exception when trying to copy something to the clipboard on the Network page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 13:14:37 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Konstantina Chremmou
dc5318010c Merge pull request #1196 from mcintyre94/CA-114492
[CA-114492] Stop GroupBy buttons remaining overlapped…
2016-10-12 20:24:36 +01:00
Mihaela Stoica
be668850a4 CP-19086: In the PVS Cache configuration dialog, we shouldn't try to save a "not configured" site if it was "not configured" before
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 17:10:39 +01:00
Mihaela Stoica
a8c7aba673 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- For the PVS cache space utilization the multiplying factor should be 1 (the default value) because its values range from 0 to 100

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-12 14:19:32 +01:00
Mihaela Stoica
80df4a2681 CP-17932: Ensure that the correct units are displayed for the PVS cache stats
- plus resorting Messages.resx

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-11 13:13:50 +01:00
Callum McIntyre
baccb87d00 [CA-114492] Only do SetUp if the user was actually dragging a button (not for every click on the button)
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-10 10:11:30 +01:00
Callum McIntyre
9f39bdfb23 [CA-114492] Stop GroupBy buttons remaining overlapped after a drag operation by ensuring they snap back to a correct setup on mouseup
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-07 14:16:06 +01:00
Mihaela Stoica
be66919627 CP-19086: Improvements to the PVS cache UI
- If the PVS site cannot be removed (it has running proxies) then popup a dialog stating the reason, instead of starting the action and failing there. We still have the same check in the action, just in case the situation changed in the meantime.
- Removed unused controls

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-03 10:51:56 +01:00
Mihaela Stoica
aebffe9b13 CP-19086: Improvements to the PVS cache UI
PVS Tab:
- Move the "View PVS sites" button inside the "Configure PVS Cache" dialog (next to Remove button) and make it per-site (showing only the PVS servers from that site)
- Remove "Currently attached" column from the VMs section
- Rename "Status" column to "Read caching status"

Configure PVS Cache" dialog:
- Make sure there is a scrollbar to accommodate all hosts in a pool
- Add a confirmation dialog when a site is removed. The action is executed when the Remove button is pressed.
- When Memory SR is selected, set the maximum value to the dom0-extra-memory..
- Allow empty configuration (but see next point): The OK button should only be disabled if the PVS site name is empty
- Add an extra option in the "Cache storage" combobox, with text "Not configured", selected by default on a new site. When this is selected, we will remove the existing entry in pvs_cache_storage and will not create a new one.
- When a PVS site is deleted (forgotten), we first delete all the associated PVS_servers, otherwise the site cannot be deleted.
2016-10-01 00:23:28 +01:00
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Mihaela Stoica
82dea74899 CP-17920: Add dialog for PVS cache configuration
- new image for PVS_site
- added cache size restrictions based on the SR selected
- added button to remove the PVS site on the page
- fixed the error where the subtext for a new PVS sites showed as "Not configured" even after it has been configured

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-27 16:34:26 +01:00
Mihaela Stoica
fe6144ba70 CP-17920: Add dialog for PVS cache configuration
- this commit contains a temporary image for PVS_site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-26 17:44:17 +01:00
Mihaela Stoica
f2b1443064 Merge branch 'master' into CAR-2184
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-09-26 13:26:31 +01:00
mcintyre94
6707139e6e CAR-2184: XAPI changes. (#1177)
* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-20 12:33:00 +01:00
Mihaela Stoica
a4ffaf239f CA-218242: Don't assign values outside the range in the memory spinner control
- The value of the spinner control is rounded to the nearest, while the minimum is rounded up and the maximum down (or, in some cases, min and max are not rounded at all).
In most cases this is fine, but if the current value (in bytes) is equal to one of these ranges, by rounding this way we might end up with a value that is outside of the control's ranges (causing ArgumentOutOfRange exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 23:14:26 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00