Commit Graph

19 Commits

Author SHA1 Message Date
Konstantina Chremmou
6dde286cc5 Stop suppressing code analysis messages.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-05-22 00:19:40 +01:00
Konstantina Chremmou
576d2d5a83 CA-271455 regression: clean temporary OVF packages extracted from OVAs, but not original OVF packages.
Also, remove obsolete lines that delete touch files (they are not created any more).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-29 10:07:36 +00:00
Konstantina Chremmou
bfc8141391 CA-318468, CA-271455: Reworked OVF validation and OVA package extraction during import.
- Handle validation for OVF files with a name different from the containing
  OVA package. Other corrections to wrong validation logic.
- Show validation warnings on a dialog that can be turned off.
- Clean up extracted files after an OVA package has been imported.
- Plus code refactoring and simplification.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-01-16 16:26:30 +00:00
Konstantina Chremmou
072397ac2a Refactoring and deletion of dead code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
ed30f1e3c3 Do not use audit or trace log.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
667e9e8caf Log the stack trace when an exception is encountered and don't use the *Format() counterpart of the logging method for it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
fad80c778b Avoid duplicate logging; compact multiple logging calls.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Konstantina Chremmou
f4265732ca Do not localise log entries or ellipsise names. Log exception stack traces where applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-11-13 12:31:44 +00:00
Lin Liu
eb309a1af2 CA-329435: Multiple vGPU settings are not preserved when importing OVA/OVF format file
Signed-off-by: Lin Liu <lin.liu@citrix.com>
2019-11-07 09:49:54 +00:00
Konstantina Chremmou
94beeb8f28 CA-329436: Prevent OVF import from crashing when the HardwareVirtualSection>System section lacks a VirtualSystemType tag.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-10-24 09:19:22 +01:00
Konstantina Chremmou
57b8d8f5cb Do not expose the Ovf project's settings to the other projects in the solution.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
0024bb9f09 Removed almost 500 lines of empty xml docs. Fixed enum docs and typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Konstantina Chremmou
536cb18837 CA-322526: Made the ImportOptions page sensitive to PBD changes in the cache. Improved combobox selection functionality.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-08-14 11:07:16 +01:00
Tim Liu
25c0787238 CP-28677: XC: Exported OVFs contain UEFI metadata
1. Add count check
2. Refine the code by linq (both export & import)
3. Create new desc rather than using the generic one
4. Add backward compatibility when importing

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-28 10:42:48 +01:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
b191cf5522 Made XenOvfApi project use log4net for logging (before it was using own logging,
leftover from the time when the OVF wizards were a XenCenter plugin; the latter
has now been removed).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-06 12:31:19 +00:00
Konstantina Chremmou
7e73622570 Moved classes DiskInfo and OvfEventArgs and enums DeviceType and OvfEventType to
a different file to reduce a bit the size of the OVF.cs file.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2014-01-06 09:08:48 +00:00
Konstantina Chremmou
ed88db2df0 Fixed two potential null reference exceptions in the XenOvfTransport project and
removed uninitialised streams which we were taking care to close. Solution-wide
style: use string.IsNullOrEmpty method instead of checking separately for null
and zero length.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-09-26 08:30:34 +01:00
Mihaela Stoica
bd36a85bff CP-4816: Initial commit to git repo
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-06-24 12:41:48 +01:00