Commit Graph

79 Commits

Author SHA1 Message Date
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-05 11:50:34 +01:00
Konstantina Chremmou
d58131910b Corrected logic checking the host is up to date. Renamed method because the old name was not descriptive of the output.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-04 12:40:30 +01:00
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 09:58:40 +01:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Mihaela Stoica
b79d7923cc CA-268105: fix the bug where the pool item is disabled when an update is already installed on one host in the pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-04 16:48:58 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
0a33bf1448 Fix PatchingWizard_SelectServers version sorting
The problem is that pool and host rows are mixed when sorting by
version.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
47ccbd4581 Merge remote-tracking branch 'upstream/REQ-411' into REQ-411
Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.resx
2017-03-28 12:44:54 +01:00
Gabor Apati-Nagy
8afd06ee00 CP-21182: Improved wording in the Install Updates Wizard 2017-03-28 11:21:27 +01:00
Gabor Apati-Nagy
acf6bc5ef8 CP-21182: Improved wording in the Install Updates Wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-28 11:17:26 +01:00
Mihaela Stoica
40680b09ea CP-21574: Add checkbox on the Select Servers page for applying all the released updates after the new version is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-27 16:12:49 +01:00
Mihaela Stoica
1896d9f958 CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Introduced the WizardMode enum and the WizardMode  properties in several wizard pages (replacing the IsInAutomatedUpdates boolean property)
When in NewVersion mode, we show the same wizard pages as the AutomatedUpdates mode and we build the update sequence based on the selected update alert (which is an update to a new version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:43:19 +00:00
Mihaela Stoica
dab5e3da05 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-28 14:29:59 +00:00
Mihaela Stoica
33979bb1f2 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:45:34 +00:00
Stephen Turner
74c567ef1d CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers 2017-02-17 16:56:44 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
Gabor Apati-Nagy
5ed6a7c8ff CP-20065: Change "Automatic Update" to "Automated Updates"
more renaming

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-10 15:01:25 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Gabor Apati-Nagy
838303b3b3 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Removed unneeded overload and it's usage

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 13:53:29 +00:00
Gabor Apati-Nagy
34169dd256 CA-230461: NullReferenceException during batch update when no check-for-updates has been performed
Much better way to update/download the CFU

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-16 12:26:26 +00:00
Gabor Apati-Nagy
7b6a296a68 CA-229185: XenCenter: Dundee and Creedence hosts should be disabled for Ely updates in 'Select Servers'
For ISO updates, when disabling hosts, use the filename matching logic for pre-Ely hosts as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 14:57:10 +00:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Gabor Apati-Nagy
5cfce00e01 CP-17848: Apply hotfixes using new API calls
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 23:26:35 +01:00
Gabor Apati-Nagy
7d62621dd3 CP-17848: Apply hotfixes using new API calls
Using new XAPI functionality in Install Update Wizard required by the new packaging format (ISO updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 14:58:54 +01:00
Callum McIntyre
5d53ab3db3 CP-18417 review changes: Simpler other_config key, added a pool extension method to check for it, moved the check on the Select Servers page to be the first check, simpler logic toggling the automatic/manual buttons. Still need to rework the PatchRequiresReboot part
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 16:37:37 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Callum McIntyre
b7de03cd98 CP-18417:Move the pool forbidden message into the Messages class (though text isn't finalised yet) 2016-08-26 14:51:05 +01:00
Callum McIntyre
8639660562 Move the check to stop Neptune servers being selected into the IsInAutomaticMode checks 2016-08-26 14:24:24 +01:00
Callum McIntyre
615b55321d Intermediate checkin, branched from REQ156 and applied my changes, needs checking. 2016-08-19 17:27:24 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
50e9504da7 CA-217862: Batch Updates: Fixed order of checks when setting the tooltip for disabled hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-11 11:14:32 +01:00
Gabor Apati-Nagy
9f7a635da1 Merge remote-tracking branch 'github_xenadmin/REQ-156' into REQ-156
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
2016-08-10 12:50:45 +01:00
Gabor Apati-Nagy
f9d8b4dea9 CA-217862: Batch updates: Install dundee released hotfixes in Batch fails when pool slave is not reachable and pool partially upgraded
Partially upgraded pools are not supported. If the versions of servers mismatch in a pool, Automatic updating will be disabled with the appropriate info message.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-10 10:48:22 +01:00
Konstantina Chremmou
5f75c0dd74 CA-217847: Fixed issue where servers were marked as unable to be updated automatically
even when automatic mode was supported for them. The problem was that the xenserver
versions were not retrieved from the DownloadUpdatesXmlAction once the latter had run.
Also, minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-09 16:53:02 +01:00
Mihaela Stoica
4046ce0f95 Merge pull request #1096 from GaborApatiNagy/master_batch_new2
CA-217382: Batch updates: Install batch updates is not showing low di…
2016-08-09 14:17:48 +01:00