Corrected the scope of two OvfApi settings as a result of the test run.
Also, sync-ed settings and app.config for XenOvfApi and XenOvfapiTransport.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
EC2 files are long gone. The script was only checking one project in the solution,
but on occasion having temporarily dead files may be needed. In any case, dead
files can be found using the IDE.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Add item "Remove From Pool" to the main Server menu; it should be enabled
if the selected servers are removable and disabled at all other times.
The item should be present in the server's right click menu only if it is enabled.
- Replaced the above item in the Pool menu with the dropdown "Remove Server"
where the user can select the server to remove from the list of removable
servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
The blurbs should be user-centric rather than developer-centric.
No need to disable the page controls in the absence of signature/manifest
since the whole page becomes disabled in that case.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
- Verification of appliance files in chunks to avoid StreamTooLong exception.
- Disposal of HashAlgorithms and X509Certificates after use.
- General code simplification.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
In the CrossPoolMigrateCanMigrateFilter a WebException can be raised if the host cannot be reached to execute the API call that asserts is the VM can be migrated there. With these changes, we catch any exception (not just Failure) and mark the VM as not migratable (because we couldn't assert if it can be migrated to that host).
Also fixed other places where the same error might occur.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
- Removed option to show host only vs pool properties on the Search Tab
when selecting a host within a pool. It is out of place and confusing
because the items under the host don't follow suit. The same result can
be achieved using the filters on the Search Tab.
- Added option to disable remembering the last selected Tab per object
as it can be annoying when trying to compare data on the same Tab for
different objects.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Removed comments that did not provide further info than the class name
they were documenting. Removed unused code. Launch progress dialog within
a using block.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, fixed issue where uploading a supp-pack resulted in a perpetually
pending action if the file had disappeared from the disk.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Also, removed echoing the test start and finish time as it is included
in the nunit3-console output.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
CA-320203: Fixed the update wizard failure when installing two cumulative updates
The issue was that when installing 2 new versions in one go (e.g. two cumulative updates), the installation succeeds on master but it cannot continue on slaves, because it cannot find the first CU update anymore.
The fix is to refresh the update record before applying the update, with the record found in the cache. Also, if there is no update in the cache, try to re-introduce the update.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
- Made storage selector blurb for XVA import a bit more informative.
- A simple checkbox for starting the new VMS on the finish page is adequate.
- Typos. Property modernisation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
If the tar contains huge files, this causes memory spikes, even OutOfMemoryException.
Instead, copy the file from the input to the output stream in chunks.
For this purpose the sanitisation code was moved to XenCenterLib to avoid
exposing the tar internals to the UI project.
Also, made some minor improvements in error handling, clean up, and logging.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
