Commit Graph

5009 Commits

Author SHA1 Message Date
Konstantina Chremmou
7d8bb514d2 CA-287723: Updated bindings to include correction in the datetime deserialization.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-10 15:26:02 +01:00
Mihaela Stoica
2af3de8e7f CA-287430: Fixed the issue where the "Install Update" page of the patching wizard does not show the information on the host reboot steps.
- use the plan action's ProgressDescription property to display the steps in RestartHostPlanAction (evacuate host, reboot host, bring babies back);
- the plan action should not be visible if the restart is skipped;

- The change to the DownloadAndUnzipXenServerPatchAction is to ensure that the download progress description is updated on the wizard with the correct description (in automated updates mode, via DownloadPatchPlanAction); DownloadPatchPlanAction is using the ActionChanged event to update its description based on the  action's DownloadProgressDescription property, but the ActionChanged event is called when the PercentComplete is updated, so this needs to happen after DownloadProgressDescription has been updated.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-10 11:08:18 +01:00
YarsinCitrix
9384a42435 CA-281881: G11N: L10N: Hardcode issue in error messages when configure AD for server
Refer to the CA ticket for details. Generall, there may be some messages (strings)
from the same error message and we cannot literally translate that in the current
framework nor can we split the error into multiple errors and make the translation
separately due to effort constrain. So we just remove the extra information/string
from the current error message to keep current message language(translation) consistent.

Signed-off-by: YarsinCitrix <yarsin.he@citrix.com>
2018-04-09 11:33:22 +01:00
Konstantina Chremmou
a112bd73fb Removed duplicate code; correction setting the request timeout in a session constructor;
renamed method to be more descriptive.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 10:45:27 +01:00
Konstantina Chremmou
a8efbbfba2 CA-286574: Fixed issue where the DR metadata were not loaded from the VDI because
the action was failing to create a metadata session; the latter was due to accessing
directly properties of the xmlrpc proxy which is null since we use the jsonrpc backend.
Also fixed some more areas where the same might occur.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 10:45:27 +01:00
Konstantina Chremmou
82dc176c44 CA-287498: Removed left over calls to the base class method which were causing an infinite loop.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 09:58:40 +01:00
Mihaela Stoica
1925fc9ec4 CA-285215: Cancel button should be enabled on the Patching wizard when the update installation is in progress
- also fixing an error on the patching wizard where a null reference exception is thrown if, when the wizard is cancelled, the host where an update has been uploaded is not connected anymore

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-09 08:47:26 +01:00
Mihaela Stoica
e85954fb75 CP-27568: Update the RPU hotfix to version 5
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-05 11:01:04 +01:00
Konstantina Chremmou
01273b205c Reverted changes that were mistakenly added with ef65d3fede.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-04 14:48:59 +01:00
Konstantina Chremmou
956ff93000
Merge pull request #2024 from MihaelaStoica/master
Merge REQ-477 into master
2018-04-04 11:52:44 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
2018-04-04 09:59:29 +01:00
Konstantina Chremmou
ea225e1d23 Removed files erroneously added to source control.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-04 09:23:27 +01:00
Konstantina Chremmou
5d4a9270eb Simplified class hierarchies for the SrDescriptors. Among others, we avoid the presence of irrelevant key-value pairs in the DeviceConfig .
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
2943b048fa CP-17099: Remove unused function
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
d4c5a86698 Fix the SR wizard tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Mihaela Stoica
6a8b65b21e CP-17099: Do the double probe for HBA
- The LVMOHBAWarningDialog class has been changed to display the type of the existing SR and the requested type (that will be used for formatting)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-04 08:03:28 +01:00
Konstantina Chremmou
585f7a848f Cleared some more warnings with regards to xml documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
c96fd646d3 Removed unused event (event handler content was commented out).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
583513f9e4 CA-202377: Removed the QueuedBackgroundWorker from the NewDisk dialog (unused)
and the vApps dialog (not particularly needed because we only query the cache
and do not make any server side calls).
Also, removed unhooked event handlers from the NewDisk dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
78511b0a02 Replaced Java-like documentation of class members with C# xml documentation.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
Konstantina Chremmou
7655011158 Compliance with C# conventions: normally interface names start with an I.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 13:00:27 +01:00
jishengx
6c43263737 CA-286293: OVF export missing the recommendations field (#2019)
* CA-286293: OVF export missing the recommendations field

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix review comment
2018-04-03 12:31:43 +01:00
Vetrivel Chinnasamy
587144d3bf L10N: Translation Updates (#2020)
* L10N: Translation Updates
2018-04-03 11:57:09 +01:00
Konstantina Chremmou
ff13eff7dd Some information (ScsiId) is contained in the Probe_result.configuration, the Probe_result.extra_info does not contain everything we need.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
6adcd2b83f Some more code simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
0e55a4f078 Tidied up SrProbeAction constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
6d5e8116c4 CP-17099: Fix the usage of IscsiChoiceDialog in the tests
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Joey
48782eac44 CA-286458: Fix latestcr XC requirement when apply CR update (#2010)
* CA-286458: Fix latestcr XC requirement when apply CR update

Using minimum_xc_version attribute in xenserver version to
determine which xencenter version is required.

* CA-286458: change MinimumXcVersion type to Version

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-03-29 11:13:13 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-28 11:34:42 +01:00
Mihaela Stoica
74695d5d38
Merge pull request #2013 from xenserver/REQ-648
Merge REQ-648 to Master
2018-03-27 13:50:00 +01:00
vetrivelc
c910f7d41b L10N: Translation Updates 2018-03-27 13:47:39 +01:00
Jisheng Xing
be88e56dbc change the field allow_network_sriov to allow-network-sriov according to template change 2018-03-27 13:46:17 +01:00
Jisheng Xing
a4bff0c560 CA-286137: Enable modprobe SR-IOV shows incorrect status at the very beginning.
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-27 13:46:17 +01:00
Joey
d80240b891 CA-281652: Add VM_REQUIRES_GPU failure reason (#1997)
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-03-26 11:04:12 +01:00
jishengx
ebadba53c3 CA-286339: The prompt information on RPU prechecks should be accurate (#2009)
* CA-286339: The prompt information on RPU prechecks should be accurate

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-03-26 10:55:24 +01:00
Mihaela Stoica
90c601bbb9
Merge pull request #2008 from jishengx/private/jishengx/CA-286278
CA-286278: VLAN network on top of SRIOV also belongs to SR-IOV + CA-286129: add or filter out SR-IOV network when creating VM or importing XVA
2018-03-26 10:07:38 +01:00
Jisheng Xing
8e64c917e2 fix review comments
modify the judgement of SR-IOV network

fix review comments

fix review comments

judge the resolve result and modify the link status of VLAN on SR-IOV
2018-03-26 16:33:11 +08:00
Jisheng Xing
ba0cfdbf59 CA-286129: add or filter out SR-IOV network when creating VM or importing XVA
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:53 +08:00
Jisheng Xing
f41a61ac73 CA-286278: VLAN network on top of SRIOV also belongs to SR-IOV
Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-26 16:32:38 +08:00
Mihaela Stoica
6077284a75
Merge pull request #2006 from xenserver/REQ-46
REQ-46 feature merge
2018-03-23 11:31:16 +00:00
Mihaela Stoica
a85552def2
Merge pull request #2003 from MihaelaStoica/REQ-477
Merge master into REQ-477
2018-03-23 09:40:16 +00:00
jishengx
a635c6e3f5 CA-286342: SRIOV should be enabled on master when 2 NICs are not the … (#1998)
* CA-286342: SRIOV should be enabled on master when 2 NICs are not the same type

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* set the ExpectDisruption as false after action finished
2018-03-23 14:45:00 +08:00