Commit Graph

4072 Commits

Author SHA1 Message Date
Konstantina Chremmou
09973b1fef Merge branch 'CAR-2205' into CAR-2214 2017-01-20 11:02:46 +00:00
Sharath Babu
fe373447b6 CA-213505: Right click on a VM allows assignment to a policy of unsupported snapshot type
[VMSS] XC -> right click 'VM' -> Assign VM to snapshot schedule shows all policies,
even though they are not supported by VM

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-01-20 11:35:10 +05:30
Gabor Apati-Nagy
974aa0293c CA-238993: Fixed the issue of forever growing updates list while new or updated metadata was not shown
These lists were continuously growing on each refresh, because the Where
clauses returned all items as the predicate was always evaluated to
true. The reason is: A. Even IEquatable<XenServerPatch> is
implemented on XenServerPatch, it only compares uuids. B. XenServerVersion
(also XenCenterversion) does not implement Equals (always different as the
Action returns new objects).

The two bugs these caused are: A] forever growing list of versions causing
obsolete data to be kept while everything is added to the end of the list
additionally. B] Any previously added Patch will not be updated unless the uuid has been changed (this never changes).

Fix in this commit: On each refresh, taking the new lists as they are
(from the Action) and not trying to keep or modify existing items. GC will do the rest with the old list (and objects)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-19 18:33:30 +00:00
Mihaela Stoica
4fd1d0877c Merge pull request #1386 from kc284/CAR-2205
Build overhaul: build XenCenter using a Jenkinsfile.
2017-01-19 15:51:49 +00:00
Konstantina Chremmou
67f5b78c15 CP-20149: Reverted removal of lines as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-19 15:26:27 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Mihaela Stoica
076599d549 Merge pull request #1389 from Frezzle/CAR-2214
Merged master into CAR-2214 and made changes to enable build
2017-01-19 14:50:10 +00:00
Frederico Mazzone
72b2429084 Enable roaming for proxy authentication settings
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:39:01 +00:00
Frederico Mazzone
76fd266913 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Properties/Settings.Designer.cs
	XenAdmin/Properties/Settings.settings
	XenAdmin/app.config
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:16:51 +00:00
Gabor Apati-Nagy
fa7548129b CA-176169: Copyright statement: Added comma at all places where it was still missing (all extensions now)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-18 17:13:09 +00:00
Gabor Apati-Nagy
c8116a46ab CA-176169: Further copyright statement changes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-18 17:07:59 +00:00
Mihaela Stoica
2ae2bdfdd8 CA-182453: XenCenter does not show an active XenMotion in another session
Added "VM.pool_migrate" to the list of tasks suitable for meddling actions.
Removed the usage of MeddlingActionTitle other_config key, because it wasn't working as intended for two reasons:
- If XenCenter starts an action that does multiple async api calls, so multiple tasks, the action's title is assigned to all tasks as MeddlingActionTitles, so the second XenCenter instance would create multiple meddling actions with the same title.
- When a second XenCenter instance tries to see if a task is suitable for a meddling action, the MeddlingActionTitle is not yet present in the task's other_config, so the task is ignored in most of the cases.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-18 14:25:55 +00:00
Gabor Apati-Nagy
356a7ebdc4 Merge pull request #1372 from MihaelaStoica/CA-226900
CA-226900: Do not allow selection of individual pool members when ins…
2017-01-18 14:07:31 +00:00
Konstantina Chremmou
88b7cd53b4 CP-20149: Build overhaul: build XenCenter using a Jenkinsfile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-18 13:48:42 +00:00
Konstantina Chremmou
71547b90db CP-20149: do not have the build scripts copy the production output to a network share.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-18 13:48:42 +00:00
Konstantina Chremmou
30ef6527a3 CP-20149: Too many variables we end up losing track of.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-18 13:48:41 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Gabor Apati-Nagy
64a48133de Merge pull request #1385 from letsboogey/master
CA-237964 - Partitioning information on RPU shows XenServer 7.0 on Ely
2017-01-18 10:26:10 +00:00
Letsibogo Ramadi
1784528e03 CA-237964 - Partitioning information on RPU shows XenServer 7.0 on Ely 2017-01-18 10:21:32 +00:00
Mihaela Stoica
66eab6d8cb Merge pull request #1384 from letsboogey/master
CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Cre…
2017-01-17 12:47:47 +00:00
Mihaela Stoica
98ad1e466d Merge pull request #1383 from geosharath/CA-227792
CA-227792: unable to change policy type and modify VMs list at the same me time
2017-01-17 12:44:43 +00:00
Gabor Apati-Nagy
7d706904b5 CA-176169: Removed unneeded param from the copyright-checker script
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-17 11:32:10 +00:00
Letsibogo Ramadi
d83bc64cef CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Created On” list
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-17 10:37:55 +00:00
Sharath Babu
866968c063 CA-227792: unable to change policy type and modify VMs list at the same time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-17 12:02:54 +05:30
Gabor Apati-Nagy
61c5b43a15 CA-176169: Copyright check to also include shell scripts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:17:15 +00:00
Gabor Apati-Nagy
fe24ba067f CA-176169: Added the comma to one more file
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:16:33 +00:00
Gabor Apati-Nagy
f30daff3b6 CA-176169: Fixed copyright statements in the shell scripts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:15:39 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Gabor Apati-Nagy
9422ce51d1 CA-176169: Added script to fail on source files with missing copyright statements
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 19:42:11 +00:00
Mihaela Stoica
35be481839 Merge pull request #1381 from letsboogey/master
CA-144221 - EN: No wrap for the description and tooltip of SR through…
2017-01-16 17:16:05 +00:00
Letsibogo Ramadi
a2c6ddd4ef CA-144221 - EN: No wrap for the description and tooltip of SR throughput Alarm, tooltip seems truncation.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 17:11:54 +00:00
Mihaela Stoica
27a2a1d88c Merge pull request #1380 from letsboogey/master
CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under …
2017-01-16 16:28:05 +00:00
Letsibogo Ramadi
75db446168 CA-151449 - EN: Missing hotkeys on Pool Properties ->GPU wizard.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 15:08:58 +00:00
Letsibogo Ramadi
c7f5dd90d1 CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under Server Properties dialog.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 13:41:40 +00:00
Konstantina Chremmou
9b9d0bb353 Merge pull request #1354 from GaborApatiNagy/master
CA-214628: .NET Image limit causes exception
2017-01-16 11:47:13 +00:00
Gabor Apati-Nagy
997e93d490 Merge pull request #1378 from letsboogey/master
CA-239308 - Collection of SSR Fails Due to Special Characters Present…
2017-01-12 16:28:23 +00:00
Letsibogo Ramadi
4fb81f6f13 CA-239308 - Collection of SSR Fails Due to Special Characters Present in File Names
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-12 16:20:54 +00:00
Mihaela Stoica
2efa3159db Merge pull request #1376 from ushamandya/master
Minor update to the RBAC topic
2017-01-12 15:04:43 +00:00
Usha Mandya
e82d26fd7e Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-01-12 15:02:34 +00:00
Usha Mandya
5906581df3 Minor update to the RBAC topic 2017-01-12 14:51:32 +00:00
Mihaela Stoica
22e9b2e37d Merge pull request #1374 from MihaelaStoica/master
L10N:Translations check-ins to master
2017-01-12 13:24:39 +00:00
sri harsha tagore k
cb0a0e2267 L10N:Translations check-ins 2017-01-12 13:22:48 +00:00
Gabor Apati-Nagy
a1a411b9df CA-214628: .NET Image limit causes exception
Further changes

* implemented similar logic for the Commands too as those are keep on getting updates so affected
* moved these static fields to a class (at Images)
* used the same casing as in Resources once they have been moved

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-11 13:56:45 +00:00
Mihaela Stoica
84df0d5f80 CA-239210: Fixed the tab order on the Select Servers page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:48:58 +00:00
Mihaela Stoica
b418a8a170 CA-226900: Do not allow selection of individual pool members when installing a hotfix
This change does not apply to supplemental packs, as we should be able to install supp packs to individual hosts in a pool.
Also, if the wizard is installing an update from disk and we cannot match it in updates.xml, then we will continue to allow host selection, because we can't tell whether it is a supp pack or a hotfix.

Plus fixing the bug where the "Select All" button is enabled even when all the selectable servers/pools are selected

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-11 11:32:57 +00:00
Konstantina Chremmou
b170fdecc1 Merge pull request #1329 from mcintyre94/CP-19888-copy
[CP-19888] Add support for code coverage in build jobs
2017-01-10 08:39:45 +00:00
Stephen Turner
0f1c4fd690 Merge pull request #1369 from MihaelaStoica/CA-237963
CA-237963: On a partially upgraded pool (from Dundee to Ely) the host…
2017-01-09 16:35:39 +00:00
Mihaela Stoica
6f9d691974 CA-237963: On a partially upgraded pool (from Dundee to Ely) the hosts lose their consoles
When getting the control domain VM, we should use the control_domain only if it is not null. there is no need to check the version (which was, however, looking at the API version of the master)
2017-01-09 16:14:03 +00:00
Callum McIntyre
a6e628b640 [CP-19888] Changes to service stop/start
Always stop any running ncover service before starting (instead of ignoring the error and using the currently running one), and ignore the error if it's already been stopped at the end. The logic for the latter is that we stop the service right after the commands that require it, so if it stopped too early they'll error anyway. If they don't error because of the stopped service then we shouldn't error right at the end.
2017-01-09 15:58:29 +00:00