Commit Graph

260 Commits

Author SHA1 Message Date
Callum McIntyre
d71d9d10d8 [CA-228729] Improve the message shown on finishing the update installation
Previous message was Remove/Removing/Removed Updates, which is confusing. Changed to Clean/Cleaning/Cleaned Update Files.
2016-11-08 16:53:50 +00:00
Gabor Apati-Nagy
bb298cc213 Merge pull request #1270 from MihaelaStoica/CA-227034
CA-227034: Slipstream packaged Live patching hotfix is rebooting host
2016-11-08 14:44:07 +00:00
Mihaela Stoica
6b374cb400 CA-227034: Slipstream packaged Live patching hotfix is rebooting host
This happened because the LivePatchCodesByHost was null when the prechecks were generated for an update, so the live patch codes returned by the precheck were ignored.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-11-08 11:43:54 +00:00
Callum McIntyre
15e04d1a6d [CA-227845] Fixing problems caused by tooltip container on hotfix wizard mode page
Due to the tooltip container introduced for the automatic radio button, winforms didn't treat these radio buttons properly - we needed code to make them mutually exclusive, tab didn't behave properly and keyboard arrow navigation between them didn't work. Therefore I have removed the tooltip container (so our radio buttons behave properly without any extra work) and we instead use a winforms tooltip shown when the mouse is over the automatic radio button. Note that since the control is disabled when we want a tooltip, neither hover events nor attaching a winforms tooltip in the usual way will work. Therefore I use a mousemove event on the table, which displays the tooltip if and only if we are over the disabled control. Also adjusted the tab indexes to make sure tab works correctly across the whole page.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-04 17:09:52 +00:00
Cheng Zhang
0b27b36d9b CA-227274: Fix CN and JP version process lable size
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-11-02 18:05:36 +08:00
Callum McIntyre
07f866e3a0 [CA-227602] Remove the unused bottom row from the table
This fixes the extra padding, we don't need that bottom row at all

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 16:32:45 +00:00
Callum McIntyre
722527f84e [CA-227602] Truncation on the Install Mode page in the Install Upgrade wizard
I've looked at how this was implemented in Dundee, and there we used an absolute height on the row containing the manual checkbox. I've done the same here, changing row 3 from autosize to absoliute 47px. I've also removed the empty row that was between the two radio buttons. This is a Winforms problem, without workarounds an autosize radio button in an autosize container (say the table row) will report its height as one row of text, no matter whether it needs more. This seems to be the only place we use a long radio label (as opposed to a separate label underneath the radio), so I doubt it's worth doing anything more complex than this. I've tested it with the CN string used in the ticket, and it uses less space than the English translation. The string also hasn't changed from Dundee.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-11-01 15:17:43 +00:00
Gabor Apati-Nagy
55a4957056 Removed unused field (Release build failed on this)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 11:29:32 +01:00
Gabor Apati-Nagy
92b59a9e44 CA-226261: Install HFX Wizard: Mode page: both radio buttons selected
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-21 10:20:25 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
Gabor Apati-Nagy
1c7f6ac643 Merge remote-tracking branch 'github_xenadmin/CAR-2245' into CAR-2245_temp 2016-10-20 17:58:20 +01:00
Gabor Apati-Nagy
6c26359dd6 Merge pull request #1222 from MihaelaStoica/CAR-2245
CP-19218: Add restart warnings to the Precheck Page when installing h…
2016-10-20 17:41:32 +01:00
Gabor Apati-Nagy
f4a0f3ae40 CP-19303: XenCenter: Use new livepatching codes
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-20 17:19:42 +01:00
Mihaela Stoica
2a66b68c7b Merge pull request #1220 from GaborApatiNagy/CAR-2245_temp
CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
2016-10-20 16:02:05 +01:00
Mihaela Stoica
8c93206ce5 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
-  If reboot is needed, display this as an info, not a warning

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 13:09:48 +01:00
Mihaela Stoica
2546731edc CA-226102: HFX wizard host selection not grayed out when hotfix not applicable for current version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-20 11:33:55 +01:00
Gabor Apati-Nagy
da0ebc467c CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Fixed refactoring mistake

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 14:02:29 +01:00
Gabor Apati-Nagy
64d7938f55 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Removed dead code

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:34 +01:00
Gabor Apati-Nagy
27581fa7a1 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Moved ISO to InvisibleMessages and Branding

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:16 +01:00
Gabor Apati-Nagy
225885ac45 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Always define the extension to search for

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:39:14 +01:00
Mihaela Stoica
07faabe1f0 CP-19218: Add restart warnings to the Precheck Page when installing hotfixes
- added a new precheck, called "Live patching status" which checks is a reboot is needed for each host. If reboot is needed, the check will display a warning, otherwise it will show a green tickbox, saying that the server does not need to be rebooted, and if live patching is used, this information will be included as well.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-19 13:10:24 +01:00
Gabor Apati-Nagy
8ac6774e80 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 11:29:57 +01:00
sri harsha tagore k
63387232b9 L10N:TRanslations check-ins 2016-10-18 20:45:24 +05:30
Konstantina Chremmou
08e1b2c1b7 CP-18417: Removed flag forbidding update; was added for CP-17750, but is no longer applicable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 11:16:16 +01:00
Konstantina Chremmou
cff98908b3 Merge remote-tracking branch 'upstream/CAR-2226' 2016-10-17 11:07:15 +01:00
Mihaela Stoica
9398837c38 Merge pull request #1205 from GaborApatiNagy/CAR-2245_CP-19266_2
CP-19266 & other changes
2016-10-13 15:08:38 +01:00
Gabor Apati-Nagy
7e20b11300 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:53:46 +01:00
Gabor Apati-Nagy
a9c2662715 CAR-2245: Passing Pool_update to the precheck page
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:55:21 +01:00
Gabor Apati-Nagy
a722c8b853 CAR-2245: Remove unused method
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:54:53 +01:00
Gabor Apati-Nagy
5fa7f5a797 CP-19265: Use Pool_update.async_apply
Changed XenCenter following the XAPI fix

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 16:27:34 +01:00
Gabor Apati-Nagy
5df1593989 CP-19264: Live Patching in XC: Use Pool_update version of Host.patches_requiring_reboot in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 14:48:17 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
sri harsha tagore k
77631ffb3e L10N:TRanslations check-ins 2016-10-05 10:58:50 +05:30
Gabor Apati-Nagy
5cfce00e01 CP-17848: Apply hotfixes using new API calls
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 23:26:35 +01:00
Gabor Apati-Nagy
5966c5399a Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PatchingPage.cs
2016-10-04 15:10:47 +01:00
Gabor Apati-Nagy
7d62621dd3 CP-17848: Apply hotfixes using new API calls
Using new XAPI functionality in Install Update Wizard required by the new packaging format (ISO updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 14:58:54 +01:00
Mihaela Stoica
4aaaea43d9 CA-223407: Hosts don't get rebooted after a supplemental pack installation and the wizard is stuck in "rebooting" phase
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 10:07:00 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
Gabor Apati-Nagy
b09de72f83 Revert "CP-18925: Hide batch hotfixing option in XenCenter" 2016-09-20 15:00:06 +01:00
Mihaela Stoica
db9eea0cf6 Merge pull request #1168 from sriharshak/master
L10N: Ely:Translation check-ins
2016-09-18 07:12:27 +01:00
Gabor Apati-Nagy
bd7d6bcc9c CP-18925: Hide batch hotfixing option in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-16 14:04:10 +01:00
Callum McIntyre
d83a9cefb5 CP-18417 review changes: Improved PatchRequiresReboot logic. Introduced a new bool someHostMayRequireRestart, passed as an out parameter into both the guidance string builder methods, and the Build method they both use. In that Build method the parameter is set to true if any restartHost guidance is seen - this check is done before live checks exit for consistency.
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 17:19:47 +01:00
Callum McIntyre
5d53ab3db3 CP-18417 review changes: Simpler other_config key, added a pool extension method to check for it, moved the check on the Select Servers page to be the first check, simpler logic toggling the automatic/manual buttons. Still need to rework the PatchRequiresReboot part
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-15 16:37:37 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Callum McIntyre
b22618ef5c Merge remote-tracking branch 'upstream/master' into CP-18417 2016-09-14 10:30:52 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Callum McIntyre
129330c326 CP-18417: Modify the hotfix wizard to make it work for hosts that can't auto-update/restart from XC
Adjusted messages, and added a tooltip to the Automatic restart radio when it's disabled. Also now support standalone hosts in addition to pooled.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-09 15:45:38 +01:00
Callum McIntyre
2b215ffd78 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-17848
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs (resolved using master)
2016-09-09 12:59:29 +01:00
Callum McIntyre
9a8cb87e29 Pull down + merge master (which has changes to update wizard in live patching etc). Automerged. 2016-09-09 12:40:07 +01:00
Callum McIntyre
d302815b66 CP-17848: Commit to hand over. PatchingWizard_UploadPage.cs contains new code to introduce a Pool_update, PatchingWizard_PatchingPage.cs to apply and clean it. 2016-09-09 12:02:59 +01:00