Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-23 19:31:01 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,311 Commits 12 Branches 48 Tags 186 MiB
d90abfd1b6
Commit Graph

6311 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Konstantina Chremmou
bc92cf793d Removed class TaskPoller and moved its code to AsyncAction. 
This simplifies the code since the TaskPoller cannot be perceived without an AsyncAction.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
145483b193 Minor corrections on Task extensions: 
- Stop rethrowing exceptions.
- Added some checks.
- Renamed method XenCenterUUID to GetXenCenterUUID to match the methods
  SetXenCenterUUID and RemoveXenCenterUUID.
- Replaced check via static string list with a string switch block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
b0eafcf1d1 Code design issue: do not override DestroyTask. Minor refactoring in VMSnapshotCreateAction. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:45:23 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed. 
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
4cf37879ec Made ShowConfirmationDialog private as in the one case it was accessed by the inheriting class it was not making the code simpler. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
0d10e1e53f Replaced own method ConvertToSelection<T>() with Linq queries. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
db89699bac Removed method SetParent. Use a setter for the property Parent instead. Property modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-10 23:44:21 +00:00
Konstantina Chremmou
ab59bf22d0 Code design: removed unnecessary base class for Patching and RPU wizards. 
Not sure why I had added that since the containing protected method is probably
more relevant as a static method in the Problem class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-02-08 17:20:05 +00:00
Ji Jiang
4d2406569f Update Jenkinsfile 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-01-26 15:44:43 +00:00
Ji Jiang
973132ed4e CP-35563: Hide health check service on Hyperman 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-01-26 15:44:43 +00:00
Ji Jiang
dc466f245c CP-35478: Rebranding effort 
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
 2021-01-26 15:44:43 +00:00
Konstantina Chremmou
75cec4dd67 Removed dependency on server side branding. Made the pipeline steps internal. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-26 12:31:31 +00:00
Konstantina Chremmou
71a5712647
Merge pull request #2764 from xenserver/feature/REQ-797 
Merge feature/REQ-797 into master
 2021-01-20 10:13:46 +00:00
Konstantina Chremmou
fee6e3942c
Merge pull request #2766 from kc284/feature/REQ-797 
Merge master into feature/REQ-797
 2021-01-19 11:34:04 +00:00
Konstantina Chremmou
0598e6342d Merge remote-tracking branch 'upstream/master' into feature/REQ-797 2021-01-19 11:01:02 +00:00
Konstantina Chremmou
75f9127e27 Move files to a better location. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-19 10:37:35 +00:00
Vetrivel Chinnasamy
78033c8186 CA-350227: L10N- Translation Updates 2021-01-15 11:54:48 +00:00
Konstantina Chremmou
be010e1c39 CA-350406: Exclude the Tools SR when plugging PBDs after a host reboot during an update process. 
Also, try plugging PBDs only for the host in question (other hosts are not necessary,
as the PBDs are re-checked for any previously evacuated VMs before repatriation).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-12 12:15:12 +00:00
Konstantina Chremmou
9a5c664eb0 CA-350574: Corrections to signing an appliance. 
Also, removed listing of CryptoServiceProviders from the settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-12 12:14:31 +00:00
Konstantina Chremmou
90e6cb0dc9 Memory leak when disposing of the RdpControl. 
The rdpControl was set to null too soon and by the time the timer ticked it had
no chance to be disposed of at all. Also, the timer itself was not disposed of.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-06 11:28:32 +00:00
Konstantina Chremmou
bbad0e5cf8 Disable schema validation as it shows false warnings for multiple VM appliances. 
It thinks that the element VirtualSystem is an invalid child element of
VirtualSystemCollection, which is not the case.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-04 16:23:11 +00:00
Konstantina Chremmou
501cca2ffb CA-350410: Ensure we set the certificate before checking it's null. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-01-04 16:23:11 +00:00
Konstantina Chremmou
33e668c0c4 Removed obsolete class XSVersionAttribute. Some refactoring of the usage of Program.Version. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-24 01:23:47 +00:00
Konstantina Chremmou
542a329a27 Fixed failure to start a VM after it was imported as an XVA package. 
Regression introduced by the changes for CA-64500. Since we initiate a VMStartAction
we need to ensure that the VM object passed to the action has a non-null Connection.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
0b0d6973ba CA-348139: Don't exclude zero bytes from the checksum calculation during manifest verification. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
3f5b11048f CA-349855: Reworked the disk validation to prevent false warnings about missing disk linkages. 
Also, removed the known file extensions from the Settings because they are not
user or application settings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1d332ba0b0 CA-347483: Silence exception thrown when disposing compression or tar stream if the user has requested cancellation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
1c4178c7fe CA-347480: Improved ability to cancel an import/export while compressing/uncompressing the files, or packaging into/extracting from an OVA file. 
Also, remove another couple of unused methods from the OVF class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
e325548a75 CA-349836: Reworked handling of manifest and signature for appliance import/export. 
- Moved the code to the ExportApplianceAction so it's easier to modify the
  action's description.
- Fixed issue where the user's option for adding signature/manifest to a plain
  OVF package was ignored.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-18 01:34:25 +00:00
Konstantina Chremmou
8d004401fb CA-343280: Removed metadata entry. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
6286f96cb1 CA-343280: Extended proxy authentication. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
f73ea42cb2 CA-343280: Reworked saving user settings. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:26 +00:00
Konstantina Chremmou
28c0f1d62a Tweaked the column autosize mode on the SelectNetwork page. 2020-12-07 15:57:00 +00:00
Konstantina Chremmou
3e0d982631 CA-347849: No need to keep track of the VIF.device numbers across all VMs of the imported appliance. 
Reset to 0 for each VM.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-07 15:57:00 +00:00
Konstantina Chremmou
84d0a2b8ae Bad application of the code reusability principle in VMDestroyAction. 
Destroying a VM does not disrupt the connection, hence the use of the BestEffort
method is not warranted. After this correction, BestEffort is only used in the
DestroyedBondAction, hence I removed it completely and replaced it with simpler
exception handling in the latter class's Run method.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-03 14:56:11 +00:00
Konstantina Chremmou
94024f99a9 CA-347481: Clean up the disks of the destroyed VM if import is interrupted due to cancellation or failure. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-03 14:55:38 +00:00
Konstantina Chremmou
e7e6fb3234 CP-35350 preliminary work: Removed images that are not displayed anywhere on the UI. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-02 12:34:09 +00:00
Konstantina Chremmou
7e6064eeb1 CP-35343: Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:37:46 +00:00
Konstantina Chremmou
9c26617ad7 CP-35343: Fixed broken build. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:08:12 +00:00
Konstantina Chremmou
2469c947c9 Increased precision in displaying progress of transferred disk data. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:07:13 +00:00
Konstantina Chremmou
719d6b5e45 CA-347487: Fixed error formatting. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 12:07:13 +00:00
Konstantina Chremmou
07ae413e15 CA-349194: Prevent crash when initialising a disk image import. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 11:03:49 +00:00
Konstantina Chremmou
d7512d14c7 CA-347479: Added more cancellation points. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-12-01 11:03:49 +00:00
Konstantina Chremmou
60fb141e57 CA-339384: Take account of thin provisioning when placing a disk on a target SR. 
Also, set the required disk size to zero when the disk spinner value is invalid.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-18 09:24:45 +00:00
Konstantina Chremmou
80119e9411 CP-15790: Implementation improvement aimed to make manual testing easier. 
- Ensure we read the updates.xml location anew from the registry, otherwise the
application has to be relaunched to pick a registry change. Look in both hives
HKCU and HKLM. To avoid performance impact on the UI, move the operation into
the action's Run() body.
- Some refactoring to improve OOP design and fix XmlReader leak.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-12 11:04:33 +00:00
Konstantina Chremmou
0b0819b0aa Moved files to a better location. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-12 11:04:33 +00:00
Konstantina Chremmou
c9a70d282e Do not disable the OK button on validation, but rather point out the problematic entry using validation tooltips. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
c1375c51ed CA-347407: Handle exceptions when failing to unprotect saved proxy credentials. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
248b99abd7 Fixed layout issue whereby the rightmost textboxes were spilling out of the containing groupbox when the control was resized. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00
Konstantina Chremmou
fd6b7b4b48 Added default values to window size and location. 
There was a silent exception thrown when reading the window location the first
time the application was launched.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-11-03 11:34:06 +00:00