Commit Graph

1560 Commits

Author SHA1 Message Date
Danilo Del Busso
d9885d342b CA-381593: Remove CIS privacy policy link from Server Status Report
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-16 19:09:28 +01:00
Konstantina Chremmou
b32168d8d8 Further work on CA-380738: After updates are applied retrieve the new metadata from the host in order to refresh the server status.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
81841c2a2b Fixed issue where supp-packs could be installed only on LCM servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
5e860b03f7 CA-381102 and other update process corrections.
- Put the servers in maintenance mode before applying the updates.
- Updated host do not disappear completely from the metadata hence we need to skip them from the update plan.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
4b64b3a261 Show the product brand alongside the version. Minor code smells.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
c7411c0bb2 The Specify Client ID link was launching the wrong dialog.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
e4012a7bd5
Merge pull request #3194 from xenserver/master
Master->feature/cdn-updates
2023-08-09 14:20:55 +01:00
Konstantina Chremmou
9d8805f060 Improved exported updates output and manual post-update instructions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:54:15 +01:00
Konstantina Chremmou
6eaff6dc54 Rewrote the update application sequence to fix various issues:
- CA-380799: Host evacuation is not needed when the guidance is toolstack restart.
- CA-380796: Sometimes the guidance was applied before the update installation.
- Livepatch notice should be shown only if guidance is not reboot host.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:54:15 +01:00
Danilo Del Busso
f92de90548
Replace usages of FCOE deprecation URL with generic deprecation URL
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-07 12:18:25 +01:00
Konstantina Chremmou
ae81d5738a CP-43267: Apply updates from CDN
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-01 13:56:54 +01:00
Konstantina Chremmou
8f18678acc Retrieve the list of available updates for a synchronised pool.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-28 09:36:54 +01:00
Konstantina Chremmou
291199182e Minor refactoring.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-07-24 21:21:48 +01:00
Konstantina Chremmou
c439f3de41
Merge pull request #3175 from xenserver/feature/merge
Merge branch 'feature/merge' -> master
2023-07-19 15:32:22 +01:00
Danilo Del Busso
d3a811d566 CA-378758: Ensure all hosts in pool hit HOST_NOT_ENOUGH_FREE_MEMORY before preventing migration
If pool any of the hosts in a pool hit the `HOST_NOT_ENOUGH_FREE_MEMORY` when calling `VM.assert_can_migrate`, XenCenter would prevent migration even if other hosts had enough memory to accommodate the VM.

Likely a result of the fact that other `VM.assert_can_migrate` failures are a consequence of pool-wide configurations. This is an exception.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-19 13:42:15 +01:00
Konstantina Chremmou
9950996db2
Merge pull request #3171 from xenserver/master
Merge master into feature/merge
2023-07-12 10:19:07 +01:00
Konstantina Chremmou
33d0b725ff
Merge pull request #3160 from danilo-delbusso/dev/vcpus-warnings
Miscellaneous fixes to vCPUs warnings
2023-07-10 15:11:56 +01:00
Danilo Del Busso
d2424eacf3
Ensure PrepareToUpgradeCheck is run first in the manual upgrade block
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-04 08:58:31 +01:00
Danilo Del Busso
4e59f26cad
Ensure CanRun is called before adding EUA check to precheks list
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-04 08:57:45 +01:00
Danilo Del Busso
b43387774e
Remove backing field for AllSelectedTargets
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-07-03 15:43:49 +01:00
Danilo Del Busso
1e78d6964b CP-41573: Do not attempt problem reversion if SolutionAction.Connection is null
Applies to newly added EUA presence problem

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 16:26:22 +01:00
Danilo Del Busso
06ab09eabb CP-41573: Apply code review suggestions
- Ensure `UpgradeRequiresEUA` runs for Yangtze or greater hosts
- Group non-manual checks in same if block
- Remove unused field in `EuaNotFoundProblem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
6ce22f759a CP-41923: Update RPU005 to version 5.0
Also:
- Add `HostDoesNotHaveHotfixWarning` warning to EUA `Check` when necessary
- Filter our `null` EUAs before passing them to the `Problem`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
ffbf8e3cd0 CP-41573: Use wizard page as a parent of AcceptEuaDialog
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
de6372f680 CP-41573: Check for presence of valid URI within UpgradeRequiresEUA Check
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
f03c1cc17b CP-41573: Move EUA precheck after hotfixes
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
5f5695057d CP-41573: Improve comparison logic for problems
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
f707b0daca CP-41573: Add UpgradeRequiresEua as a permanent check to the RollingUpgradeWizardPrecheckPage
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
34eb5ff9b0 Enable multiple IXenObjects to be associated with a Check instance
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-26 10:11:19 +01:00
Danilo Del Busso
eb0636fe9c
Update warning messages for host selection when importing VM appliance
Adds a new field in `SelectMultipleVMDestinationPage`: `AllSelectedTargets`.

This new field contains a list of all hosts that have been selected. This way `ImportSelectHostPage` can check for each `Host` that has been selected individually and add more relevant messages

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-19 13:46:33 +01:00
Danilo Del Busso
084215feaf
Reset ovfMaxVCpusCount when a new OVF is selected
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-16 11:37:32 +01:00
Danilo Del Busso
a2a5ae0cf4
Move _ovfVCpusCount.Clear outside content check loop
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-06-16 11:19:40 +01:00
Konstantina Chremmou
6d83365cfc Merge branch 'master' into feature/merge
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/Dialogs/PropertiesDialog.cs
2023-06-13 15:08:36 +01:00
Konstantina Chremmou
56357dc4bc Removed obsolete filter as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
b998cdad6c CP-41474: Authenticate for downloading updates.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
d2fc98a00b Removed unused using directives.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
7e78dc898c CP-41473: Restore installation of server updates on the Patching and RPU wizards.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
02ded9ba71 CP-41474: Added setting on the Options dialog to import a client ID for downloading hotfixes for LCM servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
c694ed26d7 CA-359700: Fixed issue whereby hotfixes applied after an upgrade in parallel were downloaded multiple times.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
2909a4996d Protected loggers do not log the class where the method is correctly.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
82940850e9 CP-43102: Removed Dundee code.
The check DundeeOrGreater always returns true since we disallow connection to anything earlier than Havana.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-06-13 14:48:23 +01:00
Konstantina Chremmou
60bb234f7b Renamed Post2X version to Cloud. Added more Xml docs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-13 14:48:23 +01:00
Danilo Del Busso
6c584bb351
CA-375532, CA-336510, and CP-41825: Add warnings when user selects too many vCPUs (#3119)
* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 11:24:39 +01:00
Konstantina Chremmou
801125f448
Merge pull request #3137 from danilo-delbusso/dev/snapshot-crash-CA-375803
CA-375803: Catch exceptions when creating a new template from snapshot
2023-05-05 14:56:46 +01:00
Konstantina Chremmou
09611a806e Removed DMC deprecation banner and RPU precheck when upgrading a system with DMC VMs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-05-05 14:43:12 +01:00
Konstantina Chremmou
d148956a1b CA-376686: There is no API call "live_migrate".
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-28 10:12:04 +01:00
Danilo Del Busso
30291cc3bd
CA-375803: Check if actions have succeeded before accessing action result
Also add check to non-relevant actions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-04-28 10:06:18 +01:00
Konstantina Chremmou
240fa78333 CP-39687: Exporting VMs with vTPMs to XVA package is now supported.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-25 13:39:54 +01:00
Konstantina Chremmou
4ead4a8bfe CA-376334: Do not show UEFI secure boot mode if UEFI is disabled.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-12 09:54:35 +01:00
Konstantina Chremmou
2c28824594 CA-294901: Reworded (again) so that we don't give the impression that the VMs' affinity will be set.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-04-11 22:15:02 +01:00