Commit Graph

149 Commits

Author SHA1 Message Date
mcintyre94
dd42394a25 CP-16922: Implement GUI for enabling PVS read caching (#1179)
* CP-16922: UI changes to PvsPage to replace the single configure button with a separate enable and disable one, per the design doc

* CP-16922: Intermediate checkin - command + dialog implemented, but PVS page has some layout problems.

* CP-16922:  Implement GUI for enabling PVS read caching and marking/unmarking VMs for prepopulation

Fix the broken layout by reverting MainWindow.resx (which shouldn't have changed) back to the previous commit. Also removed duplicate properties button code.

*  CP-16922: PVS Page changes, to properly display all VMs (not just ones with proxy), only populating proxy columns if there is a proxy set.

* CP-16922: Use a CommandButton for the enable button, connected to the same command as the VM main menu button, and using the table selection as its selection manager.

* CP-16922: Delete the old enable button click behaviour (because it now has a proper command), was causing the dialog to show up twice

* CP-16922: Properly list VMs by hiding those that should be hidden (in addition to non-VMs, also hide the __gui__ prefix and others covered by Show function). Also fixes a bug in NewVMGroupVMsPage discovered when fixing this - it would show VMs that should be hidden if you used the search bar.


* CP-16922: Use ButtonText on the Command to set the text on the PVS enable button

* CP-16922: Add the disable PVS read-caching command, and its associated proxy destroy action. Both based off enable equivalents (main difference is no dialog for now). Not used yet but will be in main window menu + disable button

* CP-16922: Add disable PVS read-caching to the main window menu (under enable), with the disable command attached to it


* CP-16922: Add support for disabling PVS read-caching for selected hosts via the PVS tab page by converting the disable button into a CommandButton in the same way as the enable button, using its own command + selection manager (because Selection Managers only bind to one control)

* CP-16922: Design - adding the "read caching enabled" column from the design, so that we display both whether caching is enabled and whether the VM is currently cached. If it's disabled all other values are missing.


* CP-16922: Add the PVS site column per the design to show the site a VM's PVS Proxy is on if it has a proxy


* CP-16922: Add an event handler for VMs changing so that newly provisioned VMs immediately show up in the PVS tab page


* CP-16922: Support for properly remembering the selection when the VM list is refreshed. A new method returns the list of VMs for the selected rows, and we can then check if the VM for the row being added is in this list. If there was no previous selection then we still select the first row by default.


* CP-16922: Remove prepopulate, which is being removed from the design. The next XAPI version will remove it, so just pass False as prepopulate for now, and remove the option from the dialog and PVS tab page.


* CP-16922: Improve UI appearance for a missing Storage Repository. Per the design, if there is no SR show the message None (memory only) instead of an empty cell

* CP-16922: Improved sorting behaviour. All columns (except VM name, which always uses it) use the VM tag as a sorting fallback (since they all have duplicates). New default sort which sorts by caching enabled first (yes before no), and then VM tag as a tiebreaker. Support for remembering the current sort on refresh, ie when a value changes.

* CP-16922: Refactoring to use a VM extension method to get the PVSProxy (or null if none exists) for a VM. This was used in the PVS Page + commands which are now much simpler.


* CP-16922: Move where the SelectionChanged event handler is set when refreshing the PVS table, so that the command buttons are updated correctly.

* CP-16922: Improvements to PVS read-caching dialog. Set accept/cancel buttons properly + adjust tab values, so focus acts as expected


* CP-16922: Remove the images from the menu for Enable/Disable PVS read-caching, most commands in the menu don't have one

* CP-16922: Sorting out the strings for the actions + ParallelAction calls, and moving them into the resx. Also reverting wrong MainWindow.resx changes.

* CAR-2184: XAPI changes. I've made the minimal possible changes to PvsPage to ensure it compiles, but it's had a lot of feature work (CP-16922) that supersedes this, these small changes should keep that merge painless.


* CAR-2184 XAPI: Reverse the unrelated changes, only keep the PVS ones.

* CP-16922: Merge latest XAPI changes, notably changes to Pvs_site.create

* CP-16922: Change tab show/hide logic for PVS tab, show it even if there are no PVS sites.

* CP-16922: Implement GUI for enabling PVS read caching

Design changes - remove the storage repo column and replace it with status, which is populated with a friendly version of the pvs_proxy_status enum. Also populate site list using site.name_label

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

*  CP-16922: Implement GUI for enabling PVS read caching

Adjusting the CanExecute of Enable PVS read-caching command to require at least one PVS site to be created. Since the PVS tab can show up without any sites, we need this because we can't create a proxy without a site.

* CP-16922: Code review changes.

Tidied up messages, and ensured actions run async properly, and without exiting before their task.

* CP-16922: Code review changes.

Update dialog resx, wider combobox on dialog, update action descriptions before setting RelatedTask, add friendly message body for PVS error notifications.
2016-09-22 15:08:15 +01:00
Mihaela Stoica
9df8b0494c CP-18407: Rename PVS farm to PVS site
- Rename everything to PVS site

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 12:01:59 +01:00
Mihaela Stoica
dea2749afa CP-18407: Rename PVS farm to PVS site
- New API bindings
- Fixed usages of PVS_farm class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-09 11:12:34 +01:00
Mihaela Stoica
f2b21975aa CP-16921: Add new PVS tab
- tab visible on pool or standalone server if the feature is not restricted and the pools has at least one farm

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-13 13:36:49 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Konstantina Chremmou
094e4c4c4f CP-18028: For hosts with more than one control domain (dom0 and cvm at the moment) add an extra tab to display the console of the cvm. 2016-07-05 08:14:13 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Frederico Mazzone
8954c2e038 [CP-17415] XC: Add awareness of new AD feature flag
Added AD-related strings to japanese and chinese resource files; still need translation.
Changed F1/Help mapping of the AD upsell tab to go to the 'Managing Users' help page.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 14:30:39 +01:00
Frederico Mazzone
9a729e2547 [CP-17415] XC: Add awareness of new AD feature flag
Added awareness; basic license now shows upsell tab and premium license shows full feature tab.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-05-20 13:01:51 +01:00
Mihaela Stoica
846ff3b827 CA-204334: When connecting to a newer server, display the link to a compatible XC version
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-24 14:31:38 +00:00
Mihaela Stoica
a7b5c52e1c CP-16205: Add AdditionalFeatures branding variable
We now have two branding variables, one for hidden features and one for additional features (empty by default)
2016-02-29 14:54:26 +00:00
Mihaela Stoica
cd8ed2d686 CP-15576: Hide containers options that aren't available for Windows Server
- Container pause is not available if the the container is on a Windows VM.
- Processes is not available if the the container is on a Windows VM.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-12 16:48:52 +00:00
Mihaela Stoica
9f99c37f83 CP-16012: Rename branding variables
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-10 11:52:30 +00:00
Mihaela Stoica
093feba229 CP-15825: Fix error where the About dialog pops up when a connection status changes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 09:54:42 +00:00
Mihaela Stoica
fb64d19853 CP-15825: Show About dialog at startup detailing company names that the connected hosts have been licensed to
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-29 14:38:58 +00:00
Mihaela Stoica
2689f0bd9e Merge pull request #797 from cheng--zhang/CA-192539
CA-192539: Adding iNode host to XenCenter should be restricted
2016-01-29 10:40:10 +00:00
Mihaela Stoica
25c787e61e CP-14817: Skip the product brand check in automated test mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-01-29 18:07:16 +08:00
Mihaela Stoica
2747ab702b CP-14817: Fixed "Unreachable code" warning
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:

	XenAdmin/MainWindow.cs
2016-01-29 14:28:47 +08:00
Mihaela Stoica
30aa9affc7 CP-14817: Add a check to refuse connection to a server that have different product brand
Change PRODUCT_BRAND to BRANDING_PRODUCT_BRAND

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:

	XenAdmin/Branding.cs
	XenAdmin/MainWindow.cs
	mk/xenadmin-build.sh
2016-01-29 14:26:53 +08:00
Mihaela Stoica
fc5ebd2d40 CP-15401: Move HiddenFeatures to a new class
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-01-28 21:43:15 +00:00
Cheng Zhang
4ba9981d28 Revert "CA-179515: Move to online help"
This reverts commit 0d0cf47523.

Conflicts:

	XenAdmin/Help/HelpManager.resx
	XenModel/InvisibleMessages.Designer.cs
	XenModel/InvisibleMessages.resx
2016-01-28 17:35:51 +08:00
Cheng Zhang
b33e579f28 CP-15401: Hide HealthCheck by reg key
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-25 13:40:45 +08:00
Cheng Zhang
d4ec1289c2 CP-15401: Move hidden check out of designer
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 17:02:59 +08:00
Cheng Zhang
88d881b126 CP-15401: Show/Hide rdpPolling, upsell and optimize for XenApp depending on XenCenter registry keys
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2016-01-22 13:31:22 +08:00
Gabor Apati-Nagy
bb0427a21c CA-187932: Cancelled tasks are reported as errors in XenCenter
Fixed: "User tasks (e.g. VM import) are reported as errors in XenCenter, when they are cancelled tasks."
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-12-03 18:41:25 +00:00
Stephen Turner
ce609e31ff CP-14647: Intermediate check-in #4 2015-11-08 11:28:01 +00:00
Stephen Turner
cf6534275e CP-14647: Intermediate check-in #2 2015-11-08 11:27:57 +00:00
Stephen Turner
b587ab832e CP-14647: Intermediate check-in #1 2015-11-08 11:27:56 +00:00
Mihaela Stoica
dfeb841e5a Merge pull request #709 from GaborApatiNagy/master_CP-12617
CP-12617: Port CP-12191 to trunk
2015-10-28 13:26:36 +00:00
Gabor Apati-Nagy
617ad06f1f CP-12617: Port CP-12191 to trunk
Add a XenCenter option to enable the old behaviour for the default search for servers

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-10-19 17:12:27 +01:00
Mihaela Stoica
0d0cf47523 CA-179515: Move to online help
Launch online help instead of XenCenter.chm
2015-10-09 12:36:30 +01:00
Mihaela Stoica
2eba1c705f Merge remote-tracking branch 'upstream/master' into CP-12156_2
Conflicts:
	XenModel/XenAPI-Extensions/Pool.cs
	XenModel/XenModel.csproj
2015-08-27 01:03:58 +01:00
Mihaela Stoica
44e18df03d CP-12156: Obtain and display the result of the CIS analysis of the last uploaded report
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-08-27 00:30:02 +01:00
Hui Zhang
0761aa5be2 CP-13848: XenCenter transfers proxy settings to HealthCheckService.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-08-25 20:32:58 +08:00
Mihaela Stoica
a9be9846ff CP-13073: Rename Call Home to Health Check in code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-29 08:44:41 +01:00
Mihaela Stoica
c1dac478b1 CP-13083: Add user setting and checkbox to the Health Check overview dialog saying "Show this when connecting to servers that are not enrolled into Health Check"
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-24 14:12:46 +01:00
Mihaela Stoica
7c737d6ce8 CP-12769: Send server connection details to the Health Check Service
- Call TransferCallHomeSettingsAction with suppressHistory=true so the action doesn't show on the Events page
- This change also fixes LogsTabTests test failure.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-07-01 16:38:12 +01:00
Cheng Zhang
324c249285 CP-12769: Send server connection details to the Health Check Service
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-07-01 11:53:56 +08:00
Mihaela Stoica
8ce3dc9952 CP-12154: Offer Call Home enrollment when connecting to Call-Home capable hosts
- Check call home enrollment status on connecting to a pool: If status is unknown it means that the pool is not enrolled (enabled) and has never been (disabled). If that's the case, then show the Health Check Overview dialog with the pool selected
- "Enroll now" on Health Check Overview will try enroll the selected pool into call home using existing token authentication. If this is not possible, then a dialog will be presented for the user to perform the initial authentication.
2015-06-08 16:46:16 +01:00
Gabor Apati-Nagy
93132ebbaa CA-165712: Show the GPU tab when GPU is licensed, even when there are no supported GPUs
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-03-31 17:26:37 +01:00
Stephen Turner
ae672aa4b0 CA-159791: Remove GC debug info from logs 2015-03-20 13:17:06 +00:00
Mihaela Stoica
740bbf133e CA-161097: Renamed Container member to Docker container to fix build failures
This fixes the build errors:
- error CS0108: Warning as Error: 'XenAdmin.TabPages.DockerDetailsPage.Container' hides inherited member 'System.ComponentModel.Component.Container'.
- error CS0108: Warning as Error: 'XenAdmin.TabPages.DockerProcessPage.Container' hides inherited member 'System.ComponentModel.Component.Container'.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-26 09:45:43 +00:00
Mihaela Stoica
1c562bcb9a CA-161097: Change IXenObject to DockerContainer in container Details and Processes page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-25 15:08:59 +00:00
Mihaela Stoica
4e29c8dbb8 CA-161097: Pause the automatic refresh on Container processes page when the page is not visible
- Instead of calling the plugin on the UI thread, we call it through an action that we execute asynchronously  and on completion update the UI.
- Pause the refresh timer on leaving the page and resume it when entering the page again.
- We do this for both Processes and Details page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-18 09:50:55 +00:00
Cheng Zhang
9c0e2c60de CP-11053: Add per-container "Details"-Tab
- Showing all detailed information from a docker_inspect call
- The information refresh/polls every 20s while it's open
- Button “Refresh” add, so user can refresh the result. Also shows time when the last refresh happens.
- Add TabPageDetails as value 9903 in HelpManager.resx

Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
2015-02-13 10:49:41 +08:00
Mihaela Stoica
e3494f2d92 Merge pull request #324 from huizh/CP-11052
CP-11052: Add per-container "Processes"-Tab to XC
2015-02-12 10:53:18 +00:00
Hui Zhang
789e45f11c CP-11052: Add per-container "Processes"-Tab to XenCenter
This tab will show docker process id, command and CPU time.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2015-02-12 17:58:17 +08:00
Mihaela Stoica
9bae16c03c CP-10927: Add container lifetime operations to the toolbar
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-11 13:46:23 +00:00