Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2025-01-22 00:00:40 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
5,852 Commits 12 Branches 48 Tags 186 MiB
e30ea433c7
Commit Graph

810 Commits

Author SHA1 Message Date
Konstantina Chremmou
5f7d3e1518 Homogeneous icon usage across the application. 
- Replaced remaining instances of SystemIcons. SystemIcons.Information of size
  32x32 were excepted as we don't have the right size icon yet.
- The question mark icon is used for help, not for asking questions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
8a6a579402 CP-20425: Use static images everywhere an image is assigned programmatically. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
d08f02cce2 CP-20425: Added test to ensure all Resource images have a static counterpart. 
Also, stop boxing Bitmap into Image so as to avoid casting wherever it is called.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
e27a0a7333 Minor refactoring on UpsellPage: 
- Modernised properties.
- Removed unnecessary public method; it was rather obfuscating setting properties.
- Made Image property non-browsable.
- Missing null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-07-18 07:49:27 +01:00
Konstantina Chremmou
f3c5e74dae CP-33892: Audited the use of First() and replaced with FirstOrDefault() where appropriate. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-25 11:17:11 +01:00
Darren Matthews
cef05ab005 L10N : Resx Resync and translation update. Fixed Confirmation Options page with the Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-06-11 13:57:12 +01:00
Darren Matthews
00b6fdc8e3 L10N: Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-06-11 13:57:12 +01:00
Konstantina Chremmou
89487fcf60 CA-337270: Perform authentication on a background thread. 
- Added controls to display the error in case authentication fails.
- Use the same control(LinkLabel) to show the rubric either when new
  authentication is needed or an existing one can be used.
- Moved privacy policy statement next to the checkbox because it looked crammed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec7fc14c18 Typo. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-06-05 11:48:54 +01:00
Konstantina Chremmou
ec1aff6c82 Control alignment corrections on the Role Elevation dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 23:03:45 +01:00
Konstantina Chremmou
8a478011d9 CA-339370: Assign the new VM's name at a late stage to reduce duplicate names. Some simplifications. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-19 07:49:23 +01:00
Darren Matthews
1d74094e5a L10N : Translation and Resx Resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-05-18 15:15:07 +01:00
Konstantina Chremmou
f05b502399 CA-339331: Skip uses deferred execution and needs enumeration. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-15 11:38:23 +01:00
Konstantina Chremmou
a84053cf8d CA-337323 : SR.scan on the SrPicker was happening silently without any indication on the UI (enhanced fix for CA-280299). 
The result was that numbers were changing suddenly; in cases of slow connections,
a user could make a selection before the scan was over.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
d1c9e7ddd1 CA-337323: Attempt finding the right owning form for the RoleElevation dialog. Also: 
- Simplified SudoElevationResult.
- Renamed SudoDialogDelegate to ElevatedSessionDelegate so that it makes more sense
  for projects not referencing WinForms.
- Call directly the RoleElevationDialog within XenAdmin without using the ElevatedSessionDelegate.
- Minor modernisation in AsyncAction.
- Launch GraphDetailsDialog in a using block.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-04 14:30:24 +01:00
Konstantina Chremmou
5927d52349 CA-336024, CA-322705: Rewrote the LVMoISCI frontend of the NewSR wizard 
This fixes various workflow bugs and disallows re-attaching GFS2 SR if clustering
is disabled.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
5b6bd343dd CA-322705: Disallow re-attaching GFS2 SR if clustering is not enabled. Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-05-01 15:27:18 +01:00
Konstantina Chremmou
bf5c66598c Merge remote-tracking branch 'upstream/master' into feature/REQ-716 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
 2020-04-29 16:47:48 +01:00
Konstantina Chremmou
17b6c28978 Merged master into feature/REQ-453 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdminTests/UnitTests/TimeUtilTests.cs
#	XenCenterLib/TimeUtil.cs
 2020-04-26 04:11:14 +01:00
Konstantina Chremmou
563b2cc359 CA-338276: Corrected virtualisation state link text for post stockholm linux guests. 
Also, merged the methods calculating the virtualisation status and its friendly
string so as to simplify the logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-26 00:03:45 +01:00
Konstantina Chremmou
9bf7e80fe9 Merged branch master into feature/REQ-716 and resolved conflicts. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/BallooningDialog.cs
#	XenAdmin/Dialogs/WarningDialogs/InstallToolsWarningDialog.cs
 2020-04-24 15:37:01 +01:00
Konstantina Chremmou
d80bbfb151
Merge pull request #2656 from xenserver/feature/read-caching 
Merge feature/read-caching branch to master
 2020-04-24 11:47:26 +01:00
Konstantina Chremmou
60da6080f9
Refactored three button dialog (#2627) 
* ThreeButtonDialog simplification step1: Help name.
* ThreeButtonDialog simplification step2: Window title.
* ThreeButtonDialog simplification step3: Removed class Details.
* ThreeButtonDialog simplification step4: Removed unnecessary (and wrong) class.
* ThreeButtonDialog simplification step5: Compacted TDButton constructors.
* ThreeButtonDialog simplification step6: Removed purposeless methods.
* ThreeButtonDialog simplification step7: Refactored constructor logic.
* ThreeButtonDialog simplification step8: Icon normalisation.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-22 14:47:03 +01:00
Konstantina Chremmou
3c68e7e097 Improved parsing of SMAPIv3 errors. Deprecated Failure method that should not be used directly by the implementation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-20 18:56:13 +01:00
Mihaela Stoica
7f6877c330
Merge pull request #2652 from xenserver/feature/REQ-811 
Merge feature/REQ-811 into master
 2020-04-20 18:39:37 +01:00
Konstantina Chremmou
f31a8f2085 Some refactoring to memory editing controls. 
Override the polymorphic methods of XenTabPage on the ballooning wizard;
No need to exposed the memory values outside the VMMemoryControlsEdit class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
d198b693d1 Replaced InstallToolsWarningDialog with a ThreeButtonDialog. Removed methods duplicating command execution logic. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Konstantina Chremmou
dfb49c97a1 CP-32687, CP-32689: Remove "Install PV Tools" options from stockholm onwards. 
Replace with help links where necessary or convenient. Also:
- Registered unused event.
- Minor refactoring to: make the InstallToolsCommand.CanExecute clearer; use
  local methods.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-17 16:23:06 +01:00
Mihaela Stoica
71a09385c3 CP-32985: XenCenter control to turn read caching on / off per SR 
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
 2020-04-16 10:26:17 +01:00
Konstantina Chremmou
c6c725c37d CA-338012: Corrected error messages for RBAC restrictions and intermediate certificate errors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-15 14:30:00 +01:00
Darren Matthews
bb560db1dc L10N : Resx resync and translation update 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-04-08 15:56:46 +01:00
Konstantina Chremmou
0188fdc69b Corrections as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
e9acde0b64 Try handling a connection interruption. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
79bebdb816 Parse the certificate alert body as xml. Accept more ISO 8086 formats. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
8fc258420d CP-32699: New dialog for certificate installation on a server. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
f0f8f90875 Dispose of X509Certificate2 objects. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
52369c9d0d Removed references to SSL certificates. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-08 13:55:35 +01:00
Konstantina Chremmou
a8fc37b22b Merge remote-tracking branch 'upstream/master' into feature/REQ-811 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Diagnostics/Checks/Check.cs
#	XenAdmin/Diagnostics/Problems/PoolProblem/PoolHasPVGuestWarningUrl.cs
#	XenAdmin/Diagnostics/Problems/Problem.cs
#	XenAdmin/Diagnostics/Problems/WarningWithMoreInfo.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
 2020-04-02 23:29:54 +01:00
Konstantina Chremmou
03dbf38f6f Merge branch 'master' into feature/REQ-814 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
 2020-04-02 10:58:58 +01:00
Konstantina Chremmou
3ecd6a4d8b Fixed missing ExpandedChanged event registrations. Tidied up methods toggling the section expanded state. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-04-01 16:27:13 +01:00
Konstantina Chremmou
5406b933fd CA-330308: Rewrote Power-On edit page to fix workflow issues: 
- It was not possible to apply different settings to multiple hosts
at the same time.
- Server calls were made on the UI thread.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-30 10:48:32 +01:00
Konstantina Chremmou
6c06b08024 Some refactoring and code modernisation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-11 22:22:17 +00:00
Konstantina Chremmou
9e458373b0 Missing copyright; typos found from spell check; added terms to ignore list. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-04 12:40:20 +00:00
Konstantina Chremmou
00cc547aaf Warning and error corrections. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
ebcbf9cabc CP-32947: Hide CHIN network type and do not restrict QoS options. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-03-02 17:46:29 +00:00
Konstantina Chremmou
76ba20205e CA-335633: Prevent crash due to iterating through modified dictionary. Ensure that per-XenObject dialogs closed by the user are removed from the tracking table. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00
Konstantina Chremmou
cf633c3d9d Removed duplicate method. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-28 13:33:57 +00:00
Konstantina Chremmou
64b23be1aa CP-32844: Drop legacy SSLv3 setting 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-27 09:29:40 +00:00
Darren Matthews
7925bcae27 L10N : Translation and resx resync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2020-02-26 08:24:06 +00:00
Konstantina Chremmou
1b35a6898f Spelling corrections, mostly for consistency with the docs. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2020-02-14 14:43:22 +00:00