Commit Graph

1939 Commits

Author SHA1 Message Date
Callum McIntyre
2b215ffd78 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-17848
Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs (resolved using master)
2016-09-09 12:59:29 +01:00
Callum McIntyre
d302815b66 CP-17848: Commit to hand over. PatchingWizard_UploadPage.cs contains new code to introduce a Pool_update, PatchingWizard_PatchingPage.cs to apply and clean it. 2016-09-09 12:02:59 +01:00
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Gabor Apati-Nagy
6065465a52 Merge pull request #1148 from MihaelaStoica/CA-220049
CA-220049: Non-livepatch hotfix installation is failing
2016-09-05 12:05:06 +01:00
Gabor Apati-Nagy
531613b037 Merge pull request #1149 from MihaelaStoica/CA-220171
CA-220171: Configure HA dialog incorrectly states failover tolerance …
2016-09-05 12:02:06 +01:00
Mihaela Stoica
7764a6bf9f Merge pull request #1145 from mcintyre94/CA-140338
CA-140338: Truncation on New Search Page with long Custom Field Filters name
2016-09-02 11:25:59 +01:00
Mihaela Stoica
8755126e8d Merge pull request #1144 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-09-02 11:17:55 +01:00
Mihaela Stoica
8e077e1e78 CA-220171: Configure HA dialog incorrectly states failover tolerance would be 0
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-02 10:46:33 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00
Mihaela Stoica
b758e0660a Resurrect CP-18011: [XenCenter] Add live patching checkbox
(reverting  8a10351c5d: Revert "Cp 18011: [XenCenter] Add live patching checkbox")

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 14:59:37 +01:00
Callum McIntyre
df9410ac6a CA-112317: Sorting on SR storage tab is incorrect
Making the requested changes: Name is now sorted by the generic CompareTo method (which uses name with opaque ref as tiebreaker), and Description also uses opaque ref as tiebreaker for consistency.
2016-08-31 16:42:01 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Gabor Apati-Nagy
d5bb5d96bc Merge pull request #1139 from mcintyre94/CA-107341
CA-107341:  Truncation issue occurred on rolling pool upgrade window.
2016-08-30 16:01:01 +01:00
Gabor Apati-Nagy
b510dbe8c7 Merge pull request #1140 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-08-30 15:57:47 +01:00
Gabor Apati-Nagy
d7a94c1684 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Fixed flickering

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:41:12 +01:00
Gabor Apati-Nagy
15f69ef584 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
Improving AvoidRestartHost usage/interface

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 16:04:28 +01:00
Gabor Apati-Nagy
f55cf77c00 CP-18014: Alter batch hotfixing to use host.patches_requiring_reboot
XenCenter will check host.patches_requiring_reboot when a host restart is due while a batch update is in progress. If the restart is not required, XenCenter will skip relevant PlanActions.
The intention here is to check this whenever a restart is due according to the original schedule - this way a completely livepatchable update can prevent the restart while the key batch hotfixing logic is not changed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-26 15:37:57 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
1cc960860b CA-112317: Sorting on SR storage tab is incorrect
Change the sorting on the Name and Description columns to use StringUtility.NaturalCompare, which correctly sorts strings with numbers at the end (eg name, name0, name1, name2, name10 will now sort correctly while alphabetic sorting is incorrect). Also added a tie break on uuid to make sorting behave predictably with duplicates in these columns.
2016-08-26 10:06:30 +01:00
Callum McIntyre
c41602085d CA-107341: Truncation issue occurred on rolling pool upgrade window.
Truncated pool and host names on the Ready to Upgrade page to 64 characters, which resolves the layout problem from extremely long names.
2016-08-25 16:48:39 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Konstantina Chremmou
a9a1cd6b9c Tidied up: the vncScreen should notify the parent vncTab when the rdp warning needs
to be shown. It is complicated to have the one control call a method in the other
which checks the state on the first control.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 11:48:42 +01:00
Callum McIntyre
7f5390e9c4 CP-18618: If live patching fails, warn the user
If we are expecting to live patch, but at the end
hosts.patches_requring_reboot contains the patch, then warn the user that
live patching has failed for the host - and it needs to be rebooted.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-24 11:13:58 +01:00
Konstantina Chremmou
38ca217bc3 Tidied up: moved the full screen message from the VNCTabView class to the more relevant
FullScreenHint class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 01:38:51 +01:00
Gabor Apati-Nagy
7ee2e605ee CP-18012: Use extended precheck information in Update Wizard
This commit implements the check for LiveUpdate capability of a patch. If
the patch is completely live-updatable, XenCenter will not restart the
host (but will do further checks once it has finished installing the
update - separate ticket)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-23 18:31:23 +01:00
Konstantina Chremmou
629c2b48d1 Merge pull request #1134 from mcintyre94/CA-140181
CA-140181: Inconsistent name displaying when it contains symbol '&’
2016-08-23 12:14:01 +01:00
Konstantina Chremmou
ba4ecd5fa4 Merge pull request #1135 from mcintyre94/CA-152163
CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
2016-08-23 12:06:20 +01:00
Callum McIntyre
cf4ed293ba CA-140181: Inconsistent name displaying when it contains symbol '&’ and becomes hotkey.
Now using the EscapeAmpersands string extension method. Also resolved the custom fields display issue in the same way.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 11:33:24 +01:00
Callum McIntyre
af9327d30a CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Redone the commit without any size changes.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-23 10:52:00 +01:00
Callum McIntyre
493b86a5c3 Revert "CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard."
This reverts commit d928a406bc.
2016-08-23 10:37:29 +01:00
Konstantina Chremmou
bb327ac245 Merge pull request #1132 from stephen-turner/CA-150364
CA-150364: Shrunken item on status bar
2016-08-23 10:01:46 +01:00
Callum McIntyre
d928a406bc CA-152163: Duplicate hotkey "S" on "Location Mirrored SRs" wizard.
Moved the hotkey for "Find Storage Repositories" from S to R.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 17:44:56 +01:00
Callum McIntyre
14288ede3a CA-140181: Inconsistent name displaying when it contains symbol '&’
The ticket said the character after the & became a hotkey (like labels etc do with UseMnemonic enabled) but I couldn't reproduce that - & symbols were simply removed from the string. The fix is to replace them with &&, so the string.format prints a single & as it should.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-22 16:07:53 +01:00
Konstantina Chremmou
e99f86c29c Merge branch 'master' into REQ-156 2016-08-19 17:54:37 +01:00
Stephen Turner
e99a97f748 CA-150364: Shrunken item on status bar 2016-08-19 16:50:08 +01:00
Konstantina Chremmou
d07a34ad19 Set checkbox state in the designer and not in the constructor to avoid starting
the checks before the page is loaded. Corrected the conditions for enabling the
Previous and Next buttons on this page. This commit fixes broken RPU wizard test.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 15:45:16 +01:00
Konstantina Chremmou
73b0c36fb6 CA-217232: Added some null ref checks.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-19 10:55:18 +01:00
Konstantina Chremmou
0cd8391feb Merge pull request #1128 from GaborApatiNagy/REQ-156_github
CA-217232: Fixed regression caused by the fix for CA-216935
2016-08-19 10:42:41 +01:00
Gabor Apati-Nagy
54f67be47c CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 17:55:44 +01:00
Gabor Apati-Nagy
d054c80f62 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:02:24 +01:00
Gabor Apati-Nagy
1c5ba794b4 CA-217232: Fixed regression caused by the fix for CA-216935
Changes following the code review
2016-08-18 16:00:50 +01:00
Gabor Apati-Nagy
53619c775d Merge remote-tracking branch 'github_xenadmin/master' into REQ-156_github_master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenModel/Actions/ParallelAction.cs
	XenModel/FriendlyNames.resx
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2016-08-18 12:22:40 +01:00
Gabor Apati-Nagy
37c120ee57 CA-217232: Fixed regression caused by the fix for CA-216935
Creation of PoolPatchMapping objects made safer.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-18 11:30:50 +01:00