Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-24 22:06:59 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,200 Commits 11 Branches 48 Tags 186 MiB
e951aa5268
Commit Graph

2426 Commits

Author SHA1 Message Date
CitrixChris
e951aa5268
Changes the confimation dialog to one that actually shows background … (#2959) 
* Changes the confimation dialog to one that actually shows background tasks

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Removes unused messages

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Seperates Download and Install Logic so background task checker only happens after msi is downloaded

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Allows download to be canceled

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Some corrections.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 15:25:32 +01:00
CitrixChris
f0f0de0076
CA-364330 wraps cyptoexception in try catch to show appropriate message (#2968) 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-03-10 14:16:13 +00:00
CitrixChris
59e45f40c6
Update alert test fixes (#2953) 
* CP-31587 made checksum comparison case insensitive as well as culture insensative

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* Fixes not null assertion

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Merges internal classes to be in same file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
 2022-02-18 10:24:33 +00:00
Konstantina Chremmou
99452959c3 Further tweaks as per code review. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
b050adaeaa Some corrections and tidy up. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0d9a204661 CP-31587 moves validate msi exception messages to messages.resx. Sets update client button to hidden on launch. 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
5845bab13f CP-31587 Implements reviewer's comments. 
Moves dialog strings to messages.resx. Corrects button colours, hides update client option to avoid highlighting when disabled. Revmoves unessessary comments.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
d8b1d5737d CP-31587 added comfirmation dialog to manageupdates page 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
755411a970 CP-31587 implements confirmation check before updating client 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
75f9b402ec CP-31587 added a checksum check to download and install client action 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
0a0533a59f CP-31587 improved DownloadAnUpdateClientAction 
Made variables more accurate, removed unnessessary code

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Christophe25
aa59e8f475 CP-31587 Created new download and install action that downloads the file from updates.xml url and stores in in temp folder with progress dialog 
Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2022-02-17 12:52:30 +00:00
Konstantina Chremmou
eef4e5f995 CP-38427 issue 1: Do not allow enabling TLS verification during RPU. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-11-30 22:46:43 +00:00
CitrixChris
8281ae5c05
CA-359809 improved illegal character message (#2898) 
* CA-359809 improved illegal character message

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 cleared whitespace, improve code readability

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 implemented reviewer comments.

Moved Path validator to XenModel Project where other language files have already been set up.
Improved error messages.

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 improved string localisation, Code tidy

Cannot became can not, messages file alphabetised, improved readability with using xenmodel as opposed to direct call

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>

* CA-359809 changed can not to cannot

Signed-off-by: Christophe25 <christopher.lancaste1@citrix.com>
 2021-11-22 12:02:26 +00:00
Konstantina Chremmou
c2f92aa02a
Merge pull request #2903 from danilo-delbusso/CP-36392-Bugs 
CP-36392: Address statically flagged trivial issues that can cause bugs
 2021-11-17 11:36:48 +00:00
Konstantina Chremmou
5078c4db0d CP-38086: Block upgrade for PV guests. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	XenAdmin/Diagnostics/Checks/PVGuestsCheck.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenModel/BrandManager.cs
#	XenModel/Utils/Helpers.cs
 2021-11-15 15:49:39 +00:00
Danilo Del Busso
e791b70ba7
CP-36392: Move return to new line in Search.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:39 +00:00
Danilo Del Busso
11e90940e0
CP-36392: Simplify Equals method in QueryTypes.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:21:08 +00:00
Danilo Del Busso
f66216bf7b
CP-36392: Improve readability in Name method of Network's xapi extension 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:18:32 +00:00
Danilo Del Busso
9b4f960336
CP-36392: Check for whitespace-only values in GEtPerfmonDefinitions 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 10:15:29 +00:00
Danilo Del Busso
5f117e90c5
CP-36392: Add null check in EnableHostAction.cs 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-15 09:21:25 +00:00
Danilo Del Busso
2978f60f8a
CP-36392: Improve readability of latest changes 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-11-03 10:23:21 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
 2021-10-27 13:24:23 +01:00
Konstantina Chremmou
c44f6496df CA-360011: Allow full disk copy only if all VDIs of the snapshot/custom template allow it. 2021-10-26 16:55:18 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392 
CP-36392: Address Security Features and Code Smells
 2021-10-26 16:54:34 +01:00
Konstantina Chremmou
45fe1f436b CA-359795: Fixed issue whereby a double error was shown when a non-privileged user attempted to apply a licence. 
Removed ApplyLicenseEditionCommand as it was unnecessary (there was no
button/menuitem calling it). Use the ApplyLicenseEditionAction instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements. 
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-10-12 12:28:42 +01:00
Danilo Del Busso
69722d93bd
CP-36392: Rename key constants in WlbReportSubscription.cs to avoid field clash 
Names are amibguous
Also made the fields `const`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:56:15 +01:00
Danilo Del Busso
3a69fa0f8c
CP-36392: Add readonly to fields used in GetHashCode 
Also tidy up some code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:39:17 +01:00
Danilo Del Busso
36b815f104
CP-36382: Add missing Equals to QueryTypes.cs 
Class implements `GetHashCode` without `Equals`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-05 11:39:13 +01:00
Danilo Del Busso
4e4747ecb8
CP-36392: Remove misleading readonly in collection/array fields 
`reaonly` should be used for items that can't be modified. The changed collections/arrays are modified, so `readonly` is misleading

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:27:42 +01:00
Danilo Del Busso
db2c00d54d
CP-36392: Cast operands of divisions to not lose precision 
Cast to `decimal` or `float` to keep floating-point precision

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 16:22:29 +01:00
Danilo Del Busso
dcbaf5d1a4
CP-36392: Amend calls that generate unused return values 
Mixture of correctly implementing `Trim()` calls, and removing calls that generate useless ephemeral variables.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:40 +01:00
Danilo Del Busso
a5ddcf1b97
CP-36392: Refactor loops into if blocks 
Loops are effectively used as if statements. Changed to improve readability.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:10 +01:00
Danilo Del Busso
02aa50f7a8
CP-36392: Refactor conditions that result in unreachable code blocks 
Also tidy up surrounding code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:42:04 +01:00
Danilo Del Busso
df53a4cd98
CP-36392: Refactor useless null checks in actions constructors 
Also remove useless `this` usage

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:41:59 +01:00
Danilo Del Busso
0623717627
CP-36392: Replace custom Utils method with direct calls 
`ThrowIfEnumerableParameterNullOrEmpty` adds complexity

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-10-04 15:09:00 +01:00
Danilo Del Busso
cf28746075 CP-34231: Amend negative language in bond deletion messages 
Wording is slightly incorrect

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-28 11:08:40 +01:00
Danilo Del Busso
ab53f3c9d3 CA-359271: Update LICENSE_EXPIRY_WEBPAGE and UPSELL_SA URLs 
Previous URL is broken

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-27 12:48:47 +01:00
Konstantina Chremmou
ddf16c008b Corrected Host.evacuate overloads. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-24 15:56:00 +01:00
Konstantina Chremmou
a2d829b93c CA-359092: Clarify SMB storage option in NewSR wizard 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-24 11:20:13 +01:00
Danilo Del Busso
2f176caf46 CP-38219: Update RPU005 to version 3.0 
Also exclude Yangtze or greater from hotfix check

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-24 11:19:36 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
 2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d740e83620 CP-38018: Report mismatch between pool and host certificate verification in an undismissable way 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Konstantina Chremmou
55fd07f8ba Minor refactoring. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Konstantina Chremmou
91e43cfe95 Updated C# SDK (xapi 1.319.0-1.xs8). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-23 10:44:30 +01:00
Danilo Del Busso
157fe77f8f
CP-36392: Add comment to ignored catch blocks 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

CP-36392: Add missing comments to ignored catch blocks

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2021-09-20 09:35:17 +01:00
Konstantina Chremmou
1936b74030 CA-294901: Reworked rubric for home server assignment because previous work on it broke the template case. 
Also, no need to use a different message for single and multiple VMs or templates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-17 14:54:56 +01:00
Konstantina Chremmou
cacdb2ef34 Typos. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2021-09-07 11:12:56 +01:00
Konstantina Chremmou
5ee8230834 Merge remote-tracking branch 'upstream/master' into feature/REQ-403 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/CertificateAlert.cs
#	XenAdmin/Commands/DisconnectWlbServerCommand.cs
#	XenAdmin/Commands/ViewWorkloadReportsCommand.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/PoolJoinRules.cs
 2021-09-01 14:43:23 +01:00