Commit Graph

2919 Commits

Author SHA1 Message Date
Konstantina Chremmou
62586ef89c CP-5750: Removed ActionType; the actions should be categorised by status (in progress,
succeeded, failed; cancelled at the moment counts as failed, we may need to distinguish
in future). As a consequence the filter checkboxes from the top of the Log tab
were removed and some temporary changes were made to the drawing of action rows
(the controls will change completely in a subsequent commit).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:38 +01:00
Konstantina Chremmou
38ab6b8ffa CP-5750: When a License warning is generated, create an alert rather than an Action.
Removed ActionType.Alert. Removed Alerts checkbox from the Log tab.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:36 +01:00
Konstantina Chremmou
077cb17deb CP-5750: Changed the declaration for the ActionBase events Completed, Changed and
NewAction to use the Action<ActionBase> delegate instead of EventHandler. Thus
there is no need to fire them with Empty or null EventArgs and on several occasions
we avoid casting objects in the event handlers.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:33 +01:00
Konstantina Chremmou
eb1dd68a28 CP-5750: Code tidy. Comment improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:20:31 +01:00
Konstantina Chremmou
58e9b1c822 CA-113431: Display a warning when a pool has a mixture of free hosts with license
expiry dates that are more than 30 days apart (not ideal, but safest solution for
the case of a mixture of free and free but expiring soon hosts.)

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:18:15 +01:00
Konstantina Chremmou
35226d65dd CA-113319: LicenseManager was showing confusing licensing information.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-09 17:17:24 +01:00
Konstantina Chremmou
accf445584 CA-112931: Fixed issue where the "Activate Free XenServer” button was disabled
when selecting multiple hosts on the Licence manager.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:46:05 +01:00
Konstantina Chremmou
fb2418da63 Try enabling unit tests for branches other than trunk.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:53 +01:00
Konstantina Chremmou
db1aacaa85 The parameter 'force' was added to Host.apply_edition in Clearwater, not Augusta.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-05 17:45:12 +01:00
Konstantina Chremmou
20770553c6 CP-5752: Renamed "Add Group" button to "More", changed its image and moved it closer
to the other grouping buttons.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:47 +01:00
Konstantina Chremmou
f3855500b4 CP-5752: Renamed default search. Use Action delegate instead of EventHandler when
there is no need to pass in parameters when the event is fired. Minor code tidy.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:45 +01:00
Konstantina Chremmou
f8044cde8e CP-5752: Removed the SearchOptions DropDownButton and moved the functionality of its items to separate buttons.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:43 +01:00
Konstantina Chremmou
1ee173d349 CP-5752: Moved ExportSearch method from the MainWindow.cs to the Search tabpage where it belongs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:42 +01:00
Konstantina Chremmou
8f51089efe CP-5752: Use Action delegate instead of EventHandler when there is no need to
pass in parameters when the event is fired. Moved QueryElement.Dispose method
from the Designer.cs to the main file (it needs visibility since it contains more
code than the autogenerated method).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:40 +01:00
Konstantina Chremmou
03d5053073 CP-5752: Moved Save Search functionality from the SearchOptions dropdown menu to
a Save button in the Searcher panel. Moved collapse Searcher panel functionality
from the SearchOptions dropdown menu to a Close button in the panel. Use new
Expanded property to query the state of the Searcher panel (instead of Visible).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:38 +01:00
Konstantina Chremmou
014de807a3 CP-5752: Moved ShowColumns functionality from the SearchOptions dropdown menu to
a button at the top left of the search output panel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2013-08-03 01:04:36 +01:00
Sorin Sbarnea
59723074a7 build scripts update: replaced some hardcoded repository names with a variable so it will work the same on git and hg. Expecting no effects here but it will minimise the differences between trunk and older branches. 2013-07-30 12:42:43 +01:00
Adrian Jachacy
16429b4707 CA-108795: Fix TestDelay tests.
Removed TestDelays tests from UpdateManagerTests.cs

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-26 14:36:18 +01:00
Adrian Jachacy
edce7529f6 CA-109273: [DELL-194] Throws exception if Download & Install used on host in maintenance mode.
1. Added additional check to DownloadAndInstall method in ManageUpdatesDialog.cs: will proceed to the prechecks page in the Install Update Wizard only when there are selected servers on the previous page.
2. Modified code to allow hotfix installation when the host is in maintenance mode; however the host cannot be upgraded when in maintenance mode.
3. Modified test to reflect changes described above.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-25 09:44:52 +01:00
Adrian Jachacy
d68db5ffaf Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-24 14:06:55 +01:00
Adrian Jachacy
b4d282577b CA-111876: XenCenter displays an empty Summary page on cancelling the reattachment of HBA SR.
Moved LMVoHBA related code from UpdateWizardContent() method to CanShowLVMoHBASummaryPage() method which is called from RunNextPagePrecheck() method now: the code prepares all lvmohbaSrDescriptors for each LUN selected by the user and executes RunFinalAction() method.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-24 13:34:21 +01:00
Stephen Turner
213f5f9591 CA-111829: Only sets the restart priority on some of the VMs when enabling HA or modifying HA configuration. 2013-07-24 13:28:32 +01:00
Adrian Jachacy
5ee8a569ee CP-4959: EA-1246: If RPUW cancelled, inform users about restarting it.
Minor code refactoring to address the comment raised in review #2003.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-24 11:01:53 +01:00
Adrian Jachacy
635a794e7c CP-4959: EA-1246: If RPUW cancelled, inform users about restarting it.
New info dialog displayed when the user cancels the last page (Apply Upgrade page) of the Rolling Pool Upgrade wizard.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 19:57:51 +01:00
Adrian Jachacy
da00b13bb9 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-23 16:29:16 +01:00
Adrian Jachacy
4451d2f3e0 CA-107917: XOP-373: When rolling out a XD desktop group, SR storage tab becomes unusuable in XC.
1. Moved Dispose(bool disposing) method to SrStoragePage.cs (from SrStoragePage.Designer.cs).
2. Added private bool disposed field as suggested in review #1998.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 16:24:01 +01:00
Adrian Jachacy
d89d04a33d CA-76329: SR destroy option is missing from XenCenter (even SR doesn't contains any VDI and SR is detached)
1. Changed definition of IsDetached property in SR.cs: SR is detached when it has no PBDs or when all its PBDs are unplugged.
2. Added bool HasPBDs property in SR.cs (replaced previous IsDetached property definition).
3. Reviewed all usages of sr.IsDetached property.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 13:42:27 +01:00
Adrian Jachacy
e61b74a720 CA-107917: XOP-373: When rolling out a XD desktop group, SR storage tab becomes unusuable in XC.
Added VDIsDataGridViewBuilder class which refreshes the data grid view with new data using background worker thread.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-23 13:40:12 +01:00
Mihaela Stoica
bec2117a2a CA-110610: It should be possible to apply a free license to a 6.1 or earlier pool if the pool has two or more servers in it.
- Changed the condition under which we show pool members as individual hosts in the License Manager dialog, from ALL to ANY,
meaning that if any of the pool members can be activated, then we split the pool.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-22 14:07:47 +01:00
Mihaela Stoica
6399087bd5 Updated ApplyLicenseEdition action to use the correct version of Host.apply_edition depending on host's version.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-19 16:32:42 +01:00
Mihaela Stoica
3d8ccf29e3 Updated Helpers.AugustaOrGreater function to use Augusta platform version
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-19 16:30:27 +01:00
Mihaela Stoica
47d2ac49b3 Host.apply_edition has an extra parameter. Provide overload for backwards compatibility. 2013-07-19 10:54:12 +01:00
Konstantina Chremmou
6576f515f2 CP-5604: Updated unit tests.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-18 15:04:47 +01:00
Konstantina Chremmou
171235f201 Merge remote-tracking branch 'origin/master' 2013-07-18 13:57:18 +01:00
Konstantina Chremmou
500fcb9522 CP-5604: Moved right click menu functionality to a separate column on the alerts datagridview.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-18 13:56:40 +01:00
Mihaela Stoica
a5cc4383e8 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-17 15:12:22 +01:00
David Scott
292b333078 Avoid throwing an exception when there are no CDs in the New VM wizard dropdown
The rest of the code is robust to there being no CDs (and e.Index = -1)
apart from this bit.

Signed-off-by: David Scott <dave.scott@eu.citrix.com>
2013-07-17 13:47:47 +01:00
Adrian Jachacy
71eea27965 CA-107917: XOP-373: When rolling out a XD desktop group, SR storage tab becomes unusuable in XC.
The logic to determine which rows have to be added/updated/removed has been moved to a separate thread. This improved the performance as the UI thread is blocked only to refresh rows in the dataGridView.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-16 15:41:55 +01:00
Mihaela Stoica
31fb3218b0 CA-110610: It should be possible to apply a free license to a 6.1 or earlier pool if the pool has two or more servers in it.
- split the pool members out when they're free, as the activation keys can only be applied to one XenServer host at a time

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-16 11:46:18 +01:00
Mihaela Stoica
b7d6b03577 CA-111310: Call VDI.copy asynchronously to avoid timeout [SCTX-1366]
- Changed the synchronous call to VDI.copy to an async one in VMMoveAction and MoveVirtualAction;
- Corrected the calculation of action step in VMMoveAction.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2013-07-16 10:25:02 +01:00
Adrian Jachacy
0927fd02c8 CA-107917: XOP-373: When rolling out a XD desktop group, SR storage tab becomes unusuable in XC.
Modified BuildList() method to remove and add dataGridViewRows only when needed (previously all rows were cleared and new rows were added every time BuildList method was executed).

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-15 13:27:47 +01:00
Konstantina Chremmou
daa36d206b CP-5604: Removed bottom alert actions ToolStrip since the information is duplicated by the right click menu (and will soon be on a separate DataGridView column).. Minor code tidy.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-15 06:41:54 +01:00
Adrian Jachacy
d4fdf02111 CP-5123: PR-1634: Add Summary page in the New SR wizard for Hardware HBA SR type.
Expand all rows when populating the Summary Page.

Signed-off-by: Adrian Jachacy <Adrian.Jachacy@citrix.com>
2013-07-12 18:27:13 +01:00
Konstantina Chremmou
d190b11fa4 CP-5604: Removed dedicated help button from the ManageUpdates dialog; use the base class help button instead. Changed column names on the alert datagridview of the AlertSummary and the ManageUpdates dialogs to match the column headers and facilitate future extraction of code shared by both of them.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-12 11:07:10 +01:00
Chris Harding
a86b851288 Merge branch 'master' of git://hg.uk.xensource.com/carbon/trunk/xenadmin 2013-07-12 09:23:38 +01:00
Chris Harding
8580544a1a CA-109237: Removing AddHostCommand test from the smoke tests 2013-07-12 09:22:50 +01:00
Konstantina Chremmou
bedda13a0d Merge remote-tracking branch 'origin/master' 2013-07-11 19:10:32 +01:00
Konstantina Chremmou
9a6a450cab CP-5604: Merged columns "Name" and "Description" to a single column "Message" on the updates dialog. Added expander column to allow expanding/collapsing rows. Reordered columns. (At the moment there is some duplicate code between the Updates and the Alerts dialog; this will be rectified soon).
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-11 19:09:29 +01:00
Konstantina Chremmou
b9f3aacfbf CP-5604: Converted the "Dismiss All" ToolStripButton on the Alerts dialog to a ToolStripSplitButton with the options to "Dismiss All" or "Dismiss Selected" alerts. Minor code tidy.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-11 18:20:18 +01:00
Konstantina Chremmou
02270b416d CP-5604: Added menu item "Show all" on the location and severity filter. Renamed the "No filter" item to "Show all" on the dates filter. Reordered top ToolStripMenuItems on the AlertSummaryDialog and changed their access hotkeys. Reordered columns on the alerts DataGridView.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@citrix.com>
2013-07-11 17:47:06 +01:00