Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 06:16:37 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
6,316 Commits 11 Branches 48 Tags 186 MiB
ec33caf4b5
Commit Graph

3995 Commits

Author SHA1 Message Date
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method. 
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
177c47f79f CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
b3bc93f1f6 CP-36392: Refactored so that GetHashCode() does not reference mutable fields. 
Also, removed some unused GridRow class members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:33 +01:00
Konstantina Chremmou
c28bb4b34c CP-36392: Removed block that is never hit: 
The situation described in the comment is not applicable as scaling does
not change outside the UI thread, and OnResize() does call SetupScaling().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-06 13:11:32 +01:00
Konstantina Chremmou
3c4808a689 Remove redundant code. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-05 10:19:13 +01:00
Konstantina Chremmou
acc5ed0210 CP-38542: Remove option to disable live patching. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:17:22 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page: 
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-04-01 16:07:43 +01:00
Konstantina Chremmou
ef86be5347
Merge pull request #2978 from kc284/actions 
Compacted ParallelAction and MultipleAction constructors.
 2022-04-01 16:07:30 +01:00
Danilo Del Busso
7a3fe5ddee CA-334613: Clip region within which performance graph lines are drawn 
Sharp turns in the graph can result in the line being drawn outside of the box.
This change makes sure the line is only rendered within the input rectangle.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-04-01 15:41:04 +01:00
Konstantina Chremmou
81d5c508a1 Refactoring suggested by code review (largely naming conventions). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-28 13:43:24 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:50:27 +00:00
Konstantina Chremmou
f5672a8645 CP-39323: Check for DMC in use prior to cross-pool migration to pools where DMC is unavailable. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:51 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:51 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-21 13:10:25 +00:00
Konstantina Chremmou
ab676786b1 CP-39366: Disallow connection to servers earlier than yangtze. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:32:48 +00:00
Konstantina Chremmou
713bec52ce CA-365082: Do not run the PrepareToUpgradeCheck before the necessary RPU hotfix has been applied. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:32:29 +00:00
Konstantina Chremmou
545d85d433 CA-364273: Do not log out the current user if they cancel the operation from the elevated session dialog. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-14 17:31:31 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-03-03 14:35:45 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters 
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
2c5373323c CP-36392: Inherit IDisposable to avoid confusion 
Classes didn't extend IDisposable
Also used null propagation to tidy up method body

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s 
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-02-24 11:53:44 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync 
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
 2022-02-24 11:53:31 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
6aec4ea281 CP-38893: Make internal roles unavailable for selection. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-02-03 11:59:17 +00:00
Konstantina Chremmou
50dd22f4da CA-362868: POOL_CA_CERTIFICATE_* alerts are issued on the certificate and not on the pool. 
Also, moved the function retrieving the XenObject from the alert to the Message class extensions.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-31 14:56:12 +00:00
Konstantina Chremmou
1580a89594
Merge pull request #2931 from kc284/settings 
Minor refactoring; null check; tidy up
 2022-01-27 13:34:20 +00:00
Konstantina Chremmou
bae03aff8b Fixed issue where the settings from previous installations were not imported. Added more documentation. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 19:55:38 +00:00
Konstantina Chremmou
b4afd3ce4c CA-261979: Use utf-8 encoding for logging (or on localised systems the log files may contain illegible characters). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-24 15:22:28 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483 
CP-38483: Unbundle putty from  Citrix Hypervisor Center
 2022-01-24 15:21:32 +00:00
Konstantina Chremmou
f29e267670 Some corrections and refactoring on the external console feature. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
c9bb9c1f0c CA-362353: Add file existence check when launching SSH console 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
66d1c6624b CA-362355: Remove SSH console location check if paths haven't changed 
Avoids users not being able to save other options if the selected SSH console location isn't valid

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
322edd3536 CA-362352: Save SSH Console settings changes on startup 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Danilo Del Busso
34876461fc CA-362354: Account for non-exe files when saving SSH client path 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-17 14:09:34 +00:00
Konstantina Chremmou
2c18b7c7ed Tidy up: moved method to Settings and renamed it. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:04:13 +00:00
Konstantina Chremmou
8086359d2d Minor refactoring. Show more logging. Null check. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-13 11:01:59 +00:00
Danilo Del Busso
9ebcdaabd7 CP-38530: Remove reference to PuTTY in LegalNoticesDialog 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Danilo Del Busso
6a52322035 CP-38530: Remove PuTTY from build scripts and wix installer 
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-07 10:04:43 +00:00
Konstantina Chremmou
7ca120eb76 Fixed DialogResult and ButtonType for buttons (dialog was not closing on Esc or from control box). 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
489069b36b Control behaviour corrections: 
- When radio buttons share the same container, only one needs to be checked.
- Do not set the owning control to null, or the balloon does not hide when asked to.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
57b07a9c7b Set roaming to true. Corrected setting type. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Konstantina Chremmou
879191424c Added hotkeys. Corrected tab indices. 
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
 2022-01-06 10:50:13 +00:00
Danilo Del Busso
b66685a927 CP-38529: Remove method calling PuTTY in GeneralTabPage 
Method is not useful anymore. This commit only removes the PuTTY-related code.

Other docker-related unused code is ignored as it should be removed separately.

Whitespace diffs are tabs -> spaces and automatic VS2019 reformatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
 2022-01-06 10:50:13 +00:00