Commit Graph

668 Commits

Author SHA1 Message Date
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
545d85d433 CA-364273: Do not log out the current user if they cancel the operation from the elevated session dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-14 17:31:31 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
b2dc968ab1 CP-38895: Check version annotations when using API fields or methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:35:45 +00:00
Darren Matthews
c7c60849b3 L10N : Resx Sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-02-24 11:53:31 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00
Konstantina Chremmou
ba8cf7f782
Merge pull request #2934 from xenserver/feature/CP-38483
CP-38483: Unbundle putty from  Citrix Hypervisor Center
2022-01-24 15:21:32 +00:00
Danilo Del Busso
b66685a927 CP-38529: Remove method calling PuTTY in GeneralTabPage
Method is not useful anymore. This commit only removes the PuTTY-related code.

Other docker-related unused code is ignored as it should be removed separately.

Whitespace diffs are tabs -> spaces and automatic VS2019 reformatting

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-06 10:50:13 +00:00
Darren Matthews
702ce7ce0f L10N : Resx resync and Translation Updates
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-01-05 11:38:40 +00:00
Konstantina Chremmou
4a6b2b1e1b
CA-343229: Some modifications:
- Fixed issue whereby logging out the current user did not log out other
  sessions of the currentUser opened from outside the application.
- Improved prompts shown to the user when changing roles.
- Corrected percentage reporting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-12-17 11:08:31 +00:00
Danilo Del Busso
53bf485a14
Replace negative term with log(ging) out user
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-17 11:06:56 +00:00
Danilo Del Busso
f1fcb64b55
CA-343229: Forcefully log out all users when changing their role
- Move _statusUpdaterLock to top of class, rename it, and set as `readonly`
- Extract logout and confirmation prompts into separate methods
- Add list of users that are being manipulated to action titles
- Group logout actions into one `MultileAction` to avoid multiple RBAC prompts being shown
- Tell user they're going to also disconnect other users when logging out current user together with others

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-17 11:06:55 +00:00
Danilo Del Busso
38701d148e
Merge branch 'master' of https://github.com/xenserver/xenadmin into pr/2903
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/GetDataSourcesAction.cs
2021-10-27 13:24:23 +01:00
Konstantina Chremmou
f2d81d5744
Merge pull request #2869 from danilo-delbusso/CP-36392
CP-36392: Address Security Features and Code Smells
2021-10-26 16:54:34 +01:00
Konstantina Chremmou
23ec669698 The message Messages.UPSELL_BLURB_TRIAL was displayed twice on the AD, HA, and Users tabpage for unlicensed pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-10-26 00:47:08 +01:00
Konstantina Chremmou
6b7cd1d9e5 Corrected calculation of datasource units (CA-359068). New/Edit Graph dialog enhancements.
- CA-359068¨Match the whole datasource name (previously the wrong one was picked
  for disk read/write latency).
- New/edit Graph dialog: differentiate between enabled/disabled datasources and
  visible/hidden (known/unknown units; the latter may mean no data).
- Some refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-10-12 12:28:42 +01:00
Danilo Del Busso
02aa50f7a8
CP-36392: Refactor conditions that result in unreachable code blocks
Also tidy up surrounding code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-10-04 15:42:04 +01:00
Konstantina Chremmou
de8acfff24 Use the DEPRECATION_URL as the default value for the Details link of the DeprecationBanner
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/BallooningPage.cs
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d59a61991e CP-36908: Remove support for xscontainer supp-pack from stockholm.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/PauseDockerContainerCommand.cs
#	XenAdmin/Commands/RestartDockerContainerCommand.cs
#	XenAdmin/Commands/ResumeDockerContainerCommand.cs
#	XenAdmin/Commands/StartDockerContainerCommand.cs
#	XenAdmin/Commands/StopDockerContainerCommand.cs
#	XenAdmin/Controls/DeprecationBanner.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/Utils/Helpers.cs
2021-09-23 10:44:43 +01:00
Konstantina Chremmou
d740e83620 CP-38018: Report mismatch between pool and host certificate verification in an undismissable way
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-09-23 10:44:30 +01:00
Danilo Del Busso
a61f61d66f
CP-36392: Remove duplicate field in MultipleDvdIsoList.cs
Also remove `VM` from designer

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-09-20 09:35:19 +01:00
Konstantina Chremmou
5ee8230834 Merge remote-tracking branch 'upstream/master' into feature/REQ-403
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/CertificateAlert.cs
#	XenAdmin/Commands/DisconnectWlbServerCommand.cs
#	XenAdmin/Commands/ViewWorkloadReportsCommand.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenModel/PoolJoinRules.cs
2021-09-01 14:43:23 +01:00
Danilo Del Busso
4b0b83245f
CP-34231: Remove language with negative connotations (#2860)
* CA-34231: Replace negative language with `block list` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `stop` in code and references

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `freezing` in code

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run/ran` in code comments

Some paramater mentions have been renamed, as they will be renamed in future commits.
Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs

* CA-34231: Replace negative language with `run` in Command.cs Run method

Used Resharper renaming utility
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/TabPages/GeneralTabPage.cs

* CA-34231: Replace negative language with `run` in Command.cs CanRun method

Used Resharper rename utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs CanRunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DRConfigureCommand.cs
#	XenAdmin/Commands/DRDryrunCommand.cs
#	XenAdmin/Commands/DRFailbackCommand.cs
#	XenAdmin/Commands/DRFailoverCommand.cs
#	XenAdmin/Commands/DisasterRecoveryCommand.cs
#	XenAdmin/Commands/VMGroupCommand.cs

* CA-34231: Replace negative language with `run` in Command.cs RunCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method

Used ReSharper rename utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Command.cs

Also applied to related symbols. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods named CanRun

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/CrossPoolMigrateCommand.cs

* CA-34231: Replace negative language with `run` in remaining Run methods

Also updated negative language in `DeleteVMCommand`
Also updated in comment in `CrossPoolMigrateCommand`
Also renamed missed instances of `CanRun`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in Commands folder

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder

Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs
#	XenAdmin/Dialogs/Wlb/WorkloadReports.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs

* CA-34231: Replace all remaining negative language with `run` in code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/Controls/WlbRecommendations.cs
#	XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs
#	XenModel/WLB/WlbScheduledTask.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in code strings

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in Messages string

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative language with `supporter` in .resx files

Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in CFUValidator code

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	CFUValidator/CFUValidator.cs

* CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method

Used ReSharper renaming utility.
also renamed similarly named method in `ObjectChange.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs
#	XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resources

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/EvacuateHostDialog.resx

* CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx`

Used ReSharper renaming utility. Excluded jp and zh resource files.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.resx

* CA-34231: Rename missing language references for change to `coordinator`

Misc files were not saved before last commits.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/HACommand.cs
#	XenAdmin/TabPages/AdPage.cs
#	XenModel/Actions/Network/CreateBondAction.cs
#	XenModel/Actions/Network/NetworkAction.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`

Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs
#	XenAdmin/Commands/HACommand.cs

* CA-34231: Replace negative language with `coordinator` in `Helpers.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Commands/AddHostToPoolCommand.cs

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NewPoolDialog.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/TabPages/GeneralTabPage.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenSearch/Columns.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Actions/Network/CreateBondAction.cs

* CA-34231: Replace remaining negative language with `coordinator` in `XenModel`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative strings with `main` in `Messages.resx`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx

* CA-34231: Replace remaining negative string names with `main` in `Messages.resx`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs
#	XenModel/Messages.resx

* CA-34231: Rename dialogs to replace negative connotations with `main`

Used ReSharper renaming utility

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs`

Also updated its resx file. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs

* CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Update class names in HelpManager.resx

Following renaming of main password dialog. Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace negative language with `main` in `Metadata.cs`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx`

Used ReSharper renaming

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx`

Used ReSharper

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-34231: Replace remaining negative language in solution

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove commented out code in VNCGraphicsClient.cs

Code has only been improved partially as it's not strictly relevant to the PR

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend negative word replacement in XSVNCScreen.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Simplify debug call formatting in NewPoolDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Add code mistakenly removed in MainWindow.cs

Removed as part of `f155f9c8`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Revert renaming of constant related to Windows' API

Considered external to CH Center

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog`

Previous ALT+<key> hotkey was conflicting with CreatePool

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs

Not relevant to the PR, but the change is small enought to no need extra testing

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend typo in PoolJoinRules.cs

supporer -> supporter

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs`

Variables and methods XenAPI-Extensions were mistakenly skipped

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member`

Used ReSharper renaming utility.

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs`

This is only used to format the string

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs`

Done in order to fix merge conflict into master

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-34231: Amend misc negative language renaming typos

`XenServerHealthCheckBugTool` and `XenServerHealthCheckService`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-31 11:31:16 +01:00
Danilo Del Busso
c5bb3dc49d
CA-279581: Prevent panel headers from overlapping scrollbar (#2844)
* CA-279581: Prevent panel headers from overlapping scrollbar
* CA-279581: Include sections' parent height in scrollbar check
* CA-279581: Move null check to parent property when refreshing GeneralTabPage scrollbar

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-08-10 14:13:11 +01:00
Konstantina Chremmou
d3e8bc0d7a Order the host certificates by type and the trusted CA certificates by name.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
3ff714da65 CP-35467: Implemented ability to reset the host certificate.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
b896da04d7 Simplified the signature of the methods adding entries to the GeneralTabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
7018c866c5 CP-36125: Extended interface for inspection of certificates.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
f4e17109c8 CP-36124: Check and enable TLS verification on first connection. Also, PascalCased some methods.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-23 15:29:53 +01:00
Konstantina Chremmou
1df1083a2d Use more generic names for client version updates, checks, alerts etc.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-06-09 15:52:10 +01:00
Konstantina Chremmou
67d1ddd1d1 Merge remote-tracking branch 'upstream/master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/Branding.resx
#	Jenkinsfile
#	XenAdmin/Alerts/Types/GuiOldAlert.cs
#	XenAdmin/Alerts/Types/LicenseAlert.cs
#	XenAdmin/Commands/RestartToolstackCommand.cs
#	XenAdmin/Diagnostics/Problems/HostProblem/HostNotSafeToUpgradeWarning.cs
#	XenAdmin/Dialogs/AllowUpdatesDialog.cs
#	XenAdmin/Dialogs/OptionsPages/ConfirmationOptionsPage.cs
#	XenAdmin/Dialogs/RepairSRDialog.cs
#	XenAdmin/Dialogs/UpsellDialog.cs
#	XenAdmin/Plugins/UI/TabPageCredentialsDialog.cs
#	XenAdmin/Program.cs
#	XenAdmin/Wizards/ConversionWizard/ConversionNetworkPage.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateDestinationPage.cs
#	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
#	XenAdmin/Wizards/PatchingWizard/PatchingWizard_FirstPage.cs
#	XenCenterLib/XSVersionAttribute.cs
#	XenModel/BrandManager.cs
#	XenModel/Messages.Designer.cs
#	XenModel/Messages.resx
2021-05-25 15:51:42 +01:00
Joey
a56a383ec0
CP-35687: Detach update mechanism from update wizard (#2812)
* CP-35687: Detach update mechanism from update wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-35687 part 2: Removed updates mechanism.
* Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-21 15:13:45 +01:00
Konstantina Chremmou
88c923b11c Removed colour settings for unsupported windows versions.
Note that OS.Version.Major=6 covers up to and including the supported Win8.1 and
WS2012, but there is not point in using earlier windows colour schemes for them.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-05-18 11:12:11 +01:00
Konstantina Chremmou
735896fdca CA-340976: Corrected disabled reason for IP address configuration button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-27 00:18:47 +01:00
Konstantina Chremmou
abf4ae3f35 CP-36392 pt.1: Removed unused using directives.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-04-07 10:04:47 +01:00
Konstantina Chremmou
a0e2967792 CP-31105: Replaced the hardcoded name patterns in the resource files with format placeholders.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-31 11:50:32 +01:00
Ji Jiang
73396d1759 CP-35345: Adjust DeprecationBanner width
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2021-03-17 10:32:17 +00:00
Ji Jiang
96c3d5e1c0 CP-35345: Add pre-cloud connection warning
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2021-03-17 10:32:17 +00:00
Konstantina Chremmou
0c572a1d6d Normalised usage of the UpsellDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-03-03 13:50:29 +00:00
Konstantina Chremmou
11ce488062 Merge branch 'master' into feature/hyperman
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Jenkinsfile
#	scripts/xenadmin-build.sh
2021-02-17 14:51:13 +00:00
Konstantina Chremmou
307b97e1d6 Refactored the Command Enabled|Disabled Tooltip to avoid multiple calculation of whether the command can be executed.
Also, use CommandButtons instead of normal buttons on the SrStorage TabPage.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2021-02-10 23:44:21 +00:00
Konstantina Chremmou
e7e6fb3234 CP-35350 preliminary work: Removed images that are not displayed anywhere on the UI.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-12-02 12:34:09 +00:00
Konstantina Chremmou
61d77cada4 CA-343956: Corrected action performed by the Attach Disk context menu item. Show grip on the Attach Disk dialog.
The dialog is launched non-modally, hence showing the grip automatically has no effect.
Also, made the dialog slightly bigger.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-11-03 11:33:16 +00:00
Darren Matthews
a9016bc14e L10N : Translation Update and RESX resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-10-13 13:56:55 +01:00
Konstantina Chremmou
f3da384a6a Configuring HA on the TabPage should offer the same UX as when using the Menu Items.
- Use CommandButtons on the HA TabPage for configuring/disabling HA.
- Added menu item to disable HA.
- There is no point in hiding the buttons on the HA TabPage when the corresponding
  menu items are available. They should rather offer the same user experience.
- Added RBAC page to the HaWizard to avoid unnecessary SR scanning only to be told
  that one cannot proceed.
- Show RBAC error dialog if the user does not have permission to launch the
  EditVmPriorities dialog.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-06 11:27:32 +01:00
Konstantina Chremmou
aec6b395ff CA-343956: Fixed issues on the VM storage TabPage:
- Disabled button tooltips did not disappear when the DataGridView selection was cleared.
- The disabled Activate/Deactivate button had no tooltip for template disks.
- Minor improvement to the tooltip of the Delete button.
- The Add button was using the enablement logic of the AttachVirtualDiskCommand.
- Use CommandButtons to avoid logic duplication.
- Hide the CommandButton.Command from the designer as it's mostly assigned programmatically.
- Increased the minimum width of the non-autosizable columns so they remain visible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-02 11:59:55 +01:00
Konstantina Chremmou
a01824b836 Fixed alignment of icons on the View dropdown on the Snapshots TabPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-10-02 11:59:55 +01:00
Konstantina Chremmou
2bb1cd5c5c CA-343781: Fixed error visibility when the check for updates fails. Corrected error image size.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2020-09-08 10:34:08 +01:00
Darren Matthews
c75ab40ef8 L10N : Translation Updates and Resx Resync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2020-09-01 14:26:40 +01:00