Commit Graph

1462 Commits

Author SHA1 Message Date
Konstantina Chremmou
eedcfbe59d CP-40350: Hide vtpm capability if the feature flag is off.
Also, some refactoring and addition of null checks.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
fc5ccf77be Warn the user when exporting VMs with vTPMs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
bbc4ccdd52 Allow vTPM assignment when creating a VM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
f7d96e21fd UEFI and UEFI secure boot modes are now fully supported, hence remove experimental warning.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
d94c55533c Renamed VM method is_a_real_vm to IsRealVm.
The new name complies with C# conventions and allows distinguishing it from xapi field names.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-09-09 11:58:15 +01:00
Konstantina Chremmou
476648636b CP-40642: Hide templates with platform["vtpm"]=true
Also, some corrections to the template comparer on the NewVM wizard's Template page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-08-19 17:11:50 +01:00
kishore Mengani
1f0452bf8f L10n: Translations updated & Resx sync
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-08-12 10:31:53 +01:00
Konstantina Chremmou
d6f83bac9c Increased width of memory NumericalUpDown because at the maximum value the text was truncated.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-19 12:26:10 +01:00
Danilo Del Busso
c2604a69bd CA-368811: Fix memory values showing in bytes in Import Wizard
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-07-19 12:10:15 +01:00
Konstantina Chremmou
030e07390c CA-368812: The SR selection page was not refreshed if the user selected a different target host in the same pool.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 22:23:52 +01:00
Konstantina Chremmou
c1e5825e24 CA-368811: FIxed issue whereby a minimum memory of 512MB was enforced silently on disk image imports.
Also, increased the maximum allowed memory for imported disk images.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-14 16:00:58 +01:00
Konstantina Chremmou
7c87333439 CA-368577: Prevent crashing when the OVF envelope has been created for a disk image import. Some code tidy.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-07-11 14:58:09 +01:00
Konstantina Chremmou
15b05ae572 Fixed issue on the Import XVA wizard where the SR selection was not taking account of...
all scenarios of changed affinity if the user moved from the SR selection
page back to the server selection page and forwards again.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-06-21 10:49:06 +01:00
Konstantina Chremmou
df35684586 Moved version checking methods to a separate file. Use C# naming conventions.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenAdmin/Commands/DragDropCrossPoolMoveHaltedVMCommand.cs
#	XenAdmin/Commands/DragDropMigrateVMCommand.cs
#	XenAdmin/Wizards/CrossPoolMigrateWizard/Filters/CrossPoolMigrateCanMigrateFilter.cs
2022-05-25 11:35:47 +01:00
Konstantina Chremmou
76738ad91f
Merge pull request #3003 from kc284/drag-drop-3
CA-294370: Rewrote logic calculating if migration is allowed + some other fixes.
2022-05-25 11:04:26 +01:00
Konstantina Chremmou
755cec2bc1
Merge pull request #2998 from danilo-delbusso/bug/scrollbar_CA-293683
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
2022-05-25 11:04:03 +01:00
Konstantina Chremmou
4f7ad4f0f0 Fixed broken build and made some additional L10n corrections to the layout.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-19 11:09:39 +01:00
Konstantina Chremmou
0cfe9c0a07 Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-18 10:54:44 +01:00
kishore Mengani
6b69496a39 L10n: Resx resync and trnslations updates
Signed-off-by: kishore Mengani <kishore.mengani@citrix.com>
2022-05-17 10:51:10 +01:00
Danilo Del Busso
4f09efe475
CA-293683: Prevent automatic scrolling when setting text in SmartScrollTextBox
Also fix issue whereby `IsVerticalScrollBarAtBottom` would also return `True`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-16 15:33:52 +01:00
Danilo Del Busso
6b200bef8b
Reorder fields in AutomatedUpdatesBasePage.cs
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:36:13 +01:00
Danilo Del Busso
f2a67243a7
Apply code cleanup to AutomatedUpdatesBasePage.cs
Use `var` where possible
Rename fields and methods following conventions
Use pattern matching when casting
Rename variables using more meaningful names

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:34:58 +01:00
Danilo Del Busso
27382f308b
CA-293683: Prevent automatic scrolling in RPU wizard if user has scrolled manually
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-05-12 13:06:04 +01:00
Konstantina Chremmou
eca6f1d2a4 CA-294370: Rewrote logic calculating if migration is allowed:
Objective was to increase efficiency and better report the reason why migration
is not allowed. For this, WlbEnabledFilter and ResidentHostIsSameAsSelection
filters were merged into the CrossPoolMigrateFilter, and properties
FailureFound and Reason of the ReasoningFilter class were merged into method
FailureFound(out failureReason).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:37 +01:00
Konstantina Chremmou
b7ce6e7fb2 Removed unused code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:36 +01:00
Konstantina Chremmou
a8bb8a7baa The Reasoning filters should look for failures on the item passed in their constructor:
This is ensured when abstract class FailureFoundFor(IXenObject) is protected.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 15:21:36 +01:00
Konstantina Chremmou
404ee1680a Tidy up.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:37:54 +01:00
Konstantina Chremmou
ae7df535c2 Some layout and logic changes so the page looks and behaves more like the other wizard pages with progress bars.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-05-09 13:37:54 +01:00
Konstantina Chremmou
1928cf3db7 CA-366139: Specify which VM lacking the feature could not be migrated during RPU.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-25 17:06:01 +01:00
Konstantina Chremmou
59486541a5
Merge pull request #2985 from kc284/sonarqube
CP-36392: Improvement of sonarqube score
2022-04-20 10:25:23 +01:00
Danilo Del Busso
d90abfd1b6
[CHC] CA-366069 & XSI-1222: Fix incorrect capitalisation of value in Japanese version + add some case insensitive checks (#2986)
* CA-366069: Fix incorrect capitalization of value in Japanese invisible messages `resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add case insensitive checks on code around usage of `ISO_UPDATE`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove changes in string capitalisation

Move capitalisation invariance to checks only

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Remove `ISO_UPDATE` from `InvisibleMessages.resx`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CA-366069: Add remaining `ToLowerInvariant()` calls

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-04-14 11:36:55 +01:00
Konstantina Chremmou
038de3ca62 Use consistent variable names.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-11 19:43:09 +01:00
Konstantina Chremmou
dce02a2562 Renamed AsyncAction.RunExternal to AsyncAction.RunSync so it is more descriptive.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:34 +01:00
Konstantina Chremmou
ec33caf4b5 CP-36392: Refactored so that GetHashCode() does not call the homonymous base class method.
This required refactoring the OVF.AddVirtualSystem() method to accept the
system ID as a parameter. Also, removed some unused methods that were
calling OVF.AddVirtualSystem().

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
177c47f79f CP-36392: Refactored so that GetHashCode() does not reference mutable fields.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-06 13:11:33 +01:00
Konstantina Chremmou
aaee939453 Some corrections on the DRWizard prechecks page:
- Re-arranged and re-worded controls so that this page looks more like
  the precheck page of the patching and RPU wizards.
- Do not show the failure message unless issues are found.
- Do no enable the Resolve All button unless all issues are fixable.
- Fixed crash when the required SR is present in the pool but detached.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-04-01 16:07:43 +01:00
Konstantina Chremmou
a91dd6398d Compacted ParallelAction and MultipleAction constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:50:27 +00:00
Konstantina Chremmou
f5672a8645 CP-39323: Check for DMC in use prior to cross-pool migration to pools where DMC is unavailable.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
dd978914cf CA-365297: Fixed error shown when attempting live migration of DMC VM to non-DMC host.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:51 +00:00
Konstantina Chremmou
220ab25302 CA-365317: Updated warnings after disallowing connection to pre-yangtze servers.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-21 13:10:25 +00:00
Konstantina Chremmou
00c5285411 CP-39142: Add RPU pre-check in CHCenter to warn of DMC removal.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Konstantina Chremmou
dec2eead15 Renamed methods so they describe better what they do.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-03-03 14:36:06 +00:00
Darren Matthews
151841ce5e L10N : Translation Updates & Resx sync
Signed-off-by: Darren Matthews <darren.matthews@citrix.com>
2022-03-03 14:35:30 +00:00
Danilo Del Busso
101d6f0a00 CP-36392: Use value in empty setters
Mostly to remove warning from SonarQube, so exception is only thrown in DEBUG mode

Address code surrounding previously emptied setters
Avoids throwing exceptions when not needed
Move default `VerticalTabs` fields outside of constructor

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Danilo Del Busso
a310fa60cf CP-36392: Remove all unnecessary using s
Ignores XenAPI

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-02-24 11:53:44 +00:00
Konstantina Chremmou
d0944cf19c A new row should be added only when it is not found.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-23 12:38:02 +00:00
Konstantina Chremmou
ca37331c8d CA-362709, CA-362711: Reworked the logic for allowing full disk copy when creating a VM from a snapshot or custom template.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-14 14:35:51 +00:00
Konstantina Chremmou
321389455e Refactoring: compacted Role.ValidRoleList() and Role.CanPerform() overloads.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-02-03 11:59:17 +00:00
Konstantina Chremmou
d6f91526d2 Restored friendly name and description for CVSM.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-01-31 14:56:12 +00:00
Danilo Del Busso
f07b3d4e05 CP-37850: Update RPU005 to version 4.0
Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2022-01-24 15:22:07 +00:00