Commit Graph

3056 Commits

Author SHA1 Message Date
vetrivelc
795612720e L10N: CA-259356 Fixed button truncation in JA 2017-10-09 12:53:23 +05:30
Callum McIntyre
e77b8f9445 [CP-24974] Avoid calculatingVM agility/failure tolerance twice
This is caused by the `waitingNtolUpdate.waitOne()` call being at the end of the loop, not the beginning. The reason is that the `waitingNtolUpdate` is set during the first iteration (before the thread even gets loaded) - because the setter for Settings in this file sets it (and that's set by the setter for AssignPriorites.Connection, which is set in the HAWizard constructor). So when the thread first spawns we do the calculations, then get to the `waitOne` lock, which is set so we go back around the loop and calculate everything again before returning to the lock and waiting to be triggered. The correct behaviour is to trigger only once on the page load, and then only when re-triggered. To achieve that I've moved the `waitOne` call to the beginning of the loop, so that (assuming the `waitingNtolUpdate` lock is set before the thread is first started) we immediately run the calculations and then stop at the beginning of the loop waiting to be triggered again. This means that on page load (and after each re-trigger) we only calculate once.

The assumption that the lock is set before the thread is triggered is currently valid, because as mentioned above it's currently set by the setter for Settings which is indirectly called by the wizard constructor. I don't want to rely on that behaviour though because it's very indirect, so just to be safe I've added an explicit set just before the thread is triggered so that it's guaranteed to run the calculations the first time. This isn't strictly necessary but seems better than relying on the existing implicit setting. Since we use the same mechanism just in a different place, all the existing code that sets `waitingNtolUpdate` continues to trigger this thread as expected.
2017-10-06 14:07:31 +01:00
Ji Jiang
89bc74583f CP-266755 & CA-266843: Fix XC brand string
Following pattern would be caught when using "XenCenter" "XenServer" and
"Citrix":
1) not "[" or "/" or """ on left of the brand string
2) brand string followed by space followed by not "p", and optional letter
3) optional letter followed by space followed by the brand string
4) brand string followed by "," and optional letter
5) begin with the brand string
6) end with the brand string

tested with all .resx files

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-06 13:30:31 +01:00
Mihaela Stoica
b79d7923cc CA-268105: fix the bug where the pool item is disabled when an update is already installed on one host in the pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-04 16:48:58 +01:00
Mihaela Stoica
20d79ad6f4 Merge remote-tracking branch 'upstream/REQ-67'
Conflicts:
	XenModel/Messages.Designer.cs
2017-10-04 14:40:01 +01:00
Ji Jiang
2f41bbfde1 CA-267553: Fix offline XC showing up to date bug
Refactor the code.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 18:00:48 +01:00
Mihaela Stoica
a62c04a3a9 Merge pull request #1798 from GaborApatiNagy/master_CA-266911
CA-266911: Exported data from Notification->updates page having incorrect values for "Web page"column
2017-10-03 17:57:26 +01:00
Mihaela Stoica
e6a6a9cc83 Merge pull request #1790 from jijiang/master
CA-267553: Fix offline XC showing up to date bug
2017-10-03 17:52:35 +01:00
Gabor Apati-Nagy
b49c14fd92 CA-266911: Exported data from Notification->updates page having incorrect values for "Web page"column
Displaying the full "Go to web page" URLs in the exported csv file

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-03 16:42:48 +01:00
Ji Jiang
7fa784ba96 CA-267553: Fix offline XC showing up to date bug
Fix comments about considering whether XS version is found in updates XML file.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-03 15:32:57 +01:00
Gabor Apati-Nagy
c00439bef4 CP-24818: [Update Wizard Improvements] Show the progress of the download in Automated mode
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-02 16:35:10 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Gabor Apati-Nagy
0cc907bb14 CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement (#1791)
* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24709: Add a warning in the New VM wizard and Import wizard if the pool is licensed using XD/XA entitlement

Fixed unintended designer code additions/changes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-29 11:05:57 +01:00
Ji Jiang
a70307a3a6 CA-267553: Fix offline XC showing up to date bug
The bug is that when XC does not connect to Internet, By Server Update
page shows all the hosts up to date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-29 10:44:50 +01:00
Gabor Apati-Nagy
39026f300e CP-24707: Add license status information to the title bar for pool and hosts (#1783)
* CP-24707: Add license status information to the title bar for pool and hosts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Show expired licenses as Unlicensed in the Header

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

Improvements, fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CP-24707: Add license status information to the title bar for pool and hosts

More code to make it even more nicer

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-09-28 16:10:41 +01:00
Ji Jiang
268b19421f REQ-534: Fix some UI text display
Based on comments from doc team:
1) Column title "Patching Status" should be replaced by "Status" in csv file
2) In View dropdown, "By Host" should be replaced by "By Server"

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-27 15:14:15 +01:00
kunm
912475a4eb CP-24331 & CP-24135: Add UI support for usb-passthrough on both Host & VM (#1766)
* CP-24331: Add UI for UsbTab and VM Usb Property

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Update XenAPI reference

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Add AttachUsbDialog

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI changes

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Discard UsbList and little refining to code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-09-27 13:37:17 +01:00
Ji Jiang
d0687e5ae3 CP-24708: Show different unlicensed pool/host icon
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-27 11:30:12 +01:00
Ji Jiang
37499d81b6 CP-24477: Add licence check for CBT feature
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 18:19:15 +01:00
Ji Jiang
cb97e3788e CP-24405: Add message alert for CBT error msg
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 15:14:53 +01:00
Ji Jiang
a63ca0a030 CP-24344: Add HelpID and warning when disable CBT
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-25 15:14:09 +01:00
Mihaela Stoica
0e5f1335d4 CP-24498: RPU wizard to block the selection of unlicensed hosts
Also includes some improvements to the Select Pools page of the RPU wizard
- do not show the checkbox if the item is disabled
- show the icon for the pool items, not only for hosts (making this consistent with the similar page in the Update Wizard)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-25 13:27:06 +01:00
Gabor Apati-Nagy
9fec33d892 Merge pull request #1777 from MihaelaStoica/master
CP-24806: Update the RPU hotfix to version 4
2017-09-22 13:58:34 +01:00
Mihaela Stoica
50623be97c CP-24806: Update the RPU hotfix to version 4
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-22 13:55:28 +01:00
Ji Jiang
152c25d2f2 Fix compilation error after merging
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-22 11:07:56 +01:00
Ji Jiang
fce3a725cd Merge 'upstream/master' into REQ-67-us
Conflicts:
	XenAdmin/Commands/MigrateVirtualDiskCommand.cs
	XenAdmin/Commands/MoveVirtualDiskCommand.cs
	XenAdmin/TabPages/SrStoragePage.cs
	XenModel/Messages.resx

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-22 11:02:51 +01:00
Ji Jiang
8f03795797 Fix compilation error after rebase REQ-534 on master
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 17:11:43 +01:00
Ji Jiang
f6f17746db CA-265684: Fix bug of disabled "Export All" button
The bug is that "Export All" button is disabled when all hosts are up to
date.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:49 +01:00
Ji Jiang
026c2b8d47 CA-265410: Fix missing required updates
The bug is that required updates for slaves of pre-dundee pool don't show.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
7fd18e99cf CP-24032: Updates page collapsing enhancement
Store the pool collapsing state and rebuild it after refresh.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
41cec6e42b CP-23967: change two superclass to abstract class
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
30400790c1 CP-24032: Updates page: collapsing funtionality
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
17f76870b3 CP-23967: Fix and unify sorting in different views
The commit fixes bug and unify sorting rules in ManageUpdatesPage,
PatchingWizard_SelectServers and RollingUpgradeWizardSelectPool data
grid views.

The rules are:
1) Name column sorted purely by name.
2) Other columns sorted by string value, if the same, sorted by default,
which is still in order even in reverse direction.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
880bde38f6 CP-23455: Add Update btn in Updates page "By Host"
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
d8ca87cd15 CP-24210: fix the patch sorting in newer version
Keep order consistency with general tab for newer version servers.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
1e335de316 CP-24210: Populate "By Host" view correctly
1) Show required updates in case of versions without minimal patches
2) Hide version text in installed updates when version is Ely or above

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
0a33bf1448 Fix PatchingWizard_SelectServers version sorting
The problem is that pool and host rows are mixed when sorting by
version.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
dfe7a2ea70 Refactoring RollingUpgradeWizardSelectPool sorting
Combine sorting by Description and by Version to a single class

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
af9143d199 CP-23967: sort "By Host" view rows in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
b5a8282089 CP-23454: Export function in "By Host" view
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Ji Jiang
66b1b52ad1 CP-23450: Add "View" btn in Updates page toolbar
1) View button has "By Update" and "By Host" options.
2) "By Host" view hides "Filter by Date", "Dismiss All" and "Restore
Dismissed Updates" buttons.
3) "By Host" view turns date filter OFF.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 14:58:04 +01:00
Mihaela Stoica
d4c980dbfd Merge branch 'master' into REQ-230 2017-09-18 13:12:06 +01:00
Hui Zhang
7298b085be CP-23604: Fix the comments to merge to XenAdmin master.
Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2017-09-18 11:42:13 +01:00
Konstantina Chremmou
673846924b Do not set API object properties that have a default value of "OpaqueRef:NULL" to null.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 12:48:05 +01:00
Konstantina Chremmou
915059d099 The Proxy_xxx classes should not be used outside the API bindings (in reality
these classes should have been internal).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-14 11:52:15 +01:00
Ji Jiang
23c903af09 CA-265029: Disable "Move VM" on CBT enabled VM
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-13 14:32:16 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Ji Jiang
48afa741b1 CP-24344: Fix and refactor CBT implementation
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-11 14:41:36 +01:00
Konstantina Chremmou
37e3810d73 Removed the background worker and added an async action to retrieve the local
server time (previously on the UI  thread) and also update the message list
for each snapshot schedule. Preserve column sorting and multiple selection
when the list is rebuilt. Do not enforce minimum size on the form since it
is not resizable.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-11 13:22:12 +01:00
Gabor Apati-Nagy
e92d3df839 Merge pull request #1752 from kc284/master
CA-265044: Text corrections on the New VMSS Schedule wizard; image co…
2017-09-08 18:00:03 +01:00
Ji Jiang
0286840728 CP-24343: Display CBT status per VDI in SR storage
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-08 16:44:38 +01:00
Ji Jiang
b19b60f442 CP-24344: Add "Disable CBT" menu item under VM
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-08 14:03:54 +01:00
Mihaela Stoica
4274bf28fb CA-265172: Ensure that the "disk space requirement" precheck is performed for a standalone host in automated updates mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-07 14:29:39 +01:00
Konstantina Chremmou
4fba904d06 CA-265044: Moved the chevron button immediately below the info icon, so it
does not jump to the bottom of the page when the run history panel is expanded.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 13:10:37 +01:00
Konstantina Chremmou
dd76b9f0d5 CA-265044: Text corrections on the New VMSS Schedule wizard; image correction
on the VM Snapshots page; update VM's status on the Snapshots page when the
VM's membership in a policy changes.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 12:56:41 +01:00
Konstantina Chremmou
d9aeeb15e5 Rewriting of the Snapshot Schedule dialog for performance optimisation.
Merged the PolicyHistory control into the dialog; removed legacy column from
the policies datagridview; put retrieval of messages on a background thread
to avoid UI freezing if there is a huge number of messages; retrieve messages
only when the VMSS collection changes and not every time the run history grid
is repopulated; sorted out button enabled state.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-07 11:02:07 +01:00
Konstantina Chremmou
1f2b550f4d Renamed controls and moved about methods in view of merging the run history controls into this dialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:22:29 +01:00
Konstantina Chremmou
9ce11ddf55 Renamed controls and placed them on a panel in view of merging them into the ScheduledSnapshotsDialog.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-06 13:15:47 +01:00
Gabor Apati-Nagy
5ef13705a5 CA-263044: [XSO-765] Install Update fails because it tries to install the hotfix to one pool twice
Fixed a bug that caused XenCenter to try to apply an update (that the user manually selected) multiple times and therefore failed. This was only present when the Select All button was used.
2017-09-05 18:38:20 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
71301eb332 Removed the extension Properties from the VMSS class. Removed the GetVMSSAlertsAction;
it's not needed as it does not make server calls. Some more refactoring and corrections
here and there.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-04 23:07:22 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Konstantina Chremmou
da3cd070ee Removed VIF.RateLimited property because usage on the VIFDialog shows it is
occasionally preferable to access the qos_algorithm_type directly.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
4825b60a60 Moved UI logic from the VM extensions to the SnapshotsPage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
85d398d067 Moved the SR.GetIcon() method to XenAdmin where it belongs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Konstantina Chremmou
880d56b30f Renamed method so it's more obvious what it does.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
6a2f77c9f6 CA-264439: Change the XenCenter version check to return just a warning in the RPU wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-31 09:51:20 +01:00
Ji Jiang
d478115ec6 CA-248292: Fix btn truncation in VM storage page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-08-30 13:38:53 +01:00
Mihaela Stoica
69007dbaec CP-24213: Some fixes in the Patching wizard
- Change the "Web page" column alignment to TopLeft, to match the other columns
- When trying to find an alert from a filename, use the patch name instead of the alert name, because now the alert name can also be a version name

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-30 09:31:05 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
c59a3d14c4 CP-24213: Show CUs as updates
CUs are available as both updates and upgrades, but they should be presented as updates where possible.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-25 10:56:04 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Mihaela Stoica
8089617eaf CP-24087: Parse the error parameters of the UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR precheck failure (#1740)
When the update precheck fails with UPDATE_PRECHECK_FAILED_UNKNOWN_ERROR, we try to find the actual error in the failure's parameters (in the form of an xml string containing the error code) and display that error instead of the "unknown error".

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-22 16:09:47 +01:00
Mihaela Stoica
67b18665f5 Merge pull request #1737 from vetrivelc/master
L10N:CA-261954,CA-261973 & CA-261977
2017-08-21 12:16:16 +01:00
Vetrivel Chinnasamy
21eff4d819 L10N:CA-261954,CA-261973 & CA-261977 2017-08-21 16:19:39 +05:30
Gabor Apati-Nagy
8514ddf21e CA-261107: Metadata file osVersion is showing same value for XenCenter on different windows versions
Added app manifest to explicitly target XC to all windows versions from Vista to Windows 10 so that the Environment variables will reflect the correct Windows versions. Note that "Manifesting the .exe for Windows 8.1 or Windows 10 will not have any impact when run on previous operating systems." [1]

[1] https://msdn.microsoft.com/en-gb/library/windows/desktop/dn481241.aspx

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-18 13:40:36 +01:00
Hui Zhang
d8c248fa76 CP-23604: Add IGMP snooping toggle.
Add the toggle to enable/disable IGMP snooping.
Display the property if the pool is licensed
and the network backend is OVS.

Signed-off-by: Hui Zhang <hui.zhang@citrix.com>
2017-08-16 12:32:18 +08:00
Gabor Apati-Nagy
5a7e6651cd CA-260304: WLB Configuration parameters can not be reset in XenCenter 7.2
Fixed the regression

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-08-15 12:20:25 +01:00
Gabor Apati-Nagy
48134dfd14 Merge pull request #1723 from xenserver/REQ-473
Merge from REQ-473
2017-08-09 10:47:01 +01:00
Ji Jiang
6bfbbc7aa8 CA-141166: Fix truncation issue on HA wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-31 09:09:54 +01:00
Mihaela Stoica
5b75b5f25d CA-260365: Hide the build number from the General Tab for Ely and newer hosts (to cover the Honolulu case)
Also restrict the use of build number as an integer to pre-Ely hosts (because a Honolulu host has a non-numeric build number and XenCenter doesn't know the difference between Ely and Honolulu)
And a small update to the pool join rule to match what we have in Honolulu XenCenter (check the database schema regardless of the version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-27 14:47:12 +01:00
Konstantina Chremmou
ad7e2fa6a6 CA-257927: Changed ChangeableList.RemoveAll method to fire the CollectionChangedEvent
once for all the items to be removed, passing in their list as argument. This method,
and the method Clear calling it, are used for alerts, updates, events and connections,
hence changed the handling of the CollectionChanged event in these cases to expect
either a single item or a collection. In the case of alerts, updates and events
this means that we can rebuild the whole list instead of removing single rows which
causes the application to hang for big numbers of items.
2017-07-24 14:48:02 +01:00
Konstantina Chremmou
bfcdfd982f The event registered on the HistoryPage is ConnectionsManager.History.CollectionChanged,
not ConnectionsManager.XenConnections.CollectionChanged.
2017-07-24 14:48:02 +01:00
Letsibogo Ramadi
2fb35c8faa CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is ove… (#1693)
* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- use col widths from resource file instead of hardcoded values

* CA-235459 - G11n:SC: The numeric tag for “Disks” and “Network” is overlap on the search window.

- safer implementation

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 16:15:29 +01:00
Letsibogo Ramadi
c44f89bf05 CA-249823 - Accept zip files in Updates Wizard (#1667)
* CA-249823 - Accept zip files in Updates Wizard
* CA-258326 - Improve implementation of CA-248823(Accept zip files in Updates Wizard)
* Small unrelated bugfix: Stop selectFromDiskRadioButton being checked when
restoring dismissed updates.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-07-21 15:56:27 +01:00
Mihaela Stoica
5e2fe55771 CA-260214: Update the uuid of the RPU hotfix (#1704)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-20 12:32:03 +01:00
vetrivelc
a9e5198c7e L10N : Translation updates and bug fixes 2017-07-19 15:09:10 +05:30
vetrivelc
d829654203 Merge branch 'master' of https://github.com/xenserver/xenadmin 2017-07-19 14:22:53 +05:30
Mihaela Stoica
8bdbb122c8 CA-259276: Error when trying to install an update via JA XenCenter
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-06 14:16:06 +01:00
vetrivelc
5abd456a28 L10N: Translation Product tag Correction Checkins 2017-07-06 11:29:02 +05:30
vetrivelc
78fc06d0af L10N : Issue Fixing 2017-07-05 17:10:43 +05:30
Letsibogo Ramadi
7f9b6e65a3 CP-22472 - Add new XenCenter metadata file to the server status report
Change OSCulture to show language currently installed on UI instead of
default language selected at OS installation stage
2017-07-05 11:19:07 +01:00
Gabor Apati-Nagy
51c08c7433 Merge pull request #1666 from MihaelaStoica/CP-21161
CP-21161: Do not call the disk-space plugin cleanup functions on Ely …
2017-07-04 15:37:34 +01:00
Mihaela Stoica
ad0cd9ef00 CP-22472: Add copyright notice
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-04 13:18:59 +01:00
vetrivelc
d624d93865 L10N:CP-23040,CP-23012 Traanslation Checkin 2017-07-04 10:39:46 +05:30
Ji Jiang
5654b4eb89 CA-258321: Incorrect CFU user agent
Fixed user agent string for CFU.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-07-03 17:54:57 +01:00
Mihaela Stoica
dd92f0e6a6 CP-22472: Add more metadata
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
0fbe225fa4 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Add an empty string (instead of 'null') if the IP address is null
- Only include the XC uptime in the SSR produced in XenCenter
- Also changed the name of the metadata file that is included in the SSR

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
713f84cf54 CP-22472: Add new XenCenter metadata file to the server status report: changes following code review
- Added more items to the metadata; the content is now slightly different between the SSR produced in XenCenter and the one from the HealthCheck;
- Encode the metadata string before sending it to the Health Check;
- Always suppress history for the action that sends the proxy settings;
- Renamed some of the new classes;
- Also refactored the actions that send data to the HealthCheck service.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
54ab9307d2 CP-22472: Add new XenCenter metadata file to the server status report
- XenCenter sends its telemetry info to the HealthCheck service
- The HealthCheck service saves this metadata in its settings file and includes it in the health check upload

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Mihaela Stoica
2c37367155 CP-22472: Add new XenCenter metadata file to the server status report
- this adds the telemetry file to the server status report produced in XenCenter

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-03 17:25:04 +01:00
Letsibogo Ramadi
a5c895da0c Merge pull request #1672 from MihaelaStoica/CA-257760
CA-257760: Strip leading and trailing spaces from the filename in the…
2017-07-03 10:32:24 +01:00
Letsibogo Ramadi
24454ad6a7 Merge pull request #1674 from MihaelaStoica/CA-39992
CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVE…
2017-07-03 10:25:39 +01:00
Mihaela Stoica
743e9938da Merge pull request #1665 from minglumlu/private/mingl/CA-254479
CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are r…
2017-07-03 09:59:18 +01:00
Mihaela Stoica
813228eed6 CA-39992: Add "Repair Storage" action to the PBD_PLUG_FAILED_ON_SERVER_START alert
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-30 16:24:29 +01:00
Mihaela Stoica
bdbe40187a CA-257760: Strip leading and trailing spaces from the filename in the Import wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-29 16:19:39 +01:00
Gabor Apati-Nagy
c0edd4c587 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
33c95f5e6f CA-224724: VBD edit page: show 'position in use' message on the dropdown items
requested changed by code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
Gabor Apati-Nagy
5df4d174c0 CA-224724: VBD edit page: show 'position in use' message on the dropdown items
This commit changes the dropdown control to not only show the available
positions, but also mark the ones that are already being used.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-29 12:04:16 +01:00
minglumlu
3a7d1c1cd9 CA-254479,CA-223802,XSO-672: distinct the VM IP addresses which are retrieved from XAPI. 2017-06-28 10:08:16 +08:00
Mihaela Stoica
c061b0f57d CA-257574: Manage vApps dialog is unusable with a vApp containing a l… (#1664)
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs

- In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows.
- Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed.
- Also improve the way we update the VM startup options and HA restart priorities on a set of VMs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review

- reverted the changes to the AssignVMsToGroup actions that added the additional constructor
- changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently
- added code to deregister PropertyChanged events on VM_appliances
- removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 17:32:46 +01:00
Mihaela Stoica
537e569a62 CP-21161: Do not call the disk-space plugin cleanup functions on Ely and above hosts
- Ensure that the disk-space plugin functions are not called on Ely or greater hosts, except for the 'get_avail_host_disk_space' function, which is still needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-27 13:48:54 +01:00
Gabor Apati-Nagy
10e2aff2e4 CA-257553: Unexpected error on the Memory tab while running an "Instant VM create" action
Calling Rebuild() from the event thread now

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-22 15:49:15 +01:00
Vetrivel Chinnasamy
1fce4298e5 L10N: Fix CA-255548 & translation updates (#1660) 2017-06-22 09:19:58 +01:00
Mihaela Stoica
15d748925a Merge pull request #1641 from letsboogey/CA-220169
CA-220169 - Network heartbeat status initially shows 'Error' after en…
2017-06-21 17:02:36 +01:00
Mihaela Stoica
bfab94f923 Merge pull request #1653 from letsboogey/CA-177402
CA-177402 - XenCenter doesnt show migrate option on selecting multipl…
2017-06-21 10:11:45 +01:00
Letsibogo Ramadi
a579ac9196 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Enable CrossPoolMove for a single VM too

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 15:00:49 +01:00
Letsibogo Ramadi
c1635fba58 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Renaming and minor refactoring

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 14:56:26 +01:00
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Gabor Apati-Nagy
46edc78e50 Merge pull request #1654 from MihaelaStoica/CA-241298
CA-241298: Do not offer to install tools if the VM runs on a slave in…
2017-06-20 13:27:04 +01:00
Konstantina Chremmou
d88fc10e3f Merge pull request #1649 from letsboogey/CA-247333
CA-247333 - Remove rdpclient6 code after April 2017
2017-06-20 13:19:52 +01:00
Letsibogo Ramadi
a17063ec7d CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 12:29:03 +01:00
Gabor Apati-Nagy
ee2f1ef920 Merge branch 'master' of https://github.com/xenserver/xenadmin into CA-243675
Conflicts:
	XenModel/Messages.resx
2017-06-20 11:40:03 +01:00
Letsibogo Ramadi
cca0ab5d89 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant
-Removed rdpControl because it is always identical to rdpClient9
-Renamed rdpClient9 to just rdpClient because we use only one
client so there is no need to distinguish, and it can easily be updated
to future versions.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-20 11:33:52 +01:00
Mihaela Stoica
410e77d94e CA-241298: Do not offer to install tools if the VM runs on a slave in a partial upgraded pool
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-16 16:49:06 +01:00
Letsibogo Ramadi
ddd481fff0 CA-177402 - XenCenter doesnt show migrate option on selecting multiple Suspended VMs
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-06-16 14:38:22 +01:00
Gabor Apati-Nagy
71ed9d8955 Merge pull request #1651 from kc284/master
CA-257209: The VNCControl has been deprecated.
2017-06-16 14:12:41 +01:00
Mihaela Stoica
7cd7be6d03 Merge pull request #1648 from GaborApatiNagy/master_fixbuild
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-16 09:43:53 +01:00
Konstantina Chremmou
39f3e9ea1e CA-257209: The VNCControl has been deprecated. 2017-06-16 08:55:38 +01:00
Gabor Apati-Nagy
9806491863 CA-243675: No Clear error message when proxy server which is configured is not running
Mention proxy in the suggestion that is shown when a connection fails

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 17:54:27 +01:00
Gabor Apati-Nagy
c19ee0bf13 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Fixed build by removing unused fields that caused the Release build to fail. Removed more dead code.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:11:05 +01:00
Gabor Apati-Nagy
9b336ec3c6 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Put back code that shouldn't have been removed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-15 16:09:32 +01:00
Mihaela Stoica
cd71c4fe1c CA-249858: Fix build warning as error
(The member 'CanExecute()' does not hide an inherited member. The new keyword is not required)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-15 08:31:47 +01:00
Konstantina Chremmou
062938878d Merge pull request #1602 from GaborApatiNagy/master_CA-220047
CA-220047: Show proper precheck error when a VM cannot be migrated
2017-06-15 08:24:06 +01:00
Letsibogo Ramadi
5e458ac234 CA-247333 - Remove rdpclient6 code after April 2017 when it will become redundant 2017-06-14 17:22:42 +01:00
Letsibogo Ramadi
be6b2ebcb3 Merge pull request #1630 from kc284/master
One more take to CA-231518
2017-06-14 13:37:13 +01:00
Gabor Apati-Nagy
5fe4b8ba09 Merge pull request #1639 from GaborApatiNagy/CA-255547
CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
2017-06-14 10:02:36 +01:00
Gabor Apati-Nagy
4e8541fb91 Merge pull request #1642 from MihaelaStoica/CA-249858
CA-249858: XenCenter gives different messages for migrate VM at diffe…
2017-06-13 16:53:19 +01:00
Mihaela Stoica
a79e156cf5 CA-249858: Moved the Trim call
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 16:47:43 +01:00
Mihaela Stoica
77b73c8d16 CP-22471: Add information on XenCenter help usage to the user settings
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:42:26 +01:00
Mihaela Stoica
8f6c345c66 CA-249858: XenCenter gives different messages for migrate VM at different screens when pool connected with vm-operator user
Expose the reasons why a cross pool migration command cannot execute.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-13 13:12:01 +01:00
Letsibogo Ramadi
f1d2dc2cf8 CA-220169 - Network heartbeat status initially shows 'Error' after enabling HA
Network HB initially shown as error because it takes time for the status to be
read from xha by xapi. This adds a delay to allow the status to be updated
before XC displays it.
2017-06-13 11:17:49 +01:00
Mihaela Stoica
ffe7ff9520 Merge pull request #1632 from xenserver/REQ-378
Feature "REQ-378: Support Chinese Language E-mail Performance Alerts"
2017-06-13 10:51:42 +01:00
Gabor Apati-Nagy
597762b884 CA-255547: WLB code in XenCenter: Remove all code targetting <= 6.1 XenServers
Removed code that is no longer needed. Also removed an obsolete unit test.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-12 16:49:37 +01:00
Konstantina Chremmou
2504779480 CA-23158: Some layout improvements and logic changes.
- Moved the top warning out of the filter toolstrip and into the same tableLayoutPanel
as the dataGridVew to avoid hardcoding the dataGridview location in the code.
- Corrected linkLabel colour for compliance. Changed icon to match the icon
of the bottom information label.
- When checking for updates disable the linklabel instead of hiding the whole
warning to avoid empty space or the dataGridView jumping up and down.
- The check button in the middle should be available when the check link is
available.
- Avoid toggling explicitly the enabled state of controls; it can be taken
care of within the check for updates event handlers.
- Other minor layout improvements (control positioning).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:32 +01:00
Konstantina Chremmou
31b98c51e5 Refactored duplicate method.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Konstantina Chremmou
9776c1e2c2 CA-23158: On alert dismissal remove single rows instead of rebuilding the datagridview,
thus solving the resizing issue of the Actions column. Also, register an action
before starting running it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-06-11 11:11:31 +01:00
Gabor Apati-Nagy
6185b24b37 CA-147943: Scrollbar for list of hotfixes installed in a pool doesn't have scrollbar the first time it is expanded
General tab (Pool): In the list of updates, added a space after each comma
to let the control wrap the text into multiple lines. This way the text is
no longer cut, therefore no additional scrollbar is needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-08 17:32:34 +01:00
Gabor Apati-Nagy
5f8db75e7c CA-220047: Show proper precheck error when a VM cannot be migrated
Changed the pre-check error message to refer to the absence of the Tools
when that is suspected to be the case.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-08 16:12:26 +01:00
Gabor Apati-Nagy
bb5235ca40 Merge pull request #1633 from MihaelaStoica/CP-21130
CP-21130: Move the test for InvernessOrGreater outside the VNCGraphic…
2017-06-08 11:16:12 +01:00
Mihaela Stoica
4bf86842ba CP-21130: Move the test for InvernessOrGreater outside the VNCGraphicsClient class
- This is needed because this class is shared with the VNCControl solution which doesn't have access to the Helpers class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-06-08 09:38:09 +01:00
minl1
2105cbf1a4 cp-21685/cp-22367: Linx/YinheKylin linux XenCenter ICON support 2017-06-07 21:01:01 +08:00
Anoob Soman
add1b5d1ab CP-21130: Restrict support for EXT_KEY_EVENT to Inverness 2017-06-06 16:34:53 +01:00
Anoob Soman
108f3b5aae Merge branch 'master' into vnc_improvements_v2 2017-06-06 16:27:24 +01:00
Gabor Apati-Nagy
0311f7dd72 CA-220047: Show proper precheck error when a VM cannot be migrated
A bit of refactoring as requested by the reviewers

I decided not remove the NullReferenceExceptions and throw the Failures
immediately in order to avoid the additional error handling that seems to be unnecessary there. However, the reason I've decided to keep it as is is that it would change what gets logged and the performance gain would not be noticeable anyway. Furthermore, the current implementation (try-catchall) catches any other exceptions providing fallback to the default Failure.
2017-06-05 10:15:18 +01:00
Gabor Apati-Nagy
de97577430 CA-255551: [SCTX-2553] Automated Updates - Slaves rebooted before Master - XenCenter 7.1.1
Due to a regression (introduced by [1]), XenCenter will not run delayed actions in the correct host-order at all times. This can cause the master to be not the first host to be rebooted what may result in connections being lost to slaves should the API change between restarts/updates in a way that it would not be compatible to the previous version. This would make the wizard fail and users would have to restart their master host manually to make it connect to its slaves again.

This commit fixes the order of the hosts when executing the delayed actions.

[1]: 15827512e1

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-01 21:20:19 +01:00
Mihaela Stoica
5291c3aa7d Merge pull request #1613 from minli1/feature/Asianux-Turbo-Linux-support/master
req-398/req-440: ICON support for Asianux Linux and Turbo Linux.
2017-06-01 14:30:25 +01:00
Mihaela Stoica
dce68b58c9 CA-242134: Remove Host.IsXCP extension (#1618)
* CA-242134: Remove Host.IsXCP extension

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-242134: Remove Host.IsXCP extension

- retain the host.license_params condition

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-31 16:58:52 +01:00
Mihaela Stoica
cf1f630486 Merge pull request #1619 from xenserver/management-on-vlan
REQ-42 feature merge
2017-05-31 15:23:28 +01:00
Gabor Apati-Nagy
f1a20c279e Merge pull request #1603 from MihaelaStoica/CA-253936
CA-253936: Fix proxy authentication in the XenServerHealthCheck service
2017-05-31 14:37:02 +01:00
Mihaela Stoica
bd8ac0d769 Merge pull request #1617 from geosharath/management-on-VLAN-B2B
B2B master to management-on-vlan
2017-05-31 12:02:51 +01:00
Konstantina Chremmou
af647fbf52 Merge pull request #1608 from MihaelaStoica/removeVMPP
Remove vmpp
2017-05-31 08:43:12 +01:00
minl1
c146747798 CP-21662:replace the icon for new vm template(asianux and turbo linux) in Xencenter 2017-05-31 13:19:47 +08:00
Mihaela Stoica
1bae482bc5 CA-242134: Remove the VMPP code: changes following code review
- removed unused methods and properties from the NewPolicyWizard class
- made the wizard pages private in the NewPolicyWizard class
- removed unused constructor from the NewPolicySnapshotTypePage class
- removed unused property from the PolicyHistory class
- removed the public properties TreeView and DataGridView from the SnapshotsPage
- removed the PolicyType from the PolicyAlert class and the constructor that is no longer used
- removed unused property from the VMSS class

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-30 15:08:01 +01:00
Mihaela Stoica
49be0ffada CA-242134: Remove the OpenLicenseFileDialog class and its usage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-26 14:54:51 +01:00
Letsibogo Ramadi
75a325056c CA-252871 - Updates order is not preserved on Exporting updates to a file
Applies sort order of DataGridView to the unfiltered list of updates before
exporting all to file, thereby preserving the update order in the file
2017-05-26 12:54:46 +01:00
Mihaela Stoica
71600b20de CA-242134: Rename some of the classes and files, following the removal of the VMPP support
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 16:29:27 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Letsibogo Ramadi
fb5438282d CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink on t… (#1591)
* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink on the “Health Check Privacy Statement” window

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Fixed tab order

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Added Japanese privacy policy

* CA-205187 - L10n: JA/SC: The websites are not shown as hyperlink

Fixed regression in tab order
2017-05-24 15:14:01 +01:00
Mihaela Stoica
ad6631f698 CA-253936: Fix proxy authentication in the XenServerHealthCheck service
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-23 16:57:38 +01:00
Gabor Apati-Nagy
02025aa2b4 CA-220047: Show proper precheck error when a VM cannot be migrated
Detect both VM_LACKS_FEATURE and VM_LACKS_FEATURE_SUSPEND, show proper error message on the pre-check page in the Install Updates Wizard

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-22 11:17:42 +01:00
Mihaela Stoica
443f01fa55 Merge pull request #1601 from xenserver/master
Merge master into management-on-vlan
2017-05-22 10:38:26 +01:00
Letsibogo Ramadi
ef68d07c47 CA-249849 - Using arrows to select license in license manager are the… (#1588)
* CA-249849 - Using arrows to select license in license manager are the wrong way

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-249849 - Using arrows to select license in license manager are the wrong way round

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>

* CA-249849 - Using arrows to select license in license manager

Reverted tab order for radiobutton groupbox as per review comments
2017-05-18 12:25:04 +01:00
Mihaela Stoica
6288ace0f5 Merge pull request #1594 from xenserver/release/falcon/staging
Merge release/falcon/staging into master
2017-05-17 12:45:36 +01:00
Gabor Apati-Nagy
47f7690536 Merge pull request #1590 from MihaelaStoica/CA-244663
CA-244663: In the Migrate VM wizard, add storage mappings for the VDI…
2017-05-16 13:54:13 +01:00
Mihaela Stoica
6440226ee3 Merge pull request #1587 from letsboogey/master
CA-250234 - XenCenter hit with NullReferenceException at HAPage
2017-05-16 11:56:33 +01:00
Mihaela Stoica
e50187b85e Merge pull request #1593 from GaborApatiNagy/master_CA-252923
CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
2017-05-16 11:52:22 +01:00
Gabor Apati-Nagy
eb45d14a8a Merge pull request #1576 from MihaelaStoica/CA-251630
CA-251630: XenCenter update wizard incorrectly states that some hosts…
2017-05-15 13:59:19 +01:00
Gabor Apati-Nagy
d55af4e5a7 CA-252923: Update apply on slave host fails with pool_patch or pool_update not found
In rare cases, the GetMaster could return null, causing the update progress to fail with "Pool_patch or Pool_update not found". (when the Cache hasn't been populated by the execution gets here)
This commit drops GetMaster and uses a pre-saved masterUuid instead of waiting for the Cache what would be the other way to solve this issue.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-12 16:10:36 +01:00
Mihaela Stoica
d2f3c0c116 CA-244663: In the Migrate VM wizard, add storage mappings for the VDIs belonging to the VM's snapshots
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-11 16:42:41 +01:00
vetrivelc
21a7a74408 L10N: CA-250470,CA-250471,CA-250472,CA-250473,CA-250893,CA-250894 Localized UI fixes 2017-05-11 19:36:14 +05:30
Letsibogo Ramadi
adde3dc044 CA-250234 - XenCenter hit with NullReferenceException at HAPage
More robust check for null connection

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 16:40:12 +01:00
Mihaela Stoica
1bc43eda7d Merge pull request #1586 from GaborApatiNagy/master_updates
CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
2017-05-10 12:35:00 +01:00
Letsibogo Ramadi
63cd499cbd CA-250234 - XenCenter hit with NullReferenceException at HAPage.Rebuild()
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 12:32:15 +01:00
Gabor Apati-Nagy
d14f0d6b49 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 12:21:11 +01:00
Mihaela Stoica
d015ba223e Merge pull request #1575 from letsboogey/master
CA-251526 - Change template order in New VM wizard
2017-05-10 11:33:03 +01:00
Letsibogo Ramadi
0c7cf8678b CA-251526 - Change template order in New VM wizard
Moved "Legacy Windows" template to the bottom of the Windows templates
to discourage users from selecting it and avoid it being selected by default
at the top of the list as was the case.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-05-10 11:30:16 +01:00
Gabor Apati-Nagy
5eff76be28 CA-252877: Precheck actions not reverted on upgrading to new XenServer version using an update
Automated Updates now undo pre-check actions once it's finished wit the updates

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-05-10 10:06:41 +01:00
Konstantina Chremmou
652e446245 Merge pull request #1585 from MihaelaStoica/CA-242134
CA-242134: Remove the code targetting <= 6.1 XenServers
2017-05-10 08:14:23 +01:00
Gabor Apati-Nagy
d9a8b646ea Merge pull request #1578 from MihaelaStoica/CA-253047
CA-253047: Wrong prechecks are performed in Automated Updates mode if…
2017-05-09 20:21:36 +01:00
Mihaela Stoica
31c26aef22 Merge branch 'master' into CA-242134 2017-05-09 16:31:04 +01:00
Mihaela Stoica
a31c31eb07 CA-242134: Remove licensing code targeting pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 13:40:48 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Mihaela Stoica
78ad827cc4 CA-242134: Remove TampaOrGreater, its usages and unreachable code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 14:31:43 +01:00
Mihaela Stoica
496a400ae4 Merge pull request #1582 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-05-05 12:45:31 +01:00
vetrivelc
16d7d6fa89 L10N:Revised Falcon Help Files 2017-05-05 16:41:56 +05:30
Mihaela Stoica
d9f6016933 CP-242134: Remove pre-Clearwater hotfixes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 10:45:10 +01:00
Mihaela Stoica
cd2cff7d91 Merge pull request #1579 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-05-04 15:22:53 +01:00
Mihaela Stoica
dd861cfeed CA-253047: Wrong prechecks are performed in Automated Updates mode if an update has been previously uploaded
Reset the PrecheckPage.PoolUpdate property on leaving the SelectPatch page, because it needs to be null for the Automated Updates mode and for the single update mode it will be updated on leaving the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 15:14:06 +01:00
vetrivelc
bf58ff1ec0 L10N:Falcon Localized Help Files Checkin 2017-05-04 19:40:06 +05:30
Mihaela Stoica
6e4c5d3548 CA-251630: XenCenter update wizard incorrectly states that some hosts need rebooting and requires suspending VMs
Perform all the prechecks on applicable hosts only (i.e. the hosts that don't have the update applied already), with the following exceptions:
- The HA check, which is performed on the pool master
- The server-side precheck (PatchPrecheckCheck) which will still be performed on all servers in the pool and will show the warning if the update has already been applied on some servers

This commit also adds an override to the HAOffCheck.SuccessfulCheckDescription to show the pool name instead of the master's if the check is successful.
Also, in the PatchPrecheckCheck, I had moved the code that checks if the patch is already applied to the very beginning (before the host liveness check), so it will return the warning that the server will be skipped even if the server is not reachable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 14:32:36 +01:00
Mihaela Stoica
cd9ef6f509 Merge pull request #1565 from letsboogey/bug_thursday
CA-250235 - XC is allowing user to configure Health check even with W…
2017-05-03 12:48:41 +01:00
Letsibogo Ramadi
042915f5be CA-250235 - XC is allowing user to configure Health check even with Wrong XenServer Credentials 2017-05-03 12:23:06 +01:00
Kun Ma
b8dbb67309 CP-21658: Expose UI only for Inverness or greater version
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-05-03 17:40:49 +08:00
Mihaela Stoica
54c7ff3c29 Merge pull request #1570 from xenserver/master
Merge master into REQ-378
2017-05-03 09:43:42 +01:00
Anoob Soman
a0c34c28bf CP-21130: Extend KeyEvent to supply translated key symbol
QEMU EXT_KEY_EVENT expects key symbol and key scan code to
be sent. This commit extends KeyEvent to supply translated key symbol,
as well as scan code.

Signed-off-by: Anoob Soman <anoob.soman@citrix.com>
2017-05-02 17:16:23 +01:00
Kun Ma
3df0174886 CP-21658: Refine zh/ja UI for PerfmonAlertOptionsPage
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-05-02 13:37:16 +01:00
vetrivelc
713dc5dc8a L10N:CP-21817 Translation Checkins 2017-05-02 13:37:16 +01:00
Mihaela Stoica
3c861b0b7a Merge pull request #1558 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-04-26 14:06:15 +01:00
Gabor Apati-Nagy
141b670964 CA-249056: Add a unique ID to XenCenter Check For Update (#1537)
* CA-249056: Add a unique ID to XenCenter Check For Update

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Fixed the format of the User-Agent to comply with [1].

[1] https://tools.ietf.org/html/rfc7231#section-5.5.3

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

* CA-249056: Add a unique ID to XenCenter Check For Update

Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-26 12:45:49 +01:00
Mihaela Stoica
7914e9d2c4 Merge pull request #1557 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-04-26 10:34:14 +01:00
Mihaela Stoica
ca6e9d43e4 Merge pull request #1553 from geosharath/CP-21970
CP-21970: Integrate new Help content to the Scheduled Snapshots GUI
2017-04-26 10:32:25 +01:00
Mihaela Stoica
5c2139f486 Merge pull request #1556 from xenserver/release/falcon/staging
Release/falcon/staging
2017-04-26 10:13:24 +01:00
Ravi Bharath Shanmugiah
c68e259534 CHM for Falcon 2017-04-26 14:31:43 +05:30
Letsibogo Ramadi
91a6b6dcf8 Merge pull request #1547 from letsboogey/master
CA-249856 - XenCenter Keyboard shortcuts not working properly on VM c…
2017-04-25 15:55:51 +01:00
Mihaela Stoica
6549b9173b Merge pull request #1525 from makunterry/private/kunm/CP-19639
Feature REQ-378 XenCenter part
2017-04-25 14:16:18 +01:00
Mihaela Stoica
42df02734a CA-249856: Fix console position and focus rectangle drawing on resize
Also ensuring that if the UpdateSessionDisplaySettings function (which we use for resize) is not supported, then we display the console centered in the parent window and with scrollbars if needed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-25 14:07:29 +01:00
Mihaela Stoica
04c652c1c7 Merge pull request #1551 from xenserver/release/falcon/staging
Merge release/falcon/staging to master
2017-04-25 10:12:03 +01:00
Sharath Babu
e8b87e592e CP-21970: Integrate new Help content to the Scheduled Snapshots GUI
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-04-25 11:22:02 +05:30
Kun Ma
f533891df0 CP-21658: Refine control logic in PerfmonAlertOptionsPage
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-25 09:54:17 +08:00
Usha Mandya
34a6584b92 CP-21780: Submitting an updated CHM for Falcon 2017-04-24 17:50:29 +01:00
Letsibogo Ramadi
3ea6d56983 CA-249856 - XenCenter Keyboard shortcuts not working properly on VM console when remote desktop mode 2017-04-24 15:52:56 +01:00
Mihaela Stoica
d8f11faff3 Merge pull request #1541 from GaborApatiNagy/CA-248920
CA-248920: The radiobutton selection on Select Update page is not preserved while navigating to the previous page in the Install Update wizard
2017-04-21 16:44:31 +01:00
Gabor Apati-Nagy
8db5d128af Merge pull request #1539 from MihaelaStoica/CP-21904
CP-21904: Update RPU hotfixes in XenCenter
2017-04-21 12:15:58 +01:00
Kun Ma
33b7bf2d4e CP-21658: Refine UI style for PerfmonAlertOptionsPage
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-21 18:12:55 +08:00
Gabor Apati-Nagy
95caad4919 CA-248920: The radiobutton selection on Select Update page is not preserved while navigating to the previous page in the Install Update wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-20 17:40:54 +01:00
Mihaela Stoica
8a4a2ab716 CP-21904: Update RPU hotfixes in XenCenter
- Added RPU004 for Ely and updated the code to upload and apply the iso format hotfix

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-20 10:36:27 +01:00
vetrivelc
a291bd730a L10N:CA-205538 & other translation checkins 2017-04-19 14:36:03 +05:30
Kun Ma
c007194e06 CP-21658: Expose UI of feature REQ-378 to user when the XenServer support the feature
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-17 15:27:50 +08:00
Kun Ma
8c837bb2c2 CP-19639: Refine data structure for mail language
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-13 13:34:30 +08:00
Gabor Apati-Nagy
49fd823650 CA-249084: deleted more unneeded code
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:50:47 +01:00
Gabor Apati-Nagy
3805bcef40 CA-249084: Fixes for code review
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:31:17 +01:00
Gabor Apati-Nagy
2823e0337b CA-249084: Fix code for new build number format
removing unneeded code (after 55f17d4)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:37:19 +01:00
Gabor Apati-Nagy
72ceeb2de3 CA-249084: Removed obsolete functionality
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:01:20 +01:00
Gabor Apati-Nagy
55f17d416b CA-249084: Fix code for new build number format
fixed by removing checks that are no longer needed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 11:06:03 +01:00
Gabor Apati-Nagy
1abf9bf525 CA-249084: Build number is gone, hiding it
Hide build number from now on
2017-04-11 11:04:49 +01:00
Mihaela Stoica
8650f5880b CA-249824: Unable to create vlan, bond using XenCenter
- set managed=true, otherwise the network creation fails with the error "The network is not managed by xapi"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-04-10 07:49:51 -04:00
Mihaela Stoica
b65c4cd578 Merge pull request #1531 from letsboogey/nre_on_rdp
CA-249627 - NPE while accessing XenCenter console on a RDP establishe…
2017-04-07 12:05:20 +01:00
Letsibogo Ramadi
0381de85a4 CA-249627 - NPE while accessing XenCenter console on a RDP established & then disconnected guest VM 2017-04-07 11:41:59 +01:00
Gabor Apati-Nagy
b332082d43 Merge pull request #1521 from MihaelaStoica/CA-248471
CA-248471: XenCenter offers passthrough on unlicensed hosts even when…
2017-04-05 10:50:30 +01:00
Mihaela Stoica
75ed339d04 Merge pull request #1522 from letsboogey/master
CA-150305 - EN: Truncation issue occurs under the “Hide Details” of S…
2017-04-04 17:34:51 +01:00
Letsibogo Ramadi
ea6a082136 CA-150305 - EN: Truncation issue occurs under the “Hide Details” of Snapshots tab
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-04-04 17:15:15 +01:00
Kun Ma
6dc10c1490 CP-19453: XenCenter: Add mail-language to other-config parameters when configure e-mail options
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 11:21:21 +08:00
Kun Ma
22446010b4 CP-19639: Provide XenCenter UI configuration option for email alert charset
Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-04-01 09:58:17 +08:00
Mihaela Stoica
6c260c04d0 CA-248471: XenCenter offers passthrough on unlicensed hosts even when it's not available
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-30 15:06:54 +01:00
Mihaela Stoica
6a8282c1c6 CP-21579: Precheck for XenCenter version: Add the link to the XC version web page
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-28 15:33:55 +01:00
Gabor Apati-Nagy
70a4e9880e Merge pull request #1506 from MihaelaStoica/CA-237939
CA-237939: Cannot create VM from Checkpoint other than the resident h…
2017-03-28 14:43:10 +01:00
Gabor Apati-Nagy
6d6a9ed147 Merge pull request #1490 from MihaelaStoica/CA-152101
CA-152101: Incorrect error when trying to license pool with old licen…
2017-03-28 14:31:58 +01:00
Mihaela Stoica
47ccbd4581 Merge remote-tracking branch 'upstream/REQ-411' into REQ-411
Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.resx
2017-03-28 12:44:54 +01:00
Gabor Apati-Nagy
8afd06ee00 CP-21182: Improved wording in the Install Updates Wizard 2017-03-28 11:21:27 +01:00
Gabor Apati-Nagy
acf6bc5ef8 CP-21182: Improved wording in the Install Updates Wizard
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-28 11:17:26 +01:00
Gabor Apati-Nagy
3a83bba457 Merge pull request #1503 from letsboogey/gpu
CP-21558 - On the vGPU types dialog, hide the column headers where al…
2017-03-28 10:54:54 +01:00
Mihaela Stoica
40680b09ea CP-21574: Add checkbox on the Select Servers page for applying all the released updates after the new version is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-27 16:12:49 +01:00
Gabor Apati-Nagy
6051949227 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:54:57 +01:00
Gabor Apati-Nagy
0ac4cd5014 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:29:44 +01:00
Gabor Apati-Nagy
bd2fa92cbb CP-21504: Added check for restart (for the version update)
as we are expecting that to require a host-restart

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:36:11 +01:00
Gabor Apati-Nagy
77daf14629 CP-21504: minor fix
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:34:20 +01:00
Letsibogo Ramadi
808063c125 CP-21558 - On the vGPU types dialog, hide the column headers where all the values are 0 2017-03-27 14:22:16 +01:00
Mihaela Stoica
4bfbcc5f83 CP-21504: Add automated updates license check for the new versions that are available as updates 2017-03-27 11:11:26 +01:00
Mihaela Stoica
7bd629c54e CP-21504: Removed an unused property in the PatchingWizard_ModePage
Also rearranged some code in PatchingWizard  class, to keep all property assignments together for each wizard page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:48:26 +00:00
Mihaela Stoica
1896d9f958 CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Introduced the WizardMode enum and the WizardMode  properties in several wizard pages (replacing the IsInAutomatedUpdates boolean property)
When in NewVersion mode, we show the same wizard pages as the AutomatedUpdates mode and we build the update sequence based on the selected update alert (which is an update to a new version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:43:19 +00:00
Gabor Apati-Nagy
d29510d5af CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 14:19:11 +00:00
Gabor Apati-Nagy
9359f5d98b CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 13:53:21 +00:00
Gabor Apati-Nagy
31c5ee68a9 CP-21504: Updates wizard: Automated mode for new versions that are available as updates
First step, this can return an upgrade sequence that will upgrade a pool to a version and will bring that version up-to-date right away. Untested skeleton yet.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 12:05:14 +00:00
Gabor Apati-Nagy
0ae60b434b CP-21500: Updates wizard: Show new versions that are available as updates
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 11:38:42 +00:00
Gabor Apati-Nagy
3ec897a6fc CP-21500: Updates wizard: Show new versions that are available as updates
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-24 11:37:43 +00:00
Mihaela Stoica
06e624c3dc Merge pull request #1502 from stephen-turner/CA-248254
CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches
2017-03-24 10:50:23 +00:00
Mihaela Stoica
dc56379dc3 CA-232996: Storage menu doesn't refresh in XenCenter for destroy and forget
Update the toolbar when an SR action is completed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 10:40:55 +00:00
Gabor Apati-Nagy
1317e5a4e3 CP-21500: Updates wizard: Show new versions that are available as updates
In the Updates wizard:
New versions that are available as updates will be listed in the "Download Updates from Citrix" section, before any other updates.
If XenCenter is not the latest version, these rows will be greyed out, with a tooltip.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-23 14:05:09 +00:00
Mihaela Stoica
83dbaf6b5e CA-237939: Cannot create VM from Checkpoint other than the resident host in pool
Use VM.clone (and not VM.copy) when creating a VM from a snapshot.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-23 12:49:24 +00:00
Konstantina Chremmou
8f1a539cca Merge pull request #1501 from stephen-turner/CA-248252b
CA-248252: Show version numbers for updates
2017-03-23 12:39:39 +00:00
Stephen Turner
be746126a1 Fix typo 2017-03-23 12:28:32 +00:00
Konstantina Chremmou
07c0ad25cf CA-248087: Updated API bindings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-03-23 12:20:07 +00:00
Mihaela Stoica
170dcfc70b Merge pull request #1504 from geosharath/CA-246288
CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
2017-03-23 09:34:08 +00:00
Sharath Babu
553e559bee CA-246288: Removing mention of the word "paused" from the text in NewpolicySnapshotTypePage
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-23 04:02:13 +05:30
Stephen Turner
5f878e9661 CA-248254: Remove unused function 2017-03-22 17:56:01 +00:00
Stephen Turner
21f6bc22c4 CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches 2017-03-22 17:47:06 +00:00
Stephen Turner
7bd5dd98ca CA-248252: Show version numbers for updates 2017-03-22 17:29:11 +00:00
Gabor Apati-Nagy
e73b989c72 Merge pull request #1500 from MihaelaStoica/REQ-411
CP-21184: Add a check for the XenCenter version
2017-03-22 14:00:29 +00:00
Gabor Apati-Nagy
a1e3e3e76d CP-21185: Show new versions of XS and XC on the top (#1499)
CP-21185: Show new versions of XS and XC on the top

...unless not sorted by name, date, or servers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-22 11:44:29 +00:00
Gabor Apati-Nagy
40074d5969 Merge pull request #1491 from MihaelaStoica/CA-242918
CA-242918: Improve the exception shown in XenCenter if the hotfix upl…
2017-03-22 11:05:51 +00:00
Gabor Apati-Nagy
7a875cae94 Merge pull request #1492 from MihaelaStoica/CA-137249
CA-137249: Strange 'Completed' text shows while enabling or disabling HA
2017-03-22 11:04:05 +00:00
Mihaela Stoica
b65084fdc3 CP-21184: Add a check for the XenCenter version
- On the Updates tab: for new versions, check that the version of XenCenter is at least the latest. If not, give an additional option to download a newer XenCenter (for both updates and upgrades), and not offer "Download and Install" (for updates).
- In the Patching wizard: if the update is a new version, we force the user to first update their XenCenter to the new version
- In the RPU wizard: if the server version is not the latest and their XenCenter version is not the latest from updates.xml, we assume that they want to upgrade to the latest XenServer version and we force the user to first update their XenCenter to the latest version.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-22 10:59:32 +00:00
Mihaela Stoica
4ceafb5cd6 Merge pull request #1497 from geosharath/CA-245801
CA-245801: [VMSS] Usability issues with Snapshot schedules window
2017-03-22 09:54:36 +00:00
Sharath Babu
035fd959c3 CA-246288: [VMSS] Incorrect message in schedule properties->snapshot type window
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-22 09:58:04 +05:30
Sharath Babu
b1373b8d76 CA-245801: [VMSS] Usability issues with Snapshot schedules window
Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-03-22 08:34:36 +05:30
Mihaela Stoica
5a2966df02 CP-21180: Show two lines on the Updates page if some servers can update to the new version and some can only upgrade
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-20 10:44:33 +00:00
Mihaela Stoica
40cd0d57f2 CP-21179: Show an update alert as a new XenServer version
If a patch updates the server version, then save a reference to that version in the alert and display this alert as a "new version" alert

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-20 10:17:35 +00:00
Letsibogo Ramadi
143456fffc CA-239224 - [IN-306] Error on viewing Network properties
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-16 16:57:23 +00:00
Mihaela Stoica
19f1460865 CA-137249: Strange 'Completed' text shows while enabling or disabling HA
Suppress updates to the status when the PureAsyncAction runs the action to populate the ApiMethodsToRoleCheck

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 13:31:51 +00:00
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
37a287edd1 CA-152101: Incorrect error when trying to license pool with old license server
Try to match the alerts by message type, not by title, because for pooled hosts the title contains the host name followed by the friendly name, while for standalone hosts the host name is not included

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 10:40:41 +00:00
Gabor Apati-Nagy
3bb3f558c0 Merge pull request #1488 from MihaelaStoica/REQ-411
CP-21174: Multiple dismissed XenCenterVersion alerts
2017-03-15 11:37:49 +00:00
Mihaela Stoica
ca5cf5037e CP-21174: Multiple dismissed XenCenterVersion alerts
- Limit the size of the list where we keep the dismissed XenCenter version alerts

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-15 11:26:00 +00:00
Gabor Apati-Nagy
d469d92357 CP-21176: Showing XC version in the new version alert
This way XC will display the name attribute of the XC-version which is expected to contain the LTSR string for LTSR version.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-14 17:27:04 +00:00
Mihaela Stoica
c5dfd7fccf CP-21174: Multiple dismissed XenCenterVersion alerts
- save multiple dismissed alerts as a comma-separated list in Settings.Default.LatestXenCenterSeen

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-14 17:16:21 +00:00
Gabor Apati-Nagy
04455b561b CP-21172: Support alerts for LTSR and CR XS versions at the same time
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-14 16:38:10 +00:00
Mihaela Stoica
802a90847a CP-21173: Show two latest XenCenter versions
- Add "latestcr" field to the XenCenterVersion class
- Change the Updates class to cope with multiple latest XenCenter versions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-14 15:50:49 +00:00
Mihaela Stoica
28546579c5 Merge pull request #1485 from stephen-turner/CA-95798
CA-95798: Limit size of LongStringComboBox
2017-03-14 13:45:33 +00:00
Stephen Turner
6d8c7b76df CA-95798: Limit size of LongStringComboBox 2017-03-10 17:29:58 +00:00
Gabor Apati-Nagy
178db9d02e CA-246338: Changing Network Bond Mode on a single host in a pool changes bond mode on all hosts
Added "Changes will apply to all hosts in a pool." to clarify the scope of these settings

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-10 16:32:17 +00:00
Letsibogo Ramadi
e6b912173d CA-147612 - EN: background should expand to the right border.
Also fixed appearance to be consistent with other Vertically Tabbed Dialogs

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-09 17:40:21 +00:00
Letsibogo Ramadi
d85af7f8a5 CA-245626 - Properties dialog content clipped when content panel is made smaller
In addition to adding scrollbars when content panel size is reduced using splitter,
I also fixed the teal top panel issue from the base class so that it is applied to all
VerticallyTabbedDialog implementations.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-09 17:35:26 +00:00
Mihaela Stoica
0da7a5c55d Merge pull request #1472 from letsboogey/vncfocusborder
CA-245475 - Focus border not visible on some sides in VNC console
2017-03-08 11:49:24 +00:00
Gabor Apati-Nagy
5f3d49e9da Merge pull request #1473 from letsboogey/gpu
CP-21120 - XenCenter shows MxGPU as 'passthrough' rather than model
2017-03-07 18:53:20 +00:00
Letsibogo Ramadi
34780b1e0a CP-21120 - XenCenter shows MxGPU as 'passthrough' rather than model 2017-03-07 16:13:53 +00:00
Mihaela Stoica
eb9ed4cda0 Merge pull request #1469 from letsboogey/rdpconsole8
CA-245546 - Only the active RDP console is resized when the main XenC…
2017-03-07 14:56:19 +00:00
Letsibogo Ramadi
b604f79fa6 CA-245475 - Focus border not visible on some sides in VNC console 2017-03-06 15:45:56 +00:00
Letsibogo Ramadi
29a683afc3 CA-245546 - Only the active RDP console is resized when the main XenCenter window is resized 2017-03-03 17:29:19 +00:00
Mihaela Stoica
ef39cd2e11 Merge pull request #1465 from letsboogey/bug_thursday
CA-245614 - Teal banner in VM properties dialog does not span with of…
2017-03-03 10:29:18 +00:00
Konstantina Chremmou
fe67df9f09 Merge pull request #1467 from MihaelaStoica/master
CA-169169: Wrong help context showing after clicking help icon on RDP…
2017-03-02 20:56:26 +00:00
Mihaela Stoica
dc758977f2 CA-169169: Wrong help context showing after clicking help icon on RDP confirmation dialog 2017-03-02 17:24:52 +00:00
Letsibogo Ramadi
8c9d65f761 CA-245614 - Teal banner in VM properties dialog does not span with of dialog box
This was a regression introduced by commit b3fe4aa2. Fixed by reversing commit
2017-03-02 13:44:43 +00:00
Mihaela Stoica
ed3668d68d Merge pull request #1457 from letsboogey/rdpconsole8
CP-20881 - Implement RDP console resize when toggling the full screen…
2017-03-02 10:36:31 +00:00
Letsibogo Ramadi
27918a1c02 CP-20881 - Implement RDP console resize when toggling the full screen mode
In addition to ticket requirements, the console size is updated when the console is:
- resized in undocked mode
- resized manually by dragging window edges
- resized by dragging the panel splitter

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-03-01 17:48:42 +00:00
Mihaela Stoica
418d2edb7b Merge pull request #1461 from GaborApatiNagy/CA-244687_2
CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
2017-03-01 13:35:42 +00:00
Gabor Apati-Nagy
e9eeb3d595 CA-244687: Install Updates Wizard: Automated mode: bugfix for omitted after-apply-guidances
Fixes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 13:10:45 +00:00
Gabor Apati-Nagy
15827512e1 CA-244687: XSINT71E003 asks user to restart toolstack after installing hotfixes using Batch hotfixing
This commit fixes a bug in the Update Wizard that causes XenCenter to not restart Toolstack when it should in the following case: in Automated Mode, when the update sequence for a host has an update that contains live-patch with restartHost guidance (and guidance-mandatory=false) followed by an update with Toolstack restart guidance.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-01 12:05:44 +00:00
Mihaela Stoica
4ef110cebe Merge pull request #1459 from letsboogey/optionsdialog
CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu
2017-02-28 16:44:29 +00:00
Letsibogo Ramadi
3d46e1e835 CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu
Added scrollbars for case when panel is resized using splitter.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-02-28 16:37:38 +00:00
Mihaela Stoica
d0b87b6ec2 Merge pull request #1460 from kc284/master
CA-244618: Corrected the xml-rpc licence.
2017-02-28 16:06:00 +00:00
Mihaela Stoica
a0b19b958a Merge pull request #1448 from letsboogey/bug_thursday
CA-244655 - XenCenter shows the wrong message on the Updates page
2017-02-28 15:30:15 +00:00
Konstantina Chremmou
b70908a300 CA-244618: Corrected the xml-rpc licence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-02-28 15:29:36 +00:00
Gabor Apati-Nagy
48ce1f5229 Merge pull request #1458 from MihaelaStoica/CAR-2214-to-master
Merge CAR-2214 to master
2017-02-28 15:28:22 +00:00
Gabor Apati-Nagy
118dea1fa7 Merge pull request #1455 from MihaelaStoica/CA-245345
CA-245345: XenCenter doesn't mark a host as unapplicable when an upda…
2017-02-28 15:19:16 +00:00
Gabor Apati-Nagy
2515c3ca4f Merge pull request #1456 from MihaelaStoica/CA-236104
CA-236104: Do not allow pre and post Ely servers to be selected at th…
2017-02-28 15:18:47 +00:00
Mihaela Stoica
dab5e3da05 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-28 14:29:59 +00:00
Mihaela Stoica
7a04e5186e Merge remote-tracking branch 'upstream/CAR-2214' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	Jenkinsfile
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2017-02-28 10:30:02 +00:00
Mihaela Stoica
1a6639bdc7 Merge pull request #1432 from letsboogey/master
CP-20727 - Use new version of the rdpclient
2017-02-27 17:25:09 +00:00
Letsibogo Ramadi
8d2cbfc87c CP-20727 - Use new version of the rdpclient 2017-02-27 17:24:25 +00:00
Mihaela Stoica
33979bb1f2 CA-236104: Do not allow pre and post Ely servers to be selected at the same time when the user browsed for an iso update or supplemental pack.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:45:34 +00:00
Mihaela Stoica
f1470d1c53 CA-245345: XenCenter doesn't mark a host as unapplicable when an update is installed via "Select update from disk" option
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-27 16:43:02 +00:00
Stephen Turner
bcc282093d Update credits 2017-02-24 16:49:16 +00:00
Mihaela Stoica
0585590afa CA-243640: XenCenter HealthCheck Analysis Status Refresh is failing
XenCenter uses the wrong token (upload token instead of the diagnostic token) when the "Request an additional update" option is used

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-24 16:03:09 +00:00
Letsibogo Ramadi
ba29f1588b CA-244655 - XenCenter shows the wrong message on the Updates page when no updates are found 2017-02-24 12:12:08 +00:00
Mihaela Stoica
46315e4c83 CA-244656: The popup dialog for Check for Updates (on first XC start) should enable all CFU options
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-23 12:48:04 +00:00
Mihaela Stoica
daa4d981b5 Merge pull request #1446 from geosharath/CAR-1841
CP-17253: [XC] Ability to select VLAN PIF as a management interface of a host/Pool
2017-02-23 09:22:56 +00:00
Sharath Babu
0dc313941c CP-17253: [XC] Ability to select VLAN PIF as a management interface of a host
This is allowed for both host and pool (on a host by host basis).

Signed-Off-By: Sharath Babu <sharath.babu@xitrix.com>
2017-02-22 18:47:12 +05:30
Frederico Mazzone
39c1169933 CA-244661: Improve dialog message for 407 proxy authentication error
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-02-21 16:33:00 +00:00
Gabor Apati-Nagy
da4140d75e Merge pull request #1443 from stephen-turner/CA-243964
CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers
2017-02-20 11:36:28 +00:00
Stephen Turner
20df8ce2fe CA-244097: XenCenter sometimes refuses .xsupdate files 2017-02-17 17:11:03 +00:00
Stephen Turner
74c567ef1d CA-243964: Don't allow upload of .xsupdate files to >= 7.1 servers 2017-02-17 16:56:44 +00:00
Letsibogo Ramadi
f414407f40 CA-164371 - Usability issue with Popup windows from XenCenter Tools Menu 2017-02-17 12:12:45 +00:00
Gabor Apati-Nagy
2de8f55e30 Merge pull request #1439 from letsboogey/funnylabelfix
CA-236150 - Funny label on status report wizard
2017-02-15 14:05:14 +00:00
Letsibogo Ramadi
10bb65d2f2 CA-236150 - Funny label on status report wizard
Changed label to a LinkLabel instead of RichTextBox. Also fixed similar bug on the healthcheck enrollment dialog.
2017-02-15 13:51:19 +00:00
Gabor Apati-Nagy
dbebd7de74 Merge pull request #1435 from kc284/master
Collect all 3rd party components in one place.
2017-02-14 12:34:44 +00:00
Stephen Turner
f3a64fc54b Merge pull request #1433 from geosharath/feature_merge
Scheduled Snapshots feature merge
2017-02-14 10:09:17 +00:00
vetrivelc
6d9273f304 L10N: Translation Changes & VMSS updates CP-20708 2017-02-14 03:27:38 +00:00
Frezzle
d3e64ad2d2 CP-20918: Remove proxy authentication registry key (#1440)
The ProxyAuthenticationEnabled registry key is no longer needed since
CAR-2214 is now in its own branch.

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-02-13 20:28:35 +00:00
Gabor Apati-Nagy
b8b8e846f5 CA-227631: License Manager doesn't respond immediately to disconnected host
Fixed the bug that caused a disconnected host to appear as if it was still connected in the License Manager. After this commit, if a host get disconnected in the background its row will be disabled and will be unselectable.

(Note that when the connection resumes, the user will still have to click on a different row to have the disabled state (and the buttons) fixed, but that is a Won't fix bug (CA-115261) that I couldn't fix right now.)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-02-10 15:55:09 +00:00
Konstantina Chremmou
a04b039870 Collected all third party libraries in one place so it's easier for developers to setup their system.
Added a help script to that purpose.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-02-09 20:27:03 +00:00
Gabor Apati-Nagy
6693570b11 Merge pull request #1428 from MihaelaStoica/CA-238265
CA-238265: Add the action title to the error message displayed on the…
2017-02-08 11:47:38 +00:00
Mihaela Stoica
ef331986c7 CA-238265: Add the action title to the error message displayed on the Install Update page of the patching wizard.
Also changed  ApplyPatchAction and ApplyUpdateAction to install a single update to a single host, so that the appropriate action title can be displayed if an action fails. And replaced 2 hardcoded strings with resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-06 13:04:07 +00:00
Mihaela Stoica
0d1862feff Merge pull request #1427 from geosharath/CA-241810
CA-241810: [VMSS] VM scheduled snapshot options visible on XC on host with Dundee XS
2017-02-06 12:11:23 +00:00
Mihaela Stoica
41adff4ea4 Merge pull request #1426 from geosharath/VMSS-B2B
B2B merge from master to VMSS
2017-02-06 09:26:32 +00:00
Sharath Babu
32836a4b49 CA-241810: [VMSS] VM scheduled snapshot options visible on XC on host with Dundee XS
Updating DundeeOrGreater check with FalconOrGreater

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-06 11:38:26 +05:30
Sharath Babu
0800e361c6 Merge branch 'master' of https://github.com/xenserver/xenadmin into VMSS 2017-02-04 13:59:58 +05:30
Gabor Apati-Nagy
01cebc9166 Merge pull request #1404 from MihaelaStoica/CP-19607
CP-19607: Make sure that event handlers are unregistered when controls are not visible
2017-02-01 13:53:14 +00:00
Mihaela Stoica
ce8cdce0a4 CA-236844: XenCenter throws "Assertion failed" error when toggling be… (#1419)
* CA-236844: XenCenter throws "Assertion failed" error when toggling between the RDP and VNC consoles

Couldn't reproduce it, but it looks like the assertion is hit because the console view still holds a subscription to an event from an old vnc stream (maybe not garbage collected yet).
Added code to deregister event handlers when the vcnStream is disconnected and also replaced the the assertion with an if statement, ignoring the case that might have caused the assertion failure.

* CA-236844: XenCenter throws "Assertion failed" error when toggling between the RDP and VNC consoles

Added a Debug assert and a null check.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-02-01 12:55:00 +00:00
Sharath Babu
b5c96618ff CA-241844: [VMSS] Deleting a snapshot schedule raises XenCenter error
After deleting the schedule vmss will be null for that message, hence
we need to handle this case.

Signed-Of-By: Sharath Babu <sharath.babu@citrix.com>
2017-02-01 14:15:49 +05:30
Mihaela Stoica
430b9e87ed CP-19607: More event handlers that needed to be deregistered 2017-01-31 14:35:59 +00:00
Sharath Babu
9da9aabce7 CA-241767: [VMSS] Scheduled snapshots not getting listed in XC
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-31 10:01:33 +05:30
Mihaela Stoica
73293c7e4b Merge pull request #1401 from letsboogey/master
CA-239951 - Patching wizard allows selection of unreachable hosts
2017-01-30 11:02:38 +00:00
Usha Mandya
2bcf798678 Fixed a tag issue 2017-01-27 12:34:54 +00:00
Letsibogo Ramadi
3a4e3e8235 CA-237968 - Unfriendly error 'method name that you used is host.call_extension' while applying Ely hotfix on partially upgraded pool 2017-01-26 17:03:23 +00:00
Letsibogo Ramadi
2aae7ab0f2 CA-239890 - EN: The update for PVS-Accelerator is displayed as “pvsaccelerator” on the “General” page.
Changes all update names to friendly names which are usually identical to the Name Description.
2017-01-26 10:39:06 +00:00
Mihaela Stoica
c35eae23be CP-19607: Unregister event handlers when the tab pages are hidden
Implemented a generic mechanism to allow tab pages to unregister their event handlers when they are hidden (when a tab page gets deselected)
Also changed VMStoragePage to derive from BaseTabPage, so it could use the same mechanism.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:38:33 +00:00
Mihaela Stoica
80e60abf7c CP-19607: Make sure that event handlers are unregistered when the SrPicker control is disposed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-25 12:15:59 +00:00
Letsibogo Ramadi
045c405f92 CA-239951 - Patching wizard allows selection of unreachable hosts
Disabled the ability to select unreachable hosts and in addition
added a try/catch block to hide error message resulting from trying
to clean up an unreachable host.

Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-25 10:28:11 +00:00
Sharath Babu
4833565ec6 Fixing copyright check failures at build time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-25 14:11:24 +05:30
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Mihaela Stoica
02c228ca85 Merge pull request #1390 from GaborApatiNagy/master_CA-238993
CA-238993: Fixed: forever growing updates list while new or updated metadata was not shown
2017-01-24 09:54:25 +00:00
Mihaela Stoica
a6e95e3cb7 Merge pull request #1387 from geosharath/CA-213512
CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
2017-01-24 09:31:34 +00:00
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Usha Mandya
7859badc54 CP-20468: XC Help for Revised Management Agent updates 2017-01-23 12:02:14 +00:00
Sharath Babu
af182d9e7e CA-213512: [VMSS] XC mentions VMPR instead of VMSS on failure of snapshot
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-23 16:25:16 +05:30
Gabor Apati-Nagy
d85cc824b5 Merge pull request #1392 from letsboogey/master
Ca-238273 - Install Update Wizard: Update still shows up in the grid …
2017-01-20 17:01:26 +00:00
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Mihaela Stoica
cfed0d1eec Merge pull request #1388 from geosharath/CA-213505
CA-213505: Right click on a VM allows assignment to a policy of unsupported snapshot type
2017-01-20 12:26:43 +00:00
Letsibogo Ramadi
8f48c99b2d Ca-238273 - Install Update Wizard: Update still shows up in the grid after it's been installed
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-20 11:35:25 +00:00
Sharath Babu
fe373447b6 CA-213505: Right click on a VM allows assignment to a policy of unsupported snapshot type
[VMSS] XC -> right click 'VM' -> Assign VM to snapshot schedule shows all policies,
even though they are not supported by VM

Signed-Off-By: Sharath Babu <sharath.babu@citrix.com>
2017-01-20 11:35:10 +05:30
Gabor Apati-Nagy
974aa0293c CA-238993: Fixed the issue of forever growing updates list while new or updated metadata was not shown
These lists were continuously growing on each refresh, because the Where
clauses returned all items as the predicate was always evaluated to
true. The reason is: A. Even IEquatable<XenServerPatch> is
implemented on XenServerPatch, it only compares uuids. B. XenServerVersion
(also XenCenterversion) does not implement Equals (always different as the
Action returns new objects).

The two bugs these caused are: A] forever growing list of versions causing
obsolete data to be kept while everything is added to the end of the list
additionally. B] Any previously added Patch will not be updated unless the uuid has been changed (this never changes).

Fix in this commit: On each refresh, taking the new lists as they are
(from the Action) and not trying to keep or modify existing items. GC will do the rest with the old list (and objects)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-19 18:33:30 +00:00
Konstantina Chremmou
a59e4f4ad3 Merge pull request #1382 from GaborApatiNagy/master_CA-176169
CA-176169: Copyright statement checking
2017-01-19 15:14:25 +00:00
Frederico Mazzone
72b2429084 Enable roaming for proxy authentication settings
Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:39:01 +00:00
Frederico Mazzone
76fd266913 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Properties/Settings.Designer.cs
	XenAdmin/Properties/Settings.settings
	XenAdmin/app.config
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs

Signed-off-by: Frederico Mazzone <frederico.mazzone@citrix.com>
2017-01-19 14:16:51 +00:00
Mihaela Stoica
2ae2bdfdd8 CA-182453: XenCenter does not show an active XenMotion in another session
Added "VM.pool_migrate" to the list of tasks suitable for meddling actions.
Removed the usage of MeddlingActionTitle other_config key, because it wasn't working as intended for two reasons:
- If XenCenter starts an action that does multiple async api calls, so multiple tasks, the action's title is assigned to all tasks as MeddlingActionTitles, so the second XenCenter instance would create multiple meddling actions with the same title.
- When a second XenCenter instance tries to see if a task is suitable for a meddling action, the MeddlingActionTitle is not yet present in the task's other_config, so the task is ignored in most of the cases.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-01-18 14:25:55 +00:00
Gabor Apati-Nagy
356a7ebdc4 Merge pull request #1372 from MihaelaStoica/CA-226900
CA-226900: Do not allow selection of individual pool members when ins…
2017-01-18 14:07:31 +00:00
Mihaela Stoica
3abce40f74 CA-226900: Do not allow selection of individual pool members when installing a hotfix
Changed the rubric on the Select Servers page.
2017-01-18 10:59:35 +00:00
Mihaela Stoica
66eab6d8cb Merge pull request #1384 from letsboogey/master
CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Cre…
2017-01-17 12:47:47 +00:00
Letsibogo Ramadi
d83bc64cef CA-169475 - G11n: SC&JA: Didn't provide AM/PM on date info under “Created On” list
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-17 10:37:55 +00:00
Sharath Babu
866968c063 CA-227792: unable to change policy type and modify VMs list at the same time
Signed-Off-by: Sharath Babu <sharath.babu@citrix.com>
2017-01-17 12:02:54 +05:30
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Mihaela Stoica
27a2a1d88c Merge pull request #1380 from letsboogey/master
CA-148598 - EN: Missing and duplicate hotkeys on "Alerts" pane under …
2017-01-16 16:28:05 +00:00
Letsibogo Ramadi
75db446168 CA-151449 - EN: Missing hotkeys on Pool Properties ->GPU wizard.
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-16 15:08:58 +00:00