Commit Graph

86 Commits

Author SHA1 Message Date
Konstantina Chremmou
3e0a958783 Removed accessors that were set but never used. Removed unused constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-11-01 13:12:09 +02:00
Tim Liu
d432cf5477 CA-293776: The order in which a single update is applied on the slave… (#2180)
* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Apply the same Hosts sorting rules for all the PatchingWizard Pages .

Signed-off-by: Tim Liu <tim.liu@citrix.com>

* CA-293776: The order in which a single update is applied on the slaves is not the same as the order in which they are displayed

Place orderby clause after where clause

Signed-off-by: Tim Liu <tim.liu@citrix.com>
2018-08-20 15:46:58 +01:00
Mihaela Stoica
b8168eed28 CA-292626: Consider the contains-livepatch flag of all the applicable… (#2165)
* CA-292626: Consider the contains-livepatch flag of all the applicable updates when doing the prechecks in the automated updates mode.

Instead of looking at the minimal patches, we look at all applicable patches for that host (i.e. all the updates on the host's version that are not already installed) and we say that the host won't need a reboot only if all these are marked as contains-livepatch.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-08-03 16:11:06 +01:00
Mihaela Stoica
9dc0d77ef6 CA-292626: Consider the contains-livepatch flag when doing prechecks in the automated updates mode.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-30 14:33:22 +01:00
jishengx
260ec2d013 CA-284914: Prechecks are re-run every time the 'Hide successful prech… (#2088)
* CA-284914: Prechecks are re-run every time the 'Hide successful prechecks' is ticked/unticked

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>

* fix some comments
2018-07-26 16:11:53 +01:00
Mihaela Stoica
9accb3c69f Merge branch 'master' into REQ-672
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs
#	XenAdmin/XenAdmin.csproj
2018-07-13 13:14:36 +01:00
Konstantina Chremmou
9157db94ac CA-293764: Added new property XenObject to the Checks, which returns the Pool
or Host accordingly. Extended comparison of Problems to also take account of
the XenObject the Check was performed on, otherwise the Problems get mixed
up when there are homonymous members across pools.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-13 12:39:33 +01:00
serencorbett1
63d09dd117 CP-28431: Block updates/upgrades from Kolkata if clustering enabled (#2124)
* CP-28431: Block updates and upgrades from Kolkata onwards if clustering enabled
* CP-28431: Rename files and change from Pool Check to [Host] Check
* CP-28431: Change description message

Signed-off-by: Seren Corbett <seren.corbett@citrix.com>
2018-07-09 10:59:09 +01:00
Konstantina Chremmou
91563ebd54 No need to catch and rethrow exception as it's logged anyway; a couple of more optimisations.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
0aa43018a4 Removed ManualModeSelected property in favour of the existing ManualUpgrade; moved the latter in the class using it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-08 22:43:21 +01:00
Konstantina Chremmou
b08e91a470 Do not create a new background worker every time the checks are refreshed; queue
a new check on the existing one instead. Moved the background worker to the designer
of the class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-04 12:09:37 +01:00
Konstantina Chremmou
6b2a9c3944 CA-293153: Moved the logic calculating the resolved precheck actions to be
reverted to the new class UpdateUpgradeWizard which serves as base for the
Patching and the RPU wizards. Pass the list of resolved problems to the
automated updates page and not the actions, so as to prevent premature (i.e.
on creation as opposed to on start) addition to the global list shown on
the Events page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
5728a84e33 Renamed method UnwindChanges to CreateUnwindChangesAction to avoid cofusion, because the method only creates the action and does not run it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
3107c111f0 CA-293153: The logic calculating the resolved precheck actions to be reverted
is now in one place, namely the PatchingWizard_PrecheckPage.UnwindChangesActions.
The pages following this page use now this list instead of the problems
encountered, so we ensure that the update/upgrade plans do not include the
unwind action if no resolution of problems took place on the prechecks page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
741bfaa864 CA-293092: Enhanced the logic of the SuccessfulDescription in the defining
class so the caller won't have to worry about it.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Konstantina Chremmou
7ea811e942 Renamed method SolveImmediately to GetSolutionAction because the old name was misleading: the method creates the action, it doesn't run it.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-07-02 17:37:52 +01:00
Mihaela Stoica
e59b5dcb2b CA-293119: Add the pending master reboot precheck to all wizard modes
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-07-02 15:24:09 +01:00
Ji Jiang
2edacbf43f CA-293092: Add HostCheck class to fix check.Host null exception
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-29 14:27:10 +01:00
Ji Jiang
41e358a8fa CP-28583: Remove host-level selection in Update wizard
1) Always pool level selection of hosts, except uploading sup pack file
from disk.
2) Revert homogeneity precheck change recently. It won't happen in new version
update any more.
3) User can never update slaves to a higher version than master, so delete
master_version_not_compatible_problem.

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-26 12:45:59 +01:00
Ji Jiang
9ae8340913 CP-28280: Add CFU availability precheck to RPU wizard
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-22 12:02:19 +01:00
Joey
abe97def1e CP-28286: Support resume from a partially upgraded pool via Update wi… (#2095)
* CP-28286: Support resume from a partially upgraded pool via Update wizard

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>

* CP-28286: Fix comments of the previous commit

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-06-18 10:46:41 +01:00
Mihaela Stoica
318f20f65f CP-28282: Preliminary work: move the disk space calculation inside the precheck
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-06-13 17:22:52 +01:00
Konstantina Chremmou
723510b853 Removed class Updates.UpgradeSequence.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-05 11:50:34 +01:00
jishengx
0c13d8786d CA-274082: Check status of SR uploaded updates during update installa… (#1937)
* CA-274082: Check status of SR uploaded updates during update installation
* fix review comments

Signed-off-by: Jisheng Xing <jisheng.xing@citrix.com>
2018-03-14 12:19:14 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
de9b0c4d30 Revisited commit 3f2eed35a0 reverting Dictionary to
List in order to enforce the order of checks (the Dictionary is not guaranteed to
keep the order the items are added). Also, extra null check.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
a22a9a41e3 A couple of small inefficiencies.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Konstantina Chremmou
058601f761 CA-279578: Update the Recheck/Resolve button state and error message visibility
alongside the wizard progress buttons. For this purpose, the separate UpdateControls
method was removed and the logic was moved in the EnableNext method. The OnPageUpdated
method that fires this is now called every time the checks start.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Konstantina Chremmou
3f2eed35a0 Refactoring: use a dictionary to hold the list of generated checks; simplified calculation of progress percentage.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-02 13:32:49 +00:00
Mihaela Stoica
6cefd4d202 CA-276976: Add a new precheck in the Update Wizard
- The new "server selection" precheck is added for Inverness or greater pools and checks if all the servers in the pool are selected (if update not already applied) when applying an update that has the "enforce-homogeneity" flag set to true

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-01-12 14:34:50 +00:00
Gabor Apati-Nagy
b589d0dd9e CA-267330: [Update Wizard Improvements] The Update wizard: block the installation of an update on slaves if a reboot or a toolstack restart is pending on master
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-13 13:55:19 +01:00
Gabor Apati-Nagy
a8db7bfae9 Merge remote-tracking branch 'github_xenadmin/REQ-411' into master_REQ-411_merge
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Core/Updates.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
2017-09-29 11:56:46 +01:00
Mihaela Stoica
92b3dc8395 Merge pull request #1757 from xenserver/REQ-420
Merging REQ-420 into master
2017-09-13 12:35:50 +01:00
Mihaela Stoica
4274bf28fb CA-265172: Ensure that the "disk space requirement" precheck is performed for a standalone host in automated updates mode
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-07 14:29:39 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Mihaela Stoica
dc2968b3d4 CP-24215: Add null checks when we log the minimal patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-09-01 15:34:58 +01:00
Mihaela Stoica
85d57f558f CP-24215: If the Automated Updates mode goes to a new version, also apply this version's minimum patches
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-08-29 17:00:58 +01:00
Mihaela Stoica
86d2acee7f Merge branch 'master' into REQ-411
Conflicts:
	CFUValidator/CFUValidator.cs
	CFUValidator/OutputDecorators/XenCenterUpdateDecorator.cs
	CFUValidator/OutputDecorators/XenServerUpdateDecorator.cs
	XenAdmin/TabPages/ManageUpdatesPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Actions/Updates/XenCenterVersion.cs
	XenModel/Actions/Updates/XenServerVersion.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.resx
2017-08-23 16:32:39 +01:00
Mihaela Stoica
6e4c5d3548 CA-251630: XenCenter update wizard incorrectly states that some hosts need rebooting and requires suspending VMs
Perform all the prechecks on applicable hosts only (i.e. the hosts that don't have the update applied already), with the following exceptions:
- The HA check, which is performed on the pool master
- The server-side precheck (PatchPrecheckCheck) which will still be performed on all servers in the pool and will show the warning if the update has already been applied on some servers

This commit also adds an override to the HAOffCheck.SuccessfulCheckDescription to show the pool name instead of the master's if the check is successful.
Also, in the PatchPrecheckCheck, I had moved the code that checks if the patch is already applied to the very beginning (before the host liveness check), so it will return the warning that the server will be skipped even if the server is not reachable

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-04 14:32:36 +01:00
Mihaela Stoica
47ccbd4581 Merge remote-tracking branch 'upstream/REQ-411' into REQ-411
Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.resx
2017-03-28 12:44:54 +01:00
Mihaela Stoica
40680b09ea CP-21574: Add checkbox on the Select Servers page for applying all the released updates after the new version is installed
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-27 16:12:49 +01:00
Gabor Apati-Nagy
6051949227 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:54:57 +01:00
Gabor Apati-Nagy
0ac4cd5014 CP-21504: Added check for restart (for the version update)
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 15:29:44 +01:00
Gabor Apati-Nagy
bd2fa92cbb CP-21504: Added check for restart (for the version update)
as we are expecting that to require a host-restart

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:36:11 +01:00
Gabor Apati-Nagy
77daf14629 CP-21504: minor fix
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-03-27 14:34:20 +01:00
Mihaela Stoica
4bfbcc5f83 CP-21504: Add automated updates license check for the new versions that are available as updates 2017-03-27 11:11:26 +01:00
Mihaela Stoica
1896d9f958 CP-21504: Updates wizard: Automated mode for new versions that are available as updates
Introduced the WizardMode enum and the WizardMode  properties in several wizard pages (replacing the IsInAutomatedUpdates boolean property)
When in NewVersion mode, we show the same wizard pages as the AutomatedUpdates mode and we build the update sequence based on the selected update alert (which is an update to a new version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-24 16:43:19 +00:00
Mihaela Stoica
b65084fdc3 CP-21184: Add a check for the XenCenter version
- On the Updates tab: for new versions, check that the version of XenCenter is at least the latest. If not, give an additional option to download a newer XenCenter (for both updates and upgrades), and not offer "Download and Install" (for updates).
- In the Patching wizard: if the update is a new version, we force the user to first update their XenCenter to the new version
- In the RPU wizard: if the server version is not the latest and their XenCenter version is not the latest from updates.xml, we assume that they want to upgrade to the latest XenServer version and we force the user to first update their XenCenter to the latest version.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-22 10:59:32 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00