Commit Graph

1971 Commits

Author SHA1 Message Date
Konstantina Chremmou
f36fa9ea2f Fixed regressed button height. Also, it seems VS designer has the bad habit of
removing event registration unless it's written out fully like the rest of the
autogenerated code.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-06 09:13:52 +01:00
Konstantina Chremmou
13bc93a5ad UI workaround for CA-220216: swapped the order of checks and put VDI migration
before move; thus, if the SR does not support migration, the user can at least
detach the disk and try a move.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:50:46 +01:00
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Konstantina Chremmou
2ff6f74488 Fixed the following issues:
- Was only able to move and not migrate vdi if selected from the objects view.
- The text on the ToolStripMenuItems on the SrStoragePage was different from the
corresponding buttons.
- Added item move/migrate to the multiple VDI context menu. The Properties item
should not be shown in this case.
2016-09-28 09:50:23 +01:00
Gabor Apati-Nagy
ccaeed67cb CA-223082: Replace PATCH_PRECHECK_LIVEPATCH_MISSING
Replace PATCH_PRECHECK_LIVEPATCH_MISSING to PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE due to changes in XAPI
Note: if XAPI change gets active before this change we will see UNKNOWN instead of PATCH_PRECHECK_LIVEPATCH_NOT_APPLICABLE in XenCenter what will make no difference
2016-09-23 13:35:02 +01:00
Mihaela Stoica
c6eab65fdf Merge pull request #1154 from kc284/master
Some corrections on VMStorage page and disk move/migrate/detach
2016-09-22 15:21:48 +01:00
Mihaela Stoica
8ea8c71f74 Merge pull request #1164 from kc284/master2
Did some work on the SrStoragePage:
2016-09-22 14:12:59 +01:00
Konstantina Chremmou
03639d35b5 Added missing hotkey to the delete toolstripmenuitem; changed the hotkey on the move
toolstripmenuitem so it's the same as the button.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 23:12:54 +01:00
Gabor Apati-Nagy
b09de72f83 Revert "CP-18925: Hide batch hotfixing option in XenCenter" 2016-09-20 15:00:06 +01:00
Mihaela Stoica
e5eeb29e55 Merge pull request #1170 from kc284/master3
CA-100083 (part of): Set minimum width of the main window's tab contr…
2016-09-20 13:57:39 +01:00
Konstantina Chremmou
6bb71ffd23 Merge pull request #1124 from GaborApatiNagy/CA-174979
CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
2016-09-20 13:15:36 +01:00
Konstantina Chremmou
2aa8d956c0 Fixed tab order.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-20 13:10:02 +01:00
Mihaela Stoica
963d5211d6 Merge pull request #1174 from mcintyre94/CA-217821
CA-217821: Renaming home server to target server in VM migration wizard
2016-09-20 11:43:24 +01:00
Mihaela Stoica
a4ffaf239f CA-218242: Don't assign values outside the range in the memory spinner control
- The value of the spinner control is rounded to the nearest, while the minimum is rounded up and the maximum down (or, in some cases, min and max are not rounded at all).
In most cases this is fine, but if the current value (in bytes) is equal to one of these ranges, by rounding this way we might end up with a value that is outside of the control's ranges (causing ArgumentOutOfRange exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 23:14:26 +01:00
Gabor Apati-Nagy
d12481fa0f CA-174979: Confusing right-click add to pool menu (if you accept the defaults)
Leaving the new pool's name field empty, forcing user to enter a name before the Next button is enabled.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-19 18:15:44 +01:00
Callum McIntyre
0c5eaef042 CA-217821: Renaming home server to target server in VM migration wizard
We already renamed the column to target server, this changes the message in the case where the user doesn't choose a server on this page to also use target server.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-19 17:00:02 +01:00
Konstantina Chremmou
2fdf033b25 Merge pull request #1150 from mcintyre94/CA-149965
CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog.
2016-09-19 12:22:48 +01:00
Mihaela Stoica
65db5e3320 Merge pull request #1171 from mcintyre94/CA-219777
CA-219777: Bad progress dialog message
2016-09-19 12:03:57 +01:00
Callum McIntyre
6136f70d13 CA-219777: Bad progress dialog message
The bad message was in the dialog created in the BugToolWizard after selecting servers. Since this method is the only one using the ActionProgressDialog(String) constructor, I've modified that ctor to hide the subaction label - which makes sense because there is no action in that ctor (to set a subaction) and no other appropriate label.
2016-09-19 11:31:48 +01:00
Callum McIntyre
c9dc5af32d CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog
Shorten the ellipsise to the first 40 characters instead of 45, which allows the ellipsis, quotation and question marks to fit correctly onto the line.
2016-09-19 10:37:48 +01:00
Mihaela Stoica
db9eea0cf6 Merge pull request #1168 from sriharshak/master
L10N: Ely:Translation check-ins
2016-09-18 07:12:27 +01:00
Konstantina Chremmou
565f95291d CA-100083 (part of): Set minimum width of the main window's tab control to 40% to
avoid buttons on the console tab overlapping. Removed some panels from the console
tab to reduce control nesting.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-17 01:23:55 +01:00
Gabor Apati-Nagy
bd7d6bcc9c CP-18925: Hide batch hotfixing option in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-16 14:04:10 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Stephen Turner
3154a0bd92 CA-220440: Remove CLM link from XenCenter home page 2016-09-14 15:31:21 +01:00
Konstantina Chremmou
9a26b3cb2e Did some work on the SrStoragePage:
- show/hide the context menu items instead of creating and adding new ones each time the context menu opens
- right click menu with rescan/add was not available for empty list or when empty space was clicked
- the condition for the edit button was slightly different from the edit toolstripmenuitem
- improved button layout (part of CA-100083)
- tidied up button event handlers and renamed one or two class members
- removed unused parameter in constructor and method of VDIRow

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-14 09:06:19 +01:00
Konstantina Chremmou
0f9c6fbc2f Did some work on the VM storage page:
- fixed issue where the context menu with add/attach items was not available
for empty list or when empty space was clicked; in the latter case I also clear
the selections
- added ability to launch the context menu by using the windows properties button
- moved context menu to the designer; changed code to show/hide the relevant menu
items instead of adding new ones each time the context menu opens
- added icon to the context menu item Properties
- fixed button layout (part of CA-100083), then removed separators between buttons
because when they wrap it looks a bit strange
- fixed some weird cross-threading exception (could not reproduce reliably)
- renamed one or two class members and tidied up the button event handlers

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-13 01:29:47 +01:00
Gabor Apati-Nagy
fdb32cf579 CA-220599: Supplemental Pack installed via XenCenter does not get listed in updates box
Fixed regression caused by 5555709337.
Supplemental packs can now be installed again in automatic mode.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-09-12 17:07:59 +01:00
Konstantina Chremmou
f4dfbe83b4 Merge pull request #1155 from MihaelaStoica/CA-220613
CA-220613: Truncation on the Migration Network page of the Cross Pool…
2016-09-12 09:02:28 +01:00
Konstantina Chremmou
6298a7e885 Do not calculate twice the VMs to move or migrate. Text improvement.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-09 18:52:38 +01:00
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
Mihaela Stoica
8bf507e634 CA-220613: Truncation on the Migration Network page of the Cross Pool Migration wizard
Fixing regression introduced in commit 3a5444ceb2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-08 12:01:56 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Konstantina Chremmou
d2a3a17369 Fixed typos.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 14:53:46 +01:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Callum McIntyre
7b78038a2b Revert "CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog."
This reverts commit 79f734f0ff.
2016-09-06 09:48:34 +01:00
Gabor Apati-Nagy
b12f488ffd Merge pull request #1147 from MihaelaStoica/CA-220040
CA-220040: Patching wizard shows reboot required where it is not expected
2016-09-05 12:05:12 +01:00
Gabor Apati-Nagy
6065465a52 Merge pull request #1148 from MihaelaStoica/CA-220049
CA-220049: Non-livepatch hotfix installation is failing
2016-09-05 12:05:06 +01:00
Gabor Apati-Nagy
531613b037 Merge pull request #1149 from MihaelaStoica/CA-220171
CA-220171: Configure HA dialog incorrectly states failover tolerance …
2016-09-05 12:02:06 +01:00
Callum McIntyre
79f734f0ff CA-149965: Snapshot name is truncated on “Revert To Snapback” dialog.
Changed the ellipsise length from 45 to 90 characters. This means that the first row of text becomes variable length, so I've reworked the dialog to support this and work like others: icon/rows of text in table cells, right aligned flow panel for buttons.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-02 17:47:23 +01:00
Mihaela Stoica
7764a6bf9f Merge pull request #1145 from mcintyre94/CA-140338
CA-140338: Truncation on New Search Page with long Custom Field Filters name
2016-09-02 11:25:59 +01:00
Mihaela Stoica
8755126e8d Merge pull request #1144 from mcintyre94/CA-112317
CA-112317: Sorting on SR storage tab is incorrect
2016-09-02 11:17:55 +01:00
Mihaela Stoica
8e077e1e78 CA-220171: Configure HA dialog incorrectly states failover tolerance would be 0
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-02 10:46:33 +01:00
Mihaela Stoica
12a025a253 CA-220040: Patching wizard shows reboot required where it is not expected
- When building the list of servers that require post-install actions, ignore the ones where the patch has already been installed.
- Also fixing the infinite recursion in Build() method (causing StackOverflowException when installing a supplemental pack).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:36:11 +01:00
Mihaela Stoica
b1728ee125 CA-220049: Non-livepatch hotfix installation is failing
This fixes the NullReferenceException that occurs when trying to evacuate a host after a non-livepatch update (that requires reboot) has been installed

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 17:14:21 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00
Mihaela Stoica
b758e0660a Resurrect CP-18011: [XenCenter] Add live patching checkbox
(reverting  8a10351c5d: Revert "Cp 18011: [XenCenter] Add live patching checkbox")

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-01 14:59:37 +01:00