Commit Graph

344 Commits

Author SHA1 Message Date
Konstantina Chremmou
775ee87bab CA-220511: Fixed issue where it was not possible to migrate the VDI of a VM without
home host from a shared to a local storage (while it was possible from the CLI).
Minor refactoring.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 23:14:25 +01:00
Konstantina Chremmou
eb3fbe2ac8 Corrections and refactoring on VDI move/migrate:
- Allow move of multiple VDIs
- CA-187659: show better messages when batching move/migration of multiple VDIs.
- Show different tooltips for single vs. multiple VDI move/migration/deletion.
- Refactored the MoveDiskDdialog. Removed the inherited class VDIMigrateDialog and
the batching manager as it was not very different from its parent, it was registering
the events twice, and was batching migration of even single VDIs.
- Tidied up the Move- and MigrateVirtualDisk commands so they're easier to compare.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-28 09:50:43 +01:00
Mihaela Stoica
a4ffaf239f CA-218242: Don't assign values outside the range in the memory spinner control
- The value of the spinner control is rounded to the nearest, while the minimum is rounded up and the maximum down (or, in some cases, min and max are not rounded at all).
In most cases this is fine, but if the current value (in bytes) is equal to one of these ranges, by rounding this way we might end up with a value that is outside of the control's ranges (causing ArgumentOutOfRange exception).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-19 23:14:26 +01:00
sri harsha tagore k
49ef8a3aad L10N: Ely:Translation check-ins 2016-09-15 16:47:31 +05:30
Mihaela Stoica
1bb49758ff Merge pull request #1151 from huazhihao/CA-218956
CA-218956: Expose HIMN when showing hidden objects
2016-09-08 13:10:38 +01:00
John Hua
b0638bb4f5 CA-218956: Expose HIMN when showing hidden objects
Expose both the HIMN network and any VIFs associated with the HIMN
network using XenCenter when the "View->Show Hidden Objects" option
is displayed. However the shown HIMN should not be able to autoplug,
edit or delete.
2016-09-08 17:48:25 +08:00
Mihaela Stoica
4623d65a4d Merge pull request #1138 from kc284/master
CA-215575: Top connection bar on full screen console was not listening to server events
2016-09-06 10:53:35 +01:00
Konstantina Chremmou
4cdb24dd29 CA-215575: Corrected regression as requested per code review: the full screen
console should appear on the same monitor as the main form.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-09-06 10:32:49 +01:00
Callum McIntyre
c36f160327 CA-140338: Truncation on New Search Page with long Custom Field Filters name
Accidentally left an extra piece of ellpising in the wrong place, now removed.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-09-01 15:03:43 +01:00
Callum McIntyre
3295dc845d CA-140338: Truncation on New Search Page with long Custom Field Filters name.
The truncating of the custom field name by space (instead of ellipsising) seems to be a Windows default, but it's not ideal. This change edits the text displayed in the dropdown when an item is selected so that if a custom field is selected it is ellipsised to an appropriate length. It doesn't affect the dropdown itself, which continues to display the full custom field name.
2016-09-01 15:00:06 +01:00
Konstantina Chremmou
9b7f90ccb4 CA-215575 plus refactoring: The connection bar does not need to manipulate anything
other than strings. Moved settings of the FullScreenForm from the VNCTabView to
the former class. The FullScreenFormof the VNCTabView is only initialised as
FullSCreenFrom so no casts are necessary. The FullScreenForm is responsible for
updating the connection bar text with the value obtained from the vncScreen everytime
the name of the connection changes. Also reduced visibility of certain members.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 13:51:50 +01:00
Konstantina Chremmou
38ca217bc3 Tidied up: moved the full screen message from the VNCTabView class to the more relevant
FullScreenHint class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-24 01:38:51 +01:00
Callum McIntyre
93518392a8 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
Remove the old value, leaving only the new one

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-09 10:31:55 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Mihaela Stoica
aa78621897 Merge pull request #1069 from kc284/master
CA-136768: Fixed bad layout of buttons at the top of the snapshots ta…
2016-07-26 14:43:33 +01:00
Gabor Apati-Nagy
f6139c713a CA-213728: Going to Home Server tab can change home server
Even though the correct row have been selected by the time the grid becomes visible, it is not displayed properly. This change set fixes the problem by selecting the row again.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 14:31:55 +01:00
Konstantina Chremmou
2fd3a91ee6 CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-20 00:04:06 +01:00
Frezzle
25d54119f3 Merge pull request #1062 from MihaelaStoica/CA-107240
CA-107240: VDI move window shows incorrect message for broken storage…
2016-07-14 11:21:07 +01:00
Mihaela Stoica
f96b36f06e CA-107240: VDI move window shows incorrect message for broken storage as ‘Local storage must belong to resident host’
Added null check for SR.Connection, displaying a different message if its null.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-14 11:16:19 +01:00
Konstantina Chremmou
ea60eaa24e Merge pull request #1065 from xenserver/CAR-2217
Request to merge CAR-2217 into master
2016-07-11 14:11:00 +01:00
Mihaela Stoica
ae4670c3b1 CA-107240: VDI move window shows incorrect message for broken storage as ‘Local storage must belong to resident host’
Also fixed a similar issue, where the broken SR was selectable (Create new virtual disk from the SR Storage tab)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-08 11:48:29 +01:00
Konstantina Chremmou
7528cefce4 Do not show the CVM's own name on its console, but rather a description including the host's name. 2016-07-08 09:19:39 +01:00
Konstantina Chremmou
336681fc6a Fixed regression introduced in previous commit. Also, the MultipleDvdIsoList on the
VMstorage page uses the default colours of the controls, hence we only need to set
them on the VNCTabView and the linklabel does not need to be public.
2016-07-06 08:55:28 +01:00
Konstantina Chremmou
094e4c4c4f CP-18028: For hosts with more than one control domain (dom0 and cvm at the moment) add an extra tab to display the console of the cvm. 2016-07-05 08:14:13 +01:00
Konstantina Chremmou
8991a257d2 Removed some unnecessary methods; changed visibility for controls that don't need to be public. 2016-07-04 23:05:51 +01:00
Konstantina Chremmou
04ffdbadc5 CP-17756: Do not use the field VM.is_control_domain to find the console for the
host as it applies to other control domains too. Use the new Host.control_domain
field instead. Minor refactoring.
2016-07-04 13:22:08 +01:00
Konstantina Chremmou
94df31b878 Removed call of virtual member in the constructors. 2016-07-04 08:22:35 +01:00
Konstantina Chremmou
f1b7aadc88 Fixed issue where the error message was not displayed if connection to the host console was not possible.
Refactored to hide/show error controls instead of adding/removing them. Removed duplicate null check.
Do not use a second list to track active VM consoles.
2016-07-03 17:45:49 +01:00
Konstantina Chremmou
8a8bdc21e6 Tidied up the ConsolePanel; moved designer code to the corresponding file and removed setting of virtual field from the constructor. 2016-07-01 17:47:41 +01:00
Konstantina Chremmou
d35c162e76 CP-17689: Restrict maximum host failures to tolerate to the number specified by the other-config:hci-limit-fault-tolerance field. 2016-06-29 12:57:29 +01:00
Konstantina Chremmou
fd3393049c Code simplification: use Action delegate instead of EventHandler since the event is not sending any objects when triggered. 2016-06-27 10:20:23 +01:00
Frezzle
7faf4fad1d Merge pull request #1032 from MihaelaStoica/CP-17161
CP-17161: Add 'using' statement around dialogs to ensure garbage collection
2016-06-23 15:52:32 +01:00
Konstantina Chremmou
bdbd9e1f55 CP-17502: No directly related to this ticket, but I found myself in the ISO SR neighbourhood and did some minor refactoring. 2016-06-21 10:29:37 +01:00
Mihaela Stoica
da9e99b1cb CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix ActionProgressDialog usages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 13:17:42 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Frederico Mazzone
acf39533fe [CA-207306] Select box is not in line with pGPU bar on GPU tab of host
The last pGPU's row was stretching to the bottom, causing the lowest select box to fill its space and go down too much.
Changed the select boxs' dock style and margin.

Signed-off-by: Frederico Mazzone <fredericom@citrite.net>
2016-06-13 15:16:31 +01:00
Liang Dai
2a874bbf40 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-06 15:55:40 +08:00
Liang Dai
fd5c7773f5 CA-150197:EN: Improvement: No confirmation message to ask if certain to delete Scheduler
Signed-off-by: Liang Dai <liang.dai1@citrix.com>
2016-06-03 14:19:59 +08:00
Mihaela Stoica
3f7f33fc40 CA-210732: XenCenter VM properties GPU always shows "None" (#983)
* CA-210732: XenCenter VM properties GPU always shows "None"

The error occurs when there is a gpu group with only one vgpu type: When setting the selected item in the vGPU combobox, XenCenter tries to select the group header instead of the vGPU type; because the group header is not selectable, we then default to "None".
With this fix, we ensure that two items are not equal if one is a group header and the other is a subitem.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Changes following code review: Added the reverse case in the Equals function

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-210732: XenCenter VM properties GPU always shows "None"

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-05-12 13:44:16 +01:00
Mihaela Stoica
aeb64f04e0 Merge pull request #948 from stephen-turner/CA-137301
CA-137301: Double-click should choose item in Move VM/VDI dialogs
2016-04-27 14:47:23 +01:00
CITRITE\sriharshak
809bf9161e L10N:Dundee translation changes 2016-04-26 16:39:21 +05:30
CITRITE\sriharshak
f600cb53a5 L10N:CA-205536 fix 2016-04-21 23:14:03 +05:30
CITRITE\sriharshak
f043573688 L10N:CA-207887 fix 2016-04-21 18:28:36 +05:30
Stephen Turner
30dfce6a7b CA-137301: Add null checks, following code review 2016-04-20 17:18:46 +01:00
CITRITE\sriharshak
8c0623b8f2 L10N:Dundee:Translation check-ins 2016-04-20 19:16:33 +05:30
Stephen Turner
953ea412df CA-137301: Double-click should choose item in Move VM/VDI dialogs 2016-04-18 16:17:01 +01:00
CITRITE\sriharshak
ef8628ff92 L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
Mihaela Stoica
ee0b20e626 Merge pull request #893 from GaborApatiNagy/master_CA-202417
CA-202417: New VM Wizard Memory Modify button is not working reliably…
2016-03-11 13:49:49 +00:00
Gabor Apati-Nagy
8091a9bc63 CA-202417: New VM Wizard Memory Modify button is not working reliably when specified in MB
Now we set Increment exactly as on other pages
when the unit is MB: the increment it will be calculated dynamically (1, 2, 4,...)
when GB, increment will be 1 GB for values >=10GB, 0.1GB otherwise

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-10 11:52:04 +00:00
Gabor Apati-Nagy
eb3d6b30a6 CA-201576: *Windows Update* filter search in XC not properly fit into box
Resized them accordingly

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-03-02 17:37:28 +00:00