Commit Graph

3103 Commits

Author SHA1 Message Date
Gabor Apati-Nagy
21bcf546d2 Merge pull request #1098 from mcintyre94/CA-150200
CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
2016-08-08 15:26:20 +01:00
Callum McIntyre
0b67303f77 CA-150200: EN: Duplicate hotkeys for “Storage” and “Show Columns” under Citrix XenCenter.
New hotkey for "Show columns" is alt+C

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-08 15:10:51 +01:00
Konstantina Chremmou
e9ca8b529a CA-217843 best effort: Run RestoreDismissedUpdates action asynchronously to prevent UI hiccups.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 14:37:47 +01:00
Mihaela Stoica
529e921e24 Merge pull request #1078 from kc284/CA-147657
CA-147657 plus some refactoring
2016-08-08 13:47:59 +01:00
Konstantina Chremmou
c30938ff12 CA-217843: Fixed various issues on the select patch page: control tab order; some
hotkeys; button enabled state; some memory leaks; added spinner while check for
updates is in progress; added alternative text for when automatic mode is not available.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-08 11:41:42 +01:00
Gabor Apati-Nagy
f93a977ddf CA-217382: Batch updates: Install batch updates is not showing low disk space error in pre-checks when host dom0 is full
Implemented pre-check to check whether there is enough free disk space
before starting updating a pool.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-05 18:05:09 +01:00
Konstantina Chremmou
9d05bcdce5 CA-33357: Improvements: show the disk name on the New VM storage page so it is
more obvious to the user that they can edit it. To this purpose change the button
Properties to Edit (and do the same on the Networking page for consistence). Also
show the name of the disk (ellipsized if too long) on the wizard's finish page.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-05 16:02:03 +01:00
Mihaela Stoica
56038e3eba CA-210549: Make MultipleAction and ParallelAction cancellable
- The multiple action is cancellable if is at least one sub action is not completed
- When a multiple action is cancelled, we try to cancel all sub actions that are not completed
- Also changed the way we calculate the percent complete for the parent action, to report partial progress of the sub actions

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-05 15:46:07 +01:00
Konstantina Chremmou
1065ca14eb Merge pull request #1088 from MihaelaStoica/CA-217449
CA-217449 &  CA-173661 - Control domain memory alert fixes
2016-08-05 12:27:31 +01:00
Mihaela Stoica
7186860cc2 CA-217390: Hotfix wizard: Add null reference check in the function that builds the list of post-update tasks.
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:31:34 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Mihaela Stoica
c3f85c7a99 Merge pull request #1091 from GaborApatiNagy/master_batch_new2
CA-216854: Fixed error messages shown
2016-08-04 14:31:19 +01:00
Mihaela Stoica
5a7e4185a9 Merge pull request #1092 from kc284/bugfix
CA-104472: Refactoring and removal of duplicate code. This also fixes…
2016-08-04 09:59:25 +01:00
Konstantina Chremmou
dbef554ac0 CA-104472: Refactoring and removal of duplicate code. This also fixes descrepancies
in the calculation of the never-expiring licence ("greater than 3653 days" in
LicenceAlert and LicenceStatus vs "greater than or equal to 3653 days" elsewhere).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-08-03 21:07:04 +01:00
Gabor Apati-Nagy
0ae6568a60 CA-216854: Fixed error messages shown
Now the wizard shows localized and friendly error messages instead of error codes

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-03 17:15:57 +01:00
Mihaela Stoica
d7ba62e025 Merge pull request #1090 from GaborApatiNagy/master_batch_new2
CA-217232: Batch updates: Install Dundee released hotfixes in Batch f…
2016-08-02 18:04:59 +01:00
Gabor Apati-Nagy
90653493c5 CA-217232: Batch updates: Install Dundee released hotfixes in Batch fails with wrong message in hotfix wizard
Despite the update sequences are correct by host, when they are flattened, the original order (order in minimal patches) was not considered properly, so a missing patch was scheduled for later in the sequence than it should have been, thus the upgrade failed with a precheck-error.

This bug occurs when we are given
* a pool of more than one host,
* with (at least) patchA not installed on 2 or more hosts
* patchA requires patchR that is not installed on at least one of the above hosts (but not not on all)
* the host that is missing patchR is ahead of other hosts in pool.Hosts.Cache

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 16:58:24 +01:00
Mihaela Stoica
2c8b542e44 Merge pull request #1089 from GaborApatiNagy/master_batch_new2
CA-216935: Fixed a bug that can occur when multiple pools are being u…
2016-08-02 16:09:48 +01:00
Gabor Apati-Nagy
48ef276c06 CA-216935: Fixed a bug that can occur when multiple pools are being updated with the same update and one of the prechecks happen before the other pool is finished applying the update
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-08-02 14:30:20 +01:00
Mihaela Stoica
35fb115358 CA-173661: Control domain memory alert setting not showing up in the tab subtitle on Host Properties dialog
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-01 12:24:25 +01:00
Mihaela Stoica
bd497356f6 CA-217449: Dom0 VM properties should not be visible in XenCenter
- The "Alarm Settings" action on Alerts page should open host's properties dialog for Dom0 alerts
- Also added help id for the Control Domain Memory Usage alert
2016-08-01 12:21:19 +01:00
Gabor Apati-Nagy
8e30dc32b7 Merge pull request #1087 from Frezzle/CA-214622
CA-214622: Confusing info shown on Install Update screen
2016-08-01 11:41:20 +01:00
Frezzle
c97787f8f4 Merge pull request #1086 from kc284/master
Fixed issue on the New SR wizard where the SR type details panel was not populated when the default checked button was invisible.
2016-07-28 15:02:46 +01:00
Frezzle
9dd0c41e7a [CA-214622] XenCenter Install update Wizard Confusing Info shown on Install update screen
Changed message to "Deleting update installation file ..." to match wording in previous page of the wizard.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-28 13:50:09 +01:00
Konstantina Chremmou
e8a009678f Fixed issue on the New SR wizard where the SR type details panel was not populated
when the default checked button was invisible.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-28 13:16:49 +01:00
Mihaela Stoica
aa78621897 Merge pull request #1069 from kc284/master
CA-136768: Fixed bad layout of buttons at the top of the snapshots ta…
2016-07-26 14:43:33 +01:00
Mihaela Stoica
54849d4f5e Merge pull request #1084 from GaborApatiNagy/master_CA-213728
CA-213728: Going to Home Server tab can change home server
2016-07-25 16:45:45 +01:00
Gabor Apati-Nagy
3ca0db4b98 Merge pull request #1072 from Frezzle/CA-209198
CA-209198: Allowed to attempt to install hotfix when it is already applied
2016-07-25 15:04:21 +01:00
Gabor Apati-Nagy
f6139c713a CA-213728: Going to Home Server tab can change home server
Even though the correct row have been selected by the time the grid becomes visible, it is not displayed properly. This change set fixes the problem by selecting the row again.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 14:31:55 +01:00
Mihaela Stoica
e1c78203d5 Merge pull request #1083 from GaborApatiNagy/master_CA-213278
CA-213281, CA-213278: OK fixed
2016-07-25 14:22:09 +01:00
Gabor Apati-Nagy
a1bb0846e8 CA-213281, CA-213278: OK fixed
Bugs fixed:
* OK button not re-enabling when switching back to using existing credentials in Health Check Enrollment dialog
* Using empty credentials to authenticate with Citrix Insight Services does not disable OK button in Health Check Enrollment dialog

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-25 13:54:47 +01:00
Mihaela Stoica
b739b74abc Merge pull request #1080 from sriharshak/master
L10N:Fix:[CTXS] (IN-215) Translate fail for the description when crea…
2016-07-25 09:22:01 +01:00
CITRITE\sriharshak
853f01b961 L10N:Fix:[CTXS] (IN-215) Translate fail for the description when create a new disk 2016-07-25 13:47:55 +05:30
Mihaela Stoica
9b9e9f87a8 Merge pull request #1076 from kc284/bugfix
Fixed bugs CA-207901 and CA-149814
2016-07-25 09:14:39 +01:00
Konstantina Chremmou
cce9d5b1ce Refactoring: (1) Simplified the logic for gathering the can't-execute-reasons for
a selected item collection - there was no need to make temporarily each one of them
the command selection just to call CanExecute on them. (2) Do not mix the methods
returning the can't-execute-reasons (which can be unknown) with the tooltip property
(which can be null).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:01:05 +01:00
Konstantina Chremmou
1bbec00d57 CA-147657: Allow setting the ToolTipText for the command ToolStripButtons and ToolStripMenuSubitems
to null, otherwise the wrond text is shown for items with null can't-execute-reason
that are selected after items with non-null can't execute reason.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:53 +01:00
Konstantina Chremmou
d32b7a967b Added overload for the SelectedItemCollection constructor taking one item - it seems to be needed as often as the other constructors.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-25 01:00:44 +01:00
Konstantina Chremmou
13e6a73fa5 Merge pull request #1074 from MihaelaStoica/CA-216697
CA-216697: MTU message present on the Network Settings page when crea…
2016-07-22 20:38:44 +01:00
Konstantina Chremmou
b9b00ca4cd CA-149814: Added short description to fill in the redundant space on the top of the
FolderBrowser dialogs. Fixed text which caused label to look unaligned. Prevent
crash when attempting to launch the DownloadAppliance dialog with "http://" as URI.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-22 08:31:58 +01:00
Konstantina Chremmou
dae95e1065 CA-207901: Fixed grammar in the vGPU description (error manifested itself on the Assign vGPU page in the NewVM wizard).
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-21 22:21:26 +01:00
Mihaela Stoica
6078612916 Merge pull request #1071 from Frezzle/CA-214622
CA-214622: XenCenter Install update Wizard Confusing Info shown on Install update screen
2016-07-20 10:37:19 +01:00
Mihaela Stoica
d739823b02 Merge pull request #1073 from kc284/CA-192541
CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk …
2016-07-20 10:34:48 +01:00
Mihaela Stoica
2e62dc8476 CA-216697: MTU message present on the Network Settings page when creating an internal network
In the New Network wizard, when the "Single-Server Private Network" type is selected, the Network settings page should not display the MTU hint message, because it is not relevant to any controls on the page

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-07-20 10:26:12 +01:00
Konstantina Chremmou
2fd3a91ee6 CA-136768: Fixed bad layout of buttons at the top of the snapshots tab page. Also fixed text alignment on the chevron button.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-20 00:04:06 +01:00
Konstantina Chremmou
917754c937 CA-192541: Added detail to the Import/Export OVF/OVA and Import Disk Image actions
title so we can tell the one from the other. For consistency I used a format similar
to Import/export XVA. I also removed the gerund from the latter as it cannot be
used when the action is completed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-07-19 23:53:17 +01:00
Frezzle
5555709337 [CA-209198] Allowed to attempt to install hotfix when it is already applied
XenCenter no longer ignores checking if the master host already has the specified patch applied; it now checks before trying to apply it, which means we get no error in the Patching Wizard's Patching Page.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 17:49:40 +01:00
Frezzle
0e133fb415 [CA-214622] XenCenter Install update Wizard Confusing Info shown on Install update screen
Changed confusing message from "Removing update ..." to "Removing update file ...".

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-07-19 14:18:58 +01:00
Mihaela Stoica
abc58d92af Merge pull request #1070 from GaborApatiNagy/master_batch_new2
CA-216162, CA-215573
2016-07-19 10:09:44 +01:00
Gabor Apati-Nagy
893275fb2f CA-215573: Batch updates: Install update wizard "Finish" button activated even when batch install still in progress
Trivial changeset

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:25:17 +01:00
Gabor Apati-Nagy
a007eec882 CA-216162: Batch updates: Wrong hover message on install update wizard when installing batch updates
Better messages on Select Server Page

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-07-19 09:12:30 +01:00