Commit Graph

93 Commits

Author SHA1 Message Date
Konstantina Chremmou
41e6c6b3ca Reworked commit c0af621167 as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 16:20:17 +01:00
Konstantina Chremmou
c0af621167 A couple of random corrrections on error handling (#2265)
* Correct out of range percentage and throw an assertion instead of silently
logging it so we can fix the causes of it. Compacted method logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Exception handling: prevent InvalidOperationException if the health check service
is not found on the computer (installation is optional).
Do not throw exception and handle if the task handle is invalid, but rather
throw it only for other cases of task.status being failure.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-12 13:36:44 +01:00
Konstantina Chremmou
365889a018 Compacted overload of method EndConnect.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
c3fcffa236 When we end the connection call OnConnectionClosed instead of OnConnectionStateChanged.
This avoids firing the ConnectionClosed event explicitly after EndConnect;
it also avoids refreshing explicitly the tree as the main Window handles the
ConnectionClosed event which requests a refresh.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
eedba61938 Minor language corrections and removal of duplicate message.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-09-21 02:08:54 +01:00
Konstantina Chremmou
8d6b615841 Check and plug PBDs for VMs only if and when there are VMs to migrate; do not log
a message in this case as the SRs are reconnected after reboot and this may lead
to duplicate messages. Also, simplified check-and-plug methods for PBDs to avoid
repetition of iterations.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-06-27 07:58:55 +01:00
Ji Jiang
9ddb253ec0 CP-26866: Add a specific warning when creating a bond on cluster network
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2018-05-23 16:47:59 +01:00
Konstantina Chremmou
a8efbbfba2 CA-286574: Fixed issue where the DR metadata were not loaded from the VDI because
the action was failing to create a metadata session; the latter was due to accessing
directly properties of the xmlrpc proxy which is null since we use the jsonrpc backend.
Also fixed some more areas where the same might occur.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-09 10:45:27 +01:00
Mihaela Stoica
cab6a051b8 Merge branch 'REQ-477' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenModel.csproj
2018-04-04 09:59:29 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Jisheng Xing
530462ad41 CP-26491: modify IsPhysical function and Properties dialog according to SR-IOV 2018-03-23 14:26:03 +08:00
Konstantina Chremmou
29cdf221bc Cleared some level 4 warnings.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-22 15:07:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Konstantina Chremmou
c5b0af533e Removed methods GetHostBootTime and GetHostAgentTime because they duplicated logic
in the Host extensions. Moved method TryResolveWithTimeout to the Connection class
where it is more relevant. Removed wrapper methods WaitForReboot and WaitForAgent
as they were not particularly useful.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-06 14:17:16 +00:00
Mihaela Stoica
ff05fb698c Merge remote-tracking branch 'upstream/master' into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

# Conflicts:
#	XenModel/XenAPI/Auth.cs
#	XenModel/XenAPI/Blob.cs
#	XenModel/XenAPI/Bond.cs
#	XenModel/XenAPI/Console.cs
#	XenModel/XenAPI/Converters.cs
#	XenModel/XenAPI/Crashdump.cs
#	XenModel/XenAPI/DR_task.cs
#	XenModel/XenAPI/Event.cs
#	XenModel/XenAPI/Feature.cs
#	XenModel/XenAPI/GPU_group.cs
#	XenModel/XenAPI/Host.cs
#	XenModel/XenAPI/Host_cpu.cs
#	XenModel/XenAPI/Host_crashdump.cs
#	XenModel/XenAPI/Host_metrics.cs
#	XenModel/XenAPI/Host_patch.cs
#	XenModel/XenAPI/JsonRpcClient.cs
#	XenModel/XenAPI/LVHD.cs
#	XenModel/XenAPI/Maps.cs
#	XenModel/XenAPI/Message.cs
#	XenModel/XenAPI/Network.cs
#	XenModel/XenAPI/PBD.cs
#	XenModel/XenAPI/PCI.cs
#	XenModel/XenAPI/PGPU.cs
#	XenModel/XenAPI/PIF.cs
#	XenModel/XenAPI/PIF_metrics.cs
#	XenModel/XenAPI/PUSB.cs
#	XenModel/XenAPI/PVS_cache_storage.cs
#	XenModel/XenAPI/PVS_proxy.cs
#	XenModel/XenAPI/PVS_server.cs
#	XenModel/XenAPI/PVS_site.cs
#	XenModel/XenAPI/Pool.cs
#	XenModel/XenAPI/Pool_patch.cs
#	XenModel/XenAPI/Pool_update.cs
#	XenModel/XenAPI/Role.cs
#	XenModel/XenAPI/SDN_controller.cs
#	XenModel/XenAPI/SM.cs
#	XenModel/XenAPI/SR.cs
#	XenModel/XenAPI/Secret.cs
#	XenModel/XenAPI/Session.cs
#	XenModel/XenAPI/Subject.cs
#	XenModel/XenAPI/Task.cs
#	XenModel/XenAPI/Tunnel.cs
#	XenModel/XenAPI/USB_group.cs
#	XenModel/XenAPI/User.cs
#	XenModel/XenAPI/VBD.cs
#	XenModel/XenAPI/VBD_metrics.cs
#	XenModel/XenAPI/VDI.cs
#	XenModel/XenAPI/VGPU.cs
#	XenModel/XenAPI/VGPU_type.cs
#	XenModel/XenAPI/VIF.cs
#	XenModel/XenAPI/VIF_metrics.cs
#	XenModel/XenAPI/VLAN.cs
#	XenModel/XenAPI/VM.cs
#	XenModel/XenAPI/VMPP.cs
#	XenModel/XenAPI/VMSS.cs
#	XenModel/XenAPI/VM_appliance.cs
#	XenModel/XenAPI/VM_guest_metrics.cs
#	XenModel/XenAPI/VM_metrics.cs
#	XenModel/XenAPI/VTPM.cs
#	XenModel/XenAPI/VUSB.cs
#	XenModel/XenModel.csproj
2018-02-27 17:42:18 +00:00
Konstantina Chremmou
63c6b817d5 CA-40854: The Session's uuid is in reality its opaque_ref. Use the opaque_ref so
it's obvious what it is. The Session's uuid will be deprecated from the API bindings.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-02-21 14:08:01 +00:00
Konstantina Chremmou
123db499f5 Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
Konstantina Chremmou
4731d6fb6f Corrections as per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Konstantina Chremmou
9d2bb0b1ed CA-275566: Do not switch to the JsonRpc backend when using a simulator URL.
Restored API version 2.10 in test database. Private member Session._uuid
has been removed from the SDK.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Konstantina Chremmou
d83b91a987 Removed unnecessary XenConnection constructor which was there only to be used by the tests; used an object initialiser instead.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Konstantina Chremmou
c294e6514a Moved method DbProxyIsSimulatorUrl from the dump-all file Helpers.cs to DbProxy.cs where it's more relevant.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Konstantina Chremmou
3fd3a42f71 Removed method NewSession; it's used once and only to set the credentials to their existing values thus adding unnecessary complexity.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-01-24 15:58:16 +00:00
Mihaela Stoica
72071a3334 Merge master into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI/Proxy.cs
2017-12-04 13:37:12 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
serenc
7e7a6d9c46 CP-25551 and CP-25565: Updated branch based on PR comments
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 13:34:38 +00:00
serenc
4837c0a5df CP-25565: Added new classes to cache and project
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 10:35:51 +00:00
Michael Zhao
44851325fe CA-272606: AD user can not log out when closing XenCenter. 2017-11-27 14:50:05 +08:00
Konstantina Chremmou
a170ec33e2 Merge remote-tracking branch 'upstream/master' into REQ-420
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	autogenerated XenModel/XenAPI/* files
2017-11-17 11:53:41 +00:00
kunm
912475a4eb CP-24331 & CP-24135: Add UI support for usb-passthrough on both Host & VM (#1766)
* CP-24331: Add UI for UsbTab and VM Usb Property

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Update XenAPI reference

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Add AttachUsbDialog

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI changes

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Discard UsbList and little refining to code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine UI code

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>

* CP-24331: Refine USBEditPage

Signed-off-by: Kun Ma <kun.ma@citrix.com>
2017-09-27 13:37:17 +01:00
Konstantina Chremmou
4c033a6b44 CP-24196: Initial implementation of switching XenCenter to use the JsonRpc backend.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-13 17:15:11 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Konstantina Chremmou
880d56b30f Renamed method so it's more obvious what it does.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:23 +01:00
Mihaela Stoica
f752f05a1d CA-242134: Remove the VMPP code
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-25 15:37:05 +01:00
Konstantina Chremmou
1a94ab1c5f CA-254412: Moved the XenObjectDownloader out of the XenAPI folder as it is
XenCenter specific and it is not retrieved from the SDK any more. Renamed
EventNextBlockedException to EventFromBlockedException since event.next() is now removed.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-05-24 09:23:47 +01:00
Konstantina Chremmou
6b4dd1d269 CA-254412: Removed legacy events system using event.next().
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-05-23 23:12:06 +01:00
Mihaela Stoica
dba1d05fcc CA-242134: Refuse connection to pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 17:54:26 +01:00
Mihaela Stoica
7a04e5186e Merge remote-tracking branch 'upstream/CAR-2214' into master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	Jenkinsfile
	XenModel/Actions/Updates/DownloadAndUnzipXenServerPatchAction.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2017-02-28 10:30:02 +00:00
Stephen Turner
d1b4b75258 Fix for NRE in fix for CA-214653 2017-02-03 14:57:42 +00:00
Sharath Babu
ee4b2818f6 Merge remote-tracking branch 'xenserver/CAR-2205' into xenserver/VMSS
Signed-Off-by: Sharath Babu <Sharath.Babu@citrix.com>
2017-01-25 13:01:54 +05:30
Konstantina Chremmou
489d8684e4 Merge remote-tracking branch 'upstream/master' into CAR-2214
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	Branding/branding.sh
#	mk/archive-unsigned.sh
#	mk/build.sh
#	mk/bumpBuildNumber.sh
#	mk/copy-build-output.sh
#	mk/declarations.sh
#	mk/tests-checks-cover.sh
#	mk/tests-checks.sh
2017-01-24 14:46:57 +00:00
Konstantina Chremmou
88b4104dac Moved the ProxyAuthenticationMethod enum to the HTTP class so the VNCControl can compile.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-01-20 14:47:04 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Frederico Mazzone
f964fa88c6 Merge branch 'master' into CAR-2214
Conflicts:
	XenAdmin/Core/Registry.cs
	XenModel/Actions/Updates/DownloadUpdatesXmlAction.cs
2016-12-23 14:10:43 +00:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
Konstantina Chremmou
082e4693a8 CA-150412: Removed invocation of XenConnections_CollectionChanged with null parameters;
the objective is to mark the events as ready to fire, whcih can be done directly.
Also, added null checks where GetCollectionForType is used.
2016-10-14 10:32:20 +01:00
Mihaela Stoica
fe2d20eb40 Merge pull request #1207 from Frezzle/CP-19111
CP-19111: Added ability to choose Basic or Digest authentication for proxy server
2016-10-13 15:55:04 +01:00
Frezzle
2f7a938643 [CA-214653] Code clean-up following code review
Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-12 19:25:38 +01:00
Frezzle
3522e2980d [CP-19111] Added ability to choose Basic or Digest authentication for proxy server
2 new radio buttons in Connection Options page, for Basic and Digest; Digest is the default as it's the most secure.
New proxy authentication method setting, which is used to configure XenAPI's HTTP class and the .NET AuthenticationManager (which handles which authentication schemes can be used by the .NET web classes).
The new setting is also transferred and used by the Health Check service.

The bug noted in CA-214653 also occurs here, but the work-around on PR#1201 for that bug will also work for this.

Signed-off-by: Frezzle <frederico.mazzone@citrix.com>
2016-10-12 19:09:35 +01:00