Commit Graph

2801 Commits

Author SHA1 Message Date
Konstantina Chremmou
f92e988866
Merge pull request #3255 from xenserver/feature/nrpe
Merge branch feature/nrpe to master
2023-11-10 10:54:59 +00:00
Bengang Yuan
eda68f60cf CA-384629: NRPE threshold check label mistake 2023-11-02 09:02:55 +00:00
Bengang Yuan
90bcef37e8 CA-384579: Call previous NRPE plugin xapi to resolve certs permission issue 2023-11-02 02:08:54 +00:00
Danilo Del Busso
93da92f1bc
Merge pull request #3250 from xenserver/feature/64-vcpus
Merge full 64 vCPUs support
2023-11-01 11:39:55 +00:00
Konstantina Chremmou
736f338cd2 Added tooltips with the original check names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-11-01 10:47:45 +00:00
Chris
9a80dc9225
CP-40844: Adds download source action that gets the latest source code in the production stage (#3153)
* CP-40844 adds download source action that gets the latest source code in the production stage.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 refactors download file actions

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

Adds source url to branding.sh

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP40844 refactors code and implements reviewers comments, aswell as better message handeling

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 Sorts messages

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 removes stray console logging

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 Changes to use FirstOrDefault to avoid null exceptions/errors

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 removes unessessary usings

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 code tidy up

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 Removes erroneous root tag from merge conflict resolution

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

CP-40844 sorts messages

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 fixes misnamed method and adds sourceurl parameter to brandmanager

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 Source url now uses XCUpdates url and just substitues the name of the file

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 Adds source url to xenadmin-build.ps1

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 defines log4net in each class not just inherited

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 removes unused class variable

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 removes unneeded class variable and uses parent property instead. Simplifies messages for source download and client update.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 reduces public exposure of member variables/properties

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 merges download x file actions into single file.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 overide ReleaseDownloadedContent in DownloadAndUpdateClientAction to handle disposal of FileStream

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 minor fixes/tidy up

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 defaults the download latest source button to be invisible.

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 if there is no client update detected then we shouldnt show a where to save dialog

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 Directs user to xenserver website to download source if automatic update checks are turned off. Renames message OUT_OF_DATE_WEBSITE to WEBSITE_DOWNLOADS

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 updates source param to sourceUrl in XCUpdates.xml

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 moves strings to Messages and applys source name string to relevant places

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 removes sourceurl from brand manager

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* CP-40844 uses string literal rather than string join

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>

* Some more corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

---------

Signed-off-by: Chris Lancaster <Christopher.Lancaste1@citrix.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-30 13:40:18 +00:00
Konstantina Chremmou
ad8ef2e124
Merge pull request #3227 from kc284/xsi-1500-wlb-resume
CA-383040/XSI-1500: Resume WLB when reverting resolved actions after an update
2023-10-27 15:46:08 +01:00
Danilo Del Busso
82ffd50271 CA-379971: Ensure ParallelAction is not waiting on _lock when no actions are running
There is a chance that all actions have completed before we hit the `Wait` call, we need to make sure we don't hit a deadlock.

This can happen if for instance there is only one action, and it is a "dummy" action, such as the one used in the EUA check.

Also I have removed the compound assignment for the `volatile _completedActionsCount` since Visual Studio was flagging it as a "suspicious usage of a volatile variable". I personally don't think it's a problem but better safe than sorry.

Contains minor whitespace fixes, too

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-10-26 11:17:03 +01:00
Danilo Del Busso
14a3539f28 CA-384191: Fix missing values for min VM restrictions
- Min and max should also include the defaults when looking across all templates
- Ensure exception isn't hit unnecessarily when parsing restriction value for VMs
- Allow use of `GetRestrictionValueFromMatchingTemplate` with template objects
- Parallelize `GetRestrictionValueAcrossTemplates` call

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-10-26 00:59:06 +01:00
Konstantina Chremmou
fb9383df11 CP-45226: Added friendly name for new datasource 'hostload'.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-25 11:43:01 +01:00
Bengang Yuan
2ad5fd8792 Resolve NRPE code review comments from Tina. 2023-10-24 15:47:40 +01:00
Bengang Yuan
7dfe809c66 Check NRPE plugin before showing properties dialog. 2023-10-24 15:47:40 +01:00
Bengang Yuan
aac73932ce All the configurations of host in a pool are the same. Fix some review comments. 2023-10-24 15:47:40 +01:00
Bengang Yuan
a720105fb9 Rename private instance class fields name, add parameters changing check, etc. 2023-10-24 15:47:40 +01:00
Konstantina Chremmou
794e1f3fbd Some corrections in wording, code style, C# usage, and null checks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-24 15:47:40 +01:00
Konstantina Chremmou
a20ea5ab6e Moved NRPE related files to the same folder.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-24 15:47:40 +01:00
Bengang Yuan
64c8f43961 CP-44372: Integrate NRPE UI with backend interface 2023-10-24 15:47:40 +01:00
Konstantina Chremmou
56b6a5b26a CA-383650: Removed UI-side-only datasource avg_cpu.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-20 17:42:44 +01:00
Konstantina Chremmou
a3e7f4366e CA-381047: Added friendly name for the new capability 'observer'.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-10-20 17:42:34 +01:00
Danilo Del Busso
afb419af04
CP-44767, CP-44766 & CP-44765: Refactor usage of VM restrictions and add reference_label to OVFs (#3211)
* Tidy up `VM` extension: use `var`
* Tidy up `VM` extension: remove redundant initialisers
* Tidy up `VM` extension: use type keywords when possible
* Tidy up `VM` extension: merge conditional expressions
* Tidy up `VM` extension: remove redundant qualifiers
* Tidy up `VM` extension: remove redundant type arguments
* Tidy up `VM` extension: remove redundant `else`s and parentheses
* Tidy up `VM` extension: fix naming
* Tidy up `VM` extension: misc changes
* Tidy up `VM` extension: use `null` propagation
* Tidy up `VM` extension: fix whitespace
* Tidy up `VM` extension: apply ReSharper Code Cleanup utility
* Tidy up `VM` extension: Fix naming of private string array
* CP-44767: Ignore VM restriction when fetching `MaxVCPUsAllowed`
Instead, fetch the highest available value in all templates for the host.
This means that VMs imported from vhd won't automatically default to `DEFAULT_NUM_VCPUS_ALLOWED`, and that VMs that have been kept across XenServer upgrades won't be limited to the number of vCPUs in their own (possibly outdated) restrictions
* CP-44766: Use value in template with a matching `reference_label` when checking VM restrictions
* Move restriction getters to own region
* CP-44766: Use matching templates to fetch VM restrictions
- Rewrite `GetRestrictions...` methods to perform simpler operations
- Add `GetIntRestrictionValue` and `GetBoolRestrictionValue` wrappers to `GetRestrictionValueFromMatchingTemplate`
- Now all calls to a restrictions first check the template value, with a fall-back to defaults
* CP-44765: Export `reference-label` when generating OVFs
---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-09-29 03:45:17 +01:00
Danilo Del Busso
86fa2f6abf
CA-375900: Prepend \\?\ to file paths when creating streams for archive generation (#3184)
* CA-375900: Prepend `//?/` to file paths when creating streams for archive generation
The string works to enable creation of files with paths larger than 260 characters.
* CA-375900: Add directory support and rename utility method
* Fix whitespace in `ArchiveWriterTest`
* CA-375900: Explicitly enumerate files and directories in `ArchiveWriter`
`Directory.GetFiles` and `Directory.GetDirectories` do not enumerate if paths are longer than 260, even when prepended with `//?/`.
* CA-375900: Add long path tests to `ArchiveWriter`
* CA-375900: Add long path tests to `ArchiveIterator`
* CA-375900: Ensure files are added to folders in archive
* Use a recursive method to add directories and files to archive in `ArchiveIterator`
Also improves progress reporting by basing it on directory count
* Fix typos
* Expand `ArchiveWriterTests` to cover all combinations of directory and path lengths
* Ensure that directories used in recursive `Directory.Delete` calls are using long path format
If files in the directory exceed the 260 character limit, the calls will fail
* Expand `ArchiveIteratorTests` to cover all combinations of directory and path lengths
* Ensure relative path name removes `rootPath`
* Fix typo
* Do not use long paths when importing OVFs
The import uses `DiscUtils` which cannot handle paths prepended with `//?/`
* Remove use of `ToLongWindowsPath` within appliance export
This partially reverts commit 819425855c56c14b937849714b359003465bd2f4.
* Refactoring and some corrections.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-22 15:41:54 +01:00
Konstantina Chremmou
ff0ce939f7 Separated HA and WLB prechecks so the problems can be resolved at the same time.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-19 23:56:22 +01:00
Konstantina Chremmou
884160e779 Simplified the action resolving the WLB-on problem. Also:
Fixed exception handling to avoid unnecessary exception rethrowing and possible cast crash.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-19 23:47:15 +01:00
Konstantina Chremmou
9470e20808 Removed obsolete project CFUValidator.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-12 10:11:58 +01:00
Konstantina Chremmou
dbe71838da Updated to SDK v23.25.0.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-12 10:11:58 +01:00
Konstantina Chremmou
dd98fe6732
CP-45071: Convert XenCenter build scripts to PowerShell. (#3219)
* CP-45071: Convert XenCenter build scripts to PowerShell.
* Removed obsolete variable.
* Pass the timestamp server and the certificate thumbprint as parameters to the build and sign scripts.
* Added further logging and made the verbose output of cmdlets optional.
* Updated README.
* Improved script readability.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-06 15:48:12 +01:00
Konstantina Chremmou
98c3814ce0
Merge pull request #3212 from kc284/oil
Refactored retrieval of values from Messages.resx.
2023-09-04 10:32:46 +01:00
Konstantina Chremmou
89fd16b903 CP-45097: Show product brand alongside the version on the General and Search tabPage.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-09-04 10:32:18 +01:00
Konstantina Chremmou
30e9924b33
Merge pull request #3209 from kc284/tech-debt
CP-40739 (build with VS 2022) and some tech debt
2023-09-01 13:09:05 +01:00
Konstantina Chremmou
c5430d0bd1 CA-381212 : The error is not always Internal Server Error;
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-30 17:08:06 +01:00
Konstantina Chremmou
d990e37a87 Moved two WLB actions to the same folder as the rest of the WLB actions. Removed obsolete messages.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-29 20:57:21 +01:00
Konstantina Chremmou
9c37834bd0 Stop retrieving values from Messages.resx by passing hardcoded strings to the Messages.ResourceManager.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-29 20:57:21 +01:00
Konstantina Chremmou
adec15e2ac CP-40739: Build with VS 2022.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-24 14:19:07 +01:00
Konstantina Chremmou
8644ed3d83 CA-381212 : The protocol is not always HTTP/1.1
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:52:32 +01:00
Konstantina Chremmou
de1120f18b
More fixes including CA-381728, CA-381618, CA-381225 (#3205)
* CA-381728: If no post-update tasks exist, XenCenter should explicitly state so.

Also, livepatches should be shown if other guidance is absent.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing placeholders for building locally without applying branding.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Missing help links.

Also removed scripts that are not used any more.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381618: The HA/WLB off check is a pool, not a host check.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* CA-381225: Corrected order of running update guidance (also uses input from CA-381718).

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* UPDATES_URL has been renamed to XC_UPDATES_URL.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

---------

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-21 13:35:49 +01:00
Konstantina Chremmou
e485a0a803 CA-381215: Try waiting on host.apply_updates if it is not immediately available.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
fe8a28e970 CA-381212, CA-381664: Corrections when fetching list of available updates:
- Try waiting on get_updates if it is not immediately available.
- Log instead of failing when a known (404/500) BadServerResponseException occurs.
- Ensure the UI is refreshed after fetching the list of updates.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-18 14:06:38 +01:00
Konstantina Chremmou
e4b2b67cf5
Merge pull request #3198 from kc284/master
UX improvements: CA-381442, XSI-1476, CA-375740
2023-08-18 10:35:05 +01:00
Konstantina Chremmou
fdd5ca775a
Merge pull request #3202 from kc284/supp-pack
Wording change; corrections for supp-pack installation.
2023-08-17 18:45:26 +01:00
Konstantina Chremmou
351c652813
Merge pull request #3200 from kc284/CA-381502-reason
CA-381502: Show the disabled reason in a new column. Extended the messages shown.
2023-08-17 18:45:02 +01:00
Konstantina Chremmou
82f55229da Changed wording.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-17 12:51:02 +01:00
Danilo Del Busso
d9885d342b CA-381593: Remove CIS privacy policy link from Server Status Report
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-08-16 19:09:28 +01:00
Konstantina Chremmou
0d103e9af6 CA-381502: Improved the disabled reason for new servers.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 21:09:25 +01:00
Konstantina Chremmou
046476cd6e Show a different alert message if the user has never synchronized.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-15 01:20:31 +01:00
Konstantina Chremmou
de18d6449f CA-381216: Corrections to Help URL and message.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 14:58:51 +01:00
Konstantina Chremmou
b32168d8d8 Further work on CA-380738: After updates are applied retrieve the new metadata from the host in order to refresh the server status.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
7fb1bd4eb6 Corrected timespan shown on the out of sync alerts and precheck.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-11 11:02:24 +01:00
Konstantina Chremmou
e4012a7bd5
Merge pull request #3194 from xenserver/master
Master->feature/cdn-updates
2023-08-09 14:20:55 +01:00
Konstantina Chremmou
4fb70e011c CA-380800: Check getting updates is allowed before running the operation. Extended precheck to check sync is in progress.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:54:15 +01:00
Konstantina Chremmou
6eaff6dc54 Rewrote the update application sequence to fix various issues:
- CA-380799: Host evacuation is not needed when the guidance is toolstack restart.
- CA-380796: Sometimes the guidance was applied before the update installation.
- Livepatch notice should be shown only if guidance is not reboot host.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-08-09 13:54:15 +01:00