Commit Graph

48 Commits

Author SHA1 Message Date
Mihaela Stoica
6b26093303 CA-242918: Improve the exception shown in XenCenter if the hotfix upload fails
When a TargetInvocationException is raised, its InnerException property holds the underlying exception, which is what we should display.
Also ellipsise the action description (which could be an error thrown by the upload action) that is displayed on the Upload page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-03-16 11:41:14 +00:00
Mihaela Stoica
b14cc05968 Merge pull request #1397 from letsboogey/master
CA-236114 - Wrong update is installed when two different updates are …
2017-01-23 12:51:03 +00:00
Letsibogo Ramadi
cdfdacd88f CA-236114 - Wrong update is installed when two different updates are uploaded in the same instance of the wizard
Signed-off-by: Letsibogo Ramadi <letsibogo.ramadi@citrix.com>
2017-01-23 12:36:47 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
Gabor Apati-Nagy
7ce6d50ed0 CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Reset both before any upload as the upload is going to set the correct one anyway

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-21 10:37:06 +00:00
Gabor Apati-Nagy
9bd776c83d CA-236547: Unexpected error while applying hotfix on multiple Xenservers of different version
Fixing the error, so the hotfix installation will fail as and where it is expected

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-12-19 18:00:42 +00:00
Mihaela Stoica
508f638b3a CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added a new method in XenTabPage which the derived classes can implement to select a default control after the page is loaded.
- Added a new wizard test that runs through the wizard by pressing the Enter key and checks if it has landed on the right page.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-08 14:52:21 +00:00
Gabor Apati-Nagy
7790c8e51d CA-229019: XenCenter behavior on installing already uploaded update
Code review follow up commit

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:46:07 +00:00
Gabor Apati-Nagy
b0588d980a CA-229009: VDI is not deleted for the updates
XenCenter will now remove VDIs that couldn't been introduced.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:18:51 +00:00
Gabor Apati-Nagy
4fad0d309a CA-229019: XenCenter behavior on installing already uploaded update
The Pool_update does not always covers all the VDIs XenCenter creates. These orphaned ones have to be deleted as well.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-11-10 17:15:40 +00:00
Gabor Apati-Nagy
27581fa7a1 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Moved ISO to InvisibleMessages and Branding

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 13:42:16 +01:00
Gabor Apati-Nagy
8ac6774e80 CA-225731: XenCenter: Find the ISO update in the zip file defined in CFU
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-19 11:29:57 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Gabor Apati-Nagy
5cfce00e01 CP-17848: Apply hotfixes using new API calls
Changes following the code review

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 23:26:35 +01:00
Gabor Apati-Nagy
7d62621dd3 CP-17848: Apply hotfixes using new API calls
Using new XAPI functionality in Install Update Wizard required by the new packaging format (ISO updates)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-04 14:58:54 +01:00
Callum McIntyre
d302815b66 CP-17848: Commit to hand over. PatchingWizard_UploadPage.cs contains new code to introduce a Pool_update, PatchingWizard_PatchingPage.cs to apply and clean it. 2016-09-09 12:02:59 +01:00
Callum McIntyre
49a586430e CP-17848: Rename UpdateType enum NewSuppPack to ISO, since for this ticket we will handle all updates as ISOs 2016-08-31 10:42:09 +01:00
Mihaela Stoica
dc24aa7fcc CA-217388: Hotfix Install wizard shows update as already uploaded when it is not actually uploaded because there wasn't enough space
- Add a new update to the list of uploaded updates only when the upload action has completed successfully.
- Do not perform the disk space check if there is nothing to upload (update has already been uploaded).

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-08-04 15:10:36 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Mihaela Stoica
7a46698141 CP-16068: Pick up new RPU hotfixes
- XenCenter build system picks up the RPU hotfixes from Artifactory
- RPU001 and RPU002 replace XS62E006 and XS65ESP1006
- Removed hotfixes from the solution, moved  XS60E001 to Branding folder
- also cleaned up code in the HotfixFactory class, removing MNR and Cowley hotfixes (not supported anymore)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-11 22:18:06 +00:00
Gabor Apati-Nagy
39ae204363 Merge remote-tracking branch 'github_xenadmin/master' 2016-02-08 10:14:25 +00:00
Gabor Apati-Nagy
b8e447afa3 CA-196315: XS65ESP1018 not showing up in XenCenter Updates (on staging)
Fixed code to treat uuids of patches case-insensitive when consuming, but not changing them (eg. to lowercase) to keep compatibility with older XAPIs.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-02-08 10:14:05 +00:00
Mihaela Stoica
8e1493209d CP-15399: Improvements to the way we handle rebranding of update file
- InvisibleMessages.resx contains the default value for the update file extension (xsupdate), which can be overwritten in Branding.cs

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-02-04 10:55:18 +00:00
Carmen Agimof
2a8a80b5fd CA-181445: Changes message and page title on the Upload Page in the Updates Wizard. If we are actually downloading an update, then the message will mention that. Otherwise, it will only mention the upload. 2015-09-08 15:04:50 +01:00
Carmen Agimof
22b3450dcd CA-181442: Make the list that contained all NewUploadedPatches a Dictionary that matches the patch with its path. This is helpful when trying to upload to a server where the update it is already uploaded (and therefore we do not do the upload again and we cannot get the patch).
Adds a flag in the UploadPatchAction that is used when checking if the file should be deleted on cancel.
2015-09-07 12:18:01 +01:00
Carmen Agimof
9b0f478952 CA-181390: Solved issue related to taking a file from disk that is not in the list of updates taken from the Citrix website. Created a dictionary that contains all the uploaded updates(the patch path) and on which hosts they were applied.
- Not applied updates do not appear anymore in the General Tab of a pool. (Related to CA-180577)
- If we apply a patch that was already applied (happens when we take a file from disk that is not in the updates list taken from the Citrix website -> no metadata), on cancel we are now removing the uploaded patch from the host.
2015-09-04 17:09:22 +01:00
Carmen Agimof
037acfc889 Added null reference check in Upload Page. 2015-07-21 11:40:45 +01:00
Carmen Agimof
2720d1bc23 Following code review, adds a few adjustments to the code. 2015-07-21 11:03:34 +01:00
Carmen Agimof
4c93dbe92e CP-13245: Check if the update is applicable to the servers on the Select Servers Page.
CA-157785: Hotfix wizard forgets which servers should be greyed out.
When clicking Download and Install update in the Updates Tab, instead of opening a new dialog, it opens the Updates Wizard on the Select Servers Page and download the file in the Upload Page.
Fixes issue regarding the upload of the update every time that the user gets to Upload Page. Now it only uploads it if it has not been uploaded before.
Fixes issue regarding the download of the update every time the user goes back to the Select Patch Page. If the user goes back, but does not change the choice of the update, the download will not be done again.
2015-07-20 14:28:44 +01:00
Carmen Agimof
3f7fd89f87 CP-13038: Takes care of the case when the user downloads multiple files(by going back in the wizard and selecting a different update). When clicking cancel or when the install is finished, all the downloaded files are removed. 2015-07-15 16:36:37 +01:00
Carmen Agimof
149e6f8c1e CP-13038: Shows the progress of downloading a hotfix in the existing Progress Bar in the Upload Page of the Patching Wizard. 2015-07-15 13:03:11 +01:00
Carmen Agimof
dd10561764 CP-13034 : On the Updates Wizard, list hotfixes from updates.xensource.com instead of from other servers.
CP-13035 : Add Refresh button to list of updates on the Updates wizard.
CP-13037 : Provide option from the Updates wizard to navigate to the web page of any hotfix.
2015-07-14 10:05:13 +01:00
Gabor Apati-Nagy
aefed11165 Revert "CA-149867: Invoke on MainWindow instead of various controls"
This reverts commit 92f0499911.
2015-04-16 14:17:02 +01:00
Gabor Apati-Nagy
92f0499911 CA-149867: Invoke on MainWindow instead of various controls
We observed that some threads can reach deadlock-ish state after they have Invoked into a control's UI thread. When it happens they are all in a waiting for join or in sleep state for very long time, although there should not be any deadlock situations.
It seems this has something to do with multiple parent controls and with which control we invoked on. This should not make a difference, because we have got one UI thread (for MainWindow) they should wait for, but we have seen it does.

The solution that fixed this issue was to invoke on the MainWindow instead of various controls (see a4fe507adf ).

This changeset is changing all our Invokes to invoke into MainWindow
instead of a control itself. (MainWindow's UI thread is the only UI thread
all Control is using in XenCenter)
This changeset should be in place until we have found the root cause or the exact reason for the above.
2015-04-08 15:16:10 +01:00
Stephen Turner
5990c53617 CA-161460: Correct help text in the case that the patch has been deleted without being installed 2015-02-24 13:42:48 +00:00
Stephen Turner
3d7db537e7 Fix line endings 2015-02-24 13:29:41 +00:00
Stephen Turner
94ec31426f CA-161460: Clear the error message when going Back and Forward 2015-02-20 13:29:00 +00:00
Stephen Turner
d4dc9e2b06 CA-161460: Rename diskSpaceErrorLinkLabel -> errorLinkLabel, as it is now used more widely 2015-02-20 13:15:40 +00:00
Stephen Turner
a2883d8252 CA-161460: Present a helpful error message when a patch we are trying to download from another server has been deleted 2015-02-20 13:07:20 +00:00
Gabor Apati-Nagy
91789256e8 CP-10798: XenCenter work for CAR-1711: Pre-Checks for hotfix installation space
-Added HostOutOfSpaceProblem to let the user to clean up disk space when getting PATCH_PRECHECK_FAILED_OUT_OF_SPACE error at precheck stage in the patch install wizard.
-A bit of refactoring of DiskSpaceRequirements class in order to be reused here

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2015-02-12 13:13:45 +00:00
Mihaela Stoica
19f66414a7 CP-10797: Ensuring sufficient disk space for service pack installation: Changes following code review
- don't update the progress bar when checking disk space (only the description)
- the color used for "in progress" action description (above the progress bar) should be the system default font color, not black
- actions should throw ArgumentNullException, not NullReferenceException

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-06 10:34:18 +00:00
Mihaela Stoica
48636e12d6 CP-10797: Ensuring sufficient disk space for service pack installation: In the Install Update Wizard check if there is enough space to upload a hotfix
- Before starting the upload to the master hosts, check if there is enough disk space (check only performed for Cream or greater hosts)
- If enough space available the upload starts automatically; otherwise an error is displayed
- If we can free up enough disk space then we offer the option to Clean up. Otherwise we provide the user with the information on required and available space and the user will have to manually free up required space.

- Also Disable the Upload page for oem updates

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-02-05 17:01:14 +00:00
Mihaela Stoica
5b33590df0 CP-10824: Supp Pack installation through XenCenter: Install supp pack from vdi
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-26 15:43:36 +00:00
Mihaela Stoica
11d86f1c90 CP-10621: Supp Pack installation through XenCenter: Select and upload a supp pack in the hotfix wizard
- Select a supp pack in the hotfix wizard
- Recognise that it's a supp pack not a hotfix
- Check if there's enough space on a SR to contain it: (1) default SR if shared or (2) any shared SR or (3) local SR on each host in pool
- Create a VDI to contain it
- Upload the supp pack to the VDI

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-23 12:31:44 +00:00
Mihaela Stoica
8f942c9b91 CA-147163: Non-modal hotfix upload progress dialog
Show pool (or standalone server) name on the Upload page.
Also corrected some resource strings.

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-14 15:23:46 +00:00
Mihaela Stoica
cfa8bcd7b3 CA-147163: Non-modal hotfix upload progress dialog
- Added resource strings to replace hard coded strings

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-09 13:23:23 +00:00
Mihaela Stoica
13c6d323c3 CA-147163: Non-modal hotfix upload progress dialog
- Added new page to the patching wizard, called "Upload" which displays the upload actions for each server and the progress of these actions
- MultipleAction: added the functionality to optionally stop the action on first failure
- Fixed the error where an existing patch downloaded from another server and then uploaded to a new one was not deleted on cancelling the wizard [CA-156788]

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2015-01-09 12:54:12 +00:00