Commit Graph

2632 Commits

Author SHA1 Message Date
Konstantina Chremmou
488f27e2ae Revised Rbac checks for addition/removal of custom fields.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:25:02 +00:00
Konstantina Chremmou
5c70cbfd3d CA-84612: Rewrote the CustomFields Property page to fix some issues:
- The CustomFieldsDialog was an unnecessary intermediate step deteriorating the user experience.
- Fixed layout issues when we have a long list of custom fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
bc40d47ba6 Corrections to removal of custom fields:
- Custom fields were not removed from all types of objects the UI allows
  setting them for, which meant they were left behind in the other_config.
- Only remove a custom field if it is set on an object, otherwise we hammer
  the server with unnecessary requests.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:16 +00:00
Konstantina Chremmou
423ee7bd81 Added RBAC checks to the actions adding/removing custom fields. Also:
- Converted them to proper AsyncActions to facilitate further refactoring.
- Moved SaveCustomFieldsAction to the same folder as the above.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 21:03:15 +00:00
Konstantina Chremmou
87ff42086f Missing RBAC permission checks for CreateDiskAction.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Konstantina Chremmou
8c42b0428e Refactored the actions creating disks.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-28 15:36:13 +00:00
Danilo Del Busso
ea9669ce1b
CP-42186: Update XML tag name in DownloadUpdatesXmlAction
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-22 10:30:05 +00:00
Konstantina Chremmou
c70116691a Corrections as per code review:
- Bumped branding to v4.11.
- Reverted VS version in the solution file.
- Removed brand override registry entry.
- Converted HealthCheck warning pop-up to info pop-up.
- Moved status report actions to a separate folder.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:10 +00:00
Konstantina Chremmou
7063b3e130 CP-42155: Removed HealthCheck service and related dialogs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-02-21 16:05:09 +00:00
Danilo Del Busso
39b84bbcc5 CA-375282: Insert sanitised TARs into Temp folder
Avoids permission related exceptions

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-17 11:50:33 +00:00
Danilo Del Busso
653d66cb10 CP-40842: Report host action as failed when connection isn't possible
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-14 11:26:17 +00:00
Konstantina Chremmou
f885be7e4d
Merge pull request #3094 from xenserver/feature/vtpm
Merge feature/vtpm into master
2023-02-13 15:33:50 +00:00
Danilo Del Busso
2678f70f83
Merge pull request #3091 from danilo-delbusso/datasources-CP-40157
CP-40157: Updates to `GraphDetailsDialog`
2023-02-13 14:04:52 +00:00
Danilo Del Busso
6f6bddd755
CP-40842: Remove CIS upload from Server Status Report wizard (#3087)
* Remove credentials controls from `BugToolPageDestination`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Explicitly call dispose in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Tidy up code in `BugToolPageDestination.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `StatusReportRow` to its own file

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Move `ClientSideDataRow` and `HostStatusRow` to own files

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update order of pages in `BugToolWizard`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update action and create row for packaging status report in BugTool wizard

Instead of creating a new action, this males ZipStatusReportAction inherit StatusReportAction

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Allow for pending `StatusReportAction` to be cancelled

This avoids the need for a running action to update the status. i.e. an action that has been registered but hasn't started running can be cancelled, too.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Update content of `ACTION_SYSTEM_STATUS_SUCCESSFUL` message

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add link to `labelBlurb` in `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Add report packaging logic to `BugToolPageRetrieveData.cs`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Open CIS URL when clicking on `linkLabelBlurb`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* CP-40842: Report packaged data amount in `ZipStatusReportAction`

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Remove unused `using`s

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

* Minor layout tweaks.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed folder and namespace to match the ones for the other wizards.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed wizard's private fields. Some code efficiency corrections.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Keep the row classes as private within the BugToolPageRetrieveData class.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Removed leftover unused action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Tidy up status report messages. Use more relevant icon.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Made blurb localisable.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed private fields.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplified the stages of the compilation of the status report.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Renamed row classes again to match the action names.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Simplify reporting the progress of the zipping action.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

* Recursive call is not necessary. Tweaked message.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Sort strings

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Update copyright notices

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>

---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
Co-authored-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2023-02-13 13:47:21 +00:00
Konstantina Chremmou
a4ddce63c6 Merge remote-tracking branch 'upstream/feature/rebrand'
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

# Conflicts:
#	XenModel/Actions/Pool/SyncDatabaseAction.cs
#	XenModel/Actions/PureAsyncAction.cs
#	XenModel/Actions/VM/VMSuspendAction.cs
#	XenModel/XenServerProxy/RbacCollectorProxy.cs
2023-02-08 16:41:07 +00:00
Danilo Del Busso
b8e1376d52
Revert string sorting
Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-08 14:00:30 +00:00
Danilo Del Busso
6fecc41045
CP-40157: Update friendly name for xapi_open_fds data source
Also apply string sorting

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-02-01 11:23:37 +00:00
Konstantina Chremmou
f30afbe1d2 XSI-1362/CA-373773: Reworked the logic for selecting boot mode when creating a VM.
The new logic takes also account of platform:secure-boot=auto.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
439d29d9c3 Don't make server requests in the body of a property. Some minor code smells.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-31 16:20:13 +00:00
Konstantina Chremmou
86c39a559a
Merge pull request #3077 from kc284/pureAsyncAction
Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
2023-01-31 12:20:47 +00:00
Konstantina Chremmou
d7b519a53c Updated copyright notice on files.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
dcbfe2c8fa Corrected user visible copyright and uses of vendor names.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-30 16:24:16 +00:00
Konstantina Chremmou
34ca86fed7 Corrections as per code review.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-26 00:15:57 +00:00
Konstantina Chremmou
6c3dc7b703 CP-41433: Updated some uses of the company name.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
72f411b950 CP-41433: Legacy console name is not applicable any more.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
ca021b95dd CP-41433: Do not rebrand released versions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
775f3e49a9 Removed XenCenterVersion from BrandManager. Use the Program.Version instead.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
f7796582c3 CP-41433: Use the product name for the installation path, and the settings/logs parent folder.
Also, renamed the placeholder because msbuild converts spaces to underscores
and in debug mode the settings path is different from the one expected.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
4d36f67f46 Renamed placeholders so they are easier to understand.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
b2cd71a915 Moved all bracketed placeholders from Branding.resx to XenModel assembly attributes.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
2506e51c9a CP-41433: Moved branded licence strings back to FriendlyNames and replaced bracketed placeholders with string formatting placeholders.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
d9a603629f Moved common assembly properties to a separate file.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
68ef3b10aa CP-41433: Updated branding of About and LegalNotices dialogs. Also:
- Corrections to the layout of the LegalNoticesDialog and the AboutDialog.
- Dispose the LegaNoticesDialog when the AboutDialog is closed.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-25 12:50:49 +00:00
Konstantina Chremmou
fbe8c60336 Merge remote-tracking branch 'upstream/feature/vtpm'
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>

# Conflicts:
#	XenAdmin/MainWindow.cs
#	XenAdmin/Properties/Resources.resx
#	XenModel/Utils/Helpers.Versions.cs
#	XenModel/XenAPI/Pool.cs
2023-01-10 15:17:23 +00:00
Konstantina Chremmou
e21598d9a0
Merge pull request #3074 from kc284/compression
CP-41281: Exposed pool option for migration compression
2023-01-09 16:09:03 +00:00
Konstantina Chremmou
6ce266a4dd Tweaked the titles of some properties and options tabs.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-05 11:39:21 +00:00
Konstantina Chremmou
512d2c217d CP-41281: Exposed pool option for migration compression.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-05 11:39:20 +00:00
Konstantina Chremmou
d46722c6eb Renamed method adding an RbacMethod with key because it was very easy to use it for adding a list of RbacMethods instead.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-04 22:10:18 +00:00
Konstantina Chremmou
7ec581eb95 Stop using PureAsyncAction and RbacCollectorProxy for RBAC checks on actions.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-01-04 21:27:42 +00:00
Konstantina Chremmou
26e7d4e700 CP-41432: Embed the homepage html files in the project resources.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2022-12-16 00:37:24 +00:00
Konstantina Chremmou
6f41019ad9 CP-41432: Replaced the HomePage .mht files with an html file.
Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2022-12-16 00:37:24 +00:00
Konstantina Chremmou
6dd175eab0 Fixed exception thrown by actions without an API task (typically actions running synchronous calls).
Also, catch and log all exceptions and Failures.

Signed-off-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2022-12-14 01:00:54 +00:00
Konstantina Chremmou
92e66a2eed
Merge pull request #3068 from kc284/ionic
Removed dependency on IonicZip.
2022-12-14 01:00:23 +00:00
Konstantina Chremmou
e74232dc15
Merge pull request #3067 from kc284/xva-verify
xva_verify: some unused code removal; added cli switch.
2022-12-14 00:59:48 +00:00
Konstantina Chremmou
a29eb998ae
Merge pull request #3065 from kc284/master
CP-41048: Add each SR to the SrPicker as soon as its scan finishes, without waiting for the other scans to finish.
2022-12-05 15:00:01 +00:00
Konstantina Chremmou
1e44d42020 Check for unplugged PBDs when selecting SRs for placing a new disk or importing an XVA.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-30 13:28:44 +00:00
Konstantina Chremmou
e29b8b39d5 Removed dependency on IonicZip. Use the corresponding classes of .NET Framework.
Also renamed the archive classes because they were named after the 3rd
party library used and were confusing.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 16:53:30 +00:00
Konstantina Chremmou
8804038dc4 Removed code for bz2 because it has never been used/exposed in the UI.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-18 12:20:59 +00:00
Konstantina Chremmou
a98d516bbe Removed delegate definitions and some unused code.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-17 14:49:35 +00:00
Konstantina Chremmou
a77f3c3994 Corrections per code review.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2022-11-16 17:36:17 +00:00