Commit Graph

128 Commits

Author SHA1 Message Date
Konstantina Chremmou
9236bbc0e3 CA-298592: Check the licenseStatus is not null when accessing its properties.
There can be cases when we have logged in a session, events are fired
causing the tab pages to be refreshed, however we may abort the connection,
for example, due to brand mismatch. In this case the licenseStatus has not
been initialized, however the refreshing general tab tries to access its
properties resulting to a crash.
Also some method tidy up.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-08 11:10:44 +01:00
Konstantina Chremmou
a7c628b9ae Fixed issues with showing the correct licence for a host/pool on the main window and general tab.
- When the host/pool was disconnected or when changing selection from connected to disconnected pool
the header was not updated with the new licence status.
- If the pool hosts' edition is none of the known editions, show unknown, not free.
- Tidy up: moved the Pool.LicenseString method to Helpers.GetFriendlyLicenseName.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-10-05 15:16:12 +01:00
Mihaela Stoica
5ad2aa302e CA-289959: Add null checks when resolving the updates which require reboot
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-05-17 14:24:51 +01:00
Konstantina Chremmou
0c3298fd8b CA-289153: Do not attempt updating the licence status for disconnected hosts. (#2072)
Also, no need to trigger an event when the host is null or when get_servertime
fails only to double-log it in the handling class.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-05-11 16:38:46 +01:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
Ji Jiang
be5aeae819 CA-249852: Add license status in pool general tab
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-10-12 13:50:24 +01:00
Ji Jiang
1e335de316 CP-24210: Populate "By Host" view correctly
1) Show required updates in case of versions without minimal patches
2) Hide version text in installed updates when version is Ely or above

Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:48 +01:00
Ji Jiang
8b2bc83a12 CP-23453: Populate "By Host" view in Updates page
Signed-off-by: Ji Jiang <ji.jiang@citrix.com>
2017-09-18 15:32:47 +01:00
Konstantina Chremmou
514c33140b Converted remaining extension get and set properties of the API classes to methods
in order to prevent them from being serialised alongside the API properties.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-05 02:15:38 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
Stephen Turner
89f51e90a1 CA-258782 Remove thin provisioning code (#1728)
* CA-258782 Remove thin provisioning code

* Revert file that shouldn't have been touched

* Remove line that was only present for debugging
2017-08-22 16:40:08 +01:00
Mihaela Stoica
5b75b5f25d CA-260365: Hide the build number from the General Tab for Ely and newer hosts (to cover the Honolulu case)
Also restrict the use of build number as an integer to pre-Ely hosts (because a Honolulu host has a non-numeric build number and XenCenter doesn't know the difference between Ely and Honolulu)
And a small update to the pool join rule to match what we have in Honolulu XenCenter (check the database schema regardless of the version)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-07-27 14:47:12 +01:00
Gabor Apati-Nagy
6185b24b37 CA-147943: Scrollbar for list of hotfixes installed in a pool doesn't have scrollbar the first time it is expanded
General tab (Pool): In the list of updates, added a space after each comma
to let the control wrap the text into multiple lines. This way the text is
no longer cut, therefore no additional scrollbar is needed.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-06-08 17:32:34 +01:00
Mihaela Stoica
dce68b58c9 CA-242134: Remove Host.IsXCP extension (#1618)
* CA-242134: Remove Host.IsXCP extension

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

* CA-242134: Remove Host.IsXCP extension

- retain the host.license_params condition

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-31 16:58:52 +01:00
Mihaela Stoica
a31c31eb07 CA-242134: Remove licensing code targeting pre-Clearwater hosts
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-08 13:40:48 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Gabor Apati-Nagy
1abf9bf525 CA-249084: Build number is gone, hiding it
Hide build number from now on
2017-04-11 11:04:49 +01:00
Mihaela Stoica
06e624c3dc Merge pull request #1502 from stephen-turner/CA-248254
CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches
2017-03-24 10:50:23 +00:00
Stephen Turner
be746126a1 Fix typo 2017-03-23 12:28:32 +00:00
Stephen Turner
5f878e9661 CA-248254: Remove unused function 2017-03-22 17:56:01 +00:00
Stephen Turner
21f6bc22c4 CA-248254: XenCenter doesn't list partially applied patches if there are fully applied patches 2017-03-22 17:47:06 +00:00
Stephen Turner
7bd5dd98ca CA-248252: Show version numbers for updates 2017-03-22 17:29:11 +00:00
Letsibogo Ramadi
2aae7ab0f2 CA-239890 - EN: The update for PVS-Accelerator is displayed as “pvsaccelerator” on the “General” page.
Changes all update names to friendly names which are usually identical to the Name Description.
2017-01-26 10:39:06 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Callum McIntyre
034a686947 [CA-226116] Add Windows update as a hidden feature
If windows_update is in the hidden features registry key, then we hide the virtualization state line about Windows update.

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-10-28 12:58:23 +01:00
Gabor Apati-Nagy
fa7dbc14ed CA-227067: General tab: XenCenter does not show Reboot required when Toolstack restart required
On the General tab XenCenter shows a list of updates that requires the host to be restarted. This is shown for applied updates for which the required guidance hasn't been done (eg. restartHost or restartAgent after-apply-guidances)

This commit fixes a regression that caused restartToolstack warnings to be not shown in the list of warnings.

The displayed messages are also improved, XenCenter will show Toolstack restart or host restart appropriately and not just restart only as it used to.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-27 14:27:20 +01:00
Gabor Apati-Nagy
668979c29f Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Conflicts:
	XenAdmin/TabPages/GeneralTabPage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizardModeGuidanceBuilder.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_ModePage.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs
	XenAdminTests/WizardTests/PatchingWizard/PatchingWizardModeGuidanceBuilderTests.cs
	XenModel/Network/Cache.cs
	XenModel/XenModel.csproj
2016-10-20 19:12:57 +01:00
mcintyre94
284afe255e Merge pull request #1210 from kc284/CA-150412
CA-150412: OtherConfigAndTagsWatcher deliberately throws exceptions
2016-10-18 17:11:28 +01:00
Mihaela Stoica
329f084a7e Merge branch 'CAR-2184' to master
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI-Extensions/SR.cs
2016-10-18 10:18:47 +01:00
Konstantina Chremmou
c7ea650cf6 CA-157786: Use NameWithLocation to display the name of the VDI's SR. Also, removed
unconventionally named method which did not offer much to code legibility.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-17 23:26:13 +01:00
Konstantina Chremmou
7a74096d3b CA-157786: Added general tab for VDIs.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-14 13:51:51 +01:00
Konstantina Chremmou
bf08f9d875 Refactored old events which did not need to pass parameters when fired, but were
defined a long time ago, before C# obtained the Action delegates.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2016-10-13 22:59:06 +01:00
Gabor Apati-Nagy
f5545c83f5 CP-19265: Some improvements to comments
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-13 14:59:20 +01:00
Mihaela Stoica
abde6e9641 CA-224567: PVS Site renaming plus some other improvements
- Renamed Add/Remove PVS Site buttons
- Added a note on the PVS Cache configuration page, regarding the recommended cache size and the allowed size for "memory only"
- Added a warning about the Site configuration not being complete until the PVS part is done as well (only visible if PVS_uuid is not set for a PVS_site)
-  Added PVS Read Caching status on the VM's general tab
- The absolute maximum allowed for a cache size is 2TB
- Changed the rubric on the Enable PVS read caching dialog

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-10-13 12:47:32 +01:00
Gabor Apati-Nagy
5df1593989 CP-19264: Live Patching in XC: Use Pool_update version of Host.patches_requiring_reboot in XenCenter
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-12 14:48:17 +01:00
Gabor Apati-Nagy
c3f376ed7d CP-18422: Remove supp pack handling code for Ely hosts
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 13:22:29 +01:00
Gabor Apati-Nagy
37735febd1 CP-18421: Use host.updates instead of host.patches
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-05 12:55:34 +01:00
Gabor Apati-Nagy
5966c5399a Merge remote-tracking branch 'github_xenadmin/master' into CAR-2245_temp
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PatchingPage.cs
2016-10-04 15:10:47 +01:00
Gabor Apati-Nagy
1750c47de9 CP-18421: Use host.updates instead of host.patches
Showing relevant Pool_updates instead of Pool_patches on General tab

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-10-03 14:19:32 +01:00
Mihaela Stoica
18fb723f6a CP-18889: Implement UI changes for vCPU hotplug (#1159)
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-09-29 12:11:37 +01:00
Gabor Apati-Nagy
0174974c93 Merge branch 'master' of https://github.com/xenserver/xenadmin into CP-18014
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>

Conflicts:
	XenAdmin/Wizards/PatchingWizard/PatchingWizard.cs
	XenAdmin/Wizards/PatchingWizard/PatchingWizard_PrecheckPage.cs
	XenModel/Messages.Designer.cs
	XenModel/Messages.ja.resx
	XenModel/Messages.resx
	XenModel/Messages.zh-CN.resx
2016-08-26 15:22:03 +01:00
Callum McIntyre
2d089fa9e9 CP-18013: [XenCenter] Update host/pool updates pane
Generalising to also support pools. New CheckHostPatchesRequiringReboot method with the same behaviour as old method (return list of KeyValue warning messages). Pool updates on Ely use the union of messages from this method instead of the old one. Also localised the "{hotfix} on {server}" string per todo (hence resx changes).

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 10:45:11 +01:00
Callum McIntyre
dffd7507cc CP-18013: [XenCenter] Update host updates pane
For servers running Ely or greater we now produce messages for patching requiring reboot using the host.patches_requiring_reboot field. The Pool_patch objects resolved are sufficient to produce the same messages. Note that some patches produce a message in the old API but not the new, this is intentional. Still to do: update pool updates in the same way,

Signed-off-by: Callum McIntyre <callumiandavid.mcintyre@citrix.com>
2016-08-17 09:29:39 +01:00
Gabor Apati-Nagy
994f5b4811 Merge remote-tracking branch 'github_xenadmin/master' into master_batch_new2 2016-06-29 16:52:13 +01:00
Mihaela Stoica
3f25c5868f CP-17161: Add 'using' statement around dialogs to ensure garbage collection
- fix all ThreeButtonDialog usages (and some other dialogs that I've came across)

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-06-20 10:49:12 +01:00
Gabor Apati-Nagy
546dbca6e1 CP-17444: Show minimal hotfixes on General tab
Changed heading from Recommended Updates to Required Updates following further discussions around wording

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 16:16:01 +01:00
Gabor Apati-Nagy
3e092f6d50 CP-17444: Show minimal hotfixes on General tab
Showing recommended* hotfixes for servers when the data is available (Check For Updates xml has been downloaded and has minimalPatches node in it for the given server version). *:Not applied ones from the minimal set.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-08 13:34:59 +01:00
Gabor Apati-Nagy
725beacd4b CA-209290: "Virtualization state" label displayed twice on General Tab of newly created VM
Fixed duplicated headers.

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2016-06-02 12:03:26 +01:00
Mihaela Stoica
cc28388726 CP-16756: Change how XenCenter decides whether to display "I/O is optimized"
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-04-08 17:10:08 +01:00
Mihaela Stoica
c4b7ca3514 CA-203434: License Status displayed as "Not Found" on General tab
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>
2016-03-11 14:17:58 +00:00