Commit Graph

147 Commits

Author SHA1 Message Date
Konstantina Chremmou
6adcd2b83f Some more code simplifications.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4b0aa132d2 Simplified the FibreChannelProbeAction and compacted the methods and helper classes for parsing the results for the various SR types.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
4452318d1d Moved the classes FibreChannelDevice and FibreChannelProbeParsing to XenModel.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Konstantina Chremmou
959e43480c CP-17099: Double probe for iSCSI - minor refactoring to reduce code duplication.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fc42be5bee CP-17099: Do the probe_ext for HBA
- Move the scan for HBA devices after the Provisioning page
- Fix the device-config for HBA (removed uri)
- Add probe_ext in FibreChannelProbeAction and the method to process the result

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
e294e903fd CP-17099: Do the double probe for iSCSI
When we scan the LUN to see if there are any existing SRs, we need to do an additional probe if the probe for the desired type didn't find any SRs.
E.g. if  GFS2 is selected and no GFS2 SR was found on the LUN, then we need to also check if there is a LVM over iSCSI SR, and if there is one we will offer to reattach it (as LVM over iSCSI) or format it as GFS2

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-04-03 11:24:40 +01:00
Mihaela Stoica
fcb6399535 CP-17099: Changes following code review
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
6ad6b4efc7 CP-17099: Use SR.probe_ext for GFS2 over iSCSI to populate the lists of IQNs and LUNs on the New SR wizard
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
Mihaela Stoica
d3fa68e210 CA-286582: Hide the Provisioning method page if the feature is not present or disabled
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-28 17:07:15 +01:00
serenc
b7d3a2b3b5 CP-17099: Add gfs2 SR probe
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-03-28 11:34:42 +01:00
Mihaela Stoica
45ad13133d Use the new methods PageLeaveCore and PageLoadedCore in ChooseSrProvisioningPage
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2018-03-19 14:08:32 +00:00
Mihaela Stoica
f7b27ec222
Merge pull request #1994 from xenserver/REQ-477
Merge REQ-477 into master
2018-03-19 13:23:19 +00:00
Konstantina Chremmou
ee648135f6 Since it is easy to forget calling the base class method at the beginning of the
PageLoaded override in derived classes, enforce it by wrapping the page specific
code in a new virtual method, which the derived classes can override and PageLoaded
can call after its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
Konstantina Chremmou
7a1b1a6dcc Since it is easy to forget calling the base class method at the end of the PageLeave
override in derived classes, enforce it by wrapping the page specific code in
a new virtual method, which the derived classes can override and PageLeave can
call before its own logic.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2018-03-09 11:22:26 +00:00
serenc
92a809e433 CP-26253: changed "images" to "virtual disks" to avoid confusion
Signed-off-by: serenc <seren.corbett@citrix.com>
2018-01-12 14:05:01 +00:00
serencorbett1
f4d501474a CP-25564: Changed clusteringEnabled variable (#1891)
* CP-25564: Changed clusteringEnabled variable

* CP-26026: Added a link to enable clustering on SR Wizard

* CP-26026: Tweaked according to PR feedback

* CP-25967: Added license restriction for GFS2

Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-12 13:36:09 +00:00
serenc
3532e9b586 CP-25563: Improved code from feedback
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-06 09:49:56 +00:00
serenc
7790bed4ca Merge remote-tracking branch 'upstream/REQ-477' into REQ-477
Signed-off-by: serenc <seren.corbett@citrix.com>

# Conflicts:
#	XenAdmin/Dialogs/NetworkingPropertiesPage.cs
#	XenAdmin/Help/HelpManager.resx
2017-12-05 11:16:16 +00:00
serenc
f430cf58c8 CP-25563: Corrected column layout of tableLayoutInfo
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 15:57:12 +00:00
serenc
00aa042bd7 CP-25563: Added hotkeys,changed flowLayout and corrected label alignment
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 13:50:52 +00:00
Mihaela Stoica
72071a3334 Merge master into REQ-477
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenModel/XenAPI/Proxy.cs
2017-12-04 13:37:12 +00:00
serenc
69edc172eb CP-25563: Build now passes unit tests
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-04 10:53:58 +00:00
Mihaela Stoica
1e4c293300 CP-26021: Update the GFS2 SR creation with the new syntax
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-12-01 15:27:42 +00:00
serenc
9f9754c8b0 CP-25563: Added Clustering page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-12-01 14:47:50 +00:00
Konstantina Chremmou
fb8434819d Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib.
Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-11-30 13:56:32 +00:00
serenc
0f752ea035 CP-25551: Changed Page order and removed Event Handler from Designer
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-29 13:34:48 +00:00
serenc
7e7a6d9c46 CP-25551 and CP-25565: Updated branch based on PR comments
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 13:34:38 +00:00
serenc
5bb7a07711 CP-25551: Added Provisioning Page to the Wizard
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-28 10:51:44 +00:00
serenc
c4b228e8da CP-25551: Change Type page, Add provisioning page
Signed-off-by: serenc <seren.corbett@citrix.com>
2017-11-23 10:59:15 +00:00
Mihaela Stoica
681f77bfd9 CA-273307: Replaced the links in the Upsell dialogs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-11-17 12:24:43 +00:00
Gabor Apati-Nagy
59b904eb2d CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-24 14:55:07 +01:00
Gabor Apati-Nagy
033e7df8af CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Fix earlier resolved conflicts

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-10-23 15:05:25 +01:00
Mihaela Stoica
304b2c9fab CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Changes following code review

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-10-20 11:06:16 +01:00
Mihaela Stoica
6249663ae2 CP-17098: Integrate gfs2 in New SR wizard for HBA and FCOE SRs
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard.cs
	XenAdmin/Wizards/NewSRWizard_Pages/ChooseSrTypePage.cs
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoHBA.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
2017-10-20 11:05:45 +01:00
Mihaela Stoica
3bab5186f8 CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Rename SrWizardType
2017-10-20 10:42:54 +01:00
Mihaela Stoica
a56338861c CP-16484: Integrate gfs2 in New SR wizard for iSCSI SRs
Signed-off-by: Mihaela Stoica <Mihaela.Stoica@citrix.com>

Conflicts:
	XenAdmin/Wizards/NewSRWizard_Pages/Frontends/LVMoISCSI.cs
	XenAdmin/Wizards/NewSRWizard_Pages/SrWizardType.cs
	XenAdmin/XenAdmin.csproj
2017-10-20 10:42:35 +01:00
Konstantina Chremmou
ae22560ce8 Converted all extension get properties of the API classes to methods in order to
prevent them from being serialised alongside the API properties. This will also
be useful for moving the API bindings out of XenModel.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2017-09-03 03:35:30 +01:00
vetrivelc
d624d93865 L10N:CP-23040,CP-23012 Traanslation Checkin 2017-07-04 10:39:46 +05:30
vetrivelc
8d0f994d40 L10N: Fix CA-255548 & translation updates 2017-06-22 13:45:26 +05:30
Stephen Turner
eda73f1dff Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
Mihaela Stoica
68aa91bcaa CA-242134: Remove code targeting pre-Clearwater hosts and unnecessary ClearwaterOrGreater checks
Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2017-05-05 15:35:25 +01:00
Gabor Apati-Nagy
49fd823650 CA-249084: deleted more unneeded code
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 17:50:47 +01:00
Gabor Apati-Nagy
2823e0337b CA-249084: Fix code for new build number format
removing unneeded code (after 55f17d4)

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 16:37:19 +01:00
Gabor Apati-Nagy
55f17d416b CA-249084: Fix code for new build number format
fixed by removing checks that are no longer needed

Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-04-11 11:06:03 +01:00
vetrivelc
6d9273f304 L10N: Translation Changes & VMSS updates CP-20708 2017-02-14 03:27:38 +00:00
Gabor Apati-Nagy
978f85233c CA-176169: Added copyright statement to files which it was missing from
Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
2017-01-16 20:14:56 +00:00
Gabor Apati-Nagy
7c0bc50b4a CA-176169: Changed copyright statements to include the comma in Citrix Systems,
Inc.

Signed-off-by: Gabor Apati-Nagy<gabor.apati-nagy@citrix.com>
2017-01-16 19:59:50 +00:00
Konstantina Chremmou
cbdf7d3742 Merge pull request #1334 from MihaelaStoica/CA-216752
CA-216752: Not all wizards progress through to the next page by press…
2016-12-22 09:14:29 +00:00
Mihaela Stoica
0115461f66 CA-216752: Not all wizards progress through to the next page by pressing the Enter key
- Added SelectDefaultControl() to more wizard pages

Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
2016-12-21 13:33:04 +00:00
Konstantina Chremmou
e176194a06 Merge pull request #1339 from GaborApatiNagy/master_CA-211363
CA-211363: Replace 'User name' labels with 'Username'
2016-12-20 09:44:25 +00:00