mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-11-25 14:27:26 +01:00
c061b0f57d
* CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs - In the VMAppliancesDialog, change event handlers to reduce the number of refreshes when something changes: only reload the appliances when the VM_appliance collection change; if a relevant property is changed (in VM_appliance or VM), then update only the affected rows. - Improve the way we assign VMs to a group (AssignVMsToVMApplianceAction and AssignVMsToPolicyAction): only update the VMs that really changed. - Also improve the way we update the VM startup options and HA restart priorities on a set of VMs Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com> * CA-257574: Manage vApps dialog is unusable with a vApp containing a large number of VMs: changes following code review - reverted the changes to the AssignVMsToGroup actions that added the additional constructor - changed the AssignVMsToGroup actions to calculate the set difference between two lists more efficiently - added code to deregister PropertyChanged events on VM_appliances - removed getCurrentSettings() method as it is not needed, GetChangedSettings can be used in all cases Signed-off-by: Mihaela Stoica <mihaela.stoica@citrix.com>
100 lines
4.0 KiB
C#
100 lines
4.0 KiB
C#
/* Copyright (c) Citrix Systems, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System.Collections.Generic;
|
|
using System.Linq;
|
|
using XenAdmin.Core;
|
|
using XenAPI;
|
|
|
|
|
|
namespace XenAdmin.Actions
|
|
{
|
|
public class AssignVMsToVMApplianceAction : PureAsyncAction
|
|
{
|
|
private VM_appliance _vmAppliance;
|
|
private List<XenRef<VM>> _selectedVMs;
|
|
|
|
public AssignVMsToVMApplianceAction(VM_appliance vmAppliance, List<XenRef<VM>> selectedVMs, bool suppressHistory)
|
|
: base(vmAppliance.Connection, selectedVMs.Count == 1 ?
|
|
string.Format(Messages.ASSIGN_VM_TO_VAPP, vmAppliance.Connection.Resolve(selectedVMs[0]), vmAppliance.Name)
|
|
: string.Format(Messages.ASSIGN_VMS_TO_VAPP, vmAppliance.Name), suppressHistory)
|
|
{
|
|
_vmAppliance = vmAppliance;
|
|
_selectedVMs = selectedVMs;
|
|
Pool = Helpers.GetPool(vmAppliance.Connection);
|
|
|
|
}
|
|
|
|
protected override void Run()
|
|
{
|
|
Description = Messages.ASSIGNING_VM_APPLIANCE;
|
|
var removedItems = _vmAppliance.VMs.Except(_selectedVMs);
|
|
foreach (var xenRef in removedItems)
|
|
{
|
|
VM.set_appliance(Session, xenRef, null);
|
|
}
|
|
|
|
foreach (var vmRef in _selectedVMs)
|
|
{
|
|
var vm = _vmAppliance.Connection.Resolve(vmRef);
|
|
if (vm != null && (vm.appliance == null || vm.appliance.opaque_ref != _vmAppliance.opaque_ref))
|
|
VM.set_appliance(Session, vm.opaque_ref, _vmAppliance.opaque_ref);
|
|
}
|
|
Description = Messages.ASSIGNED_VM_APPLIANCE;
|
|
}
|
|
}
|
|
|
|
public class RemoveVMsFromVMApplianceAction : PureAsyncAction
|
|
{
|
|
private List<XenRef<VM>> _selectedVMs;
|
|
|
|
public RemoveVMsFromVMApplianceAction(VM_appliance vmAppliance, List<XenRef<VM>> selectedVMs)
|
|
: base(vmAppliance.Connection, selectedVMs.Count == 1 ?
|
|
string.Format(Messages.REMOVE_VM_FROM_APPLIANCE, vmAppliance.Connection.Resolve(selectedVMs[0]), vmAppliance.Name)
|
|
: string.Format(Messages.REMOVE_VMS_FROM_APPLIANCE, vmAppliance.Name))
|
|
{
|
|
_selectedVMs = selectedVMs;
|
|
Pool = Helpers.GetPool(vmAppliance.Connection);
|
|
|
|
}
|
|
|
|
protected override void Run()
|
|
{
|
|
Description = Messages.REMOVING_VMS_FROM_APPLIANCE;
|
|
foreach (var xenRef in _selectedVMs)
|
|
{
|
|
VM.set_appliance(Session, xenRef, null);
|
|
}
|
|
Description = Messages.REMOVED_VMS_FROM_APPLIANCE;
|
|
}
|
|
}
|
|
|
|
} |