xenadmin/XenModel
Danilo Del Busso 16d7f74158
CP-36392: Misc fixes to flagged Bugs (#2907)
* CP-36392: Add several `null` checks

All were flagged by SonarQube

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `SettingsUpdate`

Added to `XenAdmin`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Collapse useless condition check

Also use pattern matching for type cast

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Specify `namespace` for `ProduceConsumerQueue`

Add to `XenAdmin.Actions`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Rename field in `BugToolPageSelectCapabilties` to avoid name clash

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Add explicit `null` check

While the `null` check in `GraphDetailsDialog.cs` is not strictly necessary, it has been added to fix a SonarQube issue

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Remove unused field in `WlbPoolConfiguration.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Replace useless self-assignment with ad-hoc method

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Simplify dictionary key assignment in `WlbScheduledTask.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Fix minor formatting issues

Add newline at end of file, and reformat content of if statement

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up latest flagged bugs changes

- Fix whitespace/braces in a few affected files
- Add missing null check in `ValueMaps.cs`
- Check for args length in `RbacCollectorProxy.cs`
- Fix logic in `MainWindow.cs` to revert to previous behaviour

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>

* CP-36392: Tidy up setter in `ChangeableList.cs`

Also update whitespace inconsitencies in `PerfmonAlertEditPage.cs` and `VMHAEditPage.cs`

Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
2021-12-21 15:53:46 +00:00
..
Actions CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
Alerts CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
CustomFields CP-36392: Amend calls that generate unused return values 2021-10-04 15:42:40 +01:00
Mappings CA-350411 part 2: Add conditional page control refresh in Import Wizard 2021-11-24 15:35:00 +00:00
Network CP-36392: Refactor loops into if blocks 2021-10-04 15:42:10 +01:00
Properties Removed obsolete class XSVersionAttribute. Some refactoring of the usage of Program.Version. 2020-12-24 01:23:47 +00:00
ServerDBs CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
StorageLinkAPI CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
Utils CA-343229: Some modifications: 2021-12-17 11:08:31 +00:00
WLB CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
XCM CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
XenAPI Corrected Host.evacuate overloads. 2021-09-24 15:56:00 +01:00
XenAPI-Extensions CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
XenSearch CP-36392: Move return to new line in Search.cs 2021-11-15 10:21:39 +00:00
XenServerProxy CP-36392: Misc fixes to flagged Bugs (#2907) 2021-12-21 15:53:46 +00:00
BrandManager.cs CP-38086: Block upgrade for PV guests. 2021-11-15 15:49:39 +00:00
DockerContainer.cs CP-36392: Add comment to ignored catch blocks 2021-09-20 09:35:17 +01:00
DockerContainers.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
Folder.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
Folders.cs Namespace tidy 3/several: replaced XenAdmin.Core (instances in XenCenterLib) with XenCenterLib. 2017-11-30 13:56:32 +00:00
FriendlyNameManager.cs CA-156873, CP-31105 (partial): Apply common branding and versioning to assemblies; branding refactoring 2020-01-22 14:47:39 +00:00
FriendlyNames.Designer.cs CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
FriendlyNames.ja.resx CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
FriendlyNames.resx CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
FriendlyNames.zh-CN.resx CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
HealthCheckSettings.cs CA-355018: Ensure disabled health check status is reflected in the cache before re-rerunning prechecks. 2021-06-08 15:57:08 +01:00
I18NException.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
Icons.cs CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
InvisibleMessages.Designer.cs CA-359271: Update LICENSE_EXPIRY_WEBPAGE and UPSELL_SA URLs 2021-09-27 12:48:47 +01:00
InvisibleMessages.ja.resx CA-355166: Updated help links. 2021-06-08 15:56:29 +01:00
InvisibleMessages.resx CA-359271: Update LICENSE_EXPIRY_WEBPAGE and UPSELL_SA URLs 2021-09-27 12:48:47 +01:00
InvisibleMessages.zh-CN.resx CA-355166: Updated help links. 2021-06-08 15:56:29 +01:00
InvokeHelper.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
Messages.Designer.cs CA-343229: Some modifications: 2021-12-17 11:08:31 +00:00
Messages.ja.resx CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
Messages.resx CA-343229: Some modifications: 2021-12-17 11:08:31 +00:00
Messages.zh-CN.resx CA-359092: Clarify SMB storage option in NewSR wizard 2021-09-24 11:20:13 +01:00
ObjectChange.cs CP-34231: Remove language with negative connotations (#2860) 2021-08-31 11:31:16 +01:00
OtherConfigWatcher.cs Tidy up event registration and deregistration on the MainWindow. 2020-08-21 16:08:20 +01:00
PathValidator.cs CA-359809 improved illegal character message (#2898) 2021-11-22 12:02:26 +00:00
PoolJoinRules.cs Merge remote-tracking branch 'upstream/master' into feature/REQ-403 2021-09-01 14:43:23 +01:00
RbacMethod.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00
Tags.cs Simplified signature of connection events. 2019-12-06 11:17:46 +00:00
UnitStrings.Designer.cs CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name. 2021-08-05 15:36:46 +01:00
UnitStrings.ja.resx CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name. 2021-08-05 15:36:46 +01:00
UnitStrings.resx CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name. 2021-08-05 15:36:46 +01:00
UnitStrings.zh-CN.resx CP-36567: Use the datasource units as specified in the API instead of deducing them from the datasource name. 2021-08-05 15:36:46 +01:00
XenAdminConfigManager.cs CP-15790: Implementation improvement aimed to make manual testing easier. 2020-11-12 11:04:33 +00:00
XenModel.csproj CA-359809 improved illegal character message (#2898) 2021-11-22 12:02:26 +00:00
XenObjectDownloader.cs Merge branch 'master' into REQ-420 2018-01-25 13:38:58 +00:00
XenServerPlugins.cs CP-36392 pt.1: Removed unused using directives. 2021-04-07 10:04:47 +01:00