xenadmin/XenAdmin/Dialogs/VmSnapshotDialog.cs
Danilo Del Busso afb419af04
CP-44767, CP-44766 & CP-44765: Refactor usage of VM restrictions and add reference_label to OVFs (#3211)
* Tidy up `VM` extension: use `var`
* Tidy up `VM` extension: remove redundant initialisers
* Tidy up `VM` extension: use type keywords when possible
* Tidy up `VM` extension: merge conditional expressions
* Tidy up `VM` extension: remove redundant qualifiers
* Tidy up `VM` extension: remove redundant type arguments
* Tidy up `VM` extension: remove redundant `else`s and parentheses
* Tidy up `VM` extension: fix naming
* Tidy up `VM` extension: misc changes
* Tidy up `VM` extension: use `null` propagation
* Tidy up `VM` extension: fix whitespace
* Tidy up `VM` extension: apply ReSharper Code Cleanup utility
* Tidy up `VM` extension: Fix naming of private string array
* CP-44767: Ignore VM restriction when fetching `MaxVCPUsAllowed`
Instead, fetch the highest available value in all templates for the host.
This means that VMs imported from vhd won't automatically default to `DEFAULT_NUM_VCPUS_ALLOWED`, and that VMs that have been kept across XenServer upgrades won't be limited to the number of vCPUs in their own (possibly outdated) restrictions
* CP-44766: Use value in template with a matching `reference_label` when checking VM restrictions
* Move restriction getters to own region
* CP-44766: Use matching templates to fetch VM restrictions
- Rewrite `GetRestrictions...` methods to perform simpler operations
- Add `GetIntRestrictionValue` and `GetBoolRestrictionValue` wrappers to `GetRestrictionValueFromMatchingTemplate`
- Now all calls to a restrictions first check the template value, with a fall-back to defaults
* CP-44765: Export `reference-label` when generating OVFs
---------

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
2023-09-29 03:45:17 +01:00

161 lines
6.5 KiB
C#

/* Copyright (c) Cloud Software Group, Inc.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Windows.Forms;
using XenAdmin.Actions;
using XenAPI;
using XenAdmin.Core;
namespace XenAdmin.Dialogs
{
public partial class VmSnapshotDialog : XenDialogBase
{
private readonly VM _VM;
public VmSnapshotDialog(VM vm)
{
InitializeComponent();
_VM = vm;
UpdateWarnings();
diskRadioButton.Enabled = _VM.allowed_operations.Contains(vm_operations.snapshot);
pictureBoxSnapshotsInfo.Visible = labelSnapshotInfo.Visible = !diskRadioButton.Enabled;
var quiesceAvailable = !Helpers.QuebecOrGreater(_VM.Connection);
quiesceCheckBox.Visible = quiesceAvailable;
quiesceCheckBox.Enabled = quiesceAvailable && _VM.allowed_operations.Contains(vm_operations.snapshot_with_quiesce)
&& !Helpers.FeatureForbidden(_VM, Host.RestrictVss);
pictureBoxQuiesceInfo.Visible = labelQuiesceInfo.Visible = quiesceAvailable && !quiesceCheckBox.Enabled;
memoryRadioButton.Enabled = _VM.allowed_operations.Contains(vm_operations.checkpoint)
&& !Helpers.FeatureForbidden(_VM, Host.RestrictCheckpoint);
CheckpointInfoPictureBox.Visible = labelCheckpointInfo.Visible = !memoryRadioButton.Enabled;
UpdateOK();
}
/// <summary>
/// Must be accessed on the GUI thread.
/// </summary>
public string SnapshotName => textBoxName.Text;
public string SnapshotDescription => textBoxDescription.Text;
public SnapshotType SnapshotType
{
get
{
if (quiesceCheckBox.Checked)
return SnapshotType.QUIESCED_DISK;
if (diskRadioButton.Checked)
return SnapshotType.DISK;
return SnapshotType.DISK_AND_MEMORY;
}
}
private void buttonOk_Click(object sender, EventArgs e)
{
DialogResult = DialogResult.OK;
Close();
}
private void buttonCancel_Click(object sender, EventArgs e)
{
DialogResult = DialogResult.Cancel;
Close();
}
private void textBoxName_TextChanged(object sender, EventArgs e)
{
UpdateOK();
}
private void UpdateOK()
{
buttonOk.Enabled = !String.IsNullOrEmpty(textBoxName.Text.Trim()) && (diskRadioButton.Enabled || quiesceCheckBox.Enabled || memoryRadioButton.Enabled );
}
private void RadioButton_CheckedChanged(object sender, EventArgs e)
{
RadioButton radioSender = (RadioButton)sender;
if (radioSender.Checked)
{
if (radioSender == diskRadioButton)
{
memoryRadioButton.Checked = false;
}
else
{
diskRadioButton.Checked = false;
quiesceCheckBox.Checked = false;
}
}
}
private void VmSnapshotDialog_Load(object sender, EventArgs e)
{
textBoxName.Select();
}
private void quiesceCheckBox_CheckedChanged(object sender, EventArgs e)
{
if (quiesceCheckBox.Checked)
{
diskRadioButton.Checked = true;
}
}
private void UpdateWarnings()
{
labelSnapshotInfo.Text = Messages.INFO_DISK_MODE;
if (Helpers.FeatureForbidden(_VM, Host.RestrictVss))
labelQuiesceInfo.Text = Messages.FIELD_DISABLED;
else if (_VM.power_state != vm_power_state.Running)
labelQuiesceInfo.Text = Messages.INFO_QUIESCE_MODE_POWER_STATE;
else if (!_VM.GetVirtualizationStatus(out _).HasFlag(VM.VirtualizationStatus.ManagementInstalled))
labelQuiesceInfo.Text = _VM.HasNewVirtualizationStates()
? Messages.INFO_QUIESCE_MODE_NO_MGMNT
: string.Format(Messages.INFO_QUIESCE_MODE_NO_TOOLS, BrandManager.VmTools);
else
labelQuiesceInfo.Text = Messages.INFO_QUIESCE_MODE; // This says that VSS must be enabled. This is a guess, because we can't tell whether it is or not.
if (Helpers.FeatureForbidden(_VM, Host.RestrictCheckpoint))
labelCheckpointInfo.Text = Messages.FIELD_DISABLED;
else if (_VM.power_state != vm_power_state.Running)
labelCheckpointInfo.Text = Messages.INFO_DISKMEMORY_MODE_POWER_STATE;
else if (!_VM.GetVirtualizationStatus(out _).HasFlag(VM.VirtualizationStatus.IoDriversInstalled))
labelCheckpointInfo.Text = _VM.HasNewVirtualizationStates()
? Messages.INFO_DISKMEMORY_MODE_NO_IO_DRIVERS
: string.Format(Messages.INFO_DISKMEMORY_MODE_NO_TOOLS, BrandManager.VmTools);
else
labelCheckpointInfo.Text = Messages.INFO_DISKMEMORY_MODE_MISC;
}
}
}