mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-11-25 06:16:37 +01:00
4b0b83245f
* CA-34231: Replace negative language with `block list` in code and references Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `stop` in code and references Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `freezing` in code Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run/ran` in code comments Some paramater mentions have been renamed, as they will be renamed in future commits. Excluded mentions in XenAPI/Host.cs and XenAPI/VM.cs since code is autogenerated. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # CFUValidator/CommandLineOptions/CFUCommandLineOptionManager.cs # XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs # XenAdmin/Dialogs/Wlb/WorkloadReports.cs * CA-34231: Replace negative language with `run` in Command.cs Run method Used Resharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/TabPages/GeneralTabPage.cs * CA-34231: Replace negative language with `run` in Command.cs CanRun method Used Resharper rename utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in Command.cs CanRunCore method Used ReSharper rename utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/DRConfigureCommand.cs # XenAdmin/Commands/DRDryrunCommand.cs # XenAdmin/Commands/DRFailbackCommand.cs # XenAdmin/Commands/DRFailoverCommand.cs # XenAdmin/Commands/DisasterRecoveryCommand.cs # XenAdmin/Commands/VMGroupCommand.cs * CA-34231: Replace negative language with `run` in Command.cs RunCore method Used ReSharper rename utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in Command.cs GetCantExecuteReasonCore method Used ReSharper rename utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in Command.cs GetCantRunReasons method Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative language with `run` in Command.cs Also applied to related symbols. Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in methods named CanRun Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in methods in CrossPoolMigrateCommand.cs Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/CrossPoolMigrateCommand.cs * CA-34231: Replace negative language with `run` in remaining Run methods Also updated negative language in `DeleteVMCommand` Also updated in comment in `CrossPoolMigrateCommand` Also renamed missed instances of `CanRun` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `run` in `CanRunCore` and `RunCore` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative language with `run` in Commands folder Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative language with `run` in XenAdmin/Controls folder Used ReSharper renaming utility. Had to rename `WlbReportView.xs:RunReport()` to `WlbReportView.xs:StartRunReport()` to resolve conflict with change from `WlbReportView:ExecuteReport()` to `WlbReportView:RunReport()` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Controls/Wlb/WlbOptModeScheduler.cs # XenAdmin/Dialogs/Wlb/WorkloadReports.cs # XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs * CA-34231: Replace all remaining negative language with `run` in code Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/Controls/WlbRecommendations.cs # XenAdminTests/UnitTests/WlbTests/WlbScheduledTaskTests.cs # XenModel/WLB/WlbScheduledTask.cs * CA-34231: Replace negative language with `supporter` or `bond member` in code strings Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `supporter` or `bond member` in Messages string Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/MainWindow.cs # XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs # XenModel/Messages.Designer.cs # XenModel/Messages.resx * CA-34231: Replace remaining negative language with `supporter` in .resx files Used ReSharper renaming utility. FriendlyErrorNames.resx has been excluded. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `supporter` or `bond member` in XenAdmin code Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/NewPoolDialog.cs * CA-34231: Replace negative language with `supporter` or `bond member` in XenModel code Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in CFUValidator code Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # CFUValidator/CFUValidator.cs * CA-34231: Replace negative language with `coordinator` in solution's comments and hardcoded strings Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `Helpers:GetCoordinator` method Used ReSharper renaming utility. also renamed similarly named method in `ObjectChange.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Alerts/Types/HotfixEligibilityAlert.cs # XenAdmin/Controls/CustomDataGraph/ArchiveMaintainer.cs * CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx` Used ReSharper renaming utility. Excluded jp and zh resources Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/EvacuateHostDialog.resx * CA-34231: Replace negative language with `coordinator` in `EvacuateHostDialog.resx` Used ReSharper renaming utility. Excluded jp and zh resource files. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/NewPoolDialog.resx * CA-34231: Rename missing language references for change to `coordinator` Misc files were not saved before last commits. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `Messages.resx`'s code Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/HACommand.cs # XenAdmin/TabPages/AdPage.cs # XenModel/Actions/Network/CreateBondAction.cs # XenModel/Actions/Network/NetworkAction.cs # XenModel/Messages.Designer.cs # XenModel/Messages.resx * CA-34231: Replace negative language with `coordinator` in `ExternalPluginAction.cs` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands` Used ReSharper renaming utility. Also replace negative language in missed comment in `ExternalPluginAction.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/AddHostToPoolCommand.cs # XenAdmin/Commands/HACommand.cs * CA-34231: Replace negative language with `coordinator` in `Helpers.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `NetworkingHelper.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `PoolJoinRules.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/NewPoolDialog.cs * CA-34231: Replace negative language with `coordinator` in `XenAdmin/Commands`, `Controls`, and `Core` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Commands/AddHostToPoolCommand.cs * CA-34231: Replace negative language with `coordinator` in `XenAdmin/Diagnostics` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `coordinator` in `XenAdmin/Dialogs` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/NewPoolDialog.cs * CA-34231: Replace remaining negative language with `coordinator` in `XenAdmin` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/MainWindow.cs # XenAdmin/TabPages/GeneralTabPage.cs # XenAdmin/Wizards/PatchingWizard/PatchingWizard_SelectServers.cs # XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeExtrasPage.cs # XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizard.cs # XenAdmin/Wizards/RollingUpgradeWizard/RollingUpgradeWizardPrecheckPage.cs # XenAdmin/XenSearch/Columns.cs * CA-34231: Replace remaining negative language with `coordinator` in `XenModel\Actions` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenModel/Actions/Network/CreateBondAction.cs * CA-34231: Replace remaining negative language with `coordinator` in `XenModel` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative strings with `main` in `Messages.resx` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenModel/Messages.Designer.cs # XenModel/Messages.resx * CA-34231: Replace remaining negative string names with `main` in `Messages.resx` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs # XenModel/Messages.resx * CA-34231: Rename dialogs to replace negative connotations with `main` Used ReSharper renaming utility Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `main` in `SaveAndResoreOptionsPage.cs` Also updated its resx file. Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> # Conflicts: # XenAdmin/Dialogs/OptionsPages/SaveAndRestoreOptionsPage.cs * CA-34231: Fix invalid reference in `SaveAndRestoreOptionsPage.Designer.cs` after renaming Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `main` in `EnterMainPasswordDialog.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `main` in `ChangeMainPasswordDialog.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Fix invalid reference not changed after renaming `EnterMainPasswordDialog.cs` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative language with `main` in `XenAdmin/Dialogs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Update class names in HelpManager.resx Following renaming of main password dialog. Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace negative language with `main` in `Metadata.cs` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Remove remaning negative language with `coordinator` from `Messages.resx` Used ReSharper renaming Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Remove remaning negative language with `other pool member` from `Messages.resx` Used ReSharper Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CA-34231: Replace remaining negative language in solution Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Remove commented out code in VNCGraphicsClient.cs Code has only been improved partially as it's not strictly relevant to the PR Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Amend negative word replacement in XSVNCScreen.cs Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Simplify debug call formatting in NewPoolDialog.cs Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Add code mistakenly removed in MainWindow.cs Removed as part of `f155f9c8` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Revert renaming of constant related to Windows' API Considered external to CH Center Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Amend hotkey for Coordinator field in `NewPoolDialog` Previous ALT+<key> hotkey was conflicting with CreatePool Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Remove unecessary whitespace in EvacuateHostDialog.cs Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Update if block to exclude unecessary else in DRFailoverWizard.cs Not relevant to the PR, but the change is small enought to no need extra testing Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Amend typo in PoolJoinRules.cs supporer -> supporter Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Replace missing negative language with `coordinator` in `XenAPI-Extensions/Pool.cs` Variables and methods XenAPI-Extensions were mistakenly skipped Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Replace negative language in `XenApi-Extensions` with `coordinator/interface` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Replace negative language in `XenApi-Extensions` with `supporter/member` Used ReSharper renaming utility. Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Replace remaining negative language in `XenServerHealthCheckBugTool.cs` This is only used to format the string Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Change line-endings to CRLF in `Page_CloudConfigParamters.cs` Done in order to fix merge conflict into master Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com> * CP-34231: Amend misc negative language renaming typos `XenServerHealthCheckBugTool` and `XenServerHealthCheckService` Signed-off-by: Danilo Del Busso <Danilo.Del.Busso@citrix.com>
311 lines
11 KiB
C#
311 lines
11 KiB
C#
/* Copyright (c) Citrix Systems, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using XenAdmin.Controls;
|
|
using XenAdmin.Core;
|
|
using XenAPI;
|
|
|
|
namespace XenAdmin.Wizards.NewNetworkWizard_Pages
|
|
{
|
|
public partial class NetWDetails : XenTabPage
|
|
{
|
|
private List<int> vlans;
|
|
private bool _vlanError;
|
|
private bool _mtuError;
|
|
private bool _populatingNics;
|
|
|
|
public NetWDetails()
|
|
{
|
|
InitializeComponent();
|
|
//non-browsable events
|
|
numericUpDownVLAN.TextChanged += numericUpDownVLAN_TextChanged;
|
|
numericUpDownMTU.TextChanged += numericUpDownMTU_TextChanged;
|
|
|
|
numericUpDownMTU.Maximum = XenAPI.Network.MTU_MAX;
|
|
numericUpDownMTU.Minimum = XenAPI.Network.MTU_MIN;
|
|
numericUpDownMTU.Value = XenAPI.Network.MTU_DEFAULT;
|
|
numericUpDownVLAN.Maximum = 4094;
|
|
}
|
|
|
|
public override string Text => Messages.NETW_DETAILS_TEXT;
|
|
|
|
public override string PageTitle =>
|
|
SelectedNetworkType == NetworkTypes.External
|
|
? Messages.NETW_EXTERNAL_DETAILS_TITLE
|
|
: Messages.NETW_INTERNAL_DETAILS_TITLE;
|
|
|
|
public override bool EnableNext()
|
|
{
|
|
if (_vlanError || _mtuError)
|
|
return false;
|
|
|
|
return SelectedHostNic != null || !comboBoxNICList.Visible;
|
|
}
|
|
|
|
public override void PopulatePage()
|
|
{
|
|
var external = SelectedNetworkType == NetworkTypes.External;
|
|
|
|
labelExternal.Visible = external;
|
|
labelInternal.Visible = !external;
|
|
labelNIC.Visible = external;
|
|
comboBoxNICList.Visible = external;
|
|
|
|
if (comboBoxNICList.Visible)
|
|
{
|
|
try
|
|
{
|
|
_populatingNics = true;
|
|
comboBoxNICList.Items.Clear();
|
|
|
|
foreach (PIF ThePIF in Connection.Cache.PIFs)
|
|
{
|
|
if (ThePIF.host.opaque_ref == Host.opaque_ref && ThePIF.IsPhysical() &&
|
|
(Properties.Settings.Default.ShowHiddenVMs || ThePIF.Show(Properties.Settings.Default.ShowHiddenVMs)) &&
|
|
!ThePIF.IsBondMember())
|
|
{
|
|
comboBoxNICList.Items.Add(ThePIF);
|
|
}
|
|
}
|
|
}
|
|
finally
|
|
{
|
|
_populatingNics = false;
|
|
}
|
|
|
|
if (comboBoxNICList.Items.Count > 0)
|
|
comboBoxNICList.SelectedIndex = 0;
|
|
|
|
comboBoxNICList.Focus();
|
|
}
|
|
|
|
labelVLAN.Visible = external;
|
|
numericUpDownVLAN.Visible = external;
|
|
numericUpDownVLAN.Minimum = Helpers.VLAN0Allowed(Connection) ? 0 : 1;
|
|
numericUpDownMTU.Visible = labelMTU.Visible = infoMtuPanel.Visible = external;
|
|
|
|
checkBoxSriov.Visible = SelectedHostNic != null && SelectedHostNic.IsSriovPhysicalPIF();
|
|
|
|
OnPageUpdated();
|
|
}
|
|
|
|
#region Accessors
|
|
|
|
public NetworkTypes SelectedNetworkType { private get; set; }
|
|
|
|
public Host Host { private get; set; }
|
|
|
|
public PIF SelectedHostNic => comboBoxNICList.SelectedItem as PIF;
|
|
|
|
public int VLAN => Convert.ToInt32(Math.Round(numericUpDownVLAN.Value, MidpointRounding.AwayFromZero));
|
|
|
|
public bool AddNicToVmsAutomatically => checkBoxAutomatic.Checked;
|
|
|
|
public bool CreateVlanOnSriovNetwork => checkBoxSriov.Visible && checkBoxSriov.Checked;
|
|
|
|
/// <summary>
|
|
/// Returns -1 if the custom MTU option is disabled
|
|
/// </summary>
|
|
public int MTU => numericUpDownMTU.Visible && numericUpDownMTU.Enabled
|
|
? Convert.ToInt32(Math.Round(numericUpDownMTU.Value, MidpointRounding.AwayFromZero))
|
|
: -1;
|
|
|
|
#endregion
|
|
|
|
private List<int> GetVLANList(PIF nic)
|
|
{
|
|
List<int> vlans = new List<int>();
|
|
foreach (PIF pif in nic.Connection.Cache.PIFs)
|
|
{
|
|
if (pif.device == nic.device)
|
|
{
|
|
var pifIsSriov = pif.NetworkSriov() != null;
|
|
if ((CreateVlanOnSriovNetwork && pifIsSriov) || (!CreateVlanOnSriovNetwork && !pifIsSriov))
|
|
vlans.Add((int)pif.VLAN);
|
|
}
|
|
}
|
|
|
|
return vlans;
|
|
}
|
|
|
|
private void ValidateVLANValue()
|
|
{
|
|
//CA-192746: do not call numericUpDown.Value or properties/methods that call it
|
|
//in the validation method, because it auto-corrects what the user has typed
|
|
|
|
_vlanError = false;
|
|
string msg = null;
|
|
|
|
if (!int.TryParse(numericUpDownVLAN.Text.Trim(), out int currentValue))
|
|
{
|
|
_vlanError = true;
|
|
msg = Messages.INVALID_NUMBER;
|
|
}
|
|
else if (currentValue < numericUpDownVLAN.Minimum || numericUpDownVLAN.Maximum < currentValue)
|
|
{
|
|
_vlanError = true;
|
|
msg = string.Format(Messages.NETW_DETAILS_VLAN_RANGE, numericUpDownVLAN.Minimum, numericUpDownVLAN.Maximum);
|
|
}
|
|
else if (vlans != null && vlans.Contains(currentValue))
|
|
{
|
|
_vlanError = true;
|
|
msg = Messages.NETW_DETAILS_VLAN_NUMBER_IN_USE;
|
|
}
|
|
else if (currentValue == 0)
|
|
{
|
|
msg = Messages.NETW_VLAN_ZERO;
|
|
}
|
|
|
|
if (_vlanError)
|
|
{
|
|
pictureBoxVlan.Image = Images.StaticImages._000_error_h32bit_16;
|
|
labelVlanMessage.Text = msg;
|
|
infoVlanPanel.Visible = true;
|
|
}
|
|
else if (!string.IsNullOrEmpty(msg))
|
|
{
|
|
pictureBoxVlan.Image = Images.StaticImages._000_Info3_h32bit_16;
|
|
labelVlanMessage.Text = msg;
|
|
infoVlanPanel.Visible = true;
|
|
}
|
|
else
|
|
infoVlanPanel.Visible = false;
|
|
|
|
OnPageUpdated();
|
|
}
|
|
|
|
private void ValidateMtuValue()
|
|
{
|
|
//CA-192746: do not call numericUpDown.Value or properties/methods that call it
|
|
//in the validation method, because it auto-corrects what the user has typed
|
|
|
|
_mtuError = false;
|
|
|
|
if (!int.TryParse(numericUpDownMTU.Text.Trim(), out int currentValue))
|
|
{
|
|
_mtuError = true;
|
|
pictureBoxMtu.Image = Images.StaticImages._000_error_h32bit_16;
|
|
labelMtuMessage.Text = Messages.INVALID_NUMBER;
|
|
}
|
|
else
|
|
{
|
|
if (currentValue < numericUpDownMTU.Minimum || numericUpDownMTU.Maximum < currentValue)
|
|
_mtuError = true;
|
|
|
|
pictureBoxMtu.Image = Images.StaticImages._000_Info3_h32bit_16;
|
|
labelMtuMessage.Text = numericUpDownMTU.Minimum == numericUpDownMTU.Maximum
|
|
? string.Format(Messages.ALLOWED_MTU_VALUE, numericUpDownMTU.Minimum)
|
|
: string.Format(Messages.ALLOWED_MTU_RANGE, numericUpDownMTU.Minimum, numericUpDownMTU.Maximum);
|
|
}
|
|
|
|
infoMtuPanel.Visible = true;
|
|
OnPageUpdated();
|
|
}
|
|
|
|
#region Event Handlers
|
|
|
|
private void cmbHostNicList_SelectedIndexChanged(object sender, EventArgs e)
|
|
{
|
|
if (_populatingNics || SelectedHostNic == null)
|
|
return;
|
|
|
|
checkBoxSriov.Visible = SelectedHostNic.IsSriovPhysicalPIF();
|
|
|
|
numericUpDownMTU.Maximum = Math.Min(SelectedHostNic.MTU, XenAPI.Network.MTU_MAX);
|
|
numericUpDownMTU.Enabled = numericUpDownMTU.Minimum != numericUpDownMTU.Maximum;
|
|
ValidateMtuValue();
|
|
|
|
vlans = GetVLANList(SelectedHostNic);
|
|
|
|
//CA-72484: check whether the currently selected VLAN is available and keep it
|
|
if (!vlans.Contains(VLAN))
|
|
{
|
|
ValidateVLANValue();
|
|
return;
|
|
}
|
|
|
|
//CA-19111: VLAN values should only go up to the numericUpDownVLAN.Maximum (4094)
|
|
for (int i = 1; i <= numericUpDownVLAN.Maximum; i++)
|
|
{
|
|
if (!vlans.Contains(i))
|
|
{
|
|
numericUpDownVLAN.Value = i;
|
|
break;
|
|
}
|
|
}
|
|
|
|
OnPageUpdated();
|
|
}
|
|
|
|
private void numericUpDownVLAN_Leave(object sender, EventArgs e)
|
|
{
|
|
if (numericUpDownVLAN.Text == "")
|
|
numericUpDownVLAN.Text = VLAN.ToString();
|
|
}
|
|
|
|
private void numericUpDownVLAN_TextChanged(object sender, EventArgs e)
|
|
{
|
|
ValidateVLANValue();
|
|
}
|
|
|
|
private void numericUpDownVLAN_ValueChanged(object sender, EventArgs e)
|
|
{
|
|
ValidateVLANValue();
|
|
}
|
|
|
|
private void numericUpDownMTU_Leave(object sender, EventArgs e)
|
|
{
|
|
if (numericUpDownMTU.Text == "")
|
|
numericUpDownMTU.Text = MTU.ToString();
|
|
}
|
|
|
|
private void numericUpDownMTU_TextChanged(object sender, EventArgs e)
|
|
{
|
|
ValidateMtuValue();
|
|
}
|
|
|
|
private void numericUpDownMTU_ValueChanged(object sender, EventArgs e)
|
|
{
|
|
ValidateMtuValue();
|
|
}
|
|
|
|
private void checkBoxSriov_CheckedChanged(object sender, EventArgs e)
|
|
{
|
|
vlans = GetVLANList(SelectedHostNic);
|
|
ValidateVLANValue();
|
|
}
|
|
|
|
#endregion
|
|
}
|
|
}
|