xenadmin/XenAdmin/Wizards/CrossPoolMigrateWizard/CrossPoolMigrateWizard.cs
Danilo Del Busso 6c584bb351
CA-375532, CA-336510, and CP-41825: Add warnings when user selects too many vCPUs (#3119)
* Tidy up `SelectMultipleVMDestinationPage.cs`
* CA-375532 & CA-336510: Add warning when importing VMs with too many vCPUs
* CA-375532 & CA-336510: Prevent users from starting appliance if a VM has too many vCPUs
* Tidy up `Page_CpuMem`: use expression-bodied properties
* Tidy up `Page_CpuMem`: use conventional naming scheme
* Tidy up `Page_CpuMem`: use explicit modifiers
* Tidy up `Page_CpuMem`: use `en-US` locale for names
* Tidy up `Page_CpuMem`: use `var` when possible
* Tidy up `Page_CpuMem`: rename `Vcpus` to `VCpus`
* Tidy up `Page_CpuMem`: reorder elements
* Tidy up `Page_CpuMem`: revert class renaming and fix `vCpus` typos
* CA-375532: Prevent users from starting VM if they select too many vCPUs
* Tidy up `Page_Finish`: use expression-bodied properties
* Tidy up `Page_Finish`: fix typo
* Tidy up `Page_CpuMem`: rename `CanStartVM` to `CanStartVm`
* Remove unnecessary using directives
* Anchor warning icon to the top-left corner of its parent
* CA-375532 & CA-336510: Warn users when selecting more vCPUs than pCPUs in the Properties page
* CP-41825: Add warning for imported VMs with > 32 vCPUs
* CP-41825: Add warning for new VMs with > 32 vCPUs
* CP-41825: Add warning for existing VMs when selecting > 32 vCPUs
* CP-41825: Update wording used to alert users running VMs with > 32vCPUs
* Remove unused local variable in `VappStartCommand.cs`
* Reword some vCPUs messages
* Simplify assignment of `CanStartImmediately` in `Page_Finish.cs`
* Simplify assignment of `CanStartVmsAutomatically` in `ImportFinishPage.cs`
* Remove useless `Count` check in `VappStartCommand`
* Rename `pictureBox1` to `warningPictureBox` and change its `SizeMode`
* Separate CPU and memory warnings in `Page_CpuMem`
* Shorten warning messages shown in `Page_CpuMem`
* Disable option to start VM when memory configuration isn't valid
* Report number of vCPUs and pCPUs when showing warning in New VM wizard
* Tidy up `CpuMemoryEditPage`: rename elements
* Tidy up `CpuMemoryEditPage`: use explicity modifiers
* Tidy up `CpuMemoryEditPage`: Rename `CPUMemoryEditPage` to `CpuMemoryEditPage`
* Tidy up `CpuMemoryEditPage`: Miscellaneous renames and improvements
* Tidy up `CpuMemoryEditPage`: Fix whitespace
* Tidy up `CpuMemoryEditPage`: Use ReSharper code formatter
* Tidy up `CpuMemoryEditPage`: Move events to own region
* Tidy up `CpuMemoryEditPage`: Move `IEditPage` members to own region
* Tidy up `CpuMemoryEditPage`: Order members outside of regions
* Replace topology and vCPU warning labels with structured warnings
* Ensure warnings ends with a dot
* Allow multiple CPU warnings to show at the same time
* Remove warning link for vCPUS > pCPUS Option is not achievable
* Enable option to force unit used in `MemorySpinner`
* Replace `NumericUpDown` with `MemorySpinner` and show warnings at bottom of control
* Check destination pCPUs count when destination is not a pool
* Do not disable option to start VMs after import if user selects a shared SR
* Add memory warning when importing appliance with too much memory
* Sort vCPUs and memory warning strings
* Remove target from `ImportWizard`'s summary
Target is not useful and can cause confusion as appliance VMs could start on non-target hosts
* The home server is needed in the summary when importing XVA. The target server is not needed in the summary when migrating a VM.
* Update warnings when the server selection changes. Corrected memory calculation.
* Show all warnings for vCPUs. Moved topology warning to the bottom. Separated methods for showing memory and vCPU warnings.
* Removed the memory setting from the VM Properties dialog. Split running VM info to a separate panel.
* Corrections to the logic for starting the VM automatically. Also, Fixed a bit the layout of the Finish page to make better use of the available space.
* Corrections as per code review.

Signed-off-by: Danilo Del Busso <danilo.delbusso@cloud.com>
Co-authored-by: Konstantina Chremmou <Konstantina.Chremmou@cloud.com>
2023-06-08 11:24:39 +01:00

533 lines
23 KiB
C#

/* Copyright (c) Cloud Software Group, Inc.
*
* Redistribution and use in source and binary forms,
* with or without modification, are permitted provided
* that the following conditions are met:
*
* * Redistributions of source code must retain the above
* copyright notice, this list of conditions and the
* following disclaimer.
* * Redistributions in binary form must reproduce the above
* copyright notice, this list of conditions and the
* following disclaimer in the documentation and/or other
* materials provided with the distribution.
*
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
* SUCH DAMAGE.
*/
using System;
using System.Collections.Generic;
using System.Linq;
using XenAdmin.Actions;
using XenAdmin.Actions.VMActions;
using XenAdmin.Commands;
using XenAdmin.Controls;
using XenAdmin.Core;
using XenAdmin.Dialogs;
using XenAdmin.Mappings;
using XenAdmin.Network;
using XenAdmin.Wizards.GenericPages;
using XenAPI;
namespace XenAdmin.Wizards.CrossPoolMigrateWizard
{
public enum WizardMode { Migrate, Move, Copy }
internal partial class CrossPoolMigrateWizard : XenWizardBase
{
private CrossPoolMigrateDestinationPage m_pageDestination;
private CrossPoolMigrateStoragePage m_pageStorage;
private CrossPoolMigrateNetworkingPage m_pageNetwork;
private CrossPoolMigrateFinishPage m_pageFinish;
private CrossPoolMigrateTransferNetworkPage m_pageTransferNetwork;
private RBACWarningPage m_pageTargetRbac;
private CrossPoolMigrateCopyModePage m_pageCopyMode;
private IntraPoolCopyPage m_pageIntraPoolCopy;
private IXenConnection TargetConnection { get; set; }
private Dictionary<string, VmMapping> m_vmMappings = new Dictionary<string, VmMapping>();
private Host hostPreSelection = null;
private WizardMode wizardMode;
private bool _resumeAfterMigrate;
// Note that resumeAfter is currently only implemented for Migrate mode, used for resume on server functionality
public CrossPoolMigrateWizard(IXenConnection con, SelectedItemCollection selection, Host targetHostPreSelection, WizardMode mode, bool resumeAfterMigrate = false)
: base(con)
{
InitializeComponent();
hostPreSelection = targetHostPreSelection;
wizardMode = mode;
InitialiseWizard(selection);
_resumeAfterMigrate = resumeAfterMigrate;
}
private bool HasTemplatesOnly { get; set; }
private bool IsIntraPoolMigration()
{
return m_vmMappings.All(IsIntraPoolMigration);
}
private bool IsIntraPoolMigration(KeyValuePair<string, VmMapping> mapping)
{
VM vm = xenConnection.Resolve(new XenRef<VM>(mapping.Key));
if (vm.resident_on == mapping.Value.XenRef)
return true;
Pool pool = Helpers.GetPool(vm.Connection);
if (mapping.Value.XenRef is XenRef<Pool>)
{
Pool targetPool = TargetConnection.Resolve(mapping.Value.XenRef as XenRef<Pool>);
if (pool == targetPool)
return true;
}
Host host = xenConnection.Resolve(vm.resident_on) ?? Helpers.GetCoordinator(xenConnection);
if (mapping.Value.XenRef is XenRef<Host>)
{
Host targetHost = TargetConnection.Resolve(mapping.Value.XenRef as XenRef<Host>);
Pool targetPool = Helpers.GetPool(targetHost.Connection);
// 2 stand alone hosts
if (pool == null && targetPool == null)
{
if (targetHost == host)
return true;
return false;
}
if (pool == targetPool)
return true;
}
return false;
}
private bool IsStorageMotion(KeyValuePair<string, VmMapping> mapping)
{
if (!IsIntraPoolMigration(mapping))
return true;
if (mapping.Value.Storage == null)
return false;
foreach (var vdiMapping in mapping.Value.Storage)
{
var vdi = xenConnection.Resolve(new XenRef<VDI>(vdiMapping.Key));
if (vdi.SR.opaque_ref != vdiMapping.Value.opaque_ref)
return true;
}
return false;
}
private bool IsIntraPoolMove()
{
return wizardMode == WizardMode.Move && m_vmMappings.All(IsIntraPoolMove);
}
private bool IsIntraPoolMove(KeyValuePair<string, VmMapping> mapping)
{
VM vm = xenConnection.Resolve(new XenRef<VM>(mapping.Key));
return vm != null && vm.CanBeMoved() && IsIntraPoolMigration(mapping);
}
private bool IsCopyTemplate()
{
return wizardMode == WizardMode.Copy && m_vmMappings.Any(IsTemplate);
}
private bool IsTemplate(KeyValuePair<string, VmMapping> mapping)
{
VM vm = xenConnection.Resolve(new XenRef<VM>(mapping.Key));
return vm != null && vm.is_a_template;
}
private void InitialiseWizard(SelectedItemCollection selection)
{
var vmsFromSelection = new List<VM>();
foreach (var item in selection)
{
var vm = item.XenObject as VM;
if (vm == null)
continue;
vmsFromSelection.Add(vm);
m_vmMappings.Add(item.XenObject.opaque_ref, new VmMapping(item.XenObject.opaque_ref) {VmNameLabel = item.XenObject.Name()});
}
HasTemplatesOnly = vmsFromSelection.Count > 0 && vmsFromSelection.All(vm => vm.is_a_template);
UpdateWindowTitle();
m_pageDestination = new CrossPoolMigrateDestinationPage(vmsFromSelection,
wizardMode, GetSourceConnectionsForSelection(selection))
{
VmMappings = m_vmMappings,
Connection = selection.GetConnectionOfFirstItem()
};
m_pageDestination.SelectedTarget = hostPreSelection;
m_pageStorage = new CrossPoolMigrateStoragePage(wizardMode);
m_pageNetwork = new CrossPoolMigrateNetworkingPage(HasTemplatesOnly, wizardMode);
m_pageTransferNetwork = new CrossPoolMigrateTransferNetworkPage(vmsFromSelection, HasTemplatesOnly, wizardMode);
m_pageFinish = new CrossPoolMigrateFinishPage(selection.Count(), wizardMode, HasTemplatesOnly) { SummaryRetreiver = GetVMMappingSummary };
m_pageTargetRbac = new RBACWarningPage();
m_pageCopyMode = new CrossPoolMigrateCopyModePage(vmsFromSelection);
m_pageIntraPoolCopy = new IntraPoolCopyPage(vmsFromSelection);
if (wizardMode == WizardMode.Copy)
AddPages(m_pageCopyMode, m_pageIntraPoolCopy);
else
AddPages(m_pageDestination, m_pageStorage, m_pageFinish);
}
public sealed override string Text
{
get { return base.Text; }
set { base.Text = value; }
}
protected override void FinishWizard()
{
if (!AllVMsAvailable(m_vmMappings, xenConnection))
{
base.FinishWizard();
return;
}
if (wizardMode == WizardMode.Copy && m_pageCopyMode.IntraPoolCopySelected)
{
if (m_pageIntraPoolCopy.CloneVM)
new VMCloneAction(m_pageIntraPoolCopy.TheVM, m_pageIntraPoolCopy.NewVmName, m_pageIntraPoolCopy.NewVMmDescription).RunAsync();
else if (m_pageIntraPoolCopy.SelectedSR != null)
new VMCopyAction(m_pageIntraPoolCopy.TheVM, m_pageIntraPoolCopy.TheVM.GetStorageHost(false),
m_pageIntraPoolCopy.SelectedSR, m_pageIntraPoolCopy.NewVmName, m_pageIntraPoolCopy.NewVMmDescription).RunAsync();
base.FinishWizard();
return;
}
foreach (KeyValuePair<string, VmMapping> pair in m_vmMappings)
{
VM vm = xenConnection.Resolve(new XenRef<VM>(pair.Key));
Host target = TargetConnection.Resolve(m_vmMappings[pair.Key].XenRef as XenRef<Host>);
//if a pool has been selected but no specific homeserver Key is the pool opaque ref
if (target == null)
{
Pool targetPool = TargetConnection.Resolve(m_vmMappings[pair.Key].XenRef as XenRef<Pool>);
if (targetPool == null)
{
ShowErrorMessageBox(Messages.CPM_WIZARD_ERROR_TARGET_DISCONNECTED);
base.FinishWizard();
return;
}
target = TargetConnection.Resolve(targetPool.master);
}
if (target == null)
throw new ApplicationException("Cannot resolve the target host");
if (wizardMode == WizardMode.Move && IsIntraPoolMove(pair))
{
// check if there is actually something to be moved
var moveStorage = false;
foreach (var storageMapping in pair.Value.Storage.Where(sm => sm.Value != null))
{
var vdi = vm.Connection.Resolve(new XenRef<VDI>(storageMapping.Key));
if (vdi != null && vdi.SR.opaque_ref != storageMapping.Value.opaque_ref)
{
moveStorage = true;
break;
}
}
if (moveStorage)
new VMMoveAction(vm, pair.Value.Storage, target).RunAsync();
}
else
{
var isCopy = wizardMode == WizardMode.Copy;
AsyncAction migrateAction;
if (isCopy || IsStorageMotion(pair))
migrateAction = new VMCrossPoolMigrateAction(vm, target, SelectedTransferNetwork, pair.Value, isCopy);
else
migrateAction = new VMMigrateAction(vm, target);
if (_resumeAfterMigrate)
{
var title = VMCrossPoolMigrateAction.GetTitle(vm, target, isCopy);
var startDescription = isCopy ? Messages.ACTION_VM_COPYING : Messages.ACTION_VM_MIGRATING;
var endDescription = isCopy ? Messages.ACTION_VM_COPIED : Messages.ACTION_VM_MIGRATED;
var actions = new List<AsyncAction>()
{
migrateAction,
new ResumeAndStartVMsAction(vm.Connection, target, new List<VM>{vm}, new List<VM>(), null, null)
};
new MultipleAction(vm.Connection, title, startDescription, endDescription,
actions, true, false, true).RunAsync();
}
else
{
migrateAction.RunAsync();
}
}
}
base.FinishWizard();
}
private static void ShowErrorMessageBox(string message)
{
using (var dlg = new ErrorDialog(message))
dlg.ShowDialog(Program.MainWindow);
}
private List<IXenConnection> GetSourceConnectionsForSelection(IEnumerable<SelectedItem> selection)
{
return
wizardMode == WizardMode.Copy
? selection.Select(item => item.Connection).Where(conn => conn != null).Distinct().ToList()
: new List<IXenConnection>();
}
private void UpdateWindowTitle()
{
if (m_vmMappings != null && m_vmMappings.Count > 0 && !string.IsNullOrEmpty(m_vmMappings.First().Value.TargetName))
{
var messageText = wizardMode == WizardMode.Migrate
? Messages.CPM_WIZARD_TITLE_AND_LOCATION
: wizardMode == WizardMode.Move
? Messages.MOVE_VM_WIZARD_TITLE_AND_LOCATION
: IsCopyTemplate() ? Messages.COPY_TEMPLATE_WIZARD_TITLE_AND_LOCATION : Messages.COPY_VM_WIZARD_TITLE_AND_LOCATION;
Text = String.Format(messageText, m_vmMappings.First().Value.TargetName);
}
else
Text = wizardMode == WizardMode.Migrate
? Messages.CPM_WIZARD_TITLE
: wizardMode == WizardMode.Move
? Messages.MOVE_VM_WIZARD_TITLE
: IsCopyTemplate() ? Messages.COPY_TEMPLATE_WIZARD_TITLE : Messages.COPY_VM_WIZARD_TITLE;
}
protected override void UpdateWizardContent(XenTabPage page)
{
Type type = page.GetType();
if (type == typeof(CrossPoolMigrateDestinationPage))
{
RemovePage(m_pageNetwork);
RemovePage(m_pageTransferNetwork);
RemovePage(m_pageTargetRbac);
m_vmMappings = m_pageDestination.VmMappings;
TargetConnection = m_pageDestination.SelectedTargetPool?.Connection;
m_pageStorage.TargetConnection = TargetConnection;
m_pageNetwork.TargetConnection = TargetConnection;
if (Helpers.ConnectionRequiresRbac(xenConnection) || Helpers.ConnectionRequiresRbac(TargetConnection))
{
var message = wizardMode == WizardMode.Copy
? m_vmMappings.Any(IsTemplate)
? Messages.RBAC_CROSS_POOL_COPY_TEMPLATE_BLOCKED
: Messages.RBAC_CROSS_POOL_COPY_VM_BLOCKED
: m_vmMappings.Any(IsTemplate)
? Messages.RBAC_CROSS_POOL_MIGRATE_TEMPLATE_BLOCKED
: Messages.RBAC_CROSS_POOL_MIGRATE_VM_BLOCKED;
m_pageTargetRbac.SetPermissionChecks(new List<IXenConnection> {xenConnection, TargetConnection},
new WizardRbacCheck(message, VMCrossPoolMigrateAction.StaticRBACDependencies) {Blocking = true});
AddAfterPage(m_pageDestination, m_pageTargetRbac);
}
UpdateWindowTitle();
// add Transfer network page for all cases except intra-pool move (which is performed via VMMoveAction)
if (!IsIntraPoolMove())
AddAfterPage(m_pageStorage, m_pageTransferNetwork);
m_pageTransferNetwork.Connection = TargetConnection;
if (!IsIntraPoolMigration())
{
AddAfterPage(m_pageStorage, m_pageNetwork);
}
//If no network mappings xapi should map the networks
//with the same names together - ideal for intra-pool
ClearAllNetworkMappings();
m_pageStorage.VmMappings = m_vmMappings;
}
else if (type == typeof(CrossPoolMigrateStoragePage))
{
UpdateWindowTitle();
m_vmMappings = m_pageStorage.VmMappings;
m_pageNetwork.VmMappings = m_vmMappings;
}
else if (type == typeof(CrossPoolMigrateNetworkingPage))
{
UpdateWindowTitle();
m_vmMappings = m_pageNetwork.VmMappings;
}
else if (type == typeof(CrossPoolMigrateTransferNetworkPage))
{
UpdateWindowTitle();
string netRef = m_pageTransferNetwork.NetworkUuid.Key;
SelectedTransferNetwork = TargetConnection.Cache.Networks.FirstOrDefault(n => n.uuid == netRef);
}
else if (type == typeof(CrossPoolMigrateCopyModePage))
{
if (m_pageCopyMode.IntraPoolCopySelected)
{
RemovePagesFrom(1);
AddAfterPage(m_pageCopyMode, m_pageIntraPoolCopy);
if (Helpers.ConnectionRequiresRbac(xenConnection))
{
var message = m_vmMappings.Any(IsTemplate)
? Messages.RBAC_INTRA_POOL_COPY_TEMPLATE_BLOCKED
: Messages.RBAC_INTRA_POOL_COPY_VM_BLOCKED;
var rbac = new RbacMethodList();
rbac.AddRange(VMCopyAction.StaticRBACDependencies);
rbac.AddRange(VMCloneAction.StaticRBACDependencies);
rbac.AddRange(SrRefreshAction.StaticRBACDependencies);
m_pageTargetRbac.SetPermissionChecks(xenConnection,
new WizardRbacCheck(message, rbac) {Blocking = true});
AddAfterPage(m_pageCopyMode, m_pageTargetRbac);
}
}
else
{
RemovePagesFrom(1);
AddAfterPage(m_pageCopyMode, m_pageDestination, m_pageStorage, m_pageFinish);
if (Helpers.ConnectionRequiresRbac(xenConnection))
{
var message = m_vmMappings.Any(IsTemplate)
? Messages.RBAC_CROSS_POOL_COPY_TEMPLATE_BLOCKED
: Messages.RBAC_CROSS_POOL_COPY_VM_BLOCKED;
m_pageTargetRbac.SetPermissionChecks(new List<IXenConnection> {xenConnection},
new WizardRbacCheck(message, VMCrossPoolMigrateAction.StaticRBACDependencies) {Blocking = true});
AddAfterPage(m_pageCopyMode, m_pageTargetRbac);
}
}
}
if (type != typeof(CrossPoolMigrateFinishPage))
NotifyNextPagesOfChange(m_pageDestination, m_pageStorage, m_pageNetwork, m_pageTransferNetwork, m_pageFinish);
}
private XenAPI.Network SelectedTransferNetwork { get; set; }
private void ClearAllNetworkMappings()
{
foreach (KeyValuePair<string, VmMapping> pair in m_vmMappings)
pair.Value.Networks = new Dictionary<string, XenAPI.Network>();
}
protected override string WizardPaneHelpID()
{
return FormatHelpId(CurrentStepTabPage.HelpID);
}
private IEnumerable<SummaryDetails> GetVMMappingSummary()
{
//Use decorators to build a summary
MappingSummary summary = new VMMappingSummary();
foreach (KeyValuePair<string, VmMapping> pair in m_vmMappings)
{
if (HasTemplatesOnly)
summary = new TemplateTitleSummary(summary, pair.Value);
else
summary = new VmTitleSummary(summary, pair.Value);
summary = new DestinationPoolSummary(summary, pair.Value, TargetConnection);
summary = new TransferNetworkSummary(summary, m_pageTransferNetwork.NetworkUuid.Value);
summary = new StorageSummary(summary, pair.Value, xenConnection);
summary = new NetworkSummary(summary, pair.Value, xenConnection);
summary = new SummarySplitter(summary);
}
return summary.Details;
}
/// <summary>
/// Checks if all VMs are still available for migration and shows a warning message if the check fails
/// </summary>
/// <returns>true if check succeded, false if failed</returns>
internal static bool AllVMsAvailable(List<VM> vms)
{
Func<bool> vmCheck = delegate
{
if (vms == null || vms.Count == 0 || vms[0] == null || vms[0].Connection == null)
return false;
var connection = vms[0].Connection; // the connection on which to check VM availability
return vms.All(vm => connection.Resolve(new XenRef<VM>(vm.opaque_ref)) != null);
};
return PerformCheck(vmCheck);
}
/// <summary>
/// Checks if all VMs are still available for migration and shows a warning message if the check fails
/// </summary>
/// <returns>true if check succeded, false if failed</returns>
internal static bool AllVMsAvailable(Dictionary<string, VmMapping> vmMappings, IXenConnection connection)
{
Func<bool> vmCheck = delegate
{
if (vmMappings == null || vmMappings.Count == 0 || connection == null)
return false;
return vmMappings.All(kvp => connection.Resolve(new XenRef<VM>(kvp.Key)) != null);
};
return PerformCheck(vmCheck);
}
/// <summary>
/// Performs a certain check and shows a warning message if the check fails
/// </summary>
/// <param name="check">The check to perform</param>
/// <returns>true if check succeeded, false if failed</returns>
private static bool PerformCheck(Func<bool> check)
{
if (check())
return true;
ShowErrorMessageBox(string.Format(Messages.CPM_WIZARD_VM_MISSING_ERROR, BrandManager.BrandConsole));
return false;
}
internal static void ShowWarningMessageBox(string message)
{
using (var dlg = new WarningDialog(message) { WindowTitle = Messages.CPM_WIZARD_TITLE })
dlg.ShowDialog(Program.MainWindow);
}
}
}