xenadmin/XenAdmin/Commands/Controls
Callum McIntyre 479d4b4b87 [CA-269110] Stop calling assert_can_boot_here after migrate dropdown is closed
When we right click migrate a VM we load all the hosts in the pool into
a dropdown, and then one-by-one assert whether the selected VM can boot
on that host, enabling each option where this is positive. If the
dropdown is exited then nothing stops these assert calls from
continuing, and looking at the logs we can see that they do.

With a large pool this is problematic because the UI basically locks up
until it's completed all these asserts, even if we've already selected a
host to migrate to. If we try to migrate another host then we see in the logs that both the old thread and new
thread are making `assert_can_boot_here` calls, and the UI for the new
thread doesn't function until the old one has finished.

This commit adds a new property `_isDropDownClosed`, which is set by the
new `OnDropDownClosed` event handler. In the loop enabling dropdown
items, each iteration we check this property - and if it is true then
the dropdown is no longer showing so we stop the loop and thus don't
call any more `assert_can_boot_here` commands. This stops the UI locking
up after the dropdown is closed.

Signed-off-by: Callum McIntyre <callum.mcintyre@citrix.com>
2017-11-09 16:59:25 +00:00
..
AddHostToSelectedPoolToolStripMenuItem.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
AddSelectedHostToPoolToolStripMenuItem.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
AssignVMGroupToolStripMenuItem.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
CommandButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CommandConverter.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CommandEditor.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CommandEditorControl.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CommandEditorControl.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
CommandEditorControl.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
CommandEditorControl.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
CommandEditorControl.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
CommandToolStripButton.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CommandToolStripMenuItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ContextMenuBuilder.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
ContextMenuItemCollection.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
EditPropertiesToolStripMenuItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
MigrateVMToolStripMenuItem.cs CA-242134: Remove TampaOrGreater, its usages and unreachable code 2017-05-05 14:31:43 +01:00
MultipleWarningDialog.cs Fix several usage errors identified by Lexica 2017-06-20 14:29:22 +01:00
MultipleWarningDialog.Designer.cs CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
MultipleWarningDialog.ja.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
MultipleWarningDialog.resx CP-4816: Initial commit to git repo 2013-06-24 12:41:48 +01:00
MultipleWarningDialog.zh-CN.resx L10N : Dundee translation checkins Iteration 01 2016-03-21 16:45:35 +05:30
ResumeVMOnHostToolStripMenuItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
StartVMOnHostToolStripMenuItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
VMLifeCycleToolStripMenuItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
VMOperationToolStripMenuItem.cs [CA-269110] Stop calling assert_can_boot_here after migrate dropdown is closed 2017-11-09 16:59:25 +00:00
VMOperationToolStripMenuSubItem.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
WlbRecommendations.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00