mirror of
https://github.com/xcp-ng/xenadmin.git
synced 2024-12-22 16:36:03 +01:00
48ef276c06
The PatchPrechecksOnMultipleHostsInAPoolPlanAction did not filter the patchmappings by masterhost, so with some probability, it could choose the wrong mapping (pool_patch object for the same update, but in different pool). This bug is being fixed in this commit, other changes only renamed (for more consistent naming) a class and removed an unused field. Signed-off-by: Gabor Apati-Nagy <gabor.apati-nagy@citrix.com>
97 lines
3.7 KiB
C#
97 lines
3.7 KiB
C#
/* Copyright (c) Citrix Systems Inc.
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms,
|
|
* with or without modification, are permitted provided
|
|
* that the following conditions are met:
|
|
*
|
|
* * Redistributions of source code must retain the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer.
|
|
* * Redistributions in binary form must reproduce the above
|
|
* copyright notice, this list of conditions and the
|
|
* following disclaimer in the documentation and/or other
|
|
* materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND
|
|
* CONTRIBUTORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES,
|
|
* INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF
|
|
* MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR
|
|
* CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
|
|
* SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
|
|
* BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
|
|
* INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY,
|
|
* WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING
|
|
* NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
|
|
* SUCH DAMAGE.
|
|
*/
|
|
|
|
using System;
|
|
using System.Collections.Generic;
|
|
using XenAdmin.Actions;
|
|
using XenAdmin.Core;
|
|
using XenAPI;
|
|
using System.Linq;
|
|
using System.IO;
|
|
using XenAdmin.Network;
|
|
using XenAdmin.Diagnostics.Checks;
|
|
using System.Diagnostics;
|
|
|
|
namespace XenAdmin.Wizards.PatchingWizard.PlanActions
|
|
{
|
|
class PatchPrechecksOnMultipleHostsInAPoolPlanAction : PlanActionWithSession
|
|
{
|
|
private readonly XenServerPatch patch;
|
|
private readonly List<PoolPatchMapping> mappings;
|
|
private List<Host> hosts = null;
|
|
|
|
public PatchPrechecksOnMultipleHostsInAPoolPlanAction(IXenConnection connection, XenServerPatch patch, List<Host> hosts, List<PoolPatchMapping> mappings)
|
|
: base(connection, string.Format("Precheck for {0} in {1}...", patch.Name, connection.Name))
|
|
{
|
|
this.patch = patch;
|
|
this.hosts = hosts;
|
|
this.mappings = mappings;
|
|
}
|
|
|
|
protected override void RunWithSession(ref Session session)
|
|
{
|
|
var mapping = mappings.Find(m => m.XenServerPatch == patch && m.MasterHost == Helpers.GetMaster(Connection));
|
|
if (mapping != null && mapping.Pool_patch != null)
|
|
{
|
|
foreach (var host in hosts)
|
|
{
|
|
if (Cancelling)
|
|
{
|
|
throw new CancelledException();
|
|
}
|
|
|
|
try
|
|
{
|
|
var check = new PatchPrecheckCheck(host, mapping.Pool_patch);
|
|
var problems = check.RunAllChecks();
|
|
|
|
Diagnostics.Problems.Problem problem = null;
|
|
|
|
if (problems != null && problems.Count > 0)
|
|
problem = problems[0];
|
|
|
|
if (problem != null)
|
|
{
|
|
throw new Exception(string.Format("{0}: {1}. {2}", host, problem.Title, problem.Description));
|
|
}
|
|
}
|
|
catch (Exception ex)
|
|
{
|
|
log.Error(string.Format("Precheck failed on host {0}", host.Name), ex);
|
|
throw ex;
|
|
}
|
|
}
|
|
}
|
|
|
|
}
|
|
}
|
|
}
|