Kiu/xenadmin
1
0
Fork 0
mirror of https://github.com/xcp-ng/xenadmin.git synced 2024-11-25 14:27:26 +01:00
Code Issues Actions Packages Projects Releases Wiki Activity
4ce9878b45
xenadmin/XenAdmin/Commands
History
Konstantina Chremmou 4ce9878b45 Refactored the VIFDialog to fix various problems: (#2398) 
* Refactored the VIFDialog to fix various problems:
- Launch the dialog in using blocks.
- Event GotFocus is not meant to be handled directly in the code.
- Populate the dialog in the OnLoad override instead of the constructor
  as this causes problems at design time.
- Popping up an error message for duplicate MAC on combobox item
  selection or textbox text change is not optimal UX. Perform this
  check once when closing the form. Additionally the parent form of the
  pop up should be the dialog, not the main window.
- The validation messages are not obvious to the user because they are
  hidden in the tooltip of a disabled button. Show them inline instead.
- There is no need to create commands for VIF creation/change; use
  the relevant actions instead.

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>

* Corrections as per code review plus some more code tidy and refactoring.

- Added option to suppress Create/DeleteVIFActions
- Use property RebootRequired to indicate hot-plugging is unavailable
  (assigning various objects of different types to the Result of the action
  during its run may cause confusion).

Signed-off-by: Konstantina Chremmou <konstantina.chremmou@citrix.com>
2019-04-25 08:23:09 +01:00
..
Controls CA-286291: Add the additional menu items immediately after the first item, so we don't have to wait for the WLB recommendations to be 2018-05-14 12:30:40 +01:00
ActivateVBDCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
AddHostCommand.cs Connection code simplification/update: removed CachePopulatedEventArgs class and use the newer Action delegate instead. 2018-01-24 15:58:16 +00:00
AddHostToPoolCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
AddNewHostToPoolCommand.cs Connection code simplification/update: removed CachePopulatedEventArgs class and use the newer Action delegate instead. 2018-01-24 15:58:16 +00:00
AddVirtualDiskCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
ApplyLicenseEditionCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
AttachVirtualDiskCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
BackupHostCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
BugToolCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CallHomeCommand.cs CA-176169: Added copyright statement to files which it was missing from 2017-01-16 20:14:56 +00:00
CancelHostConnectionCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ChangeControlDomainMemoryCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
ChangeHostPasswordCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
CollapseChildTreeNodesCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
Command.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ConnectAllHostsCommand.cs Modified treeview and toolbar updates (#2264) 2018-10-16 16:24:54 +01:00
ConvertVMToTemplateCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
CopyTemplateCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
CopyVMCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
CreateVMFromTemplateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CrossConnectionCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CrossPoolCopyVMCommand.cs CA-271970: Incorrect error when copying a VM on an unlicensed pool 2017-11-13 11:28:00 +00:00
CrossPoolMigrateCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
CrossPoolMigrateToHomeCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
CrossPoolMoveVMCommand.cs CA-249858: Fix build warning as error 2017-06-15 08:31:47 +01:00
DeactivateVBDCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DeleteFolderCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
DeletePoolCommand.cs CA-104539: Don't allow the user to make a pool into a standalone server if HA is enabled 2018-08-10 09:50:31 +01:00
DeleteSnapshotCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DeleteTagCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DeleteTemplateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DeleteVirtualDiskCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DeleteVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DeleteVMsAndTemplatesCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DestroyBondCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
DestroyHostCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
DestroySRCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DetachSRCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DetachVirtualDiskCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
DisableChangedBlockTrackingCommand.cs Rename resource string which causes Messages.resx to become unsorted 2018-01-11 12:45:37 +00:00
DisablePvsReadCachingCommand.cs Prevent VisualStudio's designer from crashing when opening the MainWindow. 2019-04-24 15:03:20 +01:00
DisasterRecoveryCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
DisconnectAllHostsCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DisconnectCommand.cs When we end the connection call OnConnectionClosed instead of OnConnectionStateChanged. 2018-10-08 11:10:44 +01:00
DisconnectHostCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DisconnectHostsAndPoolsCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DisconnectPoolCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DisconnectWlbServerCommand.cs Removed code applicable to servers earlier than dundee since connection to them is now blocked. 2019-02-06 09:25:38 +00:00
DragDropAddHostToPoolCommand.cs CA-268975: Do not allow multiple hosts to join the pool if the new pool size will exceed the max size 2017-10-13 10:14:00 +01:00
DragDropCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DragDropCrossPoolMoveHaltedVMCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DragDropIntoFolderCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DragDropMigrateVMCommand.cs CA-270505: Use generic msg if VM migr not allowed 2017-10-24 15:08:35 +01:00
DragDropRemoveHostFromPoolCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DragDropTagCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
DRConfigureCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
DRDryrunCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
DRFailbackCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
DRFailoverCommand.cs CA-273307: Replaced the links in the Upsell dialogs 2017-11-17 12:24:43 +00:00
EditTagsCommand.cs CA-287643: Replaced list view with data grid view to resolve column sizing issue and for consistency with the rest of the product. (#2226) 2018-10-02 10:18:34 +01:00
EnablePvsReadCachingCommand.cs Prevent VisualStudio's designer from crashing when opening the MainWindow. 2019-04-24 15:03:20 +01:00
ExpandTreeNodesCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ExportCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ExportResourceReportCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ExportSnapshotAsTemplateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ExportTemplateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ExportVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ForceVMRebootCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ForceVMShutDownCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ForgetSavedPasswordCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ForgetSRCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
HACommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
HostMaintenanceModeCommand.cs CA-293814: If there are no VMs running, immediately start entering Ma… (#2253) 2018-10-24 11:42:13 +01:00
HostPasswordCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
HostReconnectAsCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ImPortCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ImportSearchCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
InstallNewUpdateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
InstallToolsCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
InstantVMFromTemplateCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
MigrateVirtualDiskCommand.cs Removed duplicate resource. 2019-04-24 15:03:20 +01:00
MoveVirtualDiskCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
MoveVMCommand.cs CA-289948: Do not show the upsell dialog if migration is not permitted due to licensing restrictions; launch the move VM dialog instead. 2018-05-18 16:37:12 +01:00
NewFolderCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
NewPoolCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
NewSRCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
NewTemplateFromSnapshotCommand.cs Added functionality allowing renaming of folders. Fixed issue where the form 2018-11-26 10:29:39 +00:00
NewVMCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
NewVMFromSnapshotCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
NewVMFromTemplateCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PauseDockerContainerCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
PoolReconnectAsCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PowerOnHostCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
PropertiesCommands.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PutFolderIntoRenameModeCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
PutTagIntoRenameModeCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ReattachSRCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
RebootCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
RebootHostCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
RebootVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ReconnectHostCommand.cs Modified treeview and toolbar updates (#2264) 2018-10-16 16:24:54 +01:00
RemoveFromFolderCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
RemoveHostCommand.cs Modified treeview and toolbar updates (#2264) 2018-10-16 16:24:54 +01:00
RemoveHostCrashDumpsCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
RemoveHostFromPoolCommand.cs Modified treeview and toolbar updates (#2264) 2018-10-16 16:24:54 +01:00
RenameFolderCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
RenameTagCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
RepairSRCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
RescanPIFsCommand.cs Cleared some level 4 warnings. 2018-03-22 15:07:32 +00:00
RestartDockerContainerCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
RestartToolstackCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
RestoreHostFromBackupCommand.cs Reduced accessibility of controls to private. Minor refactoring. 2019-01-08 12:01:46 +00:00
ResumeDockerContainerCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ResumeVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
RevertToSnapshotCommand.cs No need to set ShowProgress to its default value. Removed unused constructor. Compacted Properties. 2019-04-24 15:03:20 +01:00
RollingUpgradeCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
SaveSessionCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
SelectedItem.cs Cleared some level 4 warnings. 2018-03-22 15:07:32 +00:00
SelectedItemCollection.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
SelectionBroadcaster.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SelectionManager.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SetAsDefaultSRCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
ShutDownCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
ShutDownHostCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
ShutDownVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
StartDockerContainerCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
StartVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
StopDockerContainerCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
SuspendVMCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
TakeSnapshotCommand.cs No need to set ShowProgress to its default value. Removed unused constructor. Compacted Properties. 2019-04-24 15:03:20 +01:00
TrimSRCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
UntagCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
VappShutDownCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
VappStartCommand.cs Converted all extension get properties of the API classes to methods in order to 2017-09-03 03:35:30 +01:00
ViewWorkloadReportsCommand.cs Removed code applicable to servers earlier than dundee since connection to them is now blocked. 2019-02-06 09:25:38 +00:00
VirtualDiskCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
VMGroupCommand.cs CA-242134: Remove the VMPP code 2017-05-25 15:37:05 +01:00
VMLifeCycleCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
VMOperationCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
VMOperationHomeServerCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00
VMOperationHostCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
VMOperationWlbHostCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
VMOperationWlbOptimalServerCommand.cs Enforce icon size 32x32 on the CommandErrorDialog. Compacted constructors 2019-03-20 16:58:02 +00:00
VMRecoveryModeCommand.cs CA-176169: Changed copyright statements to include the comma in Citrix Systems, 2017-01-16 19:59:50 +00:00